| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:258e97d8-efa1-9873-b5bc-84a4a096e637 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BFA6:2BDF1:63CD1:8187E:6981E6FF |
| html-safe-nonce | b00bb0d9495d88cff9d07f50caeb10c1b5114a232a1e2490557c7d5192af8834 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRkE2OjJCREYxOjYzQ0QxOjgxODdFOjY5ODFFNkZGIiwidmlzaXRvcl9pZCI6IjY1ODU2NjYzNTk2NzIzMDEzMTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b80a8c1d780ccc93e004e0334922d4220de3470e028dd72bf7ef8194457b62a9 |
| hovercard-subject-tag | pull_request:2172429995 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/DiamondLightSource/python-murfey/401/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c9f8e129966840f944a1de86205aaf5a1716f91d1ee2a46623be07ebbc74471e/DiamondLightSource/python-murfey/pull/401 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c9f8e129966840f944a1de86205aaf5a1716f91d1ee2a46623be07ebbc74471e/DiamondLightSource/python-murfey/pull/401 |
| og:image:alt | Adds a command line tool intended to walk non-developers through the process of setting up a configuration file in order to run Murfey properly.
Key Changes:
The Security class has been renamed to... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tieneupin |
| hostname | github.com |
| expected-hostname | github.com |
| None | ebfdf8d3e0fd17b103f41cc6696d84938694ebebdfecaf11fe00dbe4a9785801 |
| turbo-cache-control | no-preview |
| go-import | github.com/DiamondLightSource/python-murfey git https://github.com/DiamondLightSource/python-murfey.git |
| octolytics-dimension-user_id | 1233618 |
| octolytics-dimension-user_login | DiamondLightSource |
| octolytics-dimension-repository_id | 429480030 |
| octolytics-dimension-repository_nwo | DiamondLightSource/python-murfey |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 429480030 |
| octolytics-dimension-repository_network_root_nwo | DiamondLightSource/python-murfey |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 471ae8701b77c1bf177c58019d2e6fd65ae89141 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FDiamondLightSource%2Fpython-murfey%2Fpull%2F401 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FDiamondLightSource%2Fpython-murfey%2Fpull%2F401 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=DiamondLightSource%2Fpython-murfey |
| Reload | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401 |
| Reload | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401 |
| Reload | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401 |
|
DiamondLightSource
| https://patch-diff.githubusercontent.com/DiamondLightSource |
| python-murfey | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2FDiamondLightSource%2Fpython-murfey |
|
Fork
1
| https://patch-diff.githubusercontent.com/login?return_to=%2FDiamondLightSource%2Fpython-murfey |
|
Star
2
| https://patch-diff.githubusercontent.com/login?return_to=%2FDiamondLightSource%2Fpython-murfey |
|
Code
| https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey |
|
Issues
45
| https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/issues |
|
Pull requests
8
| https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/wiki |
|
Security
0
| https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/security |
|
Insights
| https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pulse |
|
Code
| https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey |
|
Issues
| https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/actions |
|
Projects
| https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/wiki |
|
Security
| https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/security |
|
Insights
| https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pulse |
| Sign up for GitHub
| https://patch-diff.githubusercontent.com/signup?return_to=%2FDiamondLightSource%2Fpython-murfey%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=%2FDiamondLightSource%2Fpython-murfey%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401#issue-comment-box |
| tieneupin | https://patch-diff.githubusercontent.com/tieneupin |
| main | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/tree/main |
| setup-cli | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/tree/setup-cli |
|
Setup CLI
| https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401#top |
| tieneupin | https://patch-diff.githubusercontent.com/tieneupin |
| main | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/tree/main |
| setup-cli | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/tree/setup-cli |
|
Conversation
18
| https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401 |
|
Commits
96
| https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits |
|
Checks
17
| https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/files |
| Please reload this page | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| tieneupin | https://patch-diff.githubusercontent.com/tieneupin |
| Nov 11, 2024 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401#issue-2648828397 |
| Please reload this page | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401 |
| Please reload this page | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401 |
| d-j-hatton | https://patch-diff.githubusercontent.com/d-j-hatton |
| October 15, 2024 09:42 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401#commits-pushed-02c9b17 |
|
| https://patch-diff.githubusercontent.com/d-j-hatton |
| The machine config for the instrument is already accessed via key | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/02c9b17c22604f9b19d731151f6bb17c642d8672 |
| 02c9b17 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/02c9b17c22604f9b19d731151f6bb17c642d8672 |
|
| https://patch-diff.githubusercontent.com/d-j-hatton |
| No longer strictly an int | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/3d747ad5269c75a17661aa813fab5c6aaf274584 |
| 3d747ad | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/3d747ad5269c75a17661aa813fab5c6aaf274584 |
|
| https://patch-diff.githubusercontent.com/d-j-hatton |
| Allow spaces in directory names when looking for gain references | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/66a424ddbfd6a705f19224a8f30a4f5bb0421b02 |
| 66a424d | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/66a424ddbfd6a705f19224a8f30a4f5bb0421b02 |
|
| https://patch-diff.githubusercontent.com/d-j-hatton |
| Fix for instrument card display now that the whole machine configurat… | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/c18c7820135455126905e55d8b19d7e7a6beb5d5 |
| c18c782 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/c18c7820135455126905e55d8b19d7e7a6beb5d5 |
|
| https://patch-diff.githubusercontent.com/d-j-hatton |
| Ignore parts with spaces, don't remove them | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/29f50ac143f8b67157debc1952c8030cc43444e5 |
| 29f50ac | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/29f50ac143f8b67157debc1952c8030cc43444e5 |
|
| https://patch-diff.githubusercontent.com/d-j-hatton |
| Remove unused function | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/8e4b0e24222ce64f7a2f21f766c5d12c52b19637 |
| 8e4b0e2 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/8e4b0e24222ce64f7a2f21f766c5d12c52b19637 |
|
| https://patch-diff.githubusercontent.com/d-j-hatton |
| THe function wasn't unused but should be renamed | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/60ec9a1437a4ded993b22e23250cd75497a667c4 |
| 60ec9a1 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/60ec9a1437a4ded993b22e23250cd75497a667c4 |
|
| https://patch-diff.githubusercontent.com/d-j-hatton |
| If there is no ISPyB connection then autogenerate data collection and… | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/7c6548f381467074d74e20f0f17faecc318bbc0b |
| 7c6548f | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/7c6548f381467074d74e20f0f17faecc318bbc0b |
|
| https://patch-diff.githubusercontent.com/d-j-hatton |
| Setup for multigrid controller to be able to skip the rsync step | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/a1996a93bb21fe98e53acf70771480fb74885979 |
| a1996a9 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/a1996a93bb21fe98e53acf70771480fb74885979 |
|
| https://patch-diff.githubusercontent.com/d-j-hatton |
| Make data transfer option configurable | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/df0719c83a8741ec8166c67f8c8ca73e14fbc2f5 |
| df0719c | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/df0719c83a8741ec8166c67f8c8ca73e14fbc2f5 |
|
| https://patch-diff.githubusercontent.com/d-j-hatton |
| Extend data transfer option configuration to TUI | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/42984f17c66490d6cb373cb74a6b2a04d9e38673 |
| 42984f1 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/42984f17c66490d6cb373cb74a6b2a04d9e38673 |
|
| https://patch-diff.githubusercontent.com/d-j-hatton |
| Add visit creation option in TUI | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/600d71f247367d7c328a0ed01ad4563b4d8419ac |
| 600d71f | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/600d71f247367d7c328a0ed01ad4563b4d8419ac |
|
| https://patch-diff.githubusercontent.com/d-j-hatton |
| Explanatory comment | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/d171395f41d7e9eff937f2c2056e0cf239645add |
| d171395 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/d171395f41d7e9eff937f2c2056e0cf239645add |
|
| https://patch-diff.githubusercontent.com/d-j-hatton |
| Remove some path construction that is specific to DLS directory struc… | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/aed6c9840e1f3ec0ec10af5443457023376cdaa3 |
| aed6c98 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/aed6c9840e1f3ec0ec10af5443457023376cdaa3 |
|
| https://patch-diff.githubusercontent.com/d-j-hatton |
| Starting to add some description to configuration | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/74871e149fc026092cb5738e53fbe1ce859163d9 |
| 74871e1 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/74871e149fc026092cb5738e53fbe1ce859163d9 |
|
| https://patch-diff.githubusercontent.com/d-j-hatton |
| Further improvements to machine configuration including some validati… | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/7fc5e28833c46af39e4634705d4c2fe8aa9fde48 |
| 7fc5e28 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/7fc5e28833c46af39e4634705d4c2fe8aa9fde48 |
|
| https://patch-diff.githubusercontent.com/d-j-hatton |
| Early development of command line tool for generating a configuration… | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/b6b6b50eb3abcf117158cfddfe1614c1dcf156f5 |
| b6b6b50 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/b6b6b50eb3abcf117158cfddfe1614c1dcf156f5 |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Merged recent changes from 'main' branch | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/616ecaf5f10f9b167aff3ca945983f528c4f3a98 |
| 616ecaf | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/616ecaf5f10f9b167aff3ca945983f528c4f3a98 |
| https://patch-diff.githubusercontent.com/apps/codecov |
| codecov | https://patch-diff.githubusercontent.com/apps/codecov |
| Nov 11, 2024 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401#issuecomment-2467748595 |
| Please reload this page | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401 |
| Codecov | https://app.codecov.io/gh/DiamondLightSource/python-murfey/pull/401?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DiamondLightSource |
| (1c5667d) | https://app.codecov.io/gh/DiamondLightSource/python-murfey/commit/1c5667de6bdbce44448b7d29431e5621d2d90b00?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DiamondLightSource |
| (1b117d3) | https://app.codecov.io/gh/DiamondLightSource/python-murfey/commit/1b117d371b7ef29266a4e242bc27b252a4a42b1a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DiamondLightSource |
| Please reload this page | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401 |
| tieneupin | https://patch-diff.githubusercontent.com/tieneupin |
| November 12, 2024 18:39 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401#commits-pushed-db60fa4 |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Rearranged MachineConfig keys by purpose and added descriptions | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/db60fa43e3ced7800dd5a8074ebff74b59f55fcb |
| db60fa4 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/db60fa43e3ced7800dd5a8074ebff74b59f55fcb |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Renamed Security as ServerConfig, given the change in its contents | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/816738a67d82cb28327d4d009f13c1720e21405f |
| 816738a | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/816738a67d82cb28327d4d009f13c1720e21405f |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Fixed '_resize_initial_model' since 'executables' dict stores Path ob… | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/70e1c68c9115d0c9b8d8b21e41086585c38d1489 |
| 70e1c68 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/70e1c68c9115d0c9b8d8b21e41086585c38d1489 |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Replaced 'from_file' with 'machine_config_from_file' for greater clarity | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/c53b099e2845e5faded01253b8ebf127b54819ab |
| c53b099 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/c53b099e2845e5faded01253b8ebf127b54819ab |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Updated code to reflect type changes of parameters from str to Path a… | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/3e1387955e3c07af404356649fcc84018783a248 |
| 3e13879 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/3e1387955e3c07af404356649fcc84018783a248 |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Renamed 'security_from_file' to 'server_config_from_file' for greater… | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/203eaacf377fd5213f61e64aca9f2c452c3704a0 |
| 203eaac | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/203eaacf377fd5213f61e64aca9f2c452c3704a0 |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Renamed 'ServerConfig' to 'GlobalConfig' and 'get_security_config' to… | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/28885240195d19ac17e624c8ee1d5486a667ff3c |
| 2888524 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/28885240195d19ac17e624c8ee1d5486a667ff3c |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Missed renaming 'get_security_config' in 'tests' folder | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/bde9c953cdf70f2076a44ba62e8133ec031388bb |
| bde9c95 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/bde9c953cdf70f2076a44ba62e8133ec031388bb |
| https://patch-diff.githubusercontent.com/tieneupin |
| tieneupin | https://patch-diff.githubusercontent.com/tieneupin |
| Nov 13, 2024 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401#event-15282029677 |
| tieneupin | https://patch-diff.githubusercontent.com/tieneupin |
| November 13, 2024 13:57 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401#commits-pushed-edfb058 |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Added default options to the description of 'flip_gain' | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/edfb058c24972c7dec6b82077bb47eb99f48f9af |
| edfb058 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/edfb058c24972c7dec6b82077bb47eb99f48f9af |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Rearranged keys and updated descriptions | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/c1a7ccf5f7df3910773ba9af4f6922bd490b8f8e |
| c1a7ccf | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/c1a7ccf5f7df3910773ba9af4f6922bd490b8f8e |
| tieneupin | https://patch-diff.githubusercontent.com/tieneupin |
| December 18, 2024 17:54 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401#commits-pushed-8db6865 |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Put y/n prompt in a different colour | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/8db6865c6a3705266053cd41b72a0855362fb332 |
| 8db6865 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/8db6865c6a3705266053cd41b72a0855362fb332 |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Allow setup wizard to skip sections if they are disabled; updated fon… | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/094470eb3bfa066e0aa26b84228eb0939d8b9637 |
| 094470e | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/094470eb3bfa066e0aa26b84228eb0939d8b9637 |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Renamed 'generate_config' to 'create_config' | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/043046e506f89640751d9b773d0c23dfb96861d6 |
| 043046e | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/043046e506f89640751d9b773d0c23dfb96861d6 |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Empty console inputs for simple fields are now converted to the defau… | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/cfffcf2551a5bee57c5a8b617547980b12a623d1 |
| cfffcf2 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/cfffcf2551a5bee57c5a8b617547980b12a623d1 |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Updated data directories type from dict[str, str] to list[Path]; chan… | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/aab451f5fa2e7b9ebf09da19230ba5a6e2f5a53f |
| aab451f | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/aab451f5fa2e7b9ebf09da19230ba5a6e2f5a53f |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Added logic to use default values for fields if empty console input i… | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/436fab74ca88a7372329d0e0d5d59e21b6d6504c |
| 436fab7 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/436fab74ca88a7372329d0e0d5d59e21b6d6504c |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Recipe keys are nowtype hinted as string literals | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/ae2d291af7d425263da240d9cd856ede3d4e71d7 |
| ae2d291 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/ae2d291af7d425263da240d9cd856ede3d4e71d7 |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Grouped 'rsync_url' together with other data transfer-related keys | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/53a30ad77d7f223b209f8334b1759fc7433f8f8f |
| 53a30ad | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/53a30ad77d7f223b209f8334b1759fc7433f8f8f |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Updated printed messages | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/194341bd38da003710292207c08129bca6734409 |
| 194341b | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/194341bd38da003710292207c08129bca6734409 |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Removed unused variable | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/2b25266e58b8b4299fd00517ab5091b8d7985387 |
| 2b25266 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/2b25266e58b8b4299fd00517ab5091b8d7985387 |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Modernised type hints | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/93ebb079ee16899a495463043814b9e113979d7e |
| 93ebb07 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/93ebb079ee16899a495463043814b9e113979d7e |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Fixed improperly cased 'GLOBAL_CONFIGURATION_PATH' | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/d19683dabaac7cef17473c76a51be0547d5abcf4 |
| d19683d | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/d19683dabaac7cef17473c76a51be0547d5abcf4 |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Union type hint still needed for Python 3.9 pytest tests | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/05b10571c3f8b60b556d993e263958c8375fa55e |
| 05b1057 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/05b10571c3f8b60b556d993e263958c8375fa55e |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Fixed improperly cased 'MURFEY_GLOBAL_CONFIGURATION' | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/d43ab647cbca3f67bcc7ec63ccf7956cf743d7dd |
| d43ab64 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/d43ab647cbca3f67bcc7ec63ccf7956cf743d7dd |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| 'murfey_db_credentials' in GlobalConfig is now a Path | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/85d905dae4e3b90ebc067ecf777b49e3e6fd972d |
| 85d905d | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/85d905dae4e3b90ebc067ecf777b49e3e6fd972d |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| 'murfey_db_credentials' no longer part of MachineConfig | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/c8e6caa982826c07d7cfd5f8aaf4abeb9ca88387 |
| c8e6caa | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/c8e6caa982826c07d7cfd5f8aaf4abeb9ca88387 |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Added description for 'sqlalchemy_pooling' field in GlobalConfig | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/0b12cb7d77c788cae585969ef6287c768d3f7343 |
| 0b12cb7 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/0b12cb7d77c788cae585969ef6287c768d3f7343 |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Added description for the 'crypto_key' field in the GlobalConfig | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/01f953215f484166a1ad7e605344a3bb59022bab |
| 01f9532 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/01f953215f484166a1ad7e605344a3bb59022bab |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Added description for the 'feedback_queue' field in the GlobalConfig | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/22b72f320bc101bec305cd7e13df5bd58d937ac8 |
| 22b72f3 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/22b72f320bc101bec305cd7e13df5bd58d937ac8 |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Added description for the 'auth_type' field in the GlobalConfig | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/3742c7185c4e55765d788b02e76c2fd0c766b62a |
| 3742c71 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/3742c7185c4e55765d788b02e76c2fd0c766b62a |
| https://patch-diff.githubusercontent.com/tieneupin |
| tieneupin | https://patch-diff.githubusercontent.com/tieneupin |
| Jan 6, 2025 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401#issuecomment-2573271092 |
| Please reload this page | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401 |
| Please reload this page | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401 |
| tieneupin | https://patch-diff.githubusercontent.com/tieneupin |
| January 7, 2025 17:36 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401#commits-pushed-67e9322 |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Merged recent changes from 'main' branch | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/67e9322f32d15bbb9adec35e3a25dcd800411f5a |
| 67e9322 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/67e9322f32d15bbb9adec35e3a25dcd800411f5a |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| 'MachineConfig.rsync_basepath' is now no longer None | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/aba0618580e78a75bf2e327b796a931f700e063a |
| aba0618 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/aba0618580e78a75bf2e327b796a931f700e063a |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Grouped all skippable keys under a single 'if' block | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/af80bf363f9b64cb3ddbf5a5b17b6372ea7dd29d |
| af80bf3 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/af80bf363f9b64cb3ddbf5a5b17b6372ea7dd29d |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Adjust logic for using default values when an empty console input is … | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/91675121656b29b86c02395d61a44d65f805ec57 |
| 9167512 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/91675121656b29b86c02395d61a44d65f805ec57 |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Merged recent changes from 'main' branch and resolved merge conflicts | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/a69aa2a83f48dad7f963fdd18bb3d68d4e73673a |
| a69aa2a | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/a69aa2a83f48dad7f963fdd18bb3d68d4e73673a |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| 'murfey_db_credentials', and 'rabbit_mq_credentials' should be mandat… | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/838720fd62992741da82d23aa6638ca8defa5b8a |
| 838720f | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/838720fd62992741da82d23aa6638ca8defa5b8a |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Fixed broken logic with interactive prompt when a field doesn't have … | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/a5c4029d51b57b4b2b4faf1d9bed18d29ec9597a |
| a5c4029 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/a5c4029d51b57b4b2b4faf1d9bed18d29ec9597a |
|
| https://patch-diff.githubusercontent.com/tieneupin |
| Merged recent changes from 'main' branch | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/1b117d371b7ef29266a4e242bc27b252a4a42b1a |
| 1b117d3 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401/commits/1b117d371b7ef29266a4e242bc27b252a4a42b1a |
| https://patch-diff.githubusercontent.com/tieneupin |
| tieneupin | https://patch-diff.githubusercontent.com/tieneupin |
| March 11, 2025 12:03 | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401#event-16683077665 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FDiamondLightSource%2Fpython-murfey%2Fpull%2F401 |
|
| https://patch-diff.githubusercontent.com/d-j-hatton |
|
d-j-hatton
| https://patch-diff.githubusercontent.com/d-j-hatton |
|
| https://patch-diff.githubusercontent.com/stephen-riggs |
|
stephen-riggs
| https://patch-diff.githubusercontent.com/stephen-riggs |
|
| https://patch-diff.githubusercontent.com/tieneupin |
|
tieneupin
| https://patch-diff.githubusercontent.com/tieneupin |
|
enhancement
| https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/issues?q=state%3Aopen%20label%3Aenhancement |
|
server
| https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/issues?q=state%3Aopen%20label%3Aserver |
| Please reload this page | https://patch-diff.githubusercontent.com/DiamondLightSource/python-murfey/pull/401 |
|
| https://patch-diff.githubusercontent.com/tieneupin |
|
| https://patch-diff.githubusercontent.com/d-j-hatton |
|
| https://patch-diff.githubusercontent.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |