Title: Early deletion in `gw_ml.F90` · Issue #37 · DataWaveProject/CAM · GitHub
Open Graph Title: Early deletion in `gw_ml.F90` · Issue #37 · DataWaveProject/CAM
X Title: Early deletion in `gw_ml.F90` · Issue #37 · DataWaveProject/CAM
Description: CAM/src/physics/cam/gw_ml.F90 Line 123 in 8ef0f5a call torch_delete(net_output_tensors(1)) Aren't we are deleting too early since the allocation of net_outputs is aliased by net_output_tensors? Or does the call to torch_delete(net_output...
Open Graph Description: CAM/src/physics/cam/gw_ml.F90 Line 123 in 8ef0f5a call torch_delete(net_output_tensors(1)) Aren't we are deleting too early since the allocation of net_outputs is aliased by net_output_tensors? Or ...
X Description: CAM/src/physics/cam/gw_ml.F90 Line 123 in 8ef0f5a call torch_delete(net_output_tensors(1)) Aren't we are deleting too early since the allocation of net_outputs is aliased by net_output_tensors?...
Opengraph URL: https://github.com/DataWaveProject/CAM/issues/37
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Early deletion in `gw_ml.F90`","articleBody":"https://github.com/DataWaveProject/CAM/blob/8ef0f5a2a861c08eb61814514f3cc93dd383a3a5/src/physics/cam/gw_ml.F90#L123\n\nAren't we are deleting too early since the allocation of net_outputs is aliased by net_output_tensors? \n\nOr does the call to `torch_delete(net_output_tensors(1))` likely only destroy the PyTorch tensor wrapper, not the memory buffer it pointed to (which is net_outputs(:, i)). There is a check for zero outputs, so if this isn't satisfied wouldn't `net_outputs` be nonsense and therefore blow up? This doesn't tally with our observations (3 year runs were successful at the time). \n\nIf we moved to batching and pushed the deletions a little lower this wouldn't be a discussion anyway. \n\n\nMaybe @jatkinson1000 can help with this. ","author":{"url":"https://github.com/ma595","@type":"Person","name":"ma595"},"datePublished":"2025-11-11T10:46:33.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/37/CAM/issues/37"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:61632018-7f97-7ce1-af38-5691d2165ff5 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8ACC:10C6E6:22F455:2D8A8C:698E9E03 |
| html-safe-nonce | 180799cf16eb9385ac8591f9c5daf7b19d51fa48d5a686cb55e174e62283a8ba |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QUNDOjEwQzZFNjoyMkY0NTU6MkQ4QThDOjY5OEU5RTAzIiwidmlzaXRvcl9pZCI6IjE2MjI3MTMxNTUyOTI0MDUyNTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 75381d7d9af1e4958ca2733f779b52e24cb61c4e8247ab22ef946d7e2e9c5914 |
| hovercard-subject-tag | issue:3611753630 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/DataWaveProject/CAM/37/issue_layout |
| twitter:image | https://opengraph.githubassets.com/157b13f2cd2dd55074e33e4230885988f836030ee3c51ab25fc8f97d84dcfa93/DataWaveProject/CAM/issues/37 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/157b13f2cd2dd55074e33e4230885988f836030ee3c51ab25fc8f97d84dcfa93/DataWaveProject/CAM/issues/37 |
| og:image:alt | CAM/src/physics/cam/gw_ml.F90 Line 123 in 8ef0f5a call torch_delete(net_output_tensors(1)) Aren't we are deleting too early since the allocation of net_outputs is aliased by net_output_tensors? Or ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ma595 |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb2828a801ee6b7be618f3ac76fbf55def35bbc30f053a9c41bf90210b8b72ba |
| turbo-cache-control | no-preview |
| go-import | github.com/DataWaveProject/CAM git https://github.com/DataWaveProject/CAM.git |
| octolytics-dimension-user_id | 79333410 |
| octolytics-dimension-user_login | DataWaveProject |
| octolytics-dimension-repository_id | 763510579 |
| octolytics-dimension-repository_nwo | DataWaveProject/CAM |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | true |
| octolytics-dimension-repository_parent_id | 204844341 |
| octolytics-dimension-repository_parent_nwo | ESCOMP/CAM |
| octolytics-dimension-repository_network_root_id | 204844341 |
| octolytics-dimension-repository_network_root_nwo | ESCOMP/CAM |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6b91a7e6e46287d26887e3fb7a4161657bab8f7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width