René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"By default, commands are registered with ‘dm_permission?’ set to ‘false’ and not null","articleBody":"### Summary\n\nHello. \r\nWhen upgrading from the SlashCommands to the Commands Library, I noticed that users can only execute the commands on Guilds and no longer via private message. \r\nAfter looking at the API Doc and the code for it, there is a deprecated field ‘dm_permission?’ in the Discord API which can be null, false or true. \r\n(https://discord.com/developers/docs/interactions/application-commands)\r\n\r\nThe default, i.e. if zero is passed, is true and commands are also displayed in DMs. \r\n\r\nAllowedContexts should actually be used, but that is not the point.\r\n\r\n[DSharpPlus.Commands](https://github.com/DSharpPlus/DSharpPlus/tree/master/DSharpPlus.Commands)/[Processors](https://github.com/DSharpPlus/DSharpPlus/tree/master/DSharpPlus.Commands/Processors)/[MessageCommands](https://github.com/DSharpPlus/DSharpPlus/tree/master/DSharpPlus.Commands/Processors/MessageCommands)\r\n/MessageCommandProcessor.cs\r\n```c#\r\npublic async Task\u003cDiscordApplicationCommand\u003e ToApplicationCommandAsync(Command command)\r\n    {\r\n        [...]\r\n\r\n        return new(\r\n            [...]\r\n            allowDMUsage: command.Attributes.Any(x =\u003e x is AllowDMUsageAttribute),\r\n            [...]\r\n        );\r\n    }\r\n``` \r\n\r\nIn the code of the MessageCommandProcessor, the following is set for allowDMUsage in line 172: command.Attributes.Any(x =\u003e x is AllowDMUsageAttribute).\r\n\r\nThis means that false is set here by default and every command must be explicitly allowed for use in DMs.\r\n\r\nI would like to ask if this is intended, that the default is false and not null.\n\n### What version of the library are you using?\n\nv5.0.0-nightly (make sure you are using the latest nightly!)\n\n### What .NET version are you using? Make sure to use the latest patch release for your major version.\n\n.NET 9.0 Previews\n\n### Operating System\n\nLinux Debian\n\n### Reproduction Steps\n\nRegister a command and try to execute it via DM. If the attribute is not set, it will not be allowed via DM.\n\n### Trace Logs\n\n_No response_\n\n### Exceptions or other error messages\n\n_No response_\n\n### Anything else you'd like to share\n\n_No response_","author":{"url":"https://github.com/Scartzz","@type":"Person","name":"Scartzz"},"datePublished":"2024-07-22T23:08:04.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/2034/DSharpPlus/issues/2034"}