René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"concore stop reports success on Windows even when taskkill fails","articleBody":"In concore_cli/commands/stop.py, the Windows kill path uses check=False and never looks at the return code:\n\n    subprocess.run(['taskkill', '/F', '/PID', str(pid)], \n                 capture_output=True, \n                 check=False)                    # never raises\n    console.print(f\"  ✓ Stopped {name}\")         # always prints success\n    killed_count += 1                            # always counts as killed\n\nOn POSIX, a failed terminate() raises TimeoutExpired which gets caught and escalated to kill(). There's actual feedback.\n\nOn Windows, if taskkill fails (Access Denied, PID not found, protected process), execution falls through silently and the user sees \"Successfully stopped all N process(es)\" when nothing was actually stopped.\n\nThe fix is straightforward: check result.returncode != 0 and raise or log accordingly, thx","author":{"url":"https://github.com/avinxshKD","@type":"Person","name":"avinxshKD"},"datePublished":"2026-02-12T08:35:52.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/280/concore/issues/280"}