René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"tuple unpacking in permutationTesting.py no longer compatible w/python3. Potential solution included.","articleBody":"Hello,\r\nI noticed the arguments for `_maxTpermutation()` from [permutationTesting.py](https://github.com/ColeLab/MultipleComparisonsPermutationTesting/blob/master/pythonCode/permutationTesting.py) includes the tuple` [diff_arr, nullmean, tail, seed]` as our input. \r\n\r\nTuple unpacking is no longer compatible with python3, but the code still works in python2. I developed, however, a workaround for this fantastic script to run in python3:\r\n\r\n**Old code:**\r\n```\r\ndef _maxTpermutation((diff_arr,nullmean,tail,seed)):\r\n    \"\"\"\r\n    Helper function to perform a single permutation\r\n    \"\"\"\r\n\r\n    np.random.seed(seed)\r\n```\r\n\r\n**New code:**\r\n```\r\ndef _maxTpermutation(t_tuple: tuple): -\u003e int:\r\n    \"\"\"\r\n    Helper function to perform a single permutation\r\n    \"\"\" \r\n\r\n    diff_arr = t_tuple[0]\r\n    nullmean = t_tuple[1]\r\n    tail = t_tuple[2]\r\n    seed = t_tuple[3]\r\n    \r\n    np.random.seed(seed)\r\n```\r\nI understand one solution could be to pass individual arguments, but our inputs is of variable length and incorporating type annotations allows your list of inputs to successfully pass through `map_async()`. Therefore, this solution should remain faithful to the logic of the original script. \r\n\r\nI was able to successfully run [pythonMaxT_Test.py](https://github.com/ColeLab/MultipleComparisonsPermutationTesting/blob/master/testCode/pythonMaxT_Test.py) with the new code. Hope this helps! I can submit a pull request for [permutationTesting.py](https://github.com/ColeLab/MultipleComparisonsPermutationTesting/blob/master/pythonCode/permutationTesting.py) too, if you like.","author":{"url":"https://github.com/lindsayshaffer","@type":"Person","name":"lindsayshaffer"},"datePublished":"2022-12-29T17:56:50.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/2/MultipleComparisonsPermutationTesting/issues/2"}