René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"sockets end in close_wait state after some time","articleBody":"Looks like we are missing a time-out on stream reader in uhttpsharp\\HttpClient.cs\r\n\r\nWhen remote http client gets disconnected due to some network issues (or because of proxies in between not handling the keep-alive header properly), uHttpSharp library code fails to close the socket, this results in open sockets stuck in close_wait state.\r\nAm new to C# not sure how to add this time out.\r\n\r\n      {\r\n        try\r\n        {\r\n            await InitializeStream();\r\n\r\n            while (_client.Connected)\r\n            {\r\n                // TODO : Configuration.\r\n                var limitedStream = new NotFlushingStream(new LimitedStream(_stream));\r\n\r\n                var request = await _requestProvider.Provide(new MyStreamReader(limitedStream)).ConfigureAwait(false);\r\n\r\n                if (request != null)\r\n                {\r\n                    UpdateLastOperationTime();\r\n\r\n                    var context = new HttpContext(request, _client.RemoteEndPoint);\r\n\r\n                    Logger.InfoFormat(\"{1} : Got request {0}\", request.Uri, _client.RemoteEndPoint);\r\n\r\n\r\n                    await _requestHandler(context).ConfigureAwait(false);\r\n\r\n                    if (context.Response != null)\r\n                    {\r\n                        var streamWriter = new StreamWriter(limitedStream) { AutoFlush = false };\r\n                        streamWriter.NewLine = \"\\r\\n\";\r\n                        await WriteResponse(context, streamWriter).ConfigureAwait(false);\r\n\r\n                         //v----- connections seem to be stuck here, resulting in piling up of  sockets in close_wait state\r\n                        await limitedStream.ExplicitFlushAsync().ConfigureAwait(false); \r\n\r\n                        if (!request.Headers.KeepAliveConnection() || context.Response.CloseConnection)\r\n                        {\r\n                            _client.Close();\r\n                        }\r\n                    }\r\n\r\n                    UpdateLastOperationTime();\r\n                }\r\n                else\r\n                {\r\n                    _client.Close();\r\n                }\r\n            }\r\n        }\r\n        catch (Exception e)\r\n        {\r\n            // Hate people who make bad calls.\r\n            Logger.WarnException(string.Format(\"Error while serving : {0}\", _remoteEndPoint), e);\r\n            _client.Close();\r\n        }\r\n\r\n        Logger.InfoFormat(\"Lost Client {0}\", _remoteEndPoint);\r\n    }\r\n\r\n","author":{"url":"https://github.com/GopinathSadasivam","@type":"Person","name":"GopinathSadasivam"},"datePublished":"2019-06-07T07:11:56.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/29/uHttpSharp/issues/29"}