René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Wrong replacing of '+'","articleBody":"When parsing the query, the replacement operation of the '+' character should be performed before URI decoding. BASE64 encoded string in the query can contain '+' character which is currently replaced, so the BASE64 value is corrupted.\r\n\r\n        public QueryStringHttpHeaders(string query)\r\n        {\r\n            var splittedKeyValues = query.Split(Seperators, StringSplitOptions.RemoveEmptyEntries);\r\n            var values = new Dictionary\u003cstring, string\u003e(splittedKeyValues.Length / 2, StringComparer.InvariantCultureIgnoreCase);\r\n\r\n            for (int i = 0; i \u003c splittedKeyValues.Length; i += 2)\r\n            {\r\n                var key = Uri.UnescapeDataString(splittedKeyValues[i]);\r\n                string value = null;\r\n                if (splittedKeyValues.Length \u003e i + 1)\r\n                {\r\n                    value = Uri.UnescapeDataString(splittedKeyValues[i + 1]).Replace('+', ' ');  \r\n                }\r\n                values[key] = value;\r\n            }\r\n            _count = values.Count;\r\n            _child = new HttpHeaders(values);\r\n        }\r\n\r\nThe replacing should be modified as follows:\r\n` value = Uri.UnescapeDataString(splittedKeyValues[i + 1].Replace('+', ' '));`\r\n\r\nAdditionally using the `StringSplitOptions.RemoveEmptyEntries` option can cause errors in the case the value is empty. I think it should be replaced by `StringSplitOptions.None`.","author":{"url":"https://github.com/czesiu20","@type":"Person","name":"czesiu20"},"datePublished":"2019-04-16T11:38:37.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/28/uHttpSharp/issues/28"}