René's URL Explorer Experiment


Title: Fix: Remove validUntil attribute from SAML SP Metadata by jdede · Pull Request #5914 · BookStackApp/BookStack · GitHub

Open Graph Title: Fix: Remove validUntil attribute from SAML SP Metadata by jdede · Pull Request #5914 · BookStackApp/BookStack

X Title: Fix: Remove validUntil attribute from SAML SP Metadata by jdede · Pull Request #5914 · BookStackApp/BookStack

Description: This PR disables the validUntil attribute in the generated SAML Service Provider (SP) metadata. Why this is needed Currently, the underlying php-saml library hardcodes the metadata validity (TIME_V...

Open Graph Description: This PR disables the validUntil attribute in the generated SAML Service Provider (SP) metadata. Why this is needed Currently, the underlying php-saml library hardcodes the metadata validity (TIME_V...

X Description: This PR disables the validUntil attribute in the generated SAML Service Provider (SP) metadata. Why this is needed Currently, the underlying php-saml library hardcodes the metadata validity (TIME_V...

Opengraph URL: https://github.com/BookStackApp/BookStack/pull/5914

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9ce03b51-7147-c41c-3015-14b3234255f0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id880E:189C33:2F9E431:3E537DC:696B7FC6
html-safe-nonce9aa181ad0aff47f08ddd093ce0e1f05ad892bdca9232cdc11ccfd475121ca307
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODBFOjE4OUMzMzoyRjlFNDMxOjNFNTM3REM6Njk2QjdGQzYiLCJ2aXNpdG9yX2lkIjoiMTAwMDg5NTQ3ODE2NjY4MzU5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb61b2e1ad80afe12382c4487dd088cf4484ffafbaf219385d711597e6ab92dd9
hovercard-subject-tagpull_request:3037953844
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/BookStackApp/BookStack/5914/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0d5dd34a0194209bc5d83faf8f390651c4528d588b118c71b9ca74184251f223/BookStackApp/BookStack/pull/5914
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0d5dd34a0194209bc5d83faf8f390651c4528d588b118c71b9ca74184251f223/BookStackApp/BookStack/pull/5914
og:image:altThis PR disables the validUntil attribute in the generated SAML Service Provider (SP) metadata. Why this is needed Currently, the underlying php-saml library hardcodes the metadata validity (TIME_V...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejdede
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/BookStackApp/BookStack git https://github.com/BookStackApp/BookStack.git
octolytics-dimension-user_id20912696
octolytics-dimension-user_loginBookStackApp
octolytics-dimension-repository_id41589337
octolytics-dimension-repository_nwoBookStackApp/BookStack
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id41589337
octolytics-dimension-repository_network_root_nwoBookStackApp/BookStack
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/BookStackApp/BookStack/pull/5914#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FBookStackApp%2FBookStack%2Fpull%2F5914
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FBookStackApp%2FBookStack%2Fpull%2F5914
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=BookStackApp%2FBookStack
Reloadhttps://patch-diff.githubusercontent.com/BookStackApp/BookStack/pull/5914
Reloadhttps://patch-diff.githubusercontent.com/BookStackApp/BookStack/pull/5914
Reloadhttps://patch-diff.githubusercontent.com/BookStackApp/BookStack/pull/5914
BookStackApp https://patch-diff.githubusercontent.com/BookStackApp
BookStackhttps://patch-diff.githubusercontent.com/BookStackApp/BookStack
Please reload this pagehttps://patch-diff.githubusercontent.com/BookStackApp/BookStack/pull/5914
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2FBookStackApp%2FBookStack
Fork 2.3k https://patch-diff.githubusercontent.com/login?return_to=%2FBookStackApp%2FBookStack
Star 18.1k https://patch-diff.githubusercontent.com/login?return_to=%2FBookStackApp%2FBookStack
Code https://patch-diff.githubusercontent.com/BookStackApp/BookStack
Issues 669 https://patch-diff.githubusercontent.com/BookStackApp/BookStack/issues
Pull requests 9 https://patch-diff.githubusercontent.com/BookStackApp/BookStack/pulls
Actions https://patch-diff.githubusercontent.com/BookStackApp/BookStack/actions
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/BookStackApp/BookStack/security
Please reload this pagehttps://patch-diff.githubusercontent.com/BookStackApp/BookStack/pull/5914
Insights https://patch-diff.githubusercontent.com/BookStackApp/BookStack/pulse
Code https://patch-diff.githubusercontent.com/BookStackApp/BookStack
Issues https://patch-diff.githubusercontent.com/BookStackApp/BookStack/issues
Pull requests https://patch-diff.githubusercontent.com/BookStackApp/BookStack/pulls
Actions https://patch-diff.githubusercontent.com/BookStackApp/BookStack/actions
Security https://patch-diff.githubusercontent.com/BookStackApp/BookStack/security
Insights https://patch-diff.githubusercontent.com/BookStackApp/BookStack/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2FBookStackApp%2FBookStack%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2FBookStackApp%2FBookStack%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/BookStackApp/BookStack/pull/5914#issue-comment-box
jdedehttps://patch-diff.githubusercontent.com/jdede
BookStackApp:developmenthttps://patch-diff.githubusercontent.com/BookStackApp/BookStack/tree/development
jdede:fix-ignoreValidUntilhttps://patch-diff.githubusercontent.com/jdede/BookStack/tree/fix-ignoreValidUntil
Fix: Remove validUntil attribute from SAML SP Metadata https://patch-diff.githubusercontent.com/BookStackApp/BookStack/pull/5914#top
jdedehttps://patch-diff.githubusercontent.com/jdede
BookStackApp:developmenthttps://patch-diff.githubusercontent.com/BookStackApp/BookStack/tree/development
jdede:fix-ignoreValidUntilhttps://patch-diff.githubusercontent.com/jdede/BookStack/tree/fix-ignoreValidUntil
Conversation 0 https://patch-diff.githubusercontent.com/BookStackApp/BookStack/pull/5914
Commits 1 https://patch-diff.githubusercontent.com/BookStackApp/BookStack/pull/5914/commits
Checks 0 https://patch-diff.githubusercontent.com/BookStackApp/BookStack/pull/5914/checks
Files changed 1 https://patch-diff.githubusercontent.com/BookStackApp/BookStack/pull/5914/files
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/BookStackApp/BookStack/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/jdede
jdedehttps://patch-diff.githubusercontent.com/jdede
Nov 23, 2025https://patch-diff.githubusercontent.com/BookStackApp/BookStack/pull/5914#issue-3656529216
Metadata.phphttps://github.com/SAML-Toolkits/php-saml/tree/master/lib/Saml2/Metadata.php
Settings.phphttps://github.com/SAML-Toolkits/php-saml/blob/master/lib/Saml2/Settings.php
Please reload this pagehttps://patch-diff.githubusercontent.com/BookStackApp/BookStack/pull/5914
https://patch-diff.githubusercontent.com/jdede
set ignoreValidUntil to truehttps://patch-diff.githubusercontent.com/BookStackApp/BookStack/pull/5914/commits/596763807e91c92f1edb0466fc981e3edc2921ce
5967638https://patch-diff.githubusercontent.com/BookStackApp/BookStack/pull/5914/commits/596763807e91c92f1edb0466fc981e3edc2921ce
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FBookStackApp%2FBookStack%2Fpull%2F5914
Please reload this pagehttps://patch-diff.githubusercontent.com/BookStackApp/BookStack/pull/5914
https://patch-diff.githubusercontent.com/jdede
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.