René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Wallet creation endpoint not working after refactor introduced recently","articleBody":"Creation of wallet address endpoint `POST /api/v2/{coin}/wallet/{walletId}/address` is not working anymore, and even the error doesn't follow the error format specified in the endpoint documentation here https://developers.bitgo.com/api/v2.wallet.newaddress.\n \nHere is a POST request example with curl we tried against a BitGoJS Express instance we run, using a HTETH wallet (testnet coin):\n\n```sh\ncurl -i -X POST \"http://bitgo-express:3080/api/v2/hteth/wallet/{MY_WALLET}/address\" \\\n     -H \"Content-Type: application/json\" -H \"Accept: application/json\" \\\n     -H \"Bearer {MY_TOKEN}\" \\\n     -d '{\"label\": \"my-address-10\", \"forwarderVersion\": 2}'\n```\n\nResponse:\n\n```\nHTTP/1.1 400 Bad Request\nX-Powered-By: Express\nContent-Type: application/json; charset=utf-8\nContent-Length: 158\nETag: W/\"9e-SCCh1WHc45CyixlBppDuHU6JGvU\"\nDate: Mon, 13 Oct 2025 13:19:22 GMT\nConnection: keep-alive\nKeep-Alive: timeout=5\n\n[\"Invalid value undefined supplied to : httpRequest/params: Exact\u003c({ coin: string, id: string } \u0026 Partial\u003c{  }\u003e)\u003e/0: { coin: string, id: string }/id: string\"]\n```\n\n## Environment Details\n\n- **OS:** we run BitGoJS with Docker using the official image `bitgo/express:15.6.0`\n- **Node Version:** Same we don't run it in our own version of Node\n- **Yarn Version:** Same above\n- **BitGoJS Version:** 15.6.0\n- **BitGo Environment:** testnet, coin HTETH\n\n## Expected Behavior\n\nAn HTTP 200 OK response, with a wallet address created.\n\n## Current Behavior\n\nAn HTTP 400 Bad Request response, with an validation error that is wrong, an no wallet address created.\n\nAlso the JSON response error doesn't follow the especification from the official documentation. Unexpected errors like this should be normalized through some sort of middleware that prevent the API to serialize error in whatever format not documented.\n\n## Possible Solution\n\nThe bug is in the source code of BitGo Express as far I understand, and it was introduced in a refactor here https://github.com/BitGo/BitGoJS/commit/4753b915ce798368be764b6ca99a31da28a11d1a#diff-2d63afad20775469d35fa72b1fc535af8b6daf51cf2aaa055983dd36ace25400L13-L16:\n\n```diff\n-  walletId: t.string,\n+  id: t.string,\n```\n\nAnd here in the same commit https://github.com/BitGo/BitGoJS/commit/4753b915ce798368be764b6ca99a31da28a11d1a#diff-851997953dfe5ce12d4c10bbabf8afa6bc49777505aae9197b0bcc6534da6677L666:\n\n```diff\n- const wallet = await coin.wallets().get({ id: req.decoded.walletId });\n+ const wallet = await coin.wallets().get({ id: req.decoded.id });\n```\n\nThere the param argument was renamed from `walletId` to `id`, but it was not renamed in the path definition here https://github.com/BitGo/BitGoJS/blob/004035b88551c5808a985f9deb66c06269c1f9dc/modules/express/src/typedRoutes/api/v2/createAddress.ts#L69\n\nCC @danielzhao122\n\n## Steps to Reproduce\n\nOnly one step described above.\n","author":{"url":"https://github.com/mrsarm","@type":"Person","name":"mrsarm"},"datePublished":"2025-10-13T13:57:57.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/7218/BitGoJS/issues/7218"}