René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Refactor: Use new Wallet instances in parallel calls (COIN-5426)","articleBody":"## Feature Description\n\nRefactor the `bulkSignAccountBasedMessagesWithProvider` function in `modules/sdk-core/src/bitgo/walletUtil/signAccountBasedMidnightClaimMessages.ts` to ensure that new instances of `Wallet` are used for each parallel call.\n\n- Extract constructor params from the original wallet instance.\n- For each message to be processed in parallel, instantiate a new `Wallet` object with the extracted params.\n- Perform signing/building using the new wallet instance per message.\n\nAlso, write comprehensive tests to verify the new behavior and cover edge cases.\n\n## Motivation\n\n- Prevent shared state issues or side effects when processing messages in parallel.\n- Align with COIN-5426 requirements.\n\n**File changed:**\n- modules/sdk-core/src/bitgo/walletUtil/signAccountBasedMidnightClaimMessages.ts\n\n**Relevant diff:**\n```diff\ndiff --git a/modules/sdk-core/src/bitgo/walletUtil/signAccountBasedMidnightClaimMessages.ts b/modules/sdk-core/src/bitgo/walletUtil/signAccountBasedMidnightClaimMessages.ts\nindex 47f39c179..74584b055 100644\n--- a/modules/sdk-core/src/bitgo/walletUtil/signAccountBasedMidnightClaimMessages.ts\n+++ b/modules/sdk-core/src/bitgo/walletUtil/signAccountBasedMidnightClaimMessages.ts\n@@ -1,4 +1,4 @@\n-import { IWallet } from '../wallet';\n+import { Wallet, IWallet } from '../wallet';\n import { MessageStandardType } from '../utils';\n import { MidnightMessageProvider } from './midnightMessageProvider';\n import { IMessageProvider, MessageInfo } from './iMessageProvider';\n@@ -27,17 +27,25 @@ async function bulkSignAccountBasedMessagesWithProvider(\n   const failedAddresses: string[] = [];\n   const txRequests: Record\u003cstring, unknown\u003e[] = [];\n \n+  // Gather all messages to process (flatten all batches)\n+  let allMessages: MessageInfo[] = [];\n   let messages: MessageInfo[] = await provider.getMessagesAndAddressesToSign();\n   while (messages.length \u003e 0) {\n-    // Sign/build all messages in parallel\n-    const results = await Promise.all(\n-      messages.map((messageInfo) =\u003e signOrBuildMessage(wallet, messageInfo, messageStandardType, walletPassphrase))\n-    );\n-    // Process results and update counters\n-    processResults(results, txRequests, failedAddresses);\n-    // Get next batch of messages\n+    allMessages = allMessages.concat(messages);\n     messages = await provider.getMessagesAndAddressesToSign();\n   }\n+\n+  // Extract wallet constructor params\n+  const { bitgo, baseCoin, _wallet: walletData } = wallet as Wallet;\n+\n+  // Process all messages in parallel, each with a new Wallet instance\n+  const results = await Promise.all(\n+    allMessages.map(async (messageInfo) =\u003e {\n+      const newWallet = new Wallet(bitgo, baseCoin, walletData);\n+      return signOrBuildMessage(newWallet, messageInfo, messageStandardType, walletPassphrase);\n+    })\n+  );\n+  processResults(results, txRequests, failedAddresses);\n   return { failedAddresses, txRequests };\n }\n \n\n```\n\n### Action Items\n- Refactor to use new Wallet instances for each parallel operation as per above.\n- Write/modify tests to validate the new behavior and prevent regression.\n- Ensure robust error handling and maintain performance.\n","author":{"url":"https://github.com/bhavidhingra","@type":"Person","name":"bhavidhingra"},"datePublished":"2025-09-12T16:30:38.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/6978/BitGoJS/issues/6978"}