René's URL Explorer Experiment


Title: fix: generate correct override stub for interface when implementation from base class by HerrCai0907 · Pull Request #2969 · AssemblyScript/assemblyscript · GitHub

Open Graph Title: fix: generate correct override stub for interface when implementation from base class by HerrCai0907 · Pull Request #2969 · AssemblyScript/assemblyscript

X Title: fix: generate correct override stub for interface when implementation from base class by HerrCai0907 · Pull Request #2969 · AssemblyScript/assemblyscript

Description: when class implements interface by its base class member, the original design will not manage it. For example, interface I { foo(): i32; } class Base { foo(): i32 { return 42;} } class C extends Base implements I {} class C implements interface I, but when creating I#foo override stub, it will only search the member of class C. which does not include Base#foo. This PR wants to split override (by extends) and implementation (by implements). Handling override needs to check whether the current class overrides the base class method. Handling implementation needs to check whether the current class and its base class implements the interface method.

Open Graph Description: when class implements interface by its base class member, the original design will not manage it. For example, interface I { foo(): i32; } class Base { foo(): i32 { return 42;} } class C extends...

X Description: when class implements interface by its base class member, the original design will not manage it. For example, interface I { foo(): i32; } class Base { foo(): i32 { return 42;} } class C extends...

Opengraph URL: https://github.com/AssemblyScript/assemblyscript/pull/2969

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2edb60b5-a4bd-f4f5-1650-dfc074129006
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA05C:374646:3A650B:5164E9:696E54ED
html-safe-nonce6f64064df107d3e976acd59ff005574fc58867289aeb4e3f0780216463ebb9a9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDVDOjM3NDY0NjozQTY1MEI6NTE2NEU5OjY5NkU1NEVEIiwidmlzaXRvcl9pZCI6IjM5ODgwNzA3MTAyODA4NjkxMDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb6747ad5ac4d8653f5de37f78ced24f9e23ebb88c41eaa3370a08834ab69988a
hovercard-subject-tagpull_request:3132984917
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/AssemblyScript/assemblyscript/pull/2969/files
twitter:imagehttps://avatars.githubusercontent.com/u/77575210?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/77575210?s=400&v=4
og:image:altwhen class implements interface by its base class member, the original design will not manage it. For example, interface I { foo(): i32; } class Base { foo(): i32 { return 42;} } class C extends...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef68b42d371252b0f236260d6234f4304a806fe5ac43d59faa21fb59d80df103b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/AssemblyScript/assemblyscript git https://github.com/AssemblyScript/assemblyscript.git
octolytics-dimension-user_id28916798
octolytics-dimension-user_loginAssemblyScript
octolytics-dimension-repository_id105138356
octolytics-dimension-repository_nwoAssemblyScript/assemblyscript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id105138356
octolytics-dimension-repository_network_root_nwoAssemblyScript/assemblyscript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6b74bc8dbcd10b5d69fd9ee9d2cfdc8b35e18a4c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FAssemblyScript%2Fassemblyscript%2Fpull%2F2969%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FAssemblyScript%2Fassemblyscript%2Fpull%2F2969%2Ffiles
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=AssemblyScript%2Fassemblyscript
Reloadhttps://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files
Reloadhttps://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files
Reloadhttps://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files
AssemblyScript https://patch-diff.githubusercontent.com/AssemblyScript
assemblyscripthttps://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript
Please reload this pagehttps://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2FAssemblyScript%2Fassemblyscript
Fork 682 https://patch-diff.githubusercontent.com/login?return_to=%2FAssemblyScript%2Fassemblyscript
Star 17.8k https://patch-diff.githubusercontent.com/login?return_to=%2FAssemblyScript%2Fassemblyscript
Code https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript
Issues 175 https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/issues
Pull requests 17 https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pulls
Actions https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/actions
Wiki https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/security
Please reload this pagehttps://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files
Insights https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pulse
Code https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript
Issues https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/issues
Pull requests https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pulls
Actions https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/actions
Wiki https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/wiki
Security https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/security
Insights https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2FAssemblyScript%2Fassemblyscript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2FAssemblyScript%2Fassemblyscript%2Fissues%2Fnew%2Fchoose
HerrCai0907https://patch-diff.githubusercontent.com/HerrCai0907
AssemblyScript:mainhttps://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/tree/main
HerrCai0907:2968-bug-compiler-generated-override-gettersetter-for-filed-in-interface-incorrectlyhttps://patch-diff.githubusercontent.com/HerrCai0907/assemblyscript/tree/2968-bug-compiler-generated-override-gettersetter-for-filed-in-interface-incorrectly
Conversation 1 https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969
Commits 2 https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/commits
Checks 14 https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/checks
Files changed 8 https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files
fix: generate correct override stub for interface when implementation from base class https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#top
Show all changes 2 commits https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files
0957546 fix: generate correct override stub for interface when implementation… HerrCai0907 Dec 28, 2025 https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/commits/0957546e79612e70534d4032f100d73632dd8ffe
bd223ff fix lint HerrCai0907 Dec 29, 2025 https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/commits/bd223ff279fa0ec6a00800079fd448ff01c9b265
Clear filters https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files
Please reload this pagehttps://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files
Please reload this pagehttps://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files
compiler.ts https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-041bb58b49fbc5e7fdf9b8d09f0f0ae8d524d727947bcfa3e3d1c91b8a35aeee
program.ts https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-34464090febe886c2a40aad4e347f95a9821cff69d4a43a793a376a466b3c885
resolver.ts https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-0d2f46f3b329944abf82b98bdebe5220e48742c8868011ed9b35b592f72b0fed
class-implements.debug.wat https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-ef442b1e7480cd1e31e347a4cd5a30a3273dc7bb963e823b663fbd179dd05818
class-implements.release.wat https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-002f9ac088697823ae7d4a740e6e89eb9b2499ab722b6604d02fd08d0403e887
impl-interface-in-base.debug.wat https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-6f78ef9fc990a3eb4e0414c26e5eb8cb4ae2c7a73fe4fca0995a7f3e0a998b62
impl-interface-in-base.release.wat https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-dae05367f5025ec45773aa9ce2d9ee581f86def338a94e2798bc59fcc6eae107
impl-interface-in-base.ts https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-dad39060b0d6a2662a696705d76e62b8f6d424ab52b33016eaed96e1d19a66d4
src/compiler.tshttps://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-041bb58b49fbc5e7fdf9b8d09f0f0ae8d524d727947bcfa3e3d1c91b8a35aeee
View file https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/blob/bd223ff279fa0ec6a00800079fd448ff01c9b265/src/compiler.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-041bb58b49fbc5e7fdf9b8d09f0f0ae8d524d727947bcfa3e3d1c91b8a35aeee
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-041bb58b49fbc5e7fdf9b8d09f0f0ae8d524d727947bcfa3e3d1c91b8a35aeee
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-041bb58b49fbc5e7fdf9b8d09f0f0ae8d524d727947bcfa3e3d1c91b8a35aeee
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-041bb58b49fbc5e7fdf9b8d09f0f0ae8d524d727947bcfa3e3d1c91b8a35aeee
src/program.tshttps://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-34464090febe886c2a40aad4e347f95a9821cff69d4a43a793a376a466b3c885
View file https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/blob/bd223ff279fa0ec6a00800079fd448ff01c9b265/src/program.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-34464090febe886c2a40aad4e347f95a9821cff69d4a43a793a376a466b3c885
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-34464090febe886c2a40aad4e347f95a9821cff69d4a43a793a376a466b3c885
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-34464090febe886c2a40aad4e347f95a9821cff69d4a43a793a376a466b3c885
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-34464090febe886c2a40aad4e347f95a9821cff69d4a43a793a376a466b3c885
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-34464090febe886c2a40aad4e347f95a9821cff69d4a43a793a376a466b3c885
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-34464090febe886c2a40aad4e347f95a9821cff69d4a43a793a376a466b3c885
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-34464090febe886c2a40aad4e347f95a9821cff69d4a43a793a376a466b3c885
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-34464090febe886c2a40aad4e347f95a9821cff69d4a43a793a376a466b3c885
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-34464090febe886c2a40aad4e347f95a9821cff69d4a43a793a376a466b3c885
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-34464090febe886c2a40aad4e347f95a9821cff69d4a43a793a376a466b3c885
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-34464090febe886c2a40aad4e347f95a9821cff69d4a43a793a376a466b3c885
src/resolver.tshttps://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-0d2f46f3b329944abf82b98bdebe5220e48742c8868011ed9b35b592f72b0fed
View file https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/blob/bd223ff279fa0ec6a00800079fd448ff01c9b265/src/resolver.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-0d2f46f3b329944abf82b98bdebe5220e48742c8868011ed9b35b592f72b0fed
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-0d2f46f3b329944abf82b98bdebe5220e48742c8868011ed9b35b592f72b0fed
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-0d2f46f3b329944abf82b98bdebe5220e48742c8868011ed9b35b592f72b0fed
tests/compiler/class-implements.debug.wathttps://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-ef442b1e7480cd1e31e347a4cd5a30a3273dc7bb963e823b663fbd179dd05818
View file https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/blob/bd223ff279fa0ec6a00800079fd448ff01c9b265/tests/compiler/class-implements.debug.wat
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-ef442b1e7480cd1e31e347a4cd5a30a3273dc7bb963e823b663fbd179dd05818
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-ef442b1e7480cd1e31e347a4cd5a30a3273dc7bb963e823b663fbd179dd05818
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-ef442b1e7480cd1e31e347a4cd5a30a3273dc7bb963e823b663fbd179dd05818
https://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files#diff-ef442b1e7480cd1e31e347a4cd5a30a3273dc7bb963e823b663fbd179dd05818
Please reload this pagehttps://patch-diff.githubusercontent.com/AssemblyScript/assemblyscript/pull/2969/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.