| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f8a7bb97-3d14-34b0-b175-a22586065a1a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BA0A:31D948:3C1BB:50931:698C90EE |
| html-safe-nonce | faf8b849a047b3824bd63729ab0c17dd5fc714b9b9427c0cf5060d9b4f34f684 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTBBOjMxRDk0ODozQzFCQjo1MDkzMTo2OThDOTBFRSIsInZpc2l0b3JfaWQiOiI0MTU0OTU3MDU0NzUyODg3MDIyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | fa56adf37a9c5d3cd726cd59ec700ac19d6ccb02c271aed278a8a627a242d404 |
| hovercard-subject-tag | pull_request:3030958170 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/ActivitySim/activitysim/1023/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/97f43873399f8e39a101b74b0aaeee77993f28276156f00f6cf5729cab635117/ActivitySim/activitysim/pull/1023 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/97f43873399f8e39a101b74b0aaeee77993f28276156f00f6cf5729cab635117/ActivitySim/activitysim/pull/1023 |
| og:image:alt | This PR addresses issue #892.
Status: Draft - core functionality implemented, remaining: logging and documentation. Update: logging and documentation are added.
Summary
Adds a new skip_failed_choic... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | i-am-sijia |
| hostname | github.com |
| expected-hostname | github.com |
| None | 640eeb7b6ff4d8d106235d228c0c286e82592d4d2403227b5b2b4fc5832297a4 |
| turbo-cache-control | no-preview |
| go-import | github.com/ActivitySim/activitysim git https://github.com/ActivitySim/activitysim.git |
| octolytics-dimension-user_id | 25851945 |
| octolytics-dimension-user_login | ActivitySim |
| octolytics-dimension-repository_id | 20981950 |
| octolytics-dimension-repository_nwo | ActivitySim/activitysim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20981950 |
| octolytics-dimension-repository_network_root_nwo | ActivitySim/activitysim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3d444f0a47beeeac94cddbb51c91ab408befe8d4 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FActivitySim%2Factivitysim%2Fpull%2F1023 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FActivitySim%2Factivitysim%2Fpull%2F1023 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=ActivitySim%2Factivitysim |
| Reload | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| Reload | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| Reload | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
|
ActivitySim
| https://patch-diff.githubusercontent.com/ActivitySim |
| activitysim | https://patch-diff.githubusercontent.com/ActivitySim/activitysim |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2FActivitySim%2Factivitysim |
|
Fork
121
| https://patch-diff.githubusercontent.com/login?return_to=%2FActivitySim%2Factivitysim |
|
Star
225
| https://patch-diff.githubusercontent.com/login?return_to=%2FActivitySim%2Factivitysim |
|
Code
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim |
|
Issues
166
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/issues |
|
Pull requests
7
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pulls |
|
Discussions
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/discussions |
|
Actions
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/actions |
|
Projects
4
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/wiki |
|
Security
0
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/security |
|
Insights
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pulse |
|
Code
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim |
|
Issues
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pulls |
|
Discussions
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/discussions |
|
Actions
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/actions |
|
Projects
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/projects |
|
Wiki
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/wiki |
|
Security
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/security |
|
Insights
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pulse |
| Sign up for GitHub
| https://patch-diff.githubusercontent.com/signup?return_to=%2FActivitySim%2Factivitysim%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=%2FActivitySim%2Factivitysim%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#issue-comment-box |
| i-am-sijia | https://patch-diff.githubusercontent.com/i-am-sijia |
| ActivitySim:main | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/tree/main |
| wsp-sag:skip-failed-hh | https://patch-diff.githubusercontent.com/wsp-sag/activitysim/tree/skip-failed-hh |
|
Add global option to skip households on simulation failure
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#top |
| i-am-sijia | https://patch-diff.githubusercontent.com/i-am-sijia |
| ActivitySim:main | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/tree/main |
| wsp-sag:skip-failed-hh | https://patch-diff.githubusercontent.com/wsp-sag/activitysim/tree/skip-failed-hh |
|
Conversation
38
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
|
Commits
23
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits |
|
Checks
19
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/files |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
| i-am-sijia | https://patch-diff.githubusercontent.com/i-am-sijia |
| Nov 20, 2025 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#issue-3648522401 |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| #892 | https://github.com/ActivitySim/activitysim/issues/892 |
| Access to global constants and removing chooser col filtering #1017 | https://github.com/ActivitySim/activitysim/pull/1017 |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| i-am-sijia | https://patch-diff.githubusercontent.com/i-am-sijia |
| November 13, 2025 11:53 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#commits-pushed-a0ec6a8 |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
| skip hh in simple simulate | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/a0ec6a8c992f5d2f6af4485ff639405b7d3bc738 |
| a0ec6a8 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/a0ec6a8c992f5d2f6af4485ff639405b7d3bc738 |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
| retain household_id by default in the drop_unused_columns() | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/8623516283f584c432a94c201679949e6713da67 |
| 8623516 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/8623516283f584c432a94c201679949e6713da67 |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
| skip choice for interaction sample simulate | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/397f2509a45cc8d474f240c04b34471353a55b05 |
| 397f250 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/397f2509a45cc8d474f240c04b34471353a55b05 |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
| don't log hh id when bad choice df is empy | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/fa08f11b489ecf8d629aa00441c37557a6416c1a |
| fa08f11 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/fa08f11b489ecf8d629aa00441c37557a6416c1a |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
| add hh id to user specified chooser_columns when chooser_columns … | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/f26cc8002a767960b35958a2fb44bc6f35848c5c |
| f26cc80 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/f26cc8002a767960b35958a2fb44bc6f35848c5c |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
| blacken | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/76fd8338c328c44560b3cf792c33f93ee9c9f434 |
| 76fd833 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/76fd8338c328c44560b3cf792c33f93ee9c9f434 |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
| update test utils to probs raises | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/96e73ecdf68519e606c3dd00646a9db7d839116c |
| 96e73ec | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/96e73ecdf68519e606c3dd00646a9db7d839116c |
| https://patch-diff.githubusercontent.com/jpn-- |
| jpn-- | https://patch-diff.githubusercontent.com/jpn-- |
| Phase 11 | https://patch-diff.githubusercontent.com/orgs/ActivitySim/projects/9 |
| Dec 2, 2025 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#event-21314219032 |
| https://patch-diff.githubusercontent.com/jpn-- |
| jpn-- | https://patch-diff.githubusercontent.com/jpn-- |
| Phase 11 | https://patch-diff.githubusercontent.com/orgs/ActivitySim/projects/9 |
| Dec 2, 2025 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#event-21314220419 |
| https://patch-diff.githubusercontent.com/jpn-- |
| jpn-- | https://patch-diff.githubusercontent.com/jpn-- |
| i-am-sijia | https://patch-diff.githubusercontent.com/i-am-sijia |
| Dec 4, 2025 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#event-21367630703 |
| i-am-sijia | https://patch-diff.githubusercontent.com/i-am-sijia |
| December 9, 2025 20:03 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#commits-pushed-cf98cd2 |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
| [skip ci] shadow price calc without failed choices | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/cf98cd2342c15d806ce803d51f41796db043decb |
| cf98cd2 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/cf98cd2342c15d806ce803d51f41796db043decb |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
| [skip ci] special case in trip mode choice | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/baa47fa12a4ce78372012e95a83602997284acb8 |
| baa47fa | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/baa47fa12a4ce78372012e95a83602997284acb8 |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
| [skip ci] adjust sample_rate | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/6cffd9b5a871f58ca6b041410887d128d41f0816 |
| 6cffd9b | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/6cffd9b5a871f58ca6b041410887d128d41f0816 |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
| [skip ci] add final logging of num hh skipped | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/0e34b7dd04f2df91291ac9ed0a30120800fb1750 |
| 0e34b7d | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/0e34b7dd04f2df91291ac9ed0a30120800fb1750 |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
| unit test | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/5da9715236ed2cc05144045a59926e520c8e56e9 |
| 5da9715 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/5da9715236ed2cc05144045a59926e520c8e56e9 |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
| update CI | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/50034fd281285eba8a1935e0831e2563d26065a7 |
| 50034fd | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/50034fd281285eba8a1935e0831e2563d26065a7 |
| https://patch-diff.githubusercontent.com/i-am-sijia |
| i-am-sijia | https://patch-diff.githubusercontent.com/i-am-sijia |
| Dec 10, 2025 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#issuecomment-3635409958 |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| https://patch-diff.githubusercontent.com/jpn-- |
| jpn-- | https://patch-diff.githubusercontent.com/jpn-- |
| Phase 11 | https://patch-diff.githubusercontent.com/orgs/ActivitySim/projects/9 |
| Dec 11, 2025 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#event-21492049006 |
| https://patch-diff.githubusercontent.com/jpn-- |
| jpn-- | https://patch-diff.githubusercontent.com/jpn-- |
| December 11, 2025 01:03 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#event-21492059480 |
| https://patch-diff.githubusercontent.com/jpn-- |
| jpn-- | https://patch-diff.githubusercontent.com/jpn-- |
|
Dec 11, 2025
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#ref-issue-3681491037 |
|
2025-12-11 Engineering Team
ActivitySim/meeting-notes#52
| https://patch-diff.githubusercontent.com/ActivitySim/meeting-notes/issues/52 |
| https://patch-diff.githubusercontent.com/jpn-- |
| jpn-- | https://patch-diff.githubusercontent.com/jpn-- |
| Copilot | https://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer |
| January 8, 2026 17:44 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#event-21929028557 |
| started reviewing | https://github.com/ActivitySim/activitysim/agents/pull/1023?session_id=3bb1cdb9-7376-407d-bd01-5cfa2fb9794e |
| jpn-- | https://patch-diff.githubusercontent.com/jpn-- |
| January 8, 2026 17:45 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#event-21929042218 |
|
View session
| https://github.com/ActivitySim/activitysim/agents/pull/1023?session_id=3bb1cdb9-7376-407d-bd01-5cfa2fb9794e |
|
| https://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer |
| Copilot | https://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer |
|
Jan 8, 2026
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#pullrequestreview-3640571976 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/files/50034fd281285eba8a1935e0831e2563d26065a7 |
| Copilot | https://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer |
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#pullrequestreview-3640571976 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Add Copilot custom instructions | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/new/main/.github/instructions?filename=*.instructions.md |
| Learn how to get started | https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| activitysim/abm/models/util/school_escort_tours_trips.py | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/files/50034fd281285eba8a1935e0831e2563d26065a7#diff-f34bad9be0028fa549ffc474aa51f96c0b6b31a429a284955e8b7b87555eaa6e |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| activitysim/core/logit.py | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/files/50034fd281285eba8a1935e0831e2563d26065a7#diff-88c604ed4382f65533159aa8b662b2d35897a3e7245e9db60aff0dfbb24d2167 |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| activitysim/core/logit.py | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/files/50034fd281285eba8a1935e0831e2563d26065a7#diff-88c604ed4382f65533159aa8b662b2d35897a3e7245e9db60aff0dfbb24d2167 |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| activitysim/core/simulate.py | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/files/50034fd281285eba8a1935e0831e2563d26065a7#diff-3b8c25f307a55dd3bdd60b73a025893bc6174504ed67c7ae2702bdd3eac51193 |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| test/skip_failed_choices/test_skip_failed_choices.py | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/files/50034fd281285eba8a1935e0831e2563d26065a7#diff-5501661252a50c0209c8cd93d69869f3c33462cfa8999ffa335d58e470ac6ce4 |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| activitysim/core/workflow/state.py | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/files/50034fd281285eba8a1935e0831e2563d26065a7#diff-fe8011cebf7b60da2bcbf32c04f2f98d02d5fa0603c40fc61f3d232e338c036a |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| activitysim/core/util.py | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/files/50034fd281285eba8a1935e0831e2563d26065a7#diff-4ac4d2e5c101db9399f46d7a60d7fc895e710ea12a505df1b8676f407fd43757 |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| test/skip_failed_choices/test_skip_failed_choices.py | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/files/50034fd281285eba8a1935e0831e2563d26065a7#diff-5501661252a50c0209c8cd93d69869f3c33462cfa8999ffa335d58e470ac6ce4 |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| test/skip_failed_choices/test_skip_failed_choices.py | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/files/50034fd281285eba8a1935e0831e2563d26065a7#diff-5501661252a50c0209c8cd93d69869f3c33462cfa8999ffa335d58e470ac6ce4 |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| activitysim/core/workflow/state.py | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/files/50034fd281285eba8a1935e0831e2563d26065a7#diff-fe8011cebf7b60da2bcbf32c04f2f98d02d5fa0603c40fc61f3d232e338c036a |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| https://patch-diff.githubusercontent.com/jpn-- |
| jpn-- | https://patch-diff.githubusercontent.com/jpn-- |
|
Jan 8, 2026
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#pullrequestreview-3640556861 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/files/50034fd281285eba8a1935e0831e2563d26065a7 |
| jpn-- | https://patch-diff.githubusercontent.com/jpn-- |
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#pullrequestreview-3640556861 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @i-am-sijia | https://github.com/i-am-sijia |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| activitysim/abm/models/util/school_escort_tours_trips.py | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/files/50034fd281285eba8a1935e0831e2563d26065a7#diff-f34bad9be0028fa549ffc474aa51f96c0b6b31a429a284955e8b7b87555eaa6e |
| jpn-- | https://patch-diff.githubusercontent.com/jpn-- |
| Jan 8, 2026 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#discussion_r2673309449 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| i-am-sijia | https://patch-diff.githubusercontent.com/i-am-sijia |
| Jan 20, 2026 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#discussion_r2708968271 |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| activitysim/abm/models/location_choice.py | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/files/50034fd281285eba8a1935e0831e2563d26065a7#diff-1e859058c23debe5b8ced1ad93b6b7c7403e6bce864f4bb64f2824ecc8a9f565 |
| jpn-- | https://patch-diff.githubusercontent.com/jpn-- |
| Jan 8, 2026 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#discussion_r2673323380 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| i-am-sijia | https://patch-diff.githubusercontent.com/i-am-sijia |
| Jan 20, 2026 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#discussion_r2708989706 |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| activitysim/abm/models/trip_matrices.py | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/files/50034fd281285eba8a1935e0831e2563d26065a7#diff-1149f0b7d04b32e7643996853f39bb5a6610a6c7caff7c156628ea03f92fae97 |
| jpn-- | https://patch-diff.githubusercontent.com/jpn-- |
| Jan 8, 2026 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#discussion_r2673326128 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| i-am-sijia | https://patch-diff.githubusercontent.com/i-am-sijia |
| Jan 20, 2026 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#discussion_r2709009199 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| activitysim/abm/models/trip_matrices.py | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/files/50034fd281285eba8a1935e0831e2563d26065a7#diff-1149f0b7d04b32e7643996853f39bb5a6610a6c7caff7c156628ea03f92fae97 |
| jpn-- | https://patch-diff.githubusercontent.com/jpn-- |
| Jan 8, 2026 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#discussion_r2673336225 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| i-am-sijia | https://patch-diff.githubusercontent.com/i-am-sijia |
| Jan 20, 2026 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#discussion_r2709193329 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| sample rate | https://github.com/ActivitySim/activitysim/blob/aa58cc453e1a0ff5c7d5498776f2f594b6085658/activitysim/abm/tables/households.py#L98-L104 |
| 1/sample rate | https://github.com/ActivitySim/activitysim/blob/aa58cc453e1a0ff5c7d5498776f2f594b6085658/activitysim/abm/models/trip_matrices.py#L415-L418 |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| activitysim/abm/models/trip_mode_choice.py | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/files/50034fd281285eba8a1935e0831e2563d26065a7#diff-5a2a3971aede0acf8b8f93968cf6b6ef95b527f1e244a9cbd6148f0921242a62 |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| activitysim/core/configuration/top.py | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/files/50034fd281285eba8a1935e0831e2563d26065a7#diff-3ce7fd936fde7f3c3df382b6d94fd5922d9e7456c716cb6923ee9267aac807d0 |
| jpn-- | https://patch-diff.githubusercontent.com/jpn-- |
| Jan 8, 2026 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#discussion_r2673347067 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| i-am-sijia | https://patch-diff.githubusercontent.com/i-am-sijia |
| Jan 20, 2026 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#discussion_r2709202137 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| activitysim/core/logit.py | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/files/50034fd281285eba8a1935e0831e2563d26065a7#diff-88c604ed4382f65533159aa8b662b2d35897a3e7245e9db60aff0dfbb24d2167 |
| jpn-- | https://patch-diff.githubusercontent.com/jpn-- |
| Jan 8, 2026 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#discussion_r2673357614 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| i-am-sijia | https://patch-diff.githubusercontent.com/i-am-sijia |
| Jan 20, 2026 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#discussion_r2709206307 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| i-am-sijia | https://patch-diff.githubusercontent.com/i-am-sijia |
| January 19, 2026 13:32 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#commits-pushed-a6ed5cb |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
| track and summarize failed households by component | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/a6ed5cb69ad0d87b213a55a2c7839e07c3d5f4ad |
| a6ed5cb | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/a6ed5cb69ad0d87b213a55a2c7839e07c3d5f4ad |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
| skipped_household_ids is now a dictionary | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/91227b66b4b86762f5b65c12327f67caf806d2ed |
| 91227b6 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/91227b66b4b86762f5b65c12327f67caf806d2ed |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
| print more loggings about trips missing modes | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/c986e5bd9e9b59c9633e4e05f5db29f47fef306e |
| c986e5b | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/c986e5bd9e9b59c9633e4e05f5db29f47fef306e |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
| adjust trip expansion factor using hh weight instead of count | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/e6a8c1b49f34f7e367db503c360540bcaa71933a |
| e6a8c1b | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/e6a8c1b49f34f7e367db503c360540bcaa71933a |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
| update state tables only when new households are skipped | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/ee5291611defbb3da1930fdbc9a7e4af692a1a10 |
| ee52916 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/ee5291611defbb3da1930fdbc9a7e4af692a1a10 |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
| put a limit on num of households allowed to skip | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/5316890ea03cfdb9931878deb2fee5ea550a4b96 |
| 5316890 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/5316890ea03cfdb9931878deb2fee5ea550a4b96 |
| i-am-sijia | https://patch-diff.githubusercontent.com/i-am-sijia |
| January 22, 2026 21:11 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#commits-pushed-f0a2581 |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
| auto debug tracing newly failed choice | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/f0a2581b3fea6be706444dedb89b68c3ffd54b1f |
| f0a2581 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/f0a2581b3fea6be706444dedb89b68c3ffd54b1f |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
| update test | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/f04bf1459d829bbea963e5ab653cf3f05928811e |
| f04bf14 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/f04bf1459d829bbea963e5ab653cf3f05928811e |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
| Add documentation to user guide | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/9d3d018d2118269de59793a616984f6cadf9f9b2 |
| 9d3d018 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/9d3d018d2118269de59793a616984f6cadf9f9b2 |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
| Merge branch 'main' into skip-failed-hh | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/06c6d753f4f0080eb53658538fb23f5fcb33faf7 |
| 06c6d75 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/commits/06c6d753f4f0080eb53658538fb23f5fcb33faf7 |
| https://patch-diff.githubusercontent.com/i-am-sijia |
| i-am-sijia | https://patch-diff.githubusercontent.com/i-am-sijia |
| Jan 25, 2026 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#issuecomment-3797386261 |
| @jpn-- | https://github.com/jpn-- |
| @bhargavasana | https://github.com/bhargavasana |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
| https://patch-diff.githubusercontent.com/i-am-sijia |
| i-am-sijia | https://patch-diff.githubusercontent.com/i-am-sijia |
| January 25, 2026 23:22 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#event-22277906414 |
| https://patch-diff.githubusercontent.com/jpn-- |
| jpn-- | https://patch-diff.githubusercontent.com/jpn-- |
| dhensle | https://patch-diff.githubusercontent.com/dhensle |
| January 29, 2026 19:09 | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023#event-22385586174 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2FActivitySim%2Factivitysim%2Fpull%2F1023 |
|
Copilot code review
| https://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer |
|
Copilot
| https://patch-diff.githubusercontent.com/apps/copilot-pull-request-reviewer |
|
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/files/50034fd281285eba8a1935e0831e2563d26065a7 |
|
| https://patch-diff.githubusercontent.com/jpn-- |
|
jpn--
| https://patch-diff.githubusercontent.com/jpn-- |
|
| https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023/files/50034fd281285eba8a1935e0831e2563d26065a7 |
|
| https://patch-diff.githubusercontent.com/dhensle |
|
dhensle
| https://patch-diff.githubusercontent.com/dhensle |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
|
i-am-sijia
| https://patch-diff.githubusercontent.com/i-am-sijia |
|
Phase 11
| https://patch-diff.githubusercontent.com/orgs/ActivitySim/projects/9 |
| Please reload this page | https://patch-diff.githubusercontent.com/ActivitySim/activitysim/pull/1023 |
|
| https://patch-diff.githubusercontent.com/i-am-sijia |
|
| https://patch-diff.githubusercontent.com/jpn-- |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |