René's URL Explorer Experiment


Title: fix: keep question marks in applied templates by ysamcode · Pull Request #689 · ycode/ycode · GitHub

Open Graph Title: fix: keep question marks in applied templates by ysamcode · Pull Request #689 · ycode/ycode

X Title: fix: keep question marks in applied templates by ysamcode · Pull Request #689 · ycode/ycode

Description: Summary Applying a template replaced every ? in its content with $1, $2, …. Images with a query string in their URL stopped loading and text such as "When does the program start?" was stored as "When does the program start$22". Changes Run the SQL returned by the template service on the transaction's own connection instead of trx.raw(). knex treats every ? in a raw query as a binding placeholder, including the ones inside string literals Apply the same to the "clear previous template" SQL, which also comes from the template service Send the SQL as-is rather than escaping ? as \?: knex drops backslashes directly before a ?, so a /\?/ regex in custom code would still be altered Test plan Apply a template whose images use URLs with a query string (e.g. Solstice) and confirm the images load in the builder and on the published site Confirm FAQ headings and other text end in ?, not $22 Confirm prices such as $129 are unchanged Apply a second template over the first and confirm the previous template's assets are cleared and user uploads are kept Apply a template with an invalid statement (or interrupt the apply) and confirm the existing content is left untouched

Open Graph Description: Summary Applying a template replaced every ? in its content with $1, $2, …. Images with a query string in their URL stopped loading and text such as "When does the program start?" was sto...

X Description: Summary Applying a template replaced every ? in its content with $1, $2, …. Images with a query string in their URL stopped loading and text such as "When does the program start?"...

Opengraph URL: https://github.com/ycode/ycode/pull/689

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d68c6879-aab0-5136-333a-408f54bdee7d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA5AC:195CE:2330AE:2E1BB2:6AFE4A3E
html-safe-noncef32abef3769c0ad8a997cd0313cf44e770a78f51de0eba37a74629bcf27e7319
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNUFDOjE5NUNFOjIzMzBBRToyRTFCQjI6NkFGRTRBM0UiLCJ2aXNpdG9yX2lkIjoiODc0ODc2ODA1MDY3ODc0NTY2MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdab25089645ec7b8f1655653ad0047f5ec6f3cbaaf33e04604788db511086308
hovercard-subject-tagpull_request:5357360595
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/ycode/ycode/pull/689/files
twitter:imagehttps://avatars.githubusercontent.com/u/7631193?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7631193?s=400&v=4
og:image:altSummary Applying a template replaced every ? in its content with $1, $2, …. Images with a query string in their URL stopped loading and text such as "When does the program start?" was sto...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef1a5901e2377b0af2a0b303f9528678f1475d04b9219dca1e993344196eaa07c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/ycode/ycode git https://github.com/ycode/ycode.git
octolytics-dimension-user_id65892203
octolytics-dimension-user_loginycode
octolytics-dimension-repository_id1165452593
octolytics-dimension-repository_nwoycode/ycode
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1165452593
octolytics-dimension-repository_network_root_nwoycode/ycode
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasece393ea11ad276623b946bc9663d3e7d6f564275
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/ycode/ycode/pull/689/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fycode%2Fycode%2Fpull%2F689%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fycode%2Fycode%2Fpull%2F689%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=ycode%2Fycode
Reloadhttps://github.com/ycode/ycode/pull/689/files
Reloadhttps://github.com/ycode/ycode/pull/689/files
Reloadhttps://github.com/ycode/ycode/pull/689/files
ycodehttps://github.com/ycode
ycodehttps://github.com/ycode/ycode
Codehttps://github.com/ycode/ycode
Issues7 (7)https://github.com/ycode/ycode/issues
Pull requests1 (1)https://github.com/ycode/ycode/pulls
Discussionshttps://github.com/ycode/ycode/discussions
Actionshttps://github.com/ycode/ycode/actions
Projectshttps://github.com/ycode/ycode/projects
Security and quality1 (1)https://github.com/ycode/ycode/security
Insightshttps://github.com/ycode/ycode/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fycode%2Fycode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fycode%2Fycode%2Fissues%2Fnew%2Fchoose
ysamcodehttps://github.com/ysamcode
develophttps://github.com/ycode/ycode/tree/develop
fix/template-apply-question-markshttps://github.com/ycode/ycode/tree/fix/template-apply-question-marks
Conversation 0 https://github.com/ycode/ycode/pull/689
Commits 1 https://github.com/ycode/ycode/pull/689/commits
Checks 0 https://github.com/ycode/ycode/pull/689/checks
Files changed https://github.com/ycode/ycode/pull/689/files
Please reload this pagehttps://github.com/ycode/ycode/pull/689/files
fix: keep question marks in applied templates https://github.com/ycode/ycode/pull/689/files#top
Show all changes 1 commit https://github.com/ycode/ycode/pull/689/files
9c1284d fix: keep question marks when applying templates ysamcode Nov 17, 2026 https://github.com/ycode/ycode/pull/689/commits/9c1284df1cb307ad25639fe69e5a32bf1e77d5a9
Clear filters https://github.com/ycode/ycode/pull/689/files
Please reload this pagehttps://github.com/ycode/ycode/pull/689/files
Please reload this pagehttps://github.com/ycode/ycode/pull/689/files
https://github.com/ycode/ycode/blob/develop/.github/CODEOWNERS#L1
lib/services/templateService.tshttps://github.com/ycode/ycode/pull/689/files#diff-4e75388655891e6c600fc03775b29e0ecbaa83fd106078f37f61942c21bfb991
View file https://github.com/ycode/ycode/blob/9c1284df1cb307ad25639fe69e5a32bf1e77d5a9/lib/services/templateService.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/ycode/ycode/pull/689/{{ revealButtonHref }}
https://github.com/ycode/ycode/pull/689/files#diff-4e75388655891e6c600fc03775b29e0ecbaa83fd106078f37f61942c21bfb991
https://github.com/ycode/ycode/pull/689/files#diff-4e75388655891e6c600fc03775b29e0ecbaa83fd106078f37f61942c21bfb991
https://github.com/ycode/ycode/pull/689/files#diff-4e75388655891e6c600fc03775b29e0ecbaa83fd106078f37f61942c21bfb991
https://github.com/ycode/ycode/pull/689/files#diff-4e75388655891e6c600fc03775b29e0ecbaa83fd106078f37f61942c21bfb991
https://github.com/ycode/ycode/pull/689/files#diff-4e75388655891e6c600fc03775b29e0ecbaa83fd106078f37f61942c21bfb991
https://github.com/ycode/ycode/pull/689/files#diff-4e75388655891e6c600fc03775b29e0ecbaa83fd106078f37f61942c21bfb991
https://github.com/ycode/ycode/pull/689/files#diff-4e75388655891e6c600fc03775b29e0ecbaa83fd106078f37f61942c21bfb991
https://github.com/ycode/ycode/pull/689/files#diff-4e75388655891e6c600fc03775b29e0ecbaa83fd106078f37f61942c21bfb991
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.