René's URL Explorer Experiment


Title: fix: make links to SVG icon assets downloadable by ysamcode · Pull Request #575 · ycode/ycode · GitHub

Open Graph Title: fix: make links to SVG icon assets downloadable by ysamcode · Pull Request #575 · ycode/ycode

X Title: fix: make links to SVG icon assets downloadable by ysamcode · Pull Request #575 · ycode/ycode

Description: Summary Links pointing at an SVG from the icon library rendered as href="#no-svg-url" and did nothing when clicked. Icon SVGs are stored inline (markup in content, no storage_path/public_url), and the link resolver still treated that as "no URL exists" even though the /a/ proxy has served inline SVGs for a while. Route those links through the proxy so they open and download like any other file. Changes Add resolveAssetLinkHref in lib/link-utils.ts that returns public_url for storage-backed assets and the versioned /a/{hash}/{slug}.svg proxy URL for inline SVGs Replace every #no-svg-url dead end (direct asset links, CMS link fields, asset-typed field links, collection link values) with the new resolver Carry id/filename in the SSR resolvedAssets map and in the renderers' getAsset callbacks so the public renderer can build the same URL Share LinkAssetLike / ResolvedAsset types across PageRenderer, LayerRenderer, LayerRendererPublic and page-fetcher instead of four inline copies Add lib/asset-link.test.ts regression tests covering the client, SSR and assetMap resolution paths Test plan Add a text or button layer, set its link to an SVG from the icon library with Download enabled, publish — clicking downloads .svg Same link without Download opens the SVG in the browser Link to a storage-backed file (PDF, PNG) still resolves to its existing /a/… URL CMS link field pointing at an icon SVG resolves on a collection list and a dynamic page Icon layers still render inline SVG (no regression from the resolvedAssets shape change) Static export bundles the linked SVG under /a/… npm test passes

Open Graph Description: Summary Links pointing at an SVG from the icon library rendered as href="#no-svg-url" and did nothing when clicked. Icon SVGs are stored inline (markup in content, no storage_path/public_...

X Description: Summary Links pointing at an SVG from the icon library rendered as href="#no-svg-url" and did nothing when clicked. Icon SVGs are stored inline (markup in content, no storage_path...

Opengraph URL: https://github.com/ycode/ycode/pull/575

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fb79a3ff-086c-366e-e48d-fe1ce84642fb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD1BA:A4A72:100F2D:14C5A9:6AFE4531
html-safe-nonce8f755b9bc3533d2ad72d380f2c8ca878f0e2f60d728ee0832a4f561a13442f28
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMUJBOkE0QTcyOjEwMEYyRDoxNEM1QTk6NkFGRTQ1MzEiLCJ2aXNpdG9yX2lkIjoiNjU3NzI3ODUzMzM4MTI3Njk3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac17e0f3ce0b01c540f5fad7e92b9eb984e8c34290ee6272f9632147cbb808fd2c
hovercard-subject-tagpull_request:4626937587
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/ycode/ycode/pull/575/files
twitter:imagehttps://avatars.githubusercontent.com/u/7631193?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7631193?s=400&v=4
og:image:altSummary Links pointing at an SVG from the icon library rendered as href="#no-svg-url" and did nothing when clicked. Icon SVGs are stored inline (markup in content, no storage_path/public_...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef1a5901e2377b0af2a0b303f9528678f1475d04b9219dca1e993344196eaa07c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/ycode/ycode git https://github.com/ycode/ycode.git
octolytics-dimension-user_id65892203
octolytics-dimension-user_loginycode
octolytics-dimension-repository_id1165452593
octolytics-dimension-repository_nwoycode/ycode
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1165452593
octolytics-dimension-repository_network_root_nwoycode/ycode
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasece393ea11ad276623b946bc9663d3e7d6f564275
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/ycode/ycode/pull/575/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fycode%2Fycode%2Fpull%2F575%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fycode%2Fycode%2Fpull%2F575%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=ycode%2Fycode
Reloadhttps://github.com/ycode/ycode/pull/575/files
Reloadhttps://github.com/ycode/ycode/pull/575/files
Reloadhttps://github.com/ycode/ycode/pull/575/files
ycodehttps://github.com/ycode
ycodehttps://github.com/ycode/ycode
Codehttps://github.com/ycode/ycode
Issues7 (7)https://github.com/ycode/ycode/issues
Pull requests1 (1)https://github.com/ycode/ycode/pulls
Discussionshttps://github.com/ycode/ycode/discussions
Actionshttps://github.com/ycode/ycode/actions
Projectshttps://github.com/ycode/ycode/projects
Security and quality1 (1)https://github.com/ycode/ycode/security
Insightshttps://github.com/ycode/ycode/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fycode%2Fycode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fycode%2Fycode%2Fissues%2Fnew%2Fchoose
ysamcodehttps://github.com/ysamcode
develophttps://github.com/ycode/ycode/tree/develop
fix/inline-svg-asset-linkshttps://github.com/ycode/ycode/tree/fix/inline-svg-asset-links
Conversation 0 https://github.com/ycode/ycode/pull/575
Commits 1 https://github.com/ycode/ycode/pull/575/commits
Checks 0 https://github.com/ycode/ycode/pull/575/checks
Files changed https://github.com/ycode/ycode/pull/575/files
Please reload this pagehttps://github.com/ycode/ycode/pull/575/files
fix: make links to SVG icon assets downloadable https://github.com/ycode/ycode/pull/575/files#top
Show all changes 1 commit https://github.com/ycode/ycode/pull/575/files
225aae3 fix: make links to inline SVG assets downloadable ysamcode Sep 24, 2026 https://github.com/ycode/ycode/pull/575/commits/225aae33abf0b069552705fa05110e17a76e7a81
Clear filters https://github.com/ycode/ycode/pull/575/files
Please reload this pagehttps://github.com/ycode/ycode/pull/575/files
Please reload this pagehttps://github.com/ycode/ycode/pull/575/files
LayerRenderer.tsx https://github.com/ycode/ycode/pull/575/files#diff-3533cf1930345e3393481c3bdade5396e611e5a4ae915db5b4dd59b9f1fbbe0a
LayerRendererPublic.tsx https://github.com/ycode/ycode/pull/575/files#diff-499181a85861d11334a0f03d8d10e5c77101833d703605a17fff08341e6e9799
PageRenderer.tsx https://github.com/ycode/ycode/pull/575/files#diff-fd744ab1e8621b1ead61c31be2c1ee564e0ec2f132090b9347bf922e9200e583
asset-link.test.ts https://github.com/ycode/ycode/pull/575/files#diff-a6f385a2c8bfdf07e57bd5d3427944f1321209a1bcff8bc0640e9501b101fff8
link-utils.ts https://github.com/ycode/ycode/pull/575/files#diff-3be163fc3672481f29209957f4a535eeebf2d0fd49c78115f857f86b95fb07ae
page-fetcher.ts https://github.com/ycode/ycode/pull/575/files#diff-28e0b23fdbe1ae4953b860f3213a935ad8d5a4c9102c3ac6180a859ae29b3f99
package.json https://github.com/ycode/ycode/pull/575/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/ycode/ycode/blob/develop/.github/CODEOWNERS#L1
components/LayerRenderer.tsxhttps://github.com/ycode/ycode/pull/575/files#diff-3533cf1930345e3393481c3bdade5396e611e5a4ae915db5b4dd59b9f1fbbe0a
View file https://github.com/ycode/ycode/blob/225aae33abf0b069552705fa05110e17a76e7a81/components/LayerRenderer.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/ycode/ycode/pull/575/{{ revealButtonHref }}
https://github.com/ycode/ycode/pull/575/files#diff-3533cf1930345e3393481c3bdade5396e611e5a4ae915db5b4dd59b9f1fbbe0a
https://github.com/ycode/ycode/pull/575/files#diff-3533cf1930345e3393481c3bdade5396e611e5a4ae915db5b4dd59b9f1fbbe0a
https://github.com/ycode/ycode/pull/575/files#diff-3533cf1930345e3393481c3bdade5396e611e5a4ae915db5b4dd59b9f1fbbe0a
https://github.com/ycode/ycode/pull/575/files#diff-3533cf1930345e3393481c3bdade5396e611e5a4ae915db5b4dd59b9f1fbbe0a
https://github.com/ycode/ycode/pull/575/files#diff-3533cf1930345e3393481c3bdade5396e611e5a4ae915db5b4dd59b9f1fbbe0a
https://github.com/ycode/ycode/pull/575/files#diff-3533cf1930345e3393481c3bdade5396e611e5a4ae915db5b4dd59b9f1fbbe0a
https://github.com/ycode/ycode/pull/575/files#diff-3533cf1930345e3393481c3bdade5396e611e5a4ae915db5b4dd59b9f1fbbe0a
https://github.com/ycode/ycode/pull/575/files#diff-3533cf1930345e3393481c3bdade5396e611e5a4ae915db5b4dd59b9f1fbbe0a
https://github.com/ycode/ycode/pull/575/files#diff-3533cf1930345e3393481c3bdade5396e611e5a4ae915db5b4dd59b9f1fbbe0a
https://github.com/ycode/ycode/pull/575/files#diff-3533cf1930345e3393481c3bdade5396e611e5a4ae915db5b4dd59b9f1fbbe0a
https://github.com/ycode/ycode/blob/develop/.github/CODEOWNERS#L1
components/LayerRendererPublic.tsxhttps://github.com/ycode/ycode/pull/575/files#diff-499181a85861d11334a0f03d8d10e5c77101833d703605a17fff08341e6e9799
View file https://github.com/ycode/ycode/blob/225aae33abf0b069552705fa05110e17a76e7a81/components/LayerRendererPublic.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/ycode/ycode/pull/575/{{ revealButtonHref }}
https://github.com/ycode/ycode/pull/575/files#diff-499181a85861d11334a0f03d8d10e5c77101833d703605a17fff08341e6e9799
https://github.com/ycode/ycode/pull/575/files#diff-499181a85861d11334a0f03d8d10e5c77101833d703605a17fff08341e6e9799
https://github.com/ycode/ycode/pull/575/files#diff-499181a85861d11334a0f03d8d10e5c77101833d703605a17fff08341e6e9799
https://github.com/ycode/ycode/pull/575/files#diff-499181a85861d11334a0f03d8d10e5c77101833d703605a17fff08341e6e9799
https://github.com/ycode/ycode/pull/575/files#diff-499181a85861d11334a0f03d8d10e5c77101833d703605a17fff08341e6e9799
https://github.com/ycode/ycode/pull/575/files#diff-499181a85861d11334a0f03d8d10e5c77101833d703605a17fff08341e6e9799
https://github.com/ycode/ycode/pull/575/files#diff-499181a85861d11334a0f03d8d10e5c77101833d703605a17fff08341e6e9799
https://github.com/ycode/ycode/pull/575/files#diff-499181a85861d11334a0f03d8d10e5c77101833d703605a17fff08341e6e9799
https://github.com/ycode/ycode/blob/develop/.github/CODEOWNERS#L1
components/PageRenderer.tsxhttps://github.com/ycode/ycode/pull/575/files#diff-fd744ab1e8621b1ead61c31be2c1ee564e0ec2f132090b9347bf922e9200e583
View file https://github.com/ycode/ycode/blob/225aae33abf0b069552705fa05110e17a76e7a81/components/PageRenderer.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/ycode/ycode/pull/575/{{ revealButtonHref }}
https://github.com/ycode/ycode/pull/575/files#diff-fd744ab1e8621b1ead61c31be2c1ee564e0ec2f132090b9347bf922e9200e583
https://github.com/ycode/ycode/pull/575/files#diff-fd744ab1e8621b1ead61c31be2c1ee564e0ec2f132090b9347bf922e9200e583
https://github.com/ycode/ycode/pull/575/files#diff-fd744ab1e8621b1ead61c31be2c1ee564e0ec2f132090b9347bf922e9200e583
https://github.com/ycode/ycode/pull/575/files#diff-fd744ab1e8621b1ead61c31be2c1ee564e0ec2f132090b9347bf922e9200e583
https://github.com/ycode/ycode/pull/575/files#diff-fd744ab1e8621b1ead61c31be2c1ee564e0ec2f132090b9347bf922e9200e583
https://github.com/ycode/ycode/pull/575/files#diff-fd744ab1e8621b1ead61c31be2c1ee564e0ec2f132090b9347bf922e9200e583
https://github.com/ycode/ycode/pull/575/files#diff-fd744ab1e8621b1ead61c31be2c1ee564e0ec2f132090b9347bf922e9200e583
https://github.com/ycode/ycode/blob/develop/.github/CODEOWNERS#L1
lib/asset-link.test.tshttps://github.com/ycode/ycode/pull/575/files#diff-a6f385a2c8bfdf07e57bd5d3427944f1321209a1bcff8bc0640e9501b101fff8
View file https://github.com/ycode/ycode/blob/225aae33abf0b069552705fa05110e17a76e7a81/lib/asset-link.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/ycode/ycode/pull/575/{{ revealButtonHref }}
https://github.com/ycode/ycode/blob/develop/.github/CODEOWNERS#L1
lib/link-utils.tshttps://github.com/ycode/ycode/pull/575/files#diff-3be163fc3672481f29209957f4a535eeebf2d0fd49c78115f857f86b95fb07ae
View file https://github.com/ycode/ycode/blob/225aae33abf0b069552705fa05110e17a76e7a81/lib/link-utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/ycode/ycode/pull/575/{{ revealButtonHref }}
https://github.com/ycode/ycode/pull/575/files#diff-3be163fc3672481f29209957f4a535eeebf2d0fd49c78115f857f86b95fb07ae
https://github.com/ycode/ycode/pull/575/files#diff-3be163fc3672481f29209957f4a535eeebf2d0fd49c78115f857f86b95fb07ae
https://github.com/ycode/ycode/pull/575/files#diff-3be163fc3672481f29209957f4a535eeebf2d0fd49c78115f857f86b95fb07ae
https://github.com/ycode/ycode/pull/575/files#diff-3be163fc3672481f29209957f4a535eeebf2d0fd49c78115f857f86b95fb07ae
https://github.com/ycode/ycode/pull/575/files#diff-3be163fc3672481f29209957f4a535eeebf2d0fd49c78115f857f86b95fb07ae
https://github.com/ycode/ycode/pull/575/files#diff-3be163fc3672481f29209957f4a535eeebf2d0fd49c78115f857f86b95fb07ae
https://github.com/ycode/ycode/pull/575/files#diff-3be163fc3672481f29209957f4a535eeebf2d0fd49c78115f857f86b95fb07ae
https://github.com/ycode/ycode/pull/575/files#diff-3be163fc3672481f29209957f4a535eeebf2d0fd49c78115f857f86b95fb07ae
https://github.com/ycode/ycode/pull/575/files#diff-3be163fc3672481f29209957f4a535eeebf2d0fd49c78115f857f86b95fb07ae
https://github.com/ycode/ycode/pull/575/files#diff-3be163fc3672481f29209957f4a535eeebf2d0fd49c78115f857f86b95fb07ae
https://github.com/ycode/ycode/pull/575/files#diff-3be163fc3672481f29209957f4a535eeebf2d0fd49c78115f857f86b95fb07ae
https://github.com/ycode/ycode/pull/575/files#diff-3be163fc3672481f29209957f4a535eeebf2d0fd49c78115f857f86b95fb07ae
https://github.com/ycode/ycode/blob/develop/.github/CODEOWNERS#L1
lib/page-fetcher.tshttps://github.com/ycode/ycode/pull/575/files#diff-28e0b23fdbe1ae4953b860f3213a935ad8d5a4c9102c3ac6180a859ae29b3f99
View file https://github.com/ycode/ycode/blob/225aae33abf0b069552705fa05110e17a76e7a81/lib/page-fetcher.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/ycode/ycode/pull/575/{{ revealButtonHref }}
https://github.com/ycode/ycode/pull/575/files#diff-28e0b23fdbe1ae4953b860f3213a935ad8d5a4c9102c3ac6180a859ae29b3f99
https://github.com/ycode/ycode/pull/575/files#diff-28e0b23fdbe1ae4953b860f3213a935ad8d5a4c9102c3ac6180a859ae29b3f99
https://github.com/ycode/ycode/pull/575/files#diff-28e0b23fdbe1ae4953b860f3213a935ad8d5a4c9102c3ac6180a859ae29b3f99
https://github.com/ycode/ycode/pull/575/files#diff-28e0b23fdbe1ae4953b860f3213a935ad8d5a4c9102c3ac6180a859ae29b3f99
Please reload this pagehttps://github.com/ycode/ycode/pull/575/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.