René's URL Explorer Experiment


Title: Make release generate safe to run unattended by schlessera · Pull Request #87 · wp-cli/wp-cli-dev · GitHub

Open Graph Title: Make release generate safe to run unattended by schlessera · Pull Request #87 · wp-cli/wp-cli-dev

X Title: Make release generate safe to run unattended by schlessera · Pull Request #87 · wp-cli/wp-cli-dev

Description: Stacked on #86. Tagging the bundled packages through release generate meant answering y/n for every milestone, and getting several of those answers wrong would have published bad releases: It offered empty milestones (extension 3.1.0, search-replace 3.1.0 and 4.0.0), which would have published releases with no notes. A repository with two open milestones would have had both tagged on the same commit. An open milestone whose tag already existed (block-command 1.0.3) would have had its notes attached to the old tag, so none of its changes would have shipped. Notes could only be fixed after publishing, by editing the release by hand. Those cases are now refused with a warning instead of being left to whoever answers the prompt. Each is either a mistake or needs a maintainer's decision. The command also skips milestones that are not a version newer than the latest tag. When a repository has more than one releasable milestone, it is skipped unless --milestone says which one. With the guards in place, --yes can safely skip the prompt, so an agent can publish a release that release plan reported as ready. --notes-file publishes notes that were generated with release-notes and tidied up first, so typo fixes happen before the release goes out rather than after. Both flags work on one milestone at a time on purpose: the maintainer decides which milestone to release, and the tooling does the rest. I checked the guards against the live repositories without publishing anything. The tag-already-exists guard reuses the tag matching that the plan's unit tests cover; no repository currently has that state to check it against. Tests for the GitHub API layer The commands are now also tested end to end against a fake GitHub API: the plan, generate with --yes, --notes-file, the guards, pagination, error handling and write pacing. Requests still go through WP-CLI's HTTP layer, and a fake transport answers them from responses each test registers. Any unexpected request fails the test. The response bodies are real GitHub responses, recorded by composer update-github-fixtures from data that no longer changes (closed milestones, a comparison between two old tags, a published release). Each test overrides only the fields its scenario depends on, so refreshing the recordings never changes what a test expects, but a change to the API itself makes the tests fail. The pause between write requests can now be configured instead of being fixed at one second. The tests set it to zero, and WP_CLI_GITHUB_WRITE_INTERVAL can raise it if GitHub still throttles a bulk run. As before, a write only waits for whatever is left of the interval since the previous write. Summary by CodeRabbit New Features Release generation can now target a specific milestone, use release notes from a file, and skip confirmation when requested. Eligible milestones are checked for release readiness; ambiguous selections are skipped rather than chosen automatically. Successful releases are published on the default branch and their milestones are closed. GitHub write pacing is configurable, with a one-second default. Bug Fixes Milestones that are already released or tagged, out of date, or missing merged pull requests are excluded from release generation.

Open Graph Description: Stacked on #86. Tagging the bundled packages through release generate meant answering y/n for every milestone, and getting several of those answers wrong would have published bad releases: It offe...

X Description: Stacked on #86. Tagging the bundled packages through release generate meant answering y/n for every milestone, and getting several of those answers wrong would have published bad releases: It offe...

Opengraph URL: https://github.com/wp-cli/wp-cli-dev/pull/87

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:00316fda-50fa-9da1-4f26-f1f76b596024
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8884:648A1:4F70B2:6CE319:6AFBA03A
html-safe-noncec29812f8cfdbd5bcef2c3e2aa88c4eed2ec9af6fc15051640cf740e04823272c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODg0OjY0OEExOjRGNzBCMjo2Q0UzMTk6NkFGQkEwM0EiLCJ2aXNpdG9yX2lkIjoiNDA3ODIyOTY0NTg3NzI4OTAxOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac29f509ef0cd2a1e03fb763c6aa2305152d4fd054ac83c7aba20788b37e8626ac
hovercard-subject-tagpull_request:5088660591
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/wp-cli/wp-cli-dev/pull/87/files
twitter:imagehttps://avatars.githubusercontent.com/u/83631?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/83631?s=400&v=4
og:image:altStacked on #86. Tagging the bundled packages through release generate meant answering y/n for every milestone, and getting several of those answers wrong would have published bad releases: It offe...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3cefd19a936819d82cfb5279d50fb56fe79cb9ec30f0f807e04e89b0c58ffae1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/wp-cli/wp-cli-dev git https://github.com/wp-cli/wp-cli-dev.git
octolytics-dimension-user_id1570774
octolytics-dimension-user_loginwp-cli
octolytics-dimension-repository_id147706405
octolytics-dimension-repository_nwowp-cli/wp-cli-dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id147706405
octolytics-dimension-repository_network_root_nwowp-cli/wp-cli-dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release606800bdb1b81d125fc845bdcc262c9fe063fc8f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/wp-cli/wp-cli-dev/pull/87/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fwp-cli%2Fwp-cli-dev%2Fpull%2F87%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fwp-cli%2Fwp-cli-dev%2Fpull%2F87%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=wp-cli%2Fwp-cli-dev
Reloadhttps://github.com/wp-cli/wp-cli-dev/pull/87/files
Reloadhttps://github.com/wp-cli/wp-cli-dev/pull/87/files
Reloadhttps://github.com/wp-cli/wp-cli-dev/pull/87/files
wp-clihttps://github.com/wp-cli
wp-cli-devhttps://github.com/wp-cli/wp-cli-dev
Codehttps://github.com/wp-cli/wp-cli-dev
Issueshttps://github.com/wp-cli/wp-cli-dev/issues
Pull requests3 (3)https://github.com/wp-cli/wp-cli-dev/pulls
Actionshttps://github.com/wp-cli/wp-cli-dev/actions
Projectshttps://github.com/wp-cli/wp-cli-dev/projects
Security and qualityhttps://github.com/wp-cli/wp-cli-dev/security
Insightshttps://github.com/wp-cli/wp-cli-dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fwp-cli%2Fwp-cli-dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fwp-cli%2Fwp-cli-dev%2Fissues%2Fnew%2Fchoose
schlesserahttps://github.com/schlessera
mainhttps://github.com/wp-cli/wp-cli-dev/tree/main
release-generate-guardshttps://github.com/wp-cli/wp-cli-dev/tree/release-generate-guards
Conversation 12 https://github.com/wp-cli/wp-cli-dev/pull/87
Commits 6 https://github.com/wp-cli/wp-cli-dev/pull/87/commits
Checks 18 https://github.com/wp-cli/wp-cli-dev/pull/87/checks
Files changed https://github.com/wp-cli/wp-cli-dev/pull/87/files
Please reload this pagehttps://github.com/wp-cli/wp-cli-dev/pull/87/files
Make release generate safe to run unattended https://github.com/wp-cli/wp-cli-dev/pull/87/files#top
Show all changes 6 commits https://github.com/wp-cli/wp-cli-dev/pull/87/files
70f5cc8 Make release generate safe to run unattended schlessera Oct 30, 2026 https://github.com/wp-cli/wp-cli-dev/pull/87/commits/70f5cc841f6a5600d9b4e074697781d8515b8f00
79bffe1 Cover the tag checks of release generate with unit tests schlessera Oct 30, 2026 https://github.com/wp-cli/wp-cli-dev/pull/87/commits/79bffe1495ea18c31626b31018d99a11062e2f19
a235eb4 Merge branch 'release-plan' into release-generate-guards schlessera Oct 30, 2026 https://github.com/wp-cli/wp-cli-dev/pull/87/commits/a235eb47e81e1431ce34a3bd577a595543e5a770
1e62739 Merge branch 'main' into release-generate-guards schlessera Oct 30, 2026 https://github.com/wp-cli/wp-cli-dev/pull/87/commits/1e627391ef9ef25a08aecd415a26a74ba261d7e9
08f53fb Test the GitHub API layer against recorded responses schlessera Oct 30, 2026 https://github.com/wp-cli/wp-cli-dev/pull/87/commits/08f53fb424070527a5baae02ad21a0bdf7f0c614
5971c02 Only release what the release plan reports as ready schlessera Oct 30, 2026 https://github.com/wp-cli/wp-cli-dev/pull/87/commits/5971c0259607827d8fdc744f9978aa9810e2287e
Clear filters https://github.com/wp-cli/wp-cli-dev/pull/87/files
Please reload this pagehttps://github.com/wp-cli/wp-cli-dev/pull/87/files
Please reload this pagehttps://github.com/wp-cli/wp-cli-dev/pull/87/files
GitHub.php https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-1089245555b63617fca529703181865dca776894c3b57fb2b08a8a1a5ea8b03f
Release_Command.php https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-5042b4a26885e272795ba4cd1faef8d61e9ba27d7d1d19b154301a49f8516700
Release_Plan.php https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-706a304a271155ab2d0f9c64168a53a38cb6a363bad649b33c5a38bb1724bf67
.typos.toml https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-f4eaaba6f80f920c13375550e7c86add0532f1cbc10516f037a8edd8bdf7cce7
composer.json https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34
GitHubApiTest.php https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-3a89acd91827c20f77bdbce4ca0acef23e3aed081ce9fd0704b312bbdaeaaad3
ReleaseCommandTest.php https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-9f23f3536fc67985c0ff5a5ce046ccf587023318bf46bf03d8431fde2b4fc08f
ReleasePlanTest.php https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-eee97a8c80538c345d2ac1aab8493c58dad73558625e6f0a0590487d5e3164d5
comparison.json https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-1c79dbf73c30e63f41184bf3e8fdc12bf7970be885d666cef5fa484d33118495
issues.json https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-c0d67480c65cd1999a5b5a43fbd3c1ce1527f7251e73cef69651571d3c777a08
milestone.json https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-93c3fe5adda6d56a3b17a66a917e9addf278c0dbd89ff4fe17682537fb06664d
pull-requests.json https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-772fa005fc85ddb2154893e86e2d6fdd72ea92280aa861936b137623481de2a1
release-absent.json https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-072775c7927df95187724289d8833063fe6ce15833ada387708ce4a16036af52
release.json https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-6fa158949e1a258be9c0a22278b4b0bfde0cf1d8bd44c0e8bc8e66531b619d26
repository.json https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-663cea2c41712ec455ad8340c63d14f15e319c53cf648943c6852050280b80d4
tags-page-1.json https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-4809b01298041c2d1119e3d068332d11929c8e54d22ab216ea0ba8cf041706a6
tags-page-2.json https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-495931ec04c00d0ac581b12d53c4393985c8762fc6fd1149ce953078f6e2428e
update.php https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-5dfc8e78b52118774a852d7400c0a933cd44463ae74efeecd375efc50cbcfcab
Fake_Transport.php https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-5ae4d52e7bc00155d2e323466052b98d0473e836b93c202783924745898d94c3
GitHub_TestCase.php https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-90b1ec1e8a464aa816107d51d087032f6c002546d0e1784b1e8bdc1baca71502
https://github.com/wp-cli/wp-cli-dev/blob/main/.github/CODEOWNERS#L1
.maintenance/src/GitHub.phphttps://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-1089245555b63617fca529703181865dca776894c3b57fb2b08a8a1a5ea8b03f
View file https://github.com/wp-cli/wp-cli-dev/blob/5971c0259607827d8fdc744f9978aa9810e2287e/.maintenance/src/GitHub.php
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/wp-cli/wp-cli-dev/pull/87/{{ revealButtonHref }}
https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-1089245555b63617fca529703181865dca776894c3b57fb2b08a8a1a5ea8b03f
https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-1089245555b63617fca529703181865dca776894c3b57fb2b08a8a1a5ea8b03f
https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-1089245555b63617fca529703181865dca776894c3b57fb2b08a8a1a5ea8b03f
https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-1089245555b63617fca529703181865dca776894c3b57fb2b08a8a1a5ea8b03f
https://github.com/wp-cli/wp-cli-dev/blob/main/.github/CODEOWNERS#L1
.maintenance/src/Release_Command.phphttps://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-5042b4a26885e272795ba4cd1faef8d61e9ba27d7d1d19b154301a49f8516700
View file https://github.com/wp-cli/wp-cli-dev/blob/5971c0259607827d8fdc744f9978aa9810e2287e/.maintenance/src/Release_Command.php
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/wp-cli/wp-cli-dev/pull/87/{{ revealButtonHref }}
https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-5042b4a26885e272795ba4cd1faef8d61e9ba27d7d1d19b154301a49f8516700
https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-5042b4a26885e272795ba4cd1faef8d61e9ba27d7d1d19b154301a49f8516700
Please reload this pagehttps://github.com/wp-cli/wp-cli-dev/pull/87/files
https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-5042b4a26885e272795ba4cd1faef8d61e9ba27d7d1d19b154301a49f8516700
Please reload this pagehttps://github.com/wp-cli/wp-cli-dev/pull/87/files
https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-5042b4a26885e272795ba4cd1faef8d61e9ba27d7d1d19b154301a49f8516700
https://github.com/wp-cli/wp-cli-dev/blob/main/.github/CODEOWNERS#L1
.maintenance/src/Release_Plan.phphttps://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-706a304a271155ab2d0f9c64168a53a38cb6a363bad649b33c5a38bb1724bf67
View file https://github.com/wp-cli/wp-cli-dev/blob/5971c0259607827d8fdc744f9978aa9810e2287e/.maintenance/src/Release_Plan.php
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/wp-cli/wp-cli-dev/pull/87/{{ revealButtonHref }}
https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-706a304a271155ab2d0f9c64168a53a38cb6a363bad649b33c5a38bb1724bf67
https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-706a304a271155ab2d0f9c64168a53a38cb6a363bad649b33c5a38bb1724bf67
https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-706a304a271155ab2d0f9c64168a53a38cb6a363bad649b33c5a38bb1724bf67
https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-706a304a271155ab2d0f9c64168a53a38cb6a363bad649b33c5a38bb1724bf67
https://github.com/wp-cli/wp-cli-dev/blob/main/.github/CODEOWNERS#L1
.typos.tomlhttps://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-f4eaaba6f80f920c13375550e7c86add0532f1cbc10516f037a8edd8bdf7cce7
View file https://github.com/wp-cli/wp-cli-dev/blob/5971c0259607827d8fdc744f9978aa9810e2287e/.typos.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/wp-cli/wp-cli-dev/pull/87/{{ revealButtonHref }}
https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-f4eaaba6f80f920c13375550e7c86add0532f1cbc10516f037a8edd8bdf7cce7
https://github.com/wp-cli/wp-cli-dev/pull/87/files#diff-f4eaaba6f80f920c13375550e7c86add0532f1cbc10516f037a8edd8bdf7cce7
Please reload this pagehttps://github.com/wp-cli/wp-cli-dev/pull/87/files
Please reload this pagehttps://github.com/wp-cli/wp-cli-dev/pull/87/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.