René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Shell binary not getting detected correctly?","articleBody":"## Bug Report\r\n\r\n- [x] Yes, I reviewed the [contribution guidelines](https://make.wordpress.org/cli/handbook/contributing/).\r\n- [x] Yes, more specifically, I reviewed the guidelines on [how to write clear bug reports](https://make.wordpress.org/cli/handbook/bug-reports/).\r\n\r\n**The shell binary '/bin/bash' is not valid.**\r\n\r\nThe `wp --info` command shows the correct `Shell`, but `wp shell` does not seem to find it. Since it's not in `/bin/bash`\r\n\r\n```\r\n[sergio@samara:/var/www/nerdpress]$ wp --info\r\nOS:     Linux 6.6.32 #1-NixOS SMP PREEMPT_DYNAMIC Sat May 25 14:22:56 UTC 2024 x86_64\r\nShell:  /run/current-system/sw/bin/bash\r\nPHP binary:     /nix/store/swkmyv7mplz46vlr9jyk7qlp2lxv19z0-php-with-extensions-8.2.19/bin/php\r\nPHP version:    8.2.19\r\nphp.ini used:   /nix/store/6g69kphwfkdx4p2qn1fgwm888l15cpz7-wp-cli-2.10.0/etc/php.ini\r\nMySQL binary:   /run/current-system/sw/bin/mysql\r\nMySQL version:  mysql  Ver 15.1 Distrib 10.11.6-MariaDB, for Linux (x86_64) using readline 5.1\r\nSQL modes:      STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION\r\nWP-CLI root dir:        phar://wp-cli.phar/vendor/wp-cli/wp-cli\r\nWP-CLI vendor dir:      phar://wp-cli.phar/vendor\r\nWP_CLI phar path:       /var/www/nerdpress\r\nWP-CLI packages dir:\r\nWP-CLI cache dir:       $XDG_CACHE_HOME/wp-cli\r\nWP-CLI global config:\r\nWP-CLI project config:\r\nWP-CLI version: 2.10.0\r\n\r\n[sergio@samara:/var/www/nerdpress]$ wp shell\r\nError: The shell binary '/bin/bash' is not valid. You can override the shell to be used through the WP_CLI_CUSTOM_SHELL environment variable.\r\n\r\n[sergio@samara:/var/www/nerdpress]$ php -a\r\nInteractive shell\r\n\r\nphp > var_dump( is_file( '/run/current-system/sw/bin/bash' ) );\r\nbool(true)\r\nphp > var_dump( is_readable( '/run/current-system/sw/bin/bash' ) );\r\nbool(true)\r\nphp > exit\r\n```\r\n\r\n**Describe how other contributors can replicate this bug**\r\n\r\n- Have `get( 'SHELL' );` return something other than `/bin/bash`\r\n- Run `wp shell`\r\n\r\n\r\n**Provide a possible solution**\r\n\r\nSeems that the `wp cli info` command gets the shell binary using:\r\n[`getenv( 'SHELL' )`](https://github.com/wp-cli/wp-cli/blob/0ca6d920123ac904c918d69181edc5071dc92c9d/php/commands/src/CLI_Command.php#L126C12-L126C29)\r\n\r\nWhere `wp shell` [uses `getenv( 'WP_CLI_CUSTOM_SHELL' )` to check for a \"custom shell\", then assumes `/bin/bash` is it isn't set](https://github.com/wp-cli/shell-command/blob/main/src/WP_CLI/Shell/REPL.php#L118).\r\n\r\n[Why not use `$shell_binary = getenv( 'SHELL' );` instead of `$shell_binary = '/bin/bash';`](https://github.com/wp-cli/shell-command/blob/main/src/WP_CLI/Shell/REPL.php#L121C4-L121C32)\r\n\r\n","author":{"url":"https://github.com/ecotechie","@type":"Person","name":"ecotechie"},"datePublished":"2024-07-10T19:08:48Z","url":"https://github.com/wp-cli/shell-command/issues/66"}