René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Table::getDisplayLines() can output excessive lines","articleBody":"## Bug Report\r\n\r\n- [x] Yes, I reviewed the [contribution guidelines](https://make.wordpress.org/cli/handbook/contributing/).\r\n- [x] Yes, more specifically, I reviewed the guidelines on [how to write clear bug reports](https://make.wordpress.org/cli/handbook/bug-reports/).\r\n\r\n**Describe the current, buggy behavior**\r\n\r\nI'm registering a table with this (simplified) code:\r\n\r\n```php\r\n$table  = new \\cli\\Table();\r\n$ascii  = new \\cli\\table\\Ascii();\r\n$widths = [\r\n\t3, // this is the longest default date format: [24-Sep-2023 20:50:51 UTC]\r\n\t3, // this is the longest default type: PHP Fatal error\r\n\t5, // trigger the overflow and last column max width by defining a very long string length\r\n];\r\n\r\n$ascii->setWidths( $widths );\r\n$table->setRenderer( $ascii );\r\n\r\n$table->setHeaders( [ 'one', 'two', 'three' ] );\r\n\r\n$table->display();\r\n```\r\n\r\nMethod Table::() returns this data:\r\n\r\n```\r\narray:4 [▶\r\n  0 => \"+----------------------------+-----------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+\"\r\n  1 => \"| One                       | Two            | Three                                                                                                                                                                                                                                                             |\"\r\n  2 => \"+----------------------------+-----------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+\"\r\n  3 => \"+----------------------------+-----------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+\"\r\n]\r\n```\r\n\r\nAs you can see, array values for 2 and 3 are the same - bottom border.\r\n\r\nThis is because I output just the table, without rows (I plan to use `->addRow()` later). And because this code in this library:\r\n\r\n```php\r\nforeach ($this->_rows as $row) {\r\n\t$row = $this->_renderer->row($row);\r\n\t$row = explode( PHP_EOL, $row );\r\n\t$out = array_merge( $out, $row );\r\n}\r\n\r\nif (isset($border)) {\r\n\t$out[] = $border;\r\n}\r\n```\r\n\r\nDoes not check whether rows is actually not empty.\r\n\r\n**Describe what you would expect as the correct outcome**\r\n\r\nIf there is a header but no rows - we should display only 1 border.\r\n\r\n**Let us know what environment you are running this on**\r\n\r\n```\r\nOS:     Darwin 22.6.0 Darwin Kernel Version 22.6.0: Fri Sep 15 13:41:28 PDT 2023; root:xnu-8796.141.3.700.8~1/RELEASE_ARM64_T6000 arm64\r\nShell:  /bin/zsh\r\nPHP binary:     /opt/homebrew/Cellar/php/8.2.10/bin/php\r\nPHP version:    8.2.10\r\nphp.ini used:   /opt/homebrew/etc/php/8.2/php.ini\r\nMySQL binary:   \r\nMySQL version:  \r\nSQL modes:      \r\nWP-CLI root dir:        phar://wp-cli.phar/vendor/wp-cli/wp-cli\r\nWP-CLI vendor dir:      phar://wp-cli.phar/vendor\r\nWP_CLI phar path:       /Users/slaffik/Projects/[redacted]\r\nWP-CLI packages dir:    /Users/slaffik/.wp-cli/packages/\r\nWP-CLI cache dir:       /Users/slaffik/.wp-cli/cache\r\nWP-CLI global config:   \r\nWP-CLI project config:  \r\nWP-CLI version: 2.8.1\r\n\r\n```\r\n\r\n**Provide a possible solution**\r\n\r\nI will create a PR.\r\n","author":{"url":"https://github.com/slaFFik","@type":"Person","name":"slaFFik"},"datePublished":"2023-09-28T21:06:01Z","url":"https://github.com/wp-cli/php-cli-tools/issues/164"}