René's URL Explorer Experiment


Title: Implemented sRGB support in ShaderSets and default format for colour framebuffer by robertosfield · Pull Request #1374 · vsg-dev/VulkanSceneGraph · GitHub

Open Graph Title: Implemented sRGB support in ShaderSets and default format for colour framebuffer by robertosfield · Pull Request #1374 · vsg-dev/VulkanSceneGraph

X Title: Implemented sRGB support in ShaderSets and default format for colour framebuffer by robertosfield · Pull Request #1374 · vsg-dev/VulkanSceneGraph

Opengraph URL: https://github.com/vsg-dev/VulkanSceneGraph/pull/1374

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a3611fc0-a20f-52e9-cd39-384ebac10da2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id858E:116046:2A05BB2:360BF5A:698C1751
html-safe-nonce861f2445911b33d02763d1b6d7fb139d51b357b6f38cd18fb8ddc3896f935763
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NThFOjExNjA0NjoyQTA1QkIyOjM2MEJGNUE6Njk4QzE3NTEiLCJ2aXNpdG9yX2lkIjoiMjcyMjE5MDE5MDE1ODg2NjczIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6b971053abef55e1ec1ecec28711112a78395a1ee35586c0d77b22136f539667
hovercard-subject-tagpull_request:2294279506
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/vsg-dev/VulkanSceneGraph/1374/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/532ece80e19c3ec7fbd2594695e1c3ef4e9e9cbb82ee63082d37084606533f7c/vsg-dev/VulkanSceneGraph/pull/1374
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/532ece80e19c3ec7fbd2594695e1c3ef4e9e9cbb82ee63082d37084606533f7c/vsg-dev/VulkanSceneGraph/pull/1374
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerobertosfield
hostnamegithub.com
expected-hostnamegithub.com
None640eeb7b6ff4d8d106235d228c0c286e82592d4d2403227b5b2b4fc5832297a4
turbo-cache-controlno-preview
go-importgithub.com/vsg-dev/VulkanSceneGraph git https://github.com/vsg-dev/VulkanSceneGraph.git
octolytics-dimension-user_id44898258
octolytics-dimension-user_loginvsg-dev
octolytics-dimension-repository_id148609004
octolytics-dimension-repository_nwovsg-dev/VulkanSceneGraph
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id148609004
octolytics-dimension-repository_network_root_nwovsg-dev/VulkanSceneGraph
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3d444f0a47beeeac94cddbb51c91ab408befe8d4
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fvsg-dev%2FVulkanSceneGraph%2Fpull%2F1374
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fvsg-dev%2FVulkanSceneGraph%2Fpull%2F1374
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=vsg-dev%2FVulkanSceneGraph
Reloadhttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374
Reloadhttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374
Reloadhttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374
vsg-dev https://github.com/vsg-dev
VulkanSceneGraphhttps://github.com/vsg-dev/VulkanSceneGraph
Notifications https://github.com/login?return_to=%2Fvsg-dev%2FVulkanSceneGraph
Fork 266 https://github.com/login?return_to=%2Fvsg-dev%2FVulkanSceneGraph
Star 1.7k https://github.com/login?return_to=%2Fvsg-dev%2FVulkanSceneGraph
Code https://github.com/vsg-dev/VulkanSceneGraph
Issues 31 https://github.com/vsg-dev/VulkanSceneGraph/issues
Pull requests 13 https://github.com/vsg-dev/VulkanSceneGraph/pulls
Discussions https://github.com/vsg-dev/VulkanSceneGraph/discussions
Actions https://github.com/vsg-dev/VulkanSceneGraph/actions
Projects 0 https://github.com/vsg-dev/VulkanSceneGraph/projects
Security 0 https://github.com/vsg-dev/VulkanSceneGraph/security
Insights https://github.com/vsg-dev/VulkanSceneGraph/pulse
Code https://github.com/vsg-dev/VulkanSceneGraph
Issues https://github.com/vsg-dev/VulkanSceneGraph/issues
Pull requests https://github.com/vsg-dev/VulkanSceneGraph/pulls
Discussions https://github.com/vsg-dev/VulkanSceneGraph/discussions
Actions https://github.com/vsg-dev/VulkanSceneGraph/actions
Projects https://github.com/vsg-dev/VulkanSceneGraph/projects
Security https://github.com/vsg-dev/VulkanSceneGraph/security
Insights https://github.com/vsg-dev/VulkanSceneGraph/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fvsg-dev%2FVulkanSceneGraph%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fvsg-dev%2FVulkanSceneGraph%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374#issue-comment-box
robertosfieldhttps://github.com/robertosfield
masterhttps://github.com/vsg-dev/VulkanSceneGraph/tree/master
ColorSpace3https://github.com/vsg-dev/VulkanSceneGraph/tree/ColorSpace3
Implemented sRGB support in ShaderSets and default format for colour framebuffer https://github.com/vsg-dev/VulkanSceneGraph/pull/1374#top
robertosfieldhttps://github.com/robertosfield
masterhttps://github.com/vsg-dev/VulkanSceneGraph/tree/master
ColorSpace3https://github.com/vsg-dev/VulkanSceneGraph/tree/ColorSpace3
Conversation 0 https://github.com/vsg-dev/VulkanSceneGraph/pull/1374
Commits 27 https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits
Checks 16 https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/checks
Files changed https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/files
Please reload this pagehttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374
https://github.co/hiddenchars
https://github.com/vsg-dev/VulkanSceneGraph/pull/{{ revealButtonHref }}
https://github.com/robertosfield
robertosfieldhttps://github.com/robertosfield
Jan 23, 2025https://github.com/vsg-dev/VulkanSceneGraph/pull/1374#issue-2806667146
Please reload this pagehttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374
AnyOldName3https://github.com/AnyOldName3
January 16, 2025 09:46https://github.com/vsg-dev/VulkanSceneGraph/pull/1374#commits-pushed-c0b2078
https://github.com/AnyOldName3
https://github.com/robertosfield
Default to sRGB surface formathttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/c0b207812975b7840024a01e49b669509b098e62
c0b2078https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/c0b207812975b7840024a01e49b669509b098e62
https://github.com/AnyOldName3
https://github.com/robertosfield
Fix sRGB_to_linear and linear_to_sRGBhttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/fc7ee726deb08ea530e1842ddbb31181f2e0fafc
fc7ee72https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/fc7ee726deb08ea530e1842ddbb31181f2e0fafc
https://github.com/AnyOldName3
https://github.com/robertosfield
Use precise sRGB conversion by defaulthttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/eea9d2eee73b8bd86e0c9f18f4e02955a9082081
eea9d2ehttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/eea9d2eee73b8bd86e0c9f18f4e02955a9082081
https://github.com/AnyOldName3
https://github.com/robertosfield
Typo fixhttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/94a2bf255a9c7fc3fef254d1dac874b1702100ae
94a2bf2https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/94a2bf255a9c7fc3fef254d1dac874b1702100ae
https://github.com/AnyOldName3
https://github.com/robertosfield
Keep the same relative ambient/diffuse intensity with correct gammahttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/7b40dee020b728b46ef0e93c5cf5e7b1eff23b48
7b40deehttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/7b40dee020b728b46ef0e93c5cf5e7b1eff23b48
https://github.com/robertosfield
Updated ShaderSetshttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/3999c1d942ee917c1cb38bc5a8f9c786a215a80a
3999c1dhttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/3999c1d942ee917c1cb38bc5a8f9c786a215a80a
https://github.com/robertosfield
Added ColorSpace header and source to assist with conversions between…https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/418914135ed1cbbdfe29d6ced3e69941ecb82cf1
https://github.com/vsg-dev/VulkanSceneGraph/commit/418914135ed1cbbdfe29d6ced3e69941ecb82cf1#comments
4189141https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/418914135ed1cbbdfe29d6ced3e69941ecb82cf1
https://github.com/robertosfield
Added remapping of image formats to be consistent to sRGB conversions.https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/7fbb1766e911c61b82ed810cdd3f01e6e3136b1b
7fbb176https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/7fbb1766e911c61b82ed810cdd3f01e6e3136b1b
https://github.com/robertosfield
Added vec3 variants and removed approx functions.https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/1ff39e528e6e22e93509511117c81e72e518ccc5
1ff39e5https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/1ff39e528e6e22e93509511117c81e72e518ccc5
https://github.com/robertosfield
Bumped version to 1.1.10 for ColorSpace work.https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/2839c67221c1369de3f84c8d7abded21d666d229
2839c67https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/2839c67221c1369de3f84c8d7abded21d666d229
https://github.com/robertosfield
Removed debug messagehttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/5a4447002ffa9a1e850df5874df081374ed59650
5a44470https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/5a4447002ffa9a1e850df5874df081374ed59650
https://github.com/robertosfield
Commented out hardwired format conversions to sRGB as we should now b…https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/2edaa3731d4ad997e9ec204db234806c9d6c8a74
2edaa37https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/2edaa3731d4ad997e9ec204db234806c9d6c8a74
https://github.com/robertosfield
Added install of xcb to Linux automated build.https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/133a17c8861e02bb05b70242cec9acd86c01a9e0
133a17chttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/133a17c8861e02bb05b70242cec9acd86c01a9e0
https://github.com/robertosfield
Deleted inappropriate copy constructorshttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/f810efa84bd2223355c73ece635b87c574b99041
f810efahttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/f810efa84bd2223355c73ece635b87c574b99041
https://github.com/robertosfield
Restructued constructor to avoid need for include Options.hhttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/296c36868b4863652467fc78d0c155546306bd51
296c368https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/296c36868b4863652467fc78d0c155546306bd51
https://github.com/robertosfield
Merge branch 'master' into ColorSpace3https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/df3eb17b204dc631ab26c6a89bfc760b4464914e
df3eb17https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/df3eb17b204dc631ab26c6a89bfc760b4464914e
https://github.com/robertosfield
Rand clang-formathttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/3154ea190cbdf677da92218853978e0a9111993f
3154ea1https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/3154ea190cbdf677da92218853978e0a9111993f
https://github.com/robertosfield
Renamed ColorSpace to CoordinateSpace and added support for specifyin…https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/b91a2f9338cc4579b087a6749522fb64606482b4
b91a2f9https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/b91a2f9338cc4579b087a6749522fb64606482b4
https://github.com/robertosfield
Wired up initial use of coordinateSpace and updated ShaderSets.https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/35bc5fec83721c90499352388e96d95962c2a5f0
35bc5fehttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/35bc5fec83721c90499352388e96d95962c2a5f0
https://github.com/robertosfield
Updated ShaderSets.https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/0c95acd6c270550261a4507132c9f057eeee444b
0c95acdhttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/0c95acd6c270550261a4507132c9f057eeee444b
https://github.com/robertosfield
Ran clang-formathttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/1c8b32dd1081eea7632e1541ab8f74d317c232c6
1c8b32dhttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/1c8b32dd1081eea7632e1541ab8f74d317c232c6
https://github.com/robertosfield
Warning fixeshttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/9f31f4e352a28f6f9a514a442e16353e0a2074ae
9f31f4ehttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/9f31f4e352a28f6f9a514a442e16353e0a2074ae
https://github.com/robertosfield
Merge branch 'master' into ColorSpace3https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/dec58461b470a17867e451ac835591107339641c
dec5846https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/dec58461b470a17867e451ac835591107339641c
https://github.com/robertosfield
Removed commented out code and combined if statements.https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/6e31fa6880ad81af2433c3988a88b8f7a9962b77
6e31fa6https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/6e31fa6880ad81af2433c3988a88b8f7a9962b77
https://github.com/robertosfield
Renamed local variable to fix cppcheck reporting shadowing of functionhttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/1104b7c781ffba0aa979e45f9e5ae6c286ec55fc
1104b7chttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/1104b7c781ffba0aa979e45f9e5ae6c286ec55fc
https://github.com/robertosfield
Fixed incomplete name change.https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/74233814400f0dd40a25aef37877e77edcee9994
7423381https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/74233814400f0dd40a25aef37877e77edcee9994
https://github.com/robertosfield
Added handling of CoordinateSpace to DescriptorConfigurator::assignTe…https://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/c9829de8a4a5739407b8efbcc9f53ff8992b38ab
c9829dehttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374/commits/c9829de8a4a5739407b8efbcc9f53ff8992b38ab
https://github.com/robertosfield
robertosfieldhttps://github.com/robertosfield
49f7a6dhttps://github.com/vsg-dev/VulkanSceneGraph/commit/49f7a6df55c31a8b10dd75993ae29fcc62919c22
Jan 24, 2025https://github.com/vsg-dev/VulkanSceneGraph/pull/1374#event-16057709592
Please reload this pagehttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374
https://github.com/robertosfield
robertosfieldhttps://github.com/robertosfield
January 31, 2025 18:38https://github.com/vsg-dev/VulkanSceneGraph/pull/1374#event-16144291044
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fvsg-dev%2FVulkanSceneGraph%2Fpull%2F1374
Please reload this pagehttps://github.com/vsg-dev/VulkanSceneGraph/pull/1374
https://github.com/robertosfield
https://github.com/AnyOldName3
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.