| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:748db420-1789-64b1-9c73-07032ad4379a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DC14:2D40DE:590B75:7083CB:6B011125 |
| html-safe-nonce | a17a3c7b34d9bca721ace56bdc97cd492e26514daf5e9dab5780d7ac6b87acc2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzE0OjJENDBERTo1OTBCNzU6NzA4M0NCOjZCMDExMTI1IiwidmlzaXRvcl9pZCI6IjQzNzQwNDI0NDc0ODgwMjg5NjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 90b3444f78abf090874b917ad9d9557629685bdadf02c9da443b58567ede3471 |
| hovercard-subject-tag | pull_request:4949743511 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/voidzero-dev/oxc-angular-compiler/596/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/62e2815c952d87179c4d43ed4e7a492a62ff3be3f8b0b746bd11a310a69d289e/voidzero-dev/oxc-angular-compiler/pull/596 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/62e2815c952d87179c4d43ed4e7a492a62ff3be3f8b0b746bd11a310a69d289e/voidzero-dev/oxc-angular-compiler/pull/596 |
| og:image:alt | Summary
Fixes #595.
In production builds, @oxc-angular/vite-optimizer ran optimizeAngularPackage(..., { markPure: true }) on every fesm20* file and ignored the package's sideEffects. Top-level ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | edbzn |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/voidzero-dev/oxc-angular-compiler git https://github.com/voidzero-dev/oxc-angular-compiler.git |
| octolytics-dimension-user_id | 149750581 |
| octolytics-dimension-user_login | voidzero-dev |
| octolytics-dimension-repository_id | 1122751442 |
| octolytics-dimension-repository_nwo | voidzero-dev/oxc-angular-compiler |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1122751442 |
| octolytics-dimension-repository_network_root_nwo | voidzero-dev/oxc-angular-compiler |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fvoidzero-dev%2Foxc-angular-compiler%2Fpull%2F596 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fvoidzero-dev%2Foxc-angular-compiler%2Fpull%2F596 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=voidzero-dev%2Foxc-angular-compiler |
| Reload | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596 |
| Reload | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596 |
| Reload | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596 |
| voidzero-dev | https://github.com/voidzero-dev |
| oxc-angular-compiler | https://github.com/voidzero-dev/oxc-angular-compiler |
| Code | https://github.com/voidzero-dev/oxc-angular-compiler |
| Issues4 (4) | https://github.com/voidzero-dev/oxc-angular-compiler/issues |
| Pull requests1 (1) | https://github.com/voidzero-dev/oxc-angular-compiler/pulls |
| Actions | https://github.com/voidzero-dev/oxc-angular-compiler/actions |
| Projects | https://github.com/voidzero-dev/oxc-angular-compiler/projects |
| Security and quality | https://github.com/voidzero-dev/oxc-angular-compiler/security |
| Insights | https://github.com/voidzero-dev/oxc-angular-compiler/insights |
| https://github.com/voidzero-dev/oxc-angular-compiler |
| Brooooooklyn | https://github.com/Brooooooklyn |
| voidzero-dev:main | https://github.com/voidzero-dev/oxc-angular-compiler/tree/main |
| edbzn:fix/optimizer-respect-side-effects | https://github.com/edbzn/oxc-angular-compiler/tree/fix/optimizer-respect-side-effects |
| Conversation | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596 |
| Commits6 (6) | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596/commits |
| Checks | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596/checks |
| Files changed | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596/files |
| fix(vite): respect package sideEffects when marking top-level calls pure | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596#top |
| Brooooooklyn | https://github.com/Brooooooklyn |
| voidzero-dev:main | https://github.com/voidzero-dev/oxc-angular-compiler/tree/main |
| edbzn:fix/optimizer-respect-side-effects | https://github.com/edbzn/oxc-angular-compiler/tree/fix/optimizer-respect-side-effects |
|
| https://github.com/edbzn |
| edbzn | https://github.com/edbzn |
| Oct 21, 2026 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596#issue-5958344509 |
| Please reload this page | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596 |
| #595 | https://github.com/voidzero-dev/oxc-angular-compiler/issues/595 |
| #598 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/598 |
| optimizer: markPure ignores package sideEffects, tree-shakes zone.js and @angular/compiler in production builds #595 | https://github.com/voidzero-dev/oxc-angular-compiler/issues/595 |
| optimizer: markPure ignores package sideEffects, tree-shakes zone.js and @angular/compiler in production builds #595 | https://github.com/voidzero-dev/oxc-angular-compiler/issues/595 |
| Claude Code | https://claude.com/claude-code |
| Please reload this page | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596 |
| edbzn | https://github.com/edbzn |
| October 21, 2026 11:57 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596#commits-pushed-cc81c0d |
|
| https://github.com/edbzn |
|
| https://github.com/claude |
| fix(vite): respect package sideEffects when marking top-level calls… | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596/commits/cc81c0d49ae791a0e7bab6c85d22dbbb710c86f2 |
| cc81c0d | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596/commits/cc81c0d49ae791a0e7bab6c85d22dbbb710c86f2 |
| voidzero-dev#595 | https://github.com/voidzero-dev/oxc-angular-compiler/issues/595 |
|
| https://github.com/Brooooooklyn |
| Merge branch 'main' into fix/optimizer-respect-side-effects | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596/commits/8138a5fe55e7d80742c1124c694c1008cfcdcf6d |
| 8138a5f | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596/commits/8138a5fe55e7d80742c1124c694c1008cfcdcf6d |
|
| https://github.com/Brooooooklyn |
|
| https://github.com/claude |
| fix(vite): read package sideEffects safely in the build optimizer | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596/commits/595b0577d6d5eb76929c4f4e2778b8fb169fd412 |
| 595b057 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596/commits/595b0577d6d5eb76929c4f4e2778b8fb169fd412 |
| @angular | https://github.com/angular |
|
| https://github.com/Brooooooklyn |
|
| https://github.com/claude |
| test(vite): check that string sideEffects entries still count next to… | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596/commits/c54506f7bfa20572cf6f43a15e493a0a6abe2b72 |
| c54506f | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596/commits/c54506f7bfa20572cf6f43a15e493a0a6abe2b72 |
|
| https://github.com/Brooooooklyn |
|
| https://github.com/claude |
| test(vite): cover sideEffects: true in an | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596/commits/e2c66b0f930e98c0615b7a5aa34a471f2045a08e |
| @angular | https://github.com/angular |
| package | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596/commits/e2c66b0f930e98c0615b7a5aa34a471f2045a08e |
| e2c66b0 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596/commits/e2c66b0f930e98c0615b7a5aa34a471f2045a08e |
| @angular | https://github.com/angular |
| @angular | https://github.com/angular |
| @angular | https://github.com/angular |
|
| https://github.com/Brooooooklyn |
|
| https://github.com/claude |
| test(vite): stop passing an unused sideEffects value in raw package.j… | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596/commits/0a10cd83448516a5ef9d4302a2b881e743ca6004 |
| 0a10cd8 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596/commits/0a10cd83448516a5ef9d4302a2b881e743ca6004 |
| https://github.com/Brooooooklyn |
| Brooooooklyn | https://github.com/Brooooooklyn |
| Oct 22, 2026 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596#issuecomment-6332329748 |
| @codex | https://github.com/codex |
| Please reload this page | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596 |
| https://github.com/apps/chatgpt-codex-connector |
| chatgpt-codex-connector | https://github.com/apps/chatgpt-codex-connector |
| Oct 22, 2026 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596#issuecomment-6332333202 |
| Please reload this page | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596 |
| Your team has set up Codex to review pull requests in this repo | https://chatgpt.com/codex/cloud/settings/general |
| @codex | https://github.com/codex |
| @codex | https://github.com/codex |
| Please reload this page | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596 |
| https://github.com/apps/chatgpt-codex-connector |
| chatgpt-codex-connector | https://github.com/apps/chatgpt-codex-connector |
| Oct 22, 2026 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596#issuecomment-6332415077 |
| Your team has set up Codex to review pull requests in this repo | https://chatgpt.com/codex/cloud/settings/general |
| @codex | https://github.com/codex |
| @codex | https://github.com/codex |
| Please reload this page | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596 |
| https://github.com/Brooooooklyn |
| Brooooooklyn | https://github.com/Brooooooklyn |
| dbb55fb | https://github.com/voidzero-dev/oxc-angular-compiler/commit/dbb55fb12e57f54023581b0ac2d2044fc1b7415a |
| Oct 22, 2026 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596#event-33915233438 |
| Please reload this page | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596 |
| https://github.co/hiddenchars |
| https://github.com/voidzero-dev/oxc-angular-compiler/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fvoidzero-dev%2Foxc-angular-compiler%2Fpull%2F596 |
| Please reload this page | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596 |
|
optimizer: markPure ignores package sideEffects, tree-shakes zone.js and @angular/compiler in production builds
| https://github.com/voidzero-dev/oxc-angular-compiler/issues/595 |
| Please reload this page | https://github.com/voidzero-dev/oxc-angular-compiler/pull/596 |
|
| https://github.com/edbzn |
|
| https://github.com/Brooooooklyn |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |