| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e1b638d1-2fff-26e1-30af-dfd15d809b55 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9C58:2E5652:FAA217:13F7408:6B011150 |
| html-safe-nonce | ac9391c60c6faa4dc566a095820e14e5e2443f8acced5c8594b453560d8f1edc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzU4OjJFNTY1MjpGQUEyMTc6MTNGNzQwODo2QjAxMTE1MCIsInZpc2l0b3JfaWQiOiIzMzU4MDI4Nzg4MjY0NTEyODEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 54389fb5f88c1b1895d69f34b65ebb56131b1ddedf22b40f02f39bf2be8389ec |
| hovercard-subject-tag | pull_request:4606576315 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/voidzero-dev/oxc-angular-compiler/491/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/bc31b69dcc134e0d3bad4478b30b346e9e091ea3a2836c94493b1bebdd9de54f/voidzero-dev/oxc-angular-compiler/pull/491 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bc31b69dcc134e0d3bad4478b30b346e9e091ea3a2836c94493b1bebdd9de54f/voidzero-dev/oxc-angular-compiler/pull/491 |
| og:image:alt | Fixes the i18n code generation so the emitted output matches ngc, and adds the test coverage that makes those differences visible.
The two bugs this started from
An i18n-<attr> message lost ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ashley-hunter |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/voidzero-dev/oxc-angular-compiler git https://github.com/voidzero-dev/oxc-angular-compiler.git |
| octolytics-dimension-user_id | 149750581 |
| octolytics-dimension-user_login | voidzero-dev |
| octolytics-dimension-repository_id | 1122751442 |
| octolytics-dimension-repository_nwo | voidzero-dev/oxc-angular-compiler |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1122751442 |
| octolytics-dimension-repository_network_root_nwo | voidzero-dev/oxc-angular-compiler |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fvoidzero-dev%2Foxc-angular-compiler%2Fpull%2F491 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fvoidzero-dev%2Foxc-angular-compiler%2Fpull%2F491 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=voidzero-dev%2Foxc-angular-compiler |
| Reload | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491 |
| Reload | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491 |
| Reload | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491 |
| voidzero-dev | https://github.com/voidzero-dev |
| oxc-angular-compiler | https://github.com/voidzero-dev/oxc-angular-compiler |
| Code | https://github.com/voidzero-dev/oxc-angular-compiler |
| Issues4 (4) | https://github.com/voidzero-dev/oxc-angular-compiler/issues |
| Pull requests1 (1) | https://github.com/voidzero-dev/oxc-angular-compiler/pulls |
| Actions | https://github.com/voidzero-dev/oxc-angular-compiler/actions |
| Projects | https://github.com/voidzero-dev/oxc-angular-compiler/projects |
| Security and quality | https://github.com/voidzero-dev/oxc-angular-compiler/security |
| Insights | https://github.com/voidzero-dev/oxc-angular-compiler/insights |
| https://github.com/voidzero-dev/oxc-angular-compiler |
| Brooooooklyn | https://github.com/Brooooooklyn |
| voidzero-dev:main | https://github.com/voidzero-dev/oxc-angular-compiler/tree/main |
| ashley-hunter:t3code/fix-angular-i18n-bugs | https://github.com/ashley-hunter/oxc-angular-compiler/tree/t3code/fix-angular-i18n-bugs |
| Conversation | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491 |
| Commits55 (55) | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits |
| Checks | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/checks |
| Files changed | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/files |
| fix(i18n): match ngc for attribute and ICU messages, and cover i18n with Angular's own tests | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491#top |
| Brooooooklyn | https://github.com/Brooooooklyn |
| voidzero-dev:main | https://github.com/voidzero-dev/oxc-angular-compiler/tree/main |
| ashley-hunter:t3code/fix-angular-i18n-bugs | https://github.com/ashley-hunter/oxc-angular-compiler/tree/t3code/fix-angular-i18n-bugs |
|
| https://github.com/ashley-hunter |
| ashley-hunter | https://github.com/ashley-hunter |
| Sep 22, 2026 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491#issue-5544883116 |
| Please reload this page | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491 |
| #334 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/334 |
| Please reload this page | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491 |
| ashley-hunter | https://github.com/ashley-hunter |
| September 22, 2026 16:58 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491#commits-pushed-bcad997 |
|
| https://github.com/ashley-hunter |
| test(i18n): add failing tests for i18n attribute and ICU messages | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/bcad99786d2a22a307d9756ca3f38de531147d71 |
| bcad997 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/bcad99786d2a22a307d9756ca3f38de531147d71 |
| @id | https://github.com/id |
|
| https://github.com/ashley-hunter |
| fix(i18n): use the attribute value as the text of i18n- messages | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/2bedf6baf0b6860c7feb966e5a7bc6035c652a26 |
| 2bedf6b | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/2bedf6baf0b6860c7feb966e5a7bc6035c652a26 |
| @id | https://github.com/id |
| @close | https://github.com/close |
|
| https://github.com/ashley-hunter |
| test(i18n): add failing test for tag placeholders inside an ICU | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/8fd4bb62d1c2b01500ddfc9c27577e483bd1c6cc |
| 8fd4bb6 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/8fd4bb62d1c2b01500ddfc9c27577e483bd1c6cc |
|
| https://github.com/ashley-hunter |
| fix(i18n): emit ICU messages and their post-processing like Angular | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/8d30bc8291c5e23aa1d6be35e5f7f5ae5f5e7d69 |
| 8d30bc8 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/8d30bc8291c5e23aa1d6be35e5f7f5ae5f5e7d69 |
|
| https://github.com/ashley-hunter |
| test(i18n): add failing test for two ICUs in one message | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/235ff950734ea65417ac12def6d7eedd13e9b670 |
| 235ff95 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/235ff950734ea65417ac12def6d7eedd13e9b670 |
|
| https://github.com/ashley-hunter |
| fix(i18n): give each ICU in a message its own placeholder name | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/e07e3500ad230a9e2bfb9d4dc00bfc1a19b6e9e0 |
| e07e350 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/e07e3500ad230a9e2bfb9d4dc00bfc1a19b6e9e0 |
|
| https://github.com/ashley-hunter |
| test(i18n): add failing tests from Angular's i18n compliance scenarios | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/caf5acfed468655d20e711f5fb2d8c580f58c0be |
| caf5acf | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/caf5acfed468655d20e711f5fb2d8c580f58c0be |
| @else | https://github.com/else |
|
| https://github.com/ashley-hunter |
| fix(i18n): keep original placeholder names in $localize messages | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/c86b86736ec3b9043ad3ede85e9fb52e0d4ea3cf |
| c86b867 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/c86b86736ec3b9043ad3ede85e9fb52e0d4ea3cf |
|
| https://github.com/ashley-hunter |
| fix(i18n): only create i18n- messages for attributes with a value | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/f49658f85b4dd8e0f8d24fa5f0d977458640252f |
| f49658f | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/f49658f85b4dd8e0f8d24fa5f0d977458640252f |
|
| https://github.com/ashley-hunter |
| fix(i18n): honour custom placeholder names for interpolations | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/cae1fc38a70cd854f33461f61117702ac361f661 |
| cae1fc3 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/cae1fc38a70cd854f33461f61117702ac361f661 |
|
| https://github.com/ashley-hunter |
| fix(i18n): keep whitespace-only text in i18n messages | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/1e3f3086b2e9a20a5c4663417a708669da55c0b3 |
| 1e3f308 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/1e3f3086b2e9a20a5c4663417a708669da55c0b3 |
|
| https://github.com/ashley-hunter |
| fix(i18n): resolve element and block placeholders once per view, in o… | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/6c9bf229be49be03b4b554e1c96861abcb886d96 |
| 6c9bf22 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/6c9bf229be49be03b4b554e1c96861abcb886d96 |
| #1 | https://github.com/ashley-hunter/oxc-angular-compiler/pull/1 |
| #1 | https://github.com/ashley-hunter/oxc-angular-compiler/pull/1 |
| @else | https://github.com/else |
|
| https://github.com/ashley-hunter |
| fix(i18n): take block placeholder names from the i18n message | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/6bd28966fab10e3c6fd535138463c2fed49b252f |
| 6bd2896 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/6bd28966fab10e3c6fd535138463c2fed49b252f |
| @else | https://github.com/else |
| @else | https://github.com/else |
|
| https://github.com/ashley-hunter |
| test(i18n): add failing tests for the remaining compliance divergences | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/879273d6ac1f55bc8820f1ef7b1a141bc24de7cf |
| 879273d | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/879273d6ac1f55bc8820f1ef7b1a141bc24de7cf |
|
| https://github.com/ashley-hunter |
| fix(i18n): serialize void elements as a single placeholder | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/c8ce5947debd5984f3b2f270a6095118c755a655 |
| c8ce594 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/c8ce5947debd5984f3b2f270a6095118c755a655 |
|
| https://github.com/ashley-hunter |
| fix(i18n): accept whitespace in custom placeholder name comments | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/a55229f94ecec8f06ab0fc56b9c3119a890763f2 |
| a55229f | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/a55229f94ecec8f06ab0fc56b9c3119a890763f2 |
|
| https://github.com/ashley-hunter |
| fix(i18n): escape $localize metadata blocks in the raw strings | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/0a7464dfe2ad2ddfeafae59250a3f1b287d488f6 |
| 0a7464d | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/0a7464dfe2ad2ddfeafae59250a3f1b287d488f6 |
| @ida | https://github.com/ida |
| @ida | https://github.com/ida |
|
| https://github.com/ashley-hunter |
| fix(i18n): name nested tag placeholders children first | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/7e34af200f81cf14b9529313e86368687a4c075f |
| 7e34af2 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/7e34af200f81cf14b9529313e86368687a4c075f |
|
| https://github.com/ashley-hunter |
| fix(i18n): take nested ICU VAR names from the ICU's message | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/2d0128eb411ae54f1657ecc548c319d9306d00f7 |
| 2d0128e | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/2d0128eb411ae54f1657ecc548c319d9306d00f7 |
|
| https://github.com/ashley-hunter |
| fix(i18n): trim ICU var names when spaces surround the ICU type | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/3bba3e5503172d794401c2b8f4fc78b04c464f5a |
| 3bba3e5 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/3bba3e5503172d794401c2b8f4fc78b04c464f5a |
|
| https://github.com/ashley-hunter |
| fix(i18n): bind interpolations in element markup inside ICUs | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/e2fe06a8b4c45310e273490c70c64dc23f131cb0 |
| e2fe06a | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/e2fe06a8b4c45310e273490c70c64dc23f131cb0 |
|
| https://github.com/ashley-hunter |
| fix(i18n): give inside i18n blocks its placeholder values | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/0f4208fcdc85a60b2768617d659d598f51a67dbf |
| 0f4208f | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/0f4208fcdc85a60b2768617d659d598f51a67dbf |
|
| https://github.com/ashley-hunter |
| fix(i18n): keep placeholder names for text that is only an interpolation | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/0afef532b2ed2d1052efbea9d4e7a604cbf5b227 |
| 0afef53 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/0afef532b2ed2d1052efbea9d4e7a604cbf5b227 |
|
| https://github.com/ashley-hunter |
| fix(i18n): compile ICUs outside i18n blocks | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/e33f9d0b36e984b4990574223d6ec3b408c216ee |
| e33f9d0 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/e33f9d0b36e984b4990574223d6ec3b408c216ee |
|
| https://github.com/ashley-hunter |
| test(i18n): add failing test for SVG element placeholder names | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/b1ae4928e54b47bade8fa21b2a11051e0651b457 |
| b1ae492 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/b1ae4928e54b47bade8fa21b2a11051e0651b457 |
|
| https://github.com/ashley-hunter |
| fix(i18n): name element placeholders with their namespace | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/c4bbb29127df98debfb6831f8c147b278b00b5ce |
| c4bbb29 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/c4bbb29127df98debfb6831f8c147b278b00b5ce |
|
| https://github.com/ashley-hunter |
| test(i18n): add failing test for whitespace around a root-level ICU | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/80c3b52df7312c9a18594a46c9948b6c0a204578 |
| 80c3b52 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/80c3b52df7312c9a18594a46c9948b6c0a204578 |
|
| https://github.com/ashley-hunter |
| fix(i18n): drop whitespace around ICUs at the template root | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/cb559f2d74043d0edf1bf7908bde7b9d06c5d89f |
| cb559f2 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/cb559f2d74043d0edf1bf7908bde7b9d06c5d89f |
|
| https://github.com/ashley-hunter |
| test(i18n): add failing test for &ngsp; in i18n messages | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/56480b4648324e6ab6ae7ee5ee9ff6063a2f9188 |
| 56480b4 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/56480b4648324e6ab6ae7ee5ee9ff6063a2f9188 |
|
| https://github.com/ashley-hunter |
| fix(i18n): build text messages from tokens like Angular | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/94856e16063c0d5ba9201197b8a186ba9f163b97 |
| 94856e1 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/94856e16063c0d5ba9201197b8a186ba9f163b97 |
| ashley-hunter | https://github.com/ashley-hunter |
| September 22, 2026 17:48 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491#commits-pushed-e3c6842 |
|
| https://github.com/ashley-hunter |
| refactor(i18n): address clippy lints in the i18n fixes | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/e3c6842b9fec8c4cf07c58c8e16ae59d9ee6d460 |
| e3c6842 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/e3c6842b9fec8c4cf07c58c8e16ae59d9ee6d460 |
|
| https://github.com/ashley-hunter |
| docs: note that legacy i18n message IDs are not supported | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/98a4f77f22424101cc724c1ea2dd06846b6e94ec |
| 98a4f77 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/98a4f77f22424101cc724c1ea2dd06846b6e94ec |
|
| https://github.com/ashley-hunter |
| fix(compare): compare static definitions emitted as class fields | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/b444737d02fca47bb13cf3d33ffe85b8c0348321 |
| b444737 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/b444737d02fca47bb13cf3d33ffe85b8c0348321 |
|
| https://github.com/ashley-hunter |
| test(i18n): add failing tests found by the compare tool's i18n fixtures | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/99e9c9a7512d6028ded8af68c7574a70591253b1 |
| 99e9c9a | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/99e9c9a7512d6028ded8af68c7574a70591253b1 |
|
| https://github.com/ashley-hunter |
| fix(i18n): use the bindings marker for i18n attributes on ng-template | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/b793154ecf8c5e790d179964757da49cf7cba5b2 |
| b793154 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/b793154ecf8c5e790d179964757da49cf7cba5b2 |
|
| https://github.com/ashley-hunter |
| fix: advance to i18nAttributes and conditional branch slots | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/789ce1bef4130ef4912c8d7e1d650f5e08bde40c |
| 789ce1b | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/789ce1bef4130ef4912c8d7e1d650f5e08bde40c |
|
| https://github.com/ashley-hunter |
| fix(i18n): name ICU sub-messages on their $localize placeholders | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/3aa727599c688a69429731286a37fde5edf3f38e |
| 3aa7275 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/3aa727599c688a69429731286a37fde5edf3f38e |
|
| https://github.com/ashley-hunter |
| fix(compare): keep whitespace in static fields for the semantic check | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/34cd87ed0ec9f5708bfdbde9a57e2d859214ea00 |
| 34cd87e | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/34cd87ed0ec9f5708bfdbde9a57e2d859214ea00 |
|
| https://github.com/ashley-hunter |
| test(compare): add i18n fixtures from Angular's own i18n tests | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/7097daca37dff7cd6438698a849da7526a50e0f4 |
| 7097dac | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/7097daca37dff7cd6438698a849da7526a50e0f4 |
| @let | https://github.com/let |
| @switch | https://github.com/switch |
|
| https://github.com/ashley-hunter |
| docs(compare): document known differences and the i18n fixture generator | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/685ef8ca80282eb76478ca58733dfa96c17d8542 |
| 685ef8c | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/685ef8ca80282eb76478ca58733dfa96c17d8542 |
|
| https://github.com/ashley-hunter |
| refactor(i18n): address clippy lints in the i18n fixes | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/d62ba1e3087daeb89c549e3807b7f70f64e88534 |
| d62ba1e | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/d62ba1e3087daeb89c549e3807b7f70f64e88534 |
|
| https://github.com/ashley-hunter |
| refactor(i18n): tidy the placeholder-name plumbing | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/8d99ca4749ef4331d9e1172a0807a6dd181d8e4c |
| 8d99ca4 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/8d99ca4749ef4331d9e1172a0807a6dd181d8e4c |
|
| https://github.com/ashley-hunter |
| test(i18n): add failing test for literal placeholder-like text | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/bb983722cbf47c1189710efd449ec25e0f2d4564 |
| bb98372 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/bb983722cbf47c1189710efd449ec25e0f2d4564 |
|
| https://github.com/ashley-hunter |
| fix(i18n): keep text that looks like a placeholder marker | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/44b6a595e92b0faccadf1760f29de121acac0120 |
| 44b6a59 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/44b6a595e92b0faccadf1760f29de121acac0120 |
| voidzero-dev#123 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/123 |
| voidzero-dev#125 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/125 |
|
| https://github.com/ashley-hunter |
| fix(i18n): clear the sole-ICU message after visiting an element's chi… | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/30aa85323d6929c58e7ea1e519702e5d53e103b2 |
| 30aa853 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/30aa85323d6929c58e7ea1e519702e5d53e103b2 |
|
| https://github.com/ashley-hunter |
| refactor(compare): type the static field comparison like the rest of … | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/b69f7e9ccab86c6844a4c772dce55bc3afe926e0 |
| b69f7e9 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/b69f7e9ccab86c6844a4c772dce55bc3afe926e0 |
|
| https://github.com/ashley-hunter |
| test(compare): regenerate i18n fixtures from the Angular submodule | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/7084fadfb148f4aa939e0d4d85fbbdaa3f0796ea |
| 7084fad | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/7084fadfb148f4aa939e0d4d85fbbdaa3f0796ea |
|
| https://github.com/ashley-hunter |
| perf(i18n): avoid allocating a full element name per element | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/6852ba0c9a5f6e53ba505683fe7950140ea2b0f4 |
| 6852ba0 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/6852ba0c9a5f6e53ba505683fe7950140ea2b0f4 |
|
| https://github.com/ashley-hunter |
| test(compare): scope known differences to the fields they document | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/6a1c66c9f97ee9e83663cfa4d5bc05f69ef5ba64 |
| 6a1c66c | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/6a1c66c9f97ee9e83663cfa4d5bc05f69ef5ba64 |
|
| https://github.com/ashley-hunter |
| test(compare): stop recording an i18n fixture flag nothing reads | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/2efc1a356726df1959c71113318a43acc2cd03bd |
| 2efc1a3 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/2efc1a356726df1959c71113318a43acc2cd03bd |
|
| https://github.com/ashley-hunter |
| docs: correct the option names in the README examples | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/af148cb2ce361e1ab78907f7a344422145d9d66e |
| af148cb | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/af148cb2ce361e1ab78907f7a344422145d9d66e |
|
| https://github.com/ashley-hunter |
| Merge remote-tracking branch 'upstream/main' into t3code/fix-angular-… | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/804766dba3a7ffd79ee5b0f6db741db3303e57a3 |
| 804766d | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/804766dba3a7ffd79ee5b0f6db741db3303e57a3 |
|
| https://github.com/ashley-hunter |
| test(compare): refresh the known differences for Angular 22.1.7 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/498fc37092ac1c2f9b4ff6f093dda97aefbab8dc |
| 498fc37 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/498fc37092ac1c2f9b4ff6f093dda97aefbab8dc |
|
| https://github.com/ashley-hunter |
| test(compare): drop a known-difference reason with no remaining users | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/b5b7e6eeebf664052a20fcff395917b96e1529ee |
| b5b7e6e | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/b5b7e6eeebf664052a20fcff395917b96e1529ee |
|
| https://github.com/ashley-hunter |
| chore: drop the handoff note that was committed by mistake | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/d2d6f58212b566d65cd90c9516fb67f1dfe0f455 |
| d2d6f58 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/commits/d2d6f58212b566d65cd90c9516fb67f1dfe0f455 |
| https://github.com/Brooooooklyn |
| Brooooooklyn | https://github.com/Brooooooklyn |
| Sep 23, 2026 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491#issuecomment-5787802819 |
| @codex | https://github.com/codex |
| Please reload this page | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491 |
| https://github.com/Brooooooklyn |
| Brooooooklyn | https://github.com/Brooooooklyn |
|
Sep 23, 2026
| https://github.com/voidzero-dev/oxc-angular-compiler/pull/491#pullrequestreview-5286459891 |
|
View reviewed changes
| https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/files/d2d6f58212b566d65cd90c9516fb67f1dfe0f455 |
| https://github.com/Brooooooklyn |
| Brooooooklyn | https://github.com/Brooooooklyn |
| 0baf86c | https://github.com/voidzero-dev/oxc-angular-compiler/commit/0baf86c8ce558b01e25596971e20534b4ef21afa |
| Sep 23, 2026 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491#event-31647380337 |
| Please reload this page | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491 |
| https://github.co/hiddenchars |
| https://github.com/voidzero-dev/oxc-angular-compiler/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fvoidzero-dev%2Foxc-angular-compiler%2Fpull%2F491 |
|
| https://github.com/Brooooooklyn |
|
Brooooooklyn
| https://github.com/Brooooooklyn |
|
| https://github.com/voidzero-dev/oxc-angular-compiler/pull/491/files/d2d6f58212b566d65cd90c9516fb67f1dfe0f455 |
| Please reload this page | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491 |
| Please reload this page | https://github.com/voidzero-dev/oxc-angular-compiler/pull/491 |
|
| https://github.com/ashley-hunter |
|
| https://github.com/Brooooooklyn |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |