| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b52f2cc2-b46f-f209-638e-9dc8595ce513 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9DD2:34DB8F:F0EB87:1425CFB:6B011144 |
| html-safe-nonce | 5bec2c83f9762d6ae0ba3cfbafd62c552e952796e1217d95f82a7f1010129452 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5REQyOjM0REI4RjpGMEVCODc6MTQyNUNGQjo2QjAxMTE0NCIsInZpc2l0b3JfaWQiOiI3NDM3NDc2ODA4MjE3Mzk5NjIwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7f3cc6e3f67a1776dadb3417a57ae47235392c928ee6da9af9133b693bcfb1b1 |
| hovercard-subject-tag | pull_request:3759687742 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/voidzero-dev/oxc-angular-compiler/306/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f48cfb35801658a7f8b04f8ae06e86f42455afc8b2b15a411d6cddeafe93551d/voidzero-dev/oxc-angular-compiler/pull/306 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f48cfb35801658a7f8b04f8ae06e86f42455afc8b2b15a411d6cddeafe93551d/voidzero-dev/oxc-angular-compiler/pull/306 |
| og:image:alt | Summary
Fixes #288. A constructor parameter whose type annotation comes from a
type-only import (import type { X } or import { type X }) was being
promoted to a runtime DI token. The compiler emitt... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Brooooooklyn |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/voidzero-dev/oxc-angular-compiler git https://github.com/voidzero-dev/oxc-angular-compiler.git |
| octolytics-dimension-user_id | 149750581 |
| octolytics-dimension-user_login | voidzero-dev |
| octolytics-dimension-repository_id | 1122751442 |
| octolytics-dimension-repository_nwo | voidzero-dev/oxc-angular-compiler |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1122751442 |
| octolytics-dimension-repository_network_root_nwo | voidzero-dev/oxc-angular-compiler |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fvoidzero-dev%2Foxc-angular-compiler%2Fpull%2F306 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fvoidzero-dev%2Foxc-angular-compiler%2Fpull%2F306 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=voidzero-dev%2Foxc-angular-compiler |
| Reload | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306 |
| Reload | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306 |
| Reload | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306 |
| voidzero-dev | https://github.com/voidzero-dev |
| oxc-angular-compiler | https://github.com/voidzero-dev/oxc-angular-compiler |
| Code | https://github.com/voidzero-dev/oxc-angular-compiler |
| Issues4 (4) | https://github.com/voidzero-dev/oxc-angular-compiler/issues |
| Pull requests1 (1) | https://github.com/voidzero-dev/oxc-angular-compiler/pulls |
| Actions | https://github.com/voidzero-dev/oxc-angular-compiler/actions |
| Projects | https://github.com/voidzero-dev/oxc-angular-compiler/projects |
| Security and quality | https://github.com/voidzero-dev/oxc-angular-compiler/security |
| Insights | https://github.com/voidzero-dev/oxc-angular-compiler/insights |
| https://github.com/voidzero-dev/oxc-angular-compiler |
| Brooooooklyn | https://github.com/Brooooooklyn |
| main | https://github.com/voidzero-dev/oxc-angular-compiler/tree/main |
| fix/288-type-only-di-tokens | https://github.com/voidzero-dev/oxc-angular-compiler/tree/fix/288-type-only-di-tokens |
| Conversation | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306 |
| Commits2 (2) | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306/commits |
| Checks | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306/checks |
| Files changed | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306/files |
| fix(di): emit ɵɵinvalidFactory for type-only constructor parameter imports | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306#top |
| Brooooooklyn | https://github.com/Brooooooklyn |
| main | https://github.com/voidzero-dev/oxc-angular-compiler/tree/main |
| fix/288-type-only-di-tokens | https://github.com/voidzero-dev/oxc-angular-compiler/tree/fix/288-type-only-di-tokens |
|
| https://github.com/Brooooooklyn |
| Brooooooklyn | https://github.com/Brooooooklyn |
| May 28, 2026 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306#issue-4537727532 |
| Please reload this page | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306 |
| #288 | https://github.com/voidzero-dev/oxc-angular-compiler/issues/288 |
| Claude Code | https://claude.com/claude-code |
| #288 | https://github.com/voidzero-dev/oxc-angular-compiler/issues/288 |
| Cursor Bugbot | https://cursor.com/bugbot |
| 433a78b | https://github.com/voidzero-dev/oxc-angular-compiler/commit/433a78b3236768c6fa50ef985b78b5666e7baf24 |
| here | https://www.cursor.com/dashboard/bugbot |
| Please reload this page | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306 |
|
| https://github.com/Brooooooklyn |
|
| https://github.com/claude |
| fix(di): emit ɵɵinvalidFactory for type-only constructor parameter im… | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306/commits/5db5284c672029d382ae2e0a01d381d8b9f220b9 |
| 5db5284 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306/commits/5db5284c672029d382ae2e0a01d381d8b9f220b9 |
| #288 | https://github.com/voidzero-dev/oxc-angular-compiler/issues/288 |
| https://github.com/apps/chatgpt-codex-connector |
| chatgpt-codex-connector | https://github.com/apps/chatgpt-codex-connector |
|
May 28, 2026
| https://github.com/voidzero-dev/oxc-angular-compiler/pull/306#pullrequestreview-4377928134 |
|
View reviewed changes
| https://github.com/voidzero-dev/oxc-angular-compiler/pull/306/files/5db5284c672029d382ae2e0a01d381d8b9f220b9 |
| chatgpt-codex-connector | https://github.com/apps/chatgpt-codex-connector |
| https://github.com/voidzero-dev/oxc-angular-compiler/pull/306#pullrequestreview-4377928134 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Your team has set up Codex to review pull requests in this repo | https://chatgpt.com/codex/cloud/settings/general |
| @codex | https://github.com/codex |
| @codex | https://github.com/codex |
| Please reload this page | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306 |
| crates/oxc_angular_compiler/src/factory/metadata.rs | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306/files/5db5284c672029d382ae2e0a01d381d8b9f220b9#diff-b8a8089fbef03aee77b2a48770efa4ee57b626a0bb196f432e52397c2b68a5ae |
| Please reload this page | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306 |
| https://github.com/apps/cursor |
| cursor | https://github.com/apps/cursor |
|
May 28, 2026
| https://github.com/voidzero-dev/oxc-angular-compiler/pull/306#pullrequestreview-4377929691 |
|
View reviewed changes
| https://github.com/voidzero-dev/oxc-angular-compiler/pull/306/files/5db5284c672029d382ae2e0a01d381d8b9f220b9 |
| cursor | https://github.com/apps/cursor |
| https://github.com/voidzero-dev/oxc-angular-compiler/pull/306#pullrequestreview-4377929691 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://cursor.com/open?link=eyJ2ZXJzaW9uIjoxLCJ0eXBlIjoiQlVHQk9UX0ZJWF9BTExfSU5fQ1VSU09SIiwiZGF0YSI6eyJyZWRpc0tleSI6ImJ1Z2JvdC1tdWx0aTo2MDQ0NDI4Ni0xZjM4LTQxYmQtYTI2Mi0xM2U2YmYwYzU1NDMiLCJlbmNyeXB0aW9uS2V5IjoicUFWamEzTnJHNDlpeXJHSUkxWTdwX3o5NU4yLU1YUlY1c3hjbE5meXhwbyIsImJyYW5jaCI6ImZpeC8yODgtdHlwZS1vbmx5LWRpLXRva2VucyIsInJlcG9Pd25lciI6InZvaWR6ZXJvLWRldiIsInJlcG9OYW1lIjoib3hjLWFuZ3VsYXItY29tcGlsZXIifX0 |
| Cursor dashboard | https://www.cursor.com/dashboard/bugbot |
| Cursor Bugbot | https://cursor.com/bugbot |
| 5db5284 | https://github.com/voidzero-dev/oxc-angular-compiler/commit/5db5284c672029d382ae2e0a01d381d8b9f220b9 |
| here | https://www.cursor.com/dashboard/bugbot |
| Please reload this page | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306 |
| crates/oxc_angular_compiler/src/component/definition.rs | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306/files/5db5284c672029d382ae2e0a01d381d8b9f220b9#diff-86cd7cd2bccdc45daffe500cdcb0b5c66bc810736f4ae87ccdba50b2e07cc995 |
| Please reload this page | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306 |
|
| https://github.com/Brooooooklyn |
|
| https://github.com/claude |
| fix(di): keep NAPI build green and share the invalidFactory helper | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306/commits/433a78b3236768c6fa50ef985b78b5666e7baf24 |
| 433a78b | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306/commits/433a78b3236768c6fa50ef985b78b5666e7baf24 |
| #306 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306 |
| https://github.com/Brooooooklyn |
| Brooooooklyn | https://github.com/Brooooooklyn |
| 5b9703e | https://github.com/voidzero-dev/oxc-angular-compiler/commit/5b9703effb5a1e0b67aa3a94c4577a9ec5870586 |
| May 28, 2026 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306#event-26048641866 |
| Please reload this page | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306 |
| https://github.com/Brooooooklyn |
| Brooooooklyn | https://github.com/Brooooooklyn |
| May 28, 2026 06:09 | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306#event-26048643018 |
| https://github.co/hiddenchars |
| https://github.com/voidzero-dev/oxc-angular-compiler/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fvoidzero-dev%2Foxc-angular-compiler%2Fpull%2F306 |
|
| https://github.com/apps/chatgpt-codex-connector |
|
chatgpt-codex-connector[bot]
| https://github.com/apps/chatgpt-codex-connector |
|
| https://github.com/voidzero-dev/oxc-angular-compiler/pull/306/files/5db5284c672029d382ae2e0a01d381d8b9f220b9 |
|
| https://github.com/apps/cursor |
|
cursor[bot]
| https://github.com/apps/cursor |
|
| https://github.com/voidzero-dev/oxc-angular-compiler/pull/306/files/5db5284c672029d382ae2e0a01d381d8b9f220b9 |
| Please reload this page | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306 |
|
DI: import type tokens promoted to runtime value imports
| https://github.com/voidzero-dev/oxc-angular-compiler/issues/288 |
| Please reload this page | https://github.com/voidzero-dev/oxc-angular-compiler/pull/306 |
|
| https://github.com/Brooooooklyn |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |