René's URL Explorer Experiment


Title: perf(spy): avoid scanning cleared mocks by scttcper · Pull Request #11092 · vitest-dev/vitest · GitHub

Open Graph Title: perf(spy): avoid scanning cleared mocks by scttcper · Pull Request #11092 · vitest-dev/vitest

X Title: perf(spy): avoid scanning cleared mocks by scttcper · Pull Request #11092 · vitest-dev/vitest

Description: Next generation testing framework powered by Vite. - perf(spy): avoid scanning cleared mocks by scttcper · Pull Request #11092 · vitest-dev/vitest

Open Graph Description: Used 5.6 sol here to generate pr, i've reviewed the change. I'm confident it fixes the bug but i'm not entirely sure it doesn't introduce something unexpected with how they were lin...

X Description: Used 5.6 sol here to generate pr, i've reviewed the change. I'm confident it fixes the bug but i'm not entirely sure it doesn't introduce something unexpected with h...

Opengraph URL: https://github.com/vitest-dev/vitest/pull/11092

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:88942ced-4903-7daa-cc8d-b3c5f4059aae
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD60E:E530F:17FFB88:1FF6389:6AED78D0
html-safe-noncec4066f323165a55e7e736e92c7bea51cd5ffd166d7588b1f6b0650d9ee291da2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjBFOkU1MzBGOjE3RkZCODg6MUZGNjM4OTo2QUVENzhEMCIsInZpc2l0b3JfaWQiOiI4MjcyMDcxNjQ5MTI5MjMyNTkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac070201da5a6eaa2ee3e9651f1681118bb326e0a0954c9625cc122a0604491863
hovercard-subject-tagpull_request:4387062636
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/vitest-dev/vitest/11092/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d75d5e55895559f456b4e838e28911a582edccb08b7ac9c10d45d1253e45c454/vitest-dev/vitest/pull/11092
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d75d5e55895559f456b4e838e28911a582edccb08b7ac9c10d45d1253e45c454/vitest-dev/vitest/pull/11092
og:image:altUsed 5.6 sol here to generate pr, i've reviewed the change. I'm confident it fixes the bug but i'm not entirely sure it doesn't introduce something unexpected with how they were lin...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamescttcper
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/vitest-dev/vitest git https://github.com/vitest-dev/vitest.git
octolytics-dimension-user_id95747107
octolytics-dimension-user_loginvitest-dev
octolytics-dimension-repository_id434708679
octolytics-dimension-repository_nwovitest-dev/vitest
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id434708679
octolytics-dimension-repository_network_root_nwovitest-dev/vitest
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/vitest-dev/vitest/pull/11092#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fvitest-dev%2Fvitest%2Fpull%2F11092
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fvitest-dev%2Fvitest%2Fpull%2F11092
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=vitest-dev%2Fvitest
Reloadhttps://github.com/vitest-dev/vitest/pull/11092
Reloadhttps://github.com/vitest-dev/vitest/pull/11092
Reloadhttps://github.com/vitest-dev/vitest/pull/11092
vitest-devhttps://github.com/vitest-dev
vitesthttps://github.com/vitest-dev/vitest
Codehttps://github.com/vitest-dev/vitest
Issues333 (333)https://github.com/vitest-dev/vitest/issues
Pull requests25 (25)https://github.com/vitest-dev/vitest/pulls
Discussionshttps://github.com/vitest-dev/vitest/discussions
Actionshttps://github.com/vitest-dev/vitest/actions
Projectshttps://github.com/vitest-dev/vitest/projects
Security and quality10 (10)https://github.com/vitest-dev/vitest/security
Insightshttps://github.com/vitest-dev/vitest/pulse
https://github.com/vitest-dev/vitest
sheremet-vahttps://github.com/sheremet-va
vitest-dev:mainhttps://github.com/vitest-dev/vitest/tree/main
scttcper:scttcper/dirty-mock-cleanuphttps://github.com/scttcper/vitest/tree/scttcper/dirty-mock-cleanup
Conversationhttps://github.com/vitest-dev/vitest/pull/11092
Commits5 (5)https://github.com/vitest-dev/vitest/pull/11092/commits
Checkshttps://github.com/vitest-dev/vitest/pull/11092/checks
Files changedhttps://github.com/vitest-dev/vitest/pull/11092/files
perf(spy): avoid scanning cleared mockshttps://github.com/vitest-dev/vitest/pull/11092#top
sheremet-vahttps://github.com/sheremet-va
vitest-dev:mainhttps://github.com/vitest-dev/vitest/tree/main
scttcper:scttcper/dirty-mock-cleanuphttps://github.com/scttcper/vitest/tree/scttcper/dirty-mock-cleanup
https://github.com/scttcper
scttcperhttps://github.com/scttcper
Aug 28, 2026https://github.com/vitest-dev/vitest/pull/11092#issue-5281056716
Please reload this pagehttps://github.com/vitest-dev/vitest/pull/11092
#9492https://github.com/vitest-dev/vitest/issues/9492
Please reload this pagehttps://github.com/vitest-dev/vitest/pull/11092
https://github.com/scttcper
https://github.com/codex
perf(spy): avoid scanning cleared mocks (https://github.com/vitest-dev/vitest/pull/11092/commits/b30400965b149a821c7483e8f9b7c89d1e380aaa
fixhttps://github.com/vitest-dev/vitest/pull/11092/commits/b30400965b149a821c7483e8f9b7c89d1e380aaa
vitest-dev#9492https://github.com/vitest-dev/vitest/issues/9492
)https://github.com/vitest-dev/vitest/pull/11092/commits/b30400965b149a821c7483e8f9b7c89d1e380aaa
b304009https://github.com/vitest-dev/vitest/pull/11092/commits/b30400965b149a821c7483e8f9b7c89d1e380aaa
vitest-dev#9492https://github.com/vitest-dev/vitest/issues/9492
https://github.com/apps/netlify
netlifyhttps://github.com/apps/netlify
Aug 28, 2026https://github.com/vitest-dev/vitest/pull/11092#issuecomment-5456163420
Please reload this pagehttps://github.com/vitest-dev/vitest/pull/11092
without sensitive environment variableshttps://docs.netlify.com/configure-builds/environment-variables/#sensitive-variable-policy
b03934bhttps://github.com/vitest-dev/vitest/commit/b03934b95c90c5d478eda1305162cde27b78010c
https://app.netlify.com/projects/vitest-dev/deploys/6a986b98df2d730008e472cahttps://app.netlify.com/projects/vitest-dev/deploys/6a986b98df2d730008e472ca
https://deploy-preview-11092--vitest-dev.netlify.apphttps://deploy-preview-11092--vitest-dev.netlify.app
https://camo.githubusercontent.com/485d7d20175f74ccdcb96df58e0f282f845456f45b551fd459837f36d8127c3b/68747470733a2f2f6170702e6e65746c6966792e636f6d2f71722d636f64652f65794a30655841694f694a4b563151694c434a68624763694f694a49557a49314e694a392e65794a31636d77694f694a6f64485277637a6f764c32526c6347787665533177636d5632615756334c5445784d446b794c5331326158526c633351745a4756324c6d356c644778705a6e6b7559584277496e302e633377722d79533832794f764f5f7978677174566e787a78416a597368644478524e557155636f35725651
Run an agent on this branchhttps://app.netlify.com/projects/vitest-dev/agent-runs#DcoxDoAgDADAv3TWSNAo-AOfAW2NRoEGcTDGv8t2w70gOQUpMAM04LOLuFVfWAoK5472XJ42JDxaPNnFW2ojljM9C9U4OmtGbw2tmqZeKWV4mDQ6-H4
Netlify project configurationhttps://app.netlify.com/projects/vitest-dev/configuration/notifications#deploy-notifications
Please reload this pagehttps://github.com/vitest-dev/vitest/pull/11092
https://github.com/scttcper
https://github.com/codex
refactor(spy): inline mock registry typehttps://github.com/vitest-dev/vitest/pull/11092/commits/affc5ef765b8f12e5d64484b60ad40f0e8451712
affc5efhttps://github.com/vitest-dev/vitest/pull/11092/commits/affc5ef765b8f12e5d64484b60ad40f0e8451712
https://github.com/scttcper
scttcperhttps://github.com/scttcper
August 28, 2026 18:30https://github.com/vitest-dev/vitest/pull/11092#event-30181594107
https://github.com/scttcper
scttcperhttps://github.com/scttcper
Aug 28, 2026https://github.com/vitest-dev/vitest/pull/11092#event-30181598650
https://github.com/sheremet-va
sheremet-vahttps://github.com/sheremet-va
Aug 28, 2026https://github.com/vitest-dev/vitest/pull/11092#issuecomment-5458616301
Please reload this pagehttps://github.com/vitest-dev/vitest/pull/11092
https://github.com/scttcper
https://github.com/codex
perf(spy): keep mock state access directhttps://github.com/vitest-dev/vitest/pull/11092/commits/4475a34782bfbb2f07a53975712526352701a393
4475a34https://github.com/vitest-dev/vitest/pull/11092/commits/4475a34782bfbb2f07a53975712526352701a393
https://github.com/scttcper
scttcperhttps://github.com/scttcper
Aug 29, 2026https://github.com/vitest-dev/vitest/pull/11092#issuecomment-5459018093
Please reload this pagehttps://github.com/vitest-dev/vitest/pull/11092
https://github.com/scttcper
Merge branch 'main' into scttcper/dirty-mock-cleanuphttps://github.com/vitest-dev/vitest/pull/11092/commits/b6773a54291c89f329f09f71d5bdd0ecc839fc6e
b6773a5https://github.com/vitest-dev/vitest/pull/11092/commits/b6773a54291c89f329f09f71d5bdd0ecc839fc6e
https://github.com/AndreasOhlsson
AndreasOhlssonhttps://github.com/AndreasOhlsson
Sep 2, 2026https://github.com/vitest-dev/vitest/pull/11092#issuecomment-5508738383
#9492https://github.com/vitest-dev/vitest/issues/9492
Please reload this pagehttps://github.com/vitest-dev/vitest/pull/11092
https://github.com/sheremet-va
sheremet-vahttps://github.com/sheremet-va
Sep 2, 2026 https://github.com/vitest-dev/vitest/pull/11092#pullrequestreview-5089353784
View reviewed changes https://github.com/vitest-dev/vitest/pull/11092/files/b6773a54291c89f329f09f71d5bdd0ecc839fc6e
packages/spy/src/index.tshttps://github.com/vitest-dev/vitest/pull/11092/files/b6773a54291c89f329f09f71d5bdd0ecc839fc6e#diff-521af3484b7228a9fd0ed12f9f61c2029be2e815b2ef25d0ddd2eaeb5dc8cecd
sheremet-vahttps://github.com/sheremet-va
Sep 2, 2026https://github.com/vitest-dev/vitest/pull/11092#discussion_r3913859510
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/vitest-dev/vitest/pull/11092
sheremet-vahttps://github.com/sheremet-va
Sep 2, 2026https://github.com/vitest-dev/vitest/pull/11092#discussion_r3914181026
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/vitest-dev/vitest/pull/11092
scttcperhttps://github.com/scttcper
Sep 2, 2026https://github.com/vitest-dev/vitest/pull/11092#discussion_r3917446559
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/vitest-dev/vitest/pull/11092
https://github.com/sheremet-va
sheremet-vahttps://github.com/sheremet-va
Sep 2, 2026 https://github.com/vitest-dev/vitest/pull/11092#pullrequestreview-5089747894
View reviewed changes https://github.com/vitest-dev/vitest/pull/11092/files/b6773a54291c89f329f09f71d5bdd0ecc839fc6e
packages/spy/src/index.tshttps://github.com/vitest-dev/vitest/pull/11092/files/b6773a54291c89f329f09f71d5bdd0ecc839fc6e#diff-521af3484b7228a9fd0ed12f9f61c2029be2e815b2ef25d0ddd2eaeb5dc8cecd
sheremet-vahttps://github.com/sheremet-va
Sep 2, 2026https://github.com/vitest-dev/vitest/pull/11092#discussion_r3914193234
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
vitest/docs/guide/browser/index.mdhttps://github.com/vitest-dev/vitest/blob/c4093fdeb87fe6a3066f6c6d637129a031802e94/docs/guide/browser/index.md?plain=1#L305
c4093fdhttps://github.com/vitest-dev/vitest/commit/c4093fdeb87fe6a3066f6c6d637129a031802e94
Please reload this pagehttps://github.com/vitest-dev/vitest/pull/11092
https://github.com/scttcper
https://github.com/codex
perf(spy): iterate dirty mocks directlyhttps://github.com/vitest-dev/vitest/pull/11092/commits/b03934b95c90c5d478eda1305162cde27b78010c
b03934bhttps://github.com/vitest-dev/vitest/pull/11092/commits/b03934b95c90c5d478eda1305162cde27b78010c
https://github.com/scttcper
scttcperhttps://github.com/scttcper
sheremet-vahttps://github.com/sheremet-va
stale reviewhttps://github.com/vitest-dev/vitest/pull/11092#pullrequestreview-5089747894
b03934bhttps://github.com/vitest-dev/vitest/commit/b03934b95c90c5d478eda1305162cde27b78010c
September 2, 2026 18:31https://github.com/vitest-dev/vitest/pull/11092#event-30437137044
https://github.com/scttcper
scttcperhttps://github.com/scttcper
Sep 2, 2026https://github.com/vitest-dev/vitest/pull/11092#issuecomment-5514539763
Please reload this pagehttps://github.com/vitest-dev/vitest/pull/11092
https://github.com/sheremet-va
sheremet-vahttps://github.com/sheremet-va
Sep 2, 2026 https://github.com/vitest-dev/vitest/pull/11092#pullrequestreview-5093850093
View reviewed changes https://github.com/vitest-dev/vitest/pull/11092/files/b03934b95c90c5d478eda1305162cde27b78010c
https://github.com/sheremet-va
sheremet-vahttps://github.com/sheremet-va
2451e34https://github.com/vitest-dev/vitest/commit/2451e34c404aba1038f5e749c85bb268b2f4525e
Sep 2, 2026https://github.com/vitest-dev/vitest/pull/11092#event-30439967829
Please reload this pagehttps://github.com/vitest-dev/vitest/pull/11092
https://github.com/johan-gorter
johan-gorterhttps://github.com/johan-gorter
Sep 8, 2026 https://github.com/vitest-dev/vitest/pull/11092#ref-pullrequest-5387607283
perf(spy): reset only mocks that were called or reconfigured #11197 https://github.com/vitest-dev/vitest/pull/11197
Property store to object literals with an accessor is 7x slower since 26.4.0 when created after Object.defineProperty(fn, "length", ...) (bisected to 3e55527eef, PR #63068) nodejs/node#66011 https://github.com/nodejs/node/issues/66011
vi.fn "memory leak" with isolate: false #9492 https://github.com/vitest-dev/vitest/issues/9492
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 17, 2026https://github.com/vitest-dev/vitest/pull/11092#event-31283951183
https://github.co/hiddenchars
https://github.com/vitest-dev/vitest/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fvitest-dev%2Fvitest%2Fpull%2F11092
https://github.com/sheremet-va
sheremet-va https://github.com/sheremet-va
https://github.com/vitest-dev/vitest/pull/11092/files/b03934b95c90c5d478eda1305162cde27b78010c
Please reload this pagehttps://github.com/vitest-dev/vitest/pull/11092
vi.fn "memory leak" with isolate: false https://github.com/vitest-dev/vitest/issues/9492
Please reload this pagehttps://github.com/vitest-dev/vitest/pull/11092
https://github.com/scttcper
https://github.com/sheremet-va
https://github.com/AndreasOhlsson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.