Title: tests: validate "patch" and "ed" commands once, print meaningful messages by marc-hb · Pull Request #226 · uutils/diffutils · GitHub
Open Graph Title: tests: validate "patch" and "ed" commands once, print meaningful messages by marc-hb · Pull Request #226 · uutils/diffutils
X Title: tests: validate "patch" and "ed" commands once, print meaningful messages by marc-hb · Pull Request #226 · uutils/diffutils
Description: macOS' /usr/bin/patch and GNU patch have very subtle incompatibilities that cause only some "more advanced" tests to fail in obscure and very time-consuming ways - while other tests pass. In some cases (depending on test threads racing), the lack of newlines in some test data even causes the whole test suite to stall. This fix runs patch -version (only once), makes sure the output starts with "GNU patch" and shows a meaningful assert message when not. It also looks for gpatch instead of patch on macOS and shows a meaningful assert message if either is missing. Fixes: #225 This also provides faster and better feedback when ed is missing (see #39) and implements a portable and basic check. Last but not least, this new code is generic enough to support the validation of any other test dependency in the future.
Open Graph Description: macOS' /usr/bin/patch and GNU patch have very subtle incompatibilities that cause only some "more advanced" tests to fail in obscure and very time-consuming ways - while other tests p...
X Description: macOS' /usr/bin/patch and GNU patch have very subtle incompatibilities that cause only some "more advanced" tests to fail in obscure and very time-consuming ways - while o...
Opengraph URL: https://github.com/uutils/diffutils/pull/226
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:46d2face-d68f-0365-f508-60a15b6aa922 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A716:1E49FF:EAB162:13CBD43:6A4D8472 |
| html-safe-nonce | f4c041c00a9c45034f08508a013e2107c3d384b2f9e84e2a47c6d174f7f5831d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzE2OjFFNDlGRjpFQUIxNjI6MTNDQkQ0Mzo2QTREODQ3MiIsInZpc2l0b3JfaWQiOiIzOTQ4MzMyMDcwODUwMTAyMzg2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 4c57fc600feef1594932a2c839e9f1298a27c12a57d332c82eacb5afc9d096dc |
| hovercard-subject-tag | pull_request:3639558794 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/uutils/diffutils/pull/226/files |
| twitter:image | https://avatars.githubusercontent.com/u/46978960?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/46978960?s=400&v=4 |
| og:image:alt | macOS' /usr/bin/patch and GNU patch have very subtle incompatibilities that cause only some "more advanced" tests to fail in obscure and very time-consuming ways - while other tests p... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | c6bf61c909482ec3072ef5d7a5a28f2a9d214788c9a44793eca1960048cb05ae |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/uutils/diffutils git https://github.com/uutils/diffutils.git |
| octolytics-dimension-user_id | 5148717 |
| octolytics-dimension-user_login | uutils |
| octolytics-dimension-repository_id | 341787720 |
| octolytics-dimension-repository_nwo | uutils/diffutils |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 341787720 |
| octolytics-dimension-repository_network_root_nwo | uutils/diffutils |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6702a58b419a792226bd21ef0fb1bcb318bbcaa3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width