René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Wrong result for has_suite and is_suite when suite annotation is missing","articleBody":"**Describe the bug**\r\n\r\nThe functions `ut_runner.has_suites` and `ut_runner.is_suite` return a true, even if the annotation `suite` is missing.\r\n\r\n**Provide version info**\r\n\r\nInformation about utPLSQL and Database version, \r\n```\r\nSQL\u003e declare\r\n  2    l_version varchar2(255);\r\n  3    l_compatibility varchar2(255);\r\n  4  begin\r\n  5    dbms_utility.db_version( l_version, l_compatibility );\r\n  6    dbms_output.put_line( l_version );\r\n  7    dbms_output.put_line( l_compatibility );\r\n  8  end;\r\n  9  /\r\n19.0.0.0.0\r\n19.0.0\r\n\r\n\r\nPL/SQL procedure successfully completed.\r\n\r\nSQL\u003e select substr(ut.version(),1,60) as ut_version from dual;\r\n\r\nUT_VERSION                                                  \r\n------------------------------------------------------------\r\nv3.1.8.3148-develop                                         \r\n\r\nSQL\u003e select * from v$version;\r\n\r\nBANNER\r\n--------------------------------------------------------------------------------\r\nBANNER_FULL\r\n------------------------------------------------------------------------------------------------------------------------------------\r\nBANNER_LEGACY                                                                        CON_ID\r\n-------------------------------------------------------------------------------- ----------\r\nOracle Database 19c Enterprise Edition Release 19.0.0.0.0 - Production           \r\nOracle Database 19c Enterprise Edition Release 19.0.0.0.0 - Production                                                              \r\nVersion 19.2.0.0.0                                                                                                                  \r\nOracle Database 19c Enterprise Edition Release 19.0.0.0.0 - Production                    0\r\n\r\n\r\nSQL\u003e select * from nls_session_parameters;\r\n\r\nPARAMETER                      VALUE                                                           \r\n------------------------------ ----------------------------------------------------------------\r\nNLS_LANGUAGE                   AMERICAN                                                        \r\nNLS_TERRITORY                  SWITZERLAND                                                     \r\nNLS_CURRENCY                   SFr.                                                            \r\nNLS_ISO_CURRENCY               SWITZERLAND                                                     \r\nNLS_NUMERIC_CHARACTERS         .'                                                              \r\nNLS_CALENDAR                   GREGORIAN                                                       \r\nNLS_DATE_FORMAT                DD.MM.RR                                                        \r\nNLS_DATE_LANGUAGE              AMERICAN                                                        \r\nNLS_SORT                       BINARY                                                          \r\nNLS_TIME_FORMAT                HH24:MI:SSXFF                                                   \r\nNLS_TIMESTAMP_FORMAT           DD.MM.RR HH24:MI:SSXFF                                          \r\nNLS_TIME_TZ_FORMAT             HH24:MI:SSXFF TZR                                               \r\nNLS_TIMESTAMP_TZ_FORMAT        DD.MM.RR HH24:MI:SSXFF TZR                                      \r\nNLS_DUAL_CURRENCY              SF                                                              \r\nNLS_COMP                       BINARY                                                          \r\nNLS_LENGTH_SEMANTICS           BYTE                                                            \r\nNLS_NCHAR_CONV_EXCP            FALSE                                                           \r\n\r\n17 rows selected. \r\n\r\nSQL\u003e select substr(dbms_utility.port_string,1,60) as port_string from dual;\r\n\r\nPORT_STRING                                                 \r\n------------------------------------------------------------\r\nx86_64/Linux 2.4.xx  \r\n```\r\n\r\n**Information about client software**\r\n\r\nnot relevant.\r\n\r\n**To Reproduce**\r\n\r\n1. connect to a schema without test suites\r\n\r\n2. create the following package\r\n```sql\r\ncreate or replace package test_pkg is\r\n  -- %test\r\n  procedure t1;\r\n\r\n  -- %Test\r\n  procedure t2;\r\n\r\n  procedure t3;\r\nend test_pkg;\r\n/\r\n```\r\n\r\n3. run the following query:\r\n```sql\r\nwith \r\n   function has_suites return varchar2 is\r\n   begin\r\n      if ut_runner.has_suites(user) then\r\n         return 'true';\r\n      else \r\n         return 'false';\r\n      end if;\r\n   end;\r\n   function is_suite return varchar2 is\r\n   begin\r\n      if ut_runner.is_suite(user, 'test_pkg') then\r\n         return 'true';\r\n      else \r\n         return 'false';\r\n      end if;\r\n   end;\r\n   function is_test return varchar2 is\r\n   begin\r\n      if ut_runner.is_test(user, 'test_pkg', 't1') then\r\n         return 'true';\r\n      else \r\n         return 'false';\r\n      end if;\r\n   end;\r\nselect has_suites, is_suite, is_test from dual;\r\n```\r\n\r\n4. look at the result\r\n```\r\nHAS_SUITES IS_SUITE   IS_TEST   \r\n---------- ---------- ----------\r\ntrue       true       false     \r\n```\r\nthe values for `has_suites` and `is_suite` are wrong.\r\n\r\n5. run tests\r\n```sql\r\nselect * from table(ut.run('SCOTT'));\r\n```\r\n\r\n6. look at the result\r\n```\r\nResult Sequence                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                \r\n---------------\r\nFinished in .000021 seconds\r\n0 tests, 0 failed, 0 errored, 0 disabled, 0 warning(s)\r\n```\r\nYou see that no tests are executed, this is expected and it confirms, that the result for `has_suites` and `is_suite` are wrong.\r\n\r\n7. run alternative annotation cache query\r\n```sql\r\nselect *\r\nfrom table(ut_runner.get_suites_info(user, null))\r\nwhere item_type in ('UT_TEST', 'UT_SUITE');\r\n```\r\nthis query returns no rows, which is correct. An additional confirmation that the result for `has_suites` and `is_suite` are wrong.\r\n\r\n**Expected behavior**\r\n\r\n`has_suites` and `is_suite` should return false, if the annotation `suite` is not defined.\r\n","author":{"url":"https://github.com/PhilippSalvisberg","@type":"Person","name":"PhilippSalvisberg"},"datePublished":"2019-07-15T13:00:49.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/976/utPLSQL/issues/976"}