René's URL Explorer Experiment

Title: Fix tool-usage detection for shared deps & declare `tomli` for `pyproject-fmt` by nathanjmcdougall · Pull Request #1948 · usethis-python/usethis-python · GitHub

Open Graph Title: Fix tool-usage detection for shared deps & declare `tomli` for `pyproject-fmt` by nathanjmcdougall · Pull Request #1948 · usethis-python/usethis-python

X Title: Fix tool-usage detection for shared deps & declare `tomli` for `pyproject-fmt` by nathanjmcdougall · Pull Request #1948 · usethis-python/usethis-python

Description: Summary This is a bug fix with two related parts. 1. Declare tomli for pyproject-fmt on Python < 3.11 Since pyproject-fmt v2.22.0, the vendored toml-fmt-common does import tomli internally on Python < 3.11 but no longer declares tomli as a dependency. usethis tool pyproject-fmt therefore produced a ModuleNotFoundError when run on Python < 3.11. PyprojectFmtToolSpec.deps_by_group() now conditionally includes tomli for Python < 3.11 projects (based on requires-python, falling back to the running interpreter), mirroring the existing CodespellToolSpec pattern. 2. Don't treat a shared supporting dependency as identifying a tool Adding tomli to pyproject-fmt exposed a pre-existing bug. ToolSpec.is_declared_as_dep() treats every dependency a tool declares as a "characteristic" dependency — i.e. evidence (via is_used()) that the tool is in use: return any( is_dep_in_any_group(dep) for dep in self.get_dep_group_deps(unconditional=True) ) But tomli is a supporting dependency shared between tools, not characteristic of any one of them. This was already wrong for codespell — tomli was never an identifying/characteristic dependency of codespell. It was simply unobservable while codespell was the only tool declaring tomli: nothing else claimed tomli, so the false positive never fired. Once pyproject-fmt also declared tomli, the two tools began cross-triggering each other's is_used(): declaring tomli for one made the other report as used (and vice versa). This surfaced as spurious ☐ Run 'uv run ' migration messages — e.g. TestPreCommit::TestRemove::test_pyproject_fmt_used / test_codespell_used on Python 3.10 began emitting a stray codespell/pyproject-fmt line. Beyond the tests, any real project using one of these tools on Python < 3.11 would have the other mis-detected as in use (affecting usethis list, migration messaging, etc.). Fix Add an is_identifying: bool = True field to Dependency. It is metadata only, so it is excluded from __eq__/__hash__ (identity remains name + extras). Mark the tomli dependency of both codespell and pyproject-fmt as is_identifying=False. is_declared_as_dep() now ignores non-identifying dependencies (the deps are still installed/removed as normal). Testing New regression tests in tests/usethis/_tool/test_base.py: a shared non-identifying dependency does not, on its own, mark a tool as used, while the identifying dependency still does. Dependency equality/hash coverage in tests/usethis/_types/test_deps.py confirming is_identifying does not affect identity or set membership. The previously-failing TestPreCommit::TestRemove::test_pyproject_fmt_used / test_codespell_used now pass, along with the broader tool/core/UI suites on Python 3.10.

Open Graph Description: Summary This is a bug fix with two related parts. 1. Declare tomli for pyproject-fmt on Python < 3.11 Since pyproject-fmt v2.22.0, the vendored toml-fmt-common does import tomli internally on Py...

X Description: Summary This is a bug fix with two related parts. 1. Declare tomli for pyproject-fmt on Python &lt; 3.11 Since pyproject-fmt v2.22.0, the vendored toml-fmt-common does import tomli internally o...

Opengraph URL: https://github.com/usethis-python/usethis-python/pull/1948

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width