Title: Add tests for Ruff dev deps not removed when using pre-commit by Copilot · Pull Request #1464 · usethis-python/usethis-python · GitHub
Open Graph Title: Add tests for Ruff dev deps not removed when using pre-commit by Copilot · Pull Request #1464 · usethis-python/usethis-python
X Title: Add tests for Ruff dev deps not removed when using pre-commit by Copilot · Pull Request #1464 · usethis-python/usethis-python
Description: The code fix to stop removing dev deps during pre-commit migration (commit 3a06c95) only added test coverage for codespell and pyproject-fmt. Ruff was explicitly called out as affected but had no test coverage.
Tests added
TestPreCommit.TestAdd.test_ruff_used — Ruff dev dep persists when use_pre_commit() is called after use_ruff()
TestPreCommit.TestMigration.test_ruff_deps_not_removed_when_migrating_to_pre_commit — Ruff dep survives migration to pre-commit
TestPreCommit.TestMigration.test_ruff_deps_not_added_when_migrating_from_pre_commit — Ruff dep not duplicated when removing pre-commit
TestRuff.TestPrecommitIntegration.test_use_first / test_use_after — Extended existing hook-only assertions to also verify dev dep presence in both orderings
Original prompt
This section details on the original issue you should resolve
Open Graph Description: The code fix to stop removing dev deps during pre-commit migration (commit 3a06c95) only added test coverage for codespell and pyproject-fmt. Ruff was explicitly called out as affected but had no t...
X Description: The code fix to stop removing dev deps during pre-commit migration (commit 3a06c95) only added test coverage for codespell and pyproject-fmt. Ruff was explicitly called out as affected but had no t...
Opengraph URL: https://github.com/usethis-python/usethis-python/pull/1464
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6306450e-931c-cc5e-2353-8dd74b716779 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E2CC:12F35E:600CB2:83C047:6A4F377E |
| html-safe-nonce | 127a616bd7bf5a4511e458b327df82759ec53940a9f82d72fc2cf013e07a57a1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMkNDOjEyRjM1RTo2MDBDQjI6ODNDMDQ3OjZBNEYzNzdFIiwidmlzaXRvcl9pZCI6IjU5NjY2OTA0MDkwMTkwMjkzNzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8321ec01cd80dacf993daa8d9f31e1b1ae9467a52b3af7a6bec869c0491f667c |
| hovercard-subject-tag | pull_request:3431156212 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/usethis-python/usethis-python/pull/1464/files |
| twitter:image | https://avatars.githubusercontent.com/in/1143301?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/in/1143301?s=400&v=4 |
| og:image:alt | The code fix to stop removing dev deps during pre-commit migration (commit 3a06c95) only added test coverage for codespell and pyproject-fmt. Ruff was explicitly called out as affected but had no t... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/usethis-python/usethis-python git https://github.com/usethis-python/usethis-python.git |
| octolytics-dimension-user_id | 216362695 |
| octolytics-dimension-user_login | usethis-python |
| octolytics-dimension-repository_id | 842189705 |
| octolytics-dimension-repository_nwo | usethis-python/usethis-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 842189705 |
| octolytics-dimension-repository_network_root_nwo | usethis-python/usethis-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b8f23afb982271f1b22258a94aede67a6b77760 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width