René's URL Explorer Experiment

Title: Enable `reportUnknownParameterType` in basedpyright by Copilot · Pull Request #1403 · usethis-python/usethis-python · GitHub

Open Graph Title: Enable `reportUnknownParameterType` in basedpyright by Copilot · Pull Request #1403 · usethis-python/usethis-python

X Title: Enable `reportUnknownParameterType` in basedpyright by Copilot · Pull Request #1403 · usethis-python/usethis-python

Description: Fix Key: TypeAlias = str | re.Pattern → str | re.Pattern[str] in _io.py Add type annotations to Series.__getitem__ and Series.__setitem__ in containers.py Fix lcs_list_update signature: use TypeVar (list[_T]) so call sites with list[int] remain valid (list is invariant, list[object] caused type errors) Fix pre-existing type issue in func.py: use raise NotImplementedError instead of assert when _union() returns None unexpectedly Add [object] type arg to bare KeyValueFileManager and UsethisFileManager references Enable reportUnknownParameterType in pyproject.toml (remove from disabled list, add to tests environment) Run prek run -a and basedpyright — all clean Original prompt This section details on the original issue you should resolve enable reportUnknownParameterType in basedpyright Doesn't need to be enabled for the tests dir - can stay disabled. [[tool.basedpyright.executionEnvironments]] root = "tests" reportUnknownParameterType = false reportUnreachable = false reportUnusedFunction = false Many violation cases seem to be that KeyValueFileManager is a generic but we're not marking it with KeyValueFileManager[object] explicitly - doing so fixes the issue. There's also some cases in pipeweld where we're not using annotations when we should be. Some cases are due to Key: TypeAlias = str | re.Pattern in src\usethis\_io.py. The re.Pattern is generic in the string type - we should go with Key: TypeAlias = str | re.Pattern[AnyStr]. Comments on the Issue (you are @copilot in this section) Fixes #1333 🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Open Graph Description: Fix Key: TypeAlias = str | re.Pattern → str | re.Pattern[str] in _io.py Add type annotations to Series.__getitem__ and Series.__setitem__ in containers.py Fix lcs_list_update signature: use TypeV...

X Description: Fix Key: TypeAlias = str | re.Pattern → str | re.Pattern[str] in _io.py Add type annotations to Series.__getitem__ and Series.__setitem__ in containers.py Fix lcs_list_update signature: use TypeV...

Opengraph URL: https://github.com/usethis-python/usethis-python/pull/1403

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width