René's URL Explorer Experiment

Title: Split `usethis._tool.impl` into `impl/spec` and `impl/base` submodules by Copilot · Pull Request #1373 · usethis-python/usethis-python · GitHub

Open Graph Title: Split `usethis._tool.impl` into `impl/spec` and `impl/base` submodules by Copilot · Pull Request #1373 · usethis-python/usethis-python

X Title: Split `usethis._tool.impl` into `impl/spec` and `impl/base` submodules by Copilot · Pull Request #1373 · usethis-python/usethis-python

Description: The flat usethis._tool.impl module mixed ToolSpec subclasses (declarative metadata) and Tool subclasses (runtime behaviour) in the same files. This splits them into parallel submodule structures to separate concerns. Structure Each tool now has two dedicated modules: usethis._tool.impl.spec.* — ToolSpec subclasses: meta, dev_deps, pre_commit_config, preferred_file_manager, etc. usethis._tool.impl.base.* — Tool subclasses: config_spec, print_how_to_use, get_bitbucket_steps, selected_rules, etc. src/usethis/_tool/impl/ ├── spec/ │ ├── codespell.py # CodespellToolSpec │ ├── ruff.py # RuffToolSpec │ └── ... └── base/ ├── codespell.py # CodespellTool ├── ruff.py # RuffTool └── ... The test directory mirrors the src structure: tests/usethis/_tool/impl/ └── base/ ├── test_codespell.py ├── test_ruff.py └── ... Notable decisions test_deps() moved to base/ for pytest and coverage_py: these methods call .is_used() on sibling Tool instances, making them runtime behaviour rather than declarative spec. Moving them to base/ eliminates the spec → base import cycle and enforces the clean base → spec dependency direction. Import-linter contracts updated: the old tool_impl contract is replaced with three — tool_impl (base above spec), tool_impl_base, and tool_impl_spec — each with the same internal layer ordering as before. All external consumers (_core/, _tool/all_.py, _toolset/, _ui/, tests) updated to the new paths. Test suite restructured: all tests/usethis/_tool/impl/test_*.py files moved to tests/usethis/_tool/impl/base/ to match the src layout. Original prompt This section details on the original issue you should resolve Split the usethis._tool.impl layer into usethis._tool.impl.spec and usethis._tool.impl.base layers Current dir structure looks like this: src\usethis_tool\impl src\usethis_tool\impl_init_.py src\usethis_tool\impl\codespell.py src\usethis_tool\impl\coverage_py.py src\usethis_tool\impl\deptry.py src\usethis_tool\impl\import_linter.py src\usethis_tool\impl\mkdocs.py src\usethis_tool\impl\pre_commit.py src\usethis_tool\impl\pyproject_fmt.py src\usethis_tool\impl\pyproject_toml.py src\usethis_tool\impl\pytest.py src\usethis_tool\impl\requirements_txt.py src\usethis_tool\impl\ruff.py Each module contains the implementation for a ToolSpec and a Tool subclass. We should create a submodule in the impl module for spec and base separately with parallel submodule structures. This helps us work toward #1311 Comments on the Issue (you are @copilot in this section) Fixes #1356 ✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Open Graph Description: The flat usethis._tool.impl module mixed ToolSpec subclasses (declarative metadata) and Tool subclasses (runtime behaviour) in the same files. This splits them into parallel submodule structures to...

X Description: The flat usethis._tool.impl module mixed ToolSpec subclasses (declarative metadata) and Tool subclasses (runtime behaviour) in the same files. This splits them into parallel submodule structures to...

Opengraph URL: https://github.com/usethis-python/usethis-python/pull/1373

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width