René's URL Explorer Experiment

Title: Forbid `functools.singledispatch` / `singledispatchmethod` via Ruff banned-api by Copilot · Pull Request #1361 · usethis-python/usethis-python · GitHub

Open Graph Title: Forbid `functools.singledispatch` / `singledispatchmethod` via Ruff banned-api by Copilot · Pull Request #1361 · usethis-python/usethis-python

X Title: Forbid `functools.singledispatch` / `singledispatchmethod` via Ruff banned-api by Copilot · Pull Request #1361 · usethis-python/usethis-python

Description: functools.singledispatch has poor static analysis semantics. This PR bans it via Ruff's flake8-tidy-imports.banned-api and replaces all existing usages with explicit isinstance-based if-branch dispatch. Config Added to pyproject.toml: lint.flake8-tidy-imports.banned-api."functools.singledispatch".msg = "Use if-branch isinstance logic instead of singledispatch." lint.flake8-tidy-imports.banned-api."functools.singledispatchmethod".msg = "Use if-branch isinstance logic instead of singledispatchmethod." Refactoring pattern All @singledispatch / @singledispatchmethod usages replaced: # Before @singledispatch def _as_dict(value: INIDocument | Section) -> ...: raise NotImplementedError @_as_dict.register(INIDocument) def _(value: INIDocument) -> ...: return {k: _as_dict(v) for k, v in value.items()} @_as_dict.register(Section) def _(value: Section) -> ...: return {option.key: option.value for option in value.iter_options()} # After def _as_dict(value: INIDocument | Section) -> ...: if isinstance(value, INIDocument): return {k: _as_dict(v) for k, v in value.items()} elif isinstance(value, Section): return {option.key: option.value for option in value.iter_options()} else: assert_never(value) Files changed _file/ini/io_.py — _as_dict _pipeweld/func.py — Adder.partition_component (method) and _get_instructions_for_insertion; complex branches extracted into _partition_series_component, _partition_parallel_component, _partition_depgroup_component _integrations/ci/bitbucket/pipeweld.py — get_pipeweld_object, _extract_step_from_item, _insert_parallel_step, _is_insertion_necessary; extracted _extract_step_from_parallel_item _integrations/ci/bitbucket/steps.py — _censor_step, get_steps_in_pipeline_item; extracted _censor_parallel_item_step, _censor_stage_item_step _integrations/pydantic/dump.py — fancy_model_dump; extracted _fancy_model_dump_list, _fancy_model_dump_dict, _fancy_model_dump_base_model Where functions were large, helpers were extracted to stay within Ruff's branch/return-count limits (PLR0912, PLR0911). All dispatch exhaustiveness is enforced via assert_never. Original prompt This section details on the original issue you should resolve Forbid usage of functools.singledispatch Toward #1340. singledispatch has semantics which don't play nicely with static analysis. Arguably, they're needlessly verbose. I would prefer to refactor just use if-branch logic. We should set up a Ruff rule for this, e.g. using example config from docs: banned-api Specific modules or module members that may not be imported or accessed. Note that this rule is only meant to flag accidental uses, and can be circumvented via eval or importlib. Default value: {} Type: dict[str, { "msg": str }] Example usage: pyproject.toml ruff.toml [lint.flake8-tidy-imports.banned-api] "cgi".msg = "The cgi module is deprecated, see https://peps.python.org/pep-0594/#cgi." "typing.TypedDict".msg = "Use typing_extensions.TypedDict instead." Comments on the Issue (you are @copilot in this section) Fixes #1360 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Open Graph Description: functools.singledispatch has poor static analysis semantics. This PR bans it via Ruff's flake8-tidy-imports.banned-api and replaces all existing usages with explicit isinstance-based if-branch ...

X Description: functools.singledispatch has poor static analysis semantics. This PR bans it via Ruff's flake8-tidy-imports.banned-api and replaces all existing usages with explicit isinstance-based if-bra...

Opengraph URL: https://github.com/usethis-python/usethis-python/pull/1361

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width