Title: agent: when adding file manager reads to _deps.py, agent must also update all transitive callers in tests · Issue #1808 · usethis-python/usethis-python · GitHub
Open Graph Title: agent: when adding file manager reads to _deps.py, agent must also update all transitive callers in tests · Issue #1808 · usethis-python/usethis-python
X Title: agent: when adding file manager reads to _deps.py, agent must also update all transitive callers in tests · Issue #1808 · usethis-python/usethis-python
Description: Lesson learned from PR #903 (infer dependencies from setup.cfg) When adding a new file manager (e.g. SetupCFGManager) read to _deps.py's get_project_deps() or get_dep_groups(), the agent correctly updated tests/usethis/test_deps.py but m...
Open Graph Description: Lesson learned from PR #903 (infer dependencies from setup.cfg) When adding a new file manager (e.g. SetupCFGManager) read to _deps.py's get_project_deps() or get_dep_groups(), the agent correctly ...
X Description: Lesson learned from PR #903 (infer dependencies from setup.cfg) When adding a new file manager (e.g. SetupCFGManager) read to _deps.py's get_project_deps() or get_dep_groups(), the agent correc...
Opengraph URL: https://github.com/usethis-python/usethis-python/issues/1808
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"agent: when adding file manager reads to _deps.py, agent must also update all transitive callers in tests","articleBody":"## Lesson learned from PR #903 (infer dependencies from setup.cfg)\n\nWhen adding a new file manager (e.g. `SetupCFGManager`) read to `_deps.py`'s `get_project_deps()` or `get_dep_groups()`, the agent correctly updated `tests/usethis/test_deps.py` but missed `tests/usethis/test_init.py`, which calls `write_simple_requirements_txt()` — a function that transitively calls `get_project_deps()`.\n\nThis caused 5 CI test failures:\n- `tests/usethis/test_init.py::TestWriteSimpleRequirementsTxt::*` all raised `UnexpectedSetupCFGIOError` because `SetupCFGManager` was not opened in the test context.\n\n## Root cause\n\nThe agent only searched for direct callers of `get_project_deps` and `get_dep_groups` in tests, not for **transitive** callers (functions that call those functions). `write_simple_requirements_txt()` in `_init.py` calls `get_project_deps()` but is tested in a different test file.\n\n## Recommendation\n\nWhen modifying `_deps.py` to add new file manager reads, the agent should:\n1. Search for **all** functions that transitively call the modified functions (not just direct callers).\n2. Run a broader set of tests — at minimum `tests/usethis/test_init.py`, `tests/usethis/test_deps.py`, and `tests/usethis/_core/test_core_tool.py` — not just `test_deps.py`.\n\nSee also the stored memory: \"When adding new file manager reads to _deps.py, ALL existing tests calling those functions must also open the corresponding file manager context.\"","author":{"url":"https://github.com/nathanjmcdougall","@type":"Person","name":"nathanjmcdougall"},"datePublished":"2026-04-04T02:31:32.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/1808/usethis-python/issues/1808"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:4e4dd269-4e14-02c9-8b0a-c4d60a3b31de |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A9A0:374E1E:1BE1ED9:283F1AC:6A4CE7CB |
| html-safe-nonce | 7676571a2beaf688bb275c7fb8da3bfa35bd7ce1635d9fd62e2bfd2e0b0c7dc0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOUEwOjM3NEUxRToxQkUxRUQ5OjI4M0YxQUM6NkE0Q0U3Q0IiLCJ2aXNpdG9yX2lkIjoiMjAyMjQxMTQ3OTExNDYzOTMwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5eb217ca284b5eb79e0c89b62bc7f578a6e382402c1cf3be6ff766622c704b48 |
| hovercard-subject-tag | issue:4203047261 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/usethis-python/usethis-python/1808/issue_layout |
| twitter:image | https://opengraph.githubassets.com/d22d634d90c31efcad7391e5b9c24176c28bcb3a2ec951182e1cf750fa053d7e/usethis-python/usethis-python/issues/1808 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d22d634d90c31efcad7391e5b9c24176c28bcb3a2ec951182e1cf750fa053d7e/usethis-python/usethis-python/issues/1808 |
| og:image:alt | Lesson learned from PR #903 (infer dependencies from setup.cfg) When adding a new file manager (e.g. SetupCFGManager) read to _deps.py's get_project_deps() or get_dep_groups(), the agent correctly ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | nathanjmcdougall |
| hostname | github.com |
| expected-hostname | github.com |
| None | 299b43bca6e02ad35197ffeba30d2466846d5fb02ab96fbced5b5e6cec589fb8 |
| turbo-cache-control | no-preview |
| go-import | github.com/usethis-python/usethis-python git https://github.com/usethis-python/usethis-python.git |
| octolytics-dimension-user_id | 216362695 |
| octolytics-dimension-user_login | usethis-python |
| octolytics-dimension-repository_id | 842189705 |
| octolytics-dimension-repository_nwo | usethis-python/usethis-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 842189705 |
| octolytics-dimension-repository_network_root_nwo | usethis-python/usethis-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c5a57f04eeb310f57c73fd6d751d957e2ca27ed2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width