| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:84090e10-93d5-a6c2-adbb-6e246c6a33ea |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8E4E:6437B:7DE8A79:A8146F3:696E05A0 |
| html-safe-nonce | 66002cd97d40dc003d2c909ef53413c83670c48574cde194c7deffb4ab0c207b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTRFOjY0MzdCOjdERThBNzk6QTgxNDZGMzo2OTZFMDVBMCIsInZpc2l0b3JfaWQiOiIxODM0NjkzMTA0NDMwMzUxNzc2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0599755098495a810fff99634ee55e72d403506ccf96fa0e8c31db5ab5c19075 |
| hovercard-subject-tag | pull_request:1628431048 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/uniswap-python/uniswap-python/358/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3069b3bac4e96b48fe18d38d3b2f0f06b73517a905e7d6a9a7e571e345981de0/uniswap-python/uniswap-python/pull/358 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3069b3bac4e96b48fe18d38d3b2f0f06b73517a905e7d6a9a7e571e345981de0/uniswap-python/uniswap-python/pull/358 |
| og:image:alt | Solves #355
Partially solves #356
What's new?
uniswap.fee.FeeTier enum added with all available tiers combined
InvalidFeeTier raised when Uniswap v3 is used without explicitly providing a fee ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | antibagr |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9b5131b207ddd175abf059a848d5f4302ec0606b02211b989013be49cf08593e |
| turbo-cache-control | no-preview |
| go-import | github.com/uniswap-python/uniswap-python git https://github.com/uniswap-python/uniswap-python.git |
| octolytics-dimension-user_id | 84646677 |
| octolytics-dimension-user_login | uniswap-python |
| octolytics-dimension-repository_id | 163547548 |
| octolytics-dimension-repository_nwo | uniswap-python/uniswap-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 163547548 |
| octolytics-dimension-repository_network_root_nwo | uniswap-python/uniswap-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f8590a63bfc8093b241930ca57d536c9a50f9680 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/uniswap-python/uniswap-python/pull/358#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Funiswap-python%2Funiswap-python%2Fpull%2F358 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Funiswap-python%2Funiswap-python%2Fpull%2F358 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=uniswap-python%2Funiswap-python |
| Reload | https://github.com/uniswap-python/uniswap-python/pull/358 |
| Reload | https://github.com/uniswap-python/uniswap-python/pull/358 |
| Reload | https://github.com/uniswap-python/uniswap-python/pull/358 |
|
uniswap-python
| https://github.com/uniswap-python |
| uniswap-python | https://github.com/uniswap-python/uniswap-python |
|
Notifications
| https://github.com/login?return_to=%2Funiswap-python%2Funiswap-python |
|
Fork
383
| https://github.com/login?return_to=%2Funiswap-python%2Funiswap-python |
|
Star
1k
| https://github.com/login?return_to=%2Funiswap-python%2Funiswap-python |
|
Code
| https://github.com/uniswap-python/uniswap-python |
|
Issues
57
| https://github.com/uniswap-python/uniswap-python/issues |
|
Pull requests
16
| https://github.com/uniswap-python/uniswap-python/pulls |
|
Discussions
| https://github.com/uniswap-python/uniswap-python/discussions |
|
Actions
| https://github.com/uniswap-python/uniswap-python/actions |
|
Projects
0
| https://github.com/uniswap-python/uniswap-python/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/uniswap-python/uniswap-python/security |
| Please reload this page | https://github.com/uniswap-python/uniswap-python/pull/358 |
|
Insights
| https://github.com/uniswap-python/uniswap-python/pulse |
|
Code
| https://github.com/uniswap-python/uniswap-python |
|
Issues
| https://github.com/uniswap-python/uniswap-python/issues |
|
Pull requests
| https://github.com/uniswap-python/uniswap-python/pulls |
|
Discussions
| https://github.com/uniswap-python/uniswap-python/discussions |
|
Actions
| https://github.com/uniswap-python/uniswap-python/actions |
|
Projects
| https://github.com/uniswap-python/uniswap-python/projects |
|
Security
| https://github.com/uniswap-python/uniswap-python/security |
|
Insights
| https://github.com/uniswap-python/uniswap-python/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Funiswap-python%2Funiswap-python%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Funiswap-python%2Funiswap-python%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/uniswap-python/uniswap-python/pull/358#issue-comment-box |
| ErikBjare | https://github.com/ErikBjare |
| uniswap-python:master | https://github.com/uniswap-python/uniswap-python/tree/master |
| antibagr:master | https://github.com/antibagr/pull-request-uniswap-python/tree/master |
|
fix: Make fee a required argument with Uniswap V3
| https://github.com/uniswap-python/uniswap-python/pull/358#top |
| ErikBjare | https://github.com/ErikBjare |
| uniswap-python:master | https://github.com/uniswap-python/uniswap-python/tree/master |
| antibagr:master | https://github.com/antibagr/pull-request-uniswap-python/tree/master |
|
Conversation
6
| https://github.com/uniswap-python/uniswap-python/pull/358 |
|
Commits
5
| https://github.com/uniswap-python/uniswap-python/pull/358/commits |
|
Checks
0
| https://github.com/uniswap-python/uniswap-python/pull/358/checks |
|
Files changed
| https://github.com/uniswap-python/uniswap-python/pull/358/files |
| Please reload this page | https://github.com/uniswap-python/uniswap-python/pull/358 |
| https://github.co/hiddenchars |
| https://github.com/uniswap-python/uniswap-python/pull/{{ revealButtonHref }} |
|
| https://github.com/antibagr |
| antibagr | https://github.com/antibagr |
| Dec 4, 2023 | https://github.com/uniswap-python/uniswap-python/pull/358#issue-2023999545 |
| #355 | https://github.com/uniswap-python/uniswap-python/issues/355 |
| #356 | https://github.com/uniswap-python/uniswap-python/issues/356 |
| Please reload this page | https://github.com/uniswap-python/uniswap-python/pull/358 |
| antibagr | https://github.com/antibagr |
| December 4, 2023 18:14 | https://github.com/uniswap-python/uniswap-python/pull/358#commits-pushed-c707b70 |
|
| https://github.com/antibagr |
| Add FeeTier | https://github.com/uniswap-python/uniswap-python/pull/358/commits/c707b70ba2aedb3373ca29ca2bff0cdbefda84d5 |
| c707b70 | https://github.com/uniswap-python/uniswap-python/pull/358/commits/c707b70ba2aedb3373ca29ca2bff0cdbefda84d5 |
|
| https://github.com/antibagr |
| Add FeeTier tests | https://github.com/uniswap-python/uniswap-python/pull/358/commits/e18e01e505307f2b21130d6e08acdff0ed6596ae |
| e18e01e | https://github.com/uniswap-python/uniswap-python/pull/358/commits/e18e01e505307f2b21130d6e08acdff0ed6596ae |
|
| https://github.com/antibagr |
| Update project version 0.7.0 -> 0.7.1 | https://github.com/uniswap-python/uniswap-python/pull/358/commits/0c9cd26d743939962a1f6c2c82a58f03599c0324 |
| 0c9cd26 | https://github.com/uniswap-python/uniswap-python/pull/358/commits/0c9cd26d743939962a1f6c2c82a58f03599c0324 |
|
| https://github.com/antibagr |
| Revert several unnecessary changes | https://github.com/uniswap-python/uniswap-python/pull/358/commits/9b985f747540bba800c6b269f50e7b5ffe010e78 |
| 9b985f7 | https://github.com/uniswap-python/uniswap-python/pull/358/commits/9b985f747540bba800c6b269f50e7b5ffe010e78 |
| https://github.com/antibagr |
| antibagr | https://github.com/antibagr |
| Dec 4, 2023 | https://github.com/uniswap-python/uniswap-python/pull/358#issuecomment-1838766637 |
| Please reload this page | https://github.com/uniswap-python/uniswap-python/pull/358 |
| https://github.com/antibagr |
| antibagr | https://github.com/antibagr |
| Dec 4, 2023 | https://github.com/uniswap-python/uniswap-python/pull/358#event-11140048845 |
| https://github.com/ErikBjare |
| ErikBjare | https://github.com/ErikBjare |
| Dec 4, 2023 | https://github.com/uniswap-python/uniswap-python/pull/358#issuecomment-1839486034 |
| Please reload this page | https://github.com/uniswap-python/uniswap-python/pull/358 |
|
| https://github.com/antibagr |
| Fix tests | https://github.com/uniswap-python/uniswap-python/pull/358/commits/eb744d7f3666146f52ba4a4c04580ffe8b85795e |
| eb744d7 | https://github.com/uniswap-python/uniswap-python/pull/358/commits/eb744d7f3666146f52ba4a4c04580ffe8b85795e |
| https://github.com/antibagr |
| antibagr | https://github.com/antibagr |
|
Dec 5, 2023
| https://github.com/uniswap-python/uniswap-python/pull/358#pullrequestreview-1764550564 |
|
View reviewed changes
| https://github.com/uniswap-python/uniswap-python/pull/358/files/eb744d7f3666146f52ba4a4c04580ffe8b85795e |
| tests/test_uniswap.py | https://github.com/uniswap-python/uniswap-python/pull/358/files/9b985f747540bba800c6b269f50e7b5ffe010e78..eb744d7f3666146f52ba4a4c04580ffe8b85795e#diff-82467cc9f9bc62c54a260dca6957d746bc412265195be25406a9829362a51805 |
| antibagr | https://github.com/antibagr |
| Dec 5, 2023 | https://github.com/uniswap-python/uniswap-python/pull/358#discussion_r1415249617 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/uniswap-python/uniswap-python/pull/358 |
| ErikBjare | https://github.com/ErikBjare |
| Dec 6, 2023 | https://github.com/uniswap-python/uniswap-python/pull/358#discussion_r1417283929 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/uniswap-python/uniswap-python/pull/358 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Dec 6, 2023 | https://github.com/uniswap-python/uniswap-python/pull/358#issuecomment-1842847526 |
| Please reload this page | https://github.com/uniswap-python/uniswap-python/pull/358 |
| Codecov | https://app.codecov.io/gh/uniswap-python/uniswap-python/pull/358?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uniswap-python |
| (ad8c8a1) | https://app.codecov.io/gh/uniswap-python/uniswap-python/commit/ad8c8a14d7539c615795174ef0bcd52f6f73c614?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uniswap-python |
| (eb744d7) | https://app.codecov.io/gh/uniswap-python/uniswap-python/pull/358?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uniswap-python |
| ☔ View full report in Codecov by Sentry | https://app.codecov.io/gh/uniswap-python/uniswap-python/pull/358?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uniswap-python |
| Share it here | https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uniswap-python |
| Please reload this page | https://github.com/uniswap-python/uniswap-python/pull/358 |
| https://github.com/ErikBjare |
| ErikBjare | https://github.com/ErikBjare |
| Dec 6, 2023 | https://github.com/uniswap-python/uniswap-python/pull/358#issuecomment-1842859372 |
| Please reload this page | https://github.com/uniswap-python/uniswap-python/pull/358 |
| https://github.com/ErikBjare |
| ErikBjare | https://github.com/ErikBjare |
| cd5d95e | https://github.com/uniswap-python/uniswap-python/commit/cd5d95e8b4ebf89a9ce4fcc971a31e4c35668ca6 |
| Dec 6, 2023 | https://github.com/uniswap-python/uniswap-python/pull/358#event-11168245191 |
| https://github.com/ErikBjare |
| ErikBjare | https://github.com/ErikBjare |
|
Dec 6, 2023
| https://github.com/uniswap-python/uniswap-python/pull/358#ref-pullrequest-2028580216 |
|
test: readded failing insufficient balance test
#359
| https://github.com/uniswap-python/uniswap-python/pull/359 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Funiswap-python%2Funiswap-python%2Fpull%2F358 |
|
| https://github.com/ErikBjare |
|
ErikBjare
| https://github.com/ErikBjare |
|
| https://github.com/uniswap-python/uniswap-python/pull/358/files/eb744d7f3666146f52ba4a4c04580ffe8b85795e |
| Please reload this page | https://github.com/uniswap-python/uniswap-python/pull/358 |
|
| https://github.com/antibagr |
|
| https://github.com/ErikBjare |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |