René's URL Explorer Experiment


Title: fix/enhancement: removes over-approval, adds manual approve by liquid-8 · Pull Request #136 · uniswap-python/uniswap-python · GitHub

Open Graph Title: fix/enhancement: removes over-approval, adds manual approve by liquid-8 · Pull Request #136 · uniswap-python/uniswap-python

X Title: fix/enhancement: removes over-approval, adds manual approve by liquid-8 · Pull Request #136 · uniswap-python/uniswap-python

Description: Closes #73 check_approval() decorator should check/approve first token only, there is no practical reason to check second actually. _approve() method becomes public to let users approve manually.

Open Graph Description: Closes #73 check_approval() decorator should check/approve first token only, there is no practical reason to check second actually. _approve() method becomes public to let users approve manually.

X Description: Closes #73 check_approval() decorator should check/approve first token only, there is no practical reason to check second actually. _approve() method becomes public to let users approve manually.

Opengraph URL: https://github.com/uniswap-python/uniswap-python/pull/136

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:78586133-1ee6-3a70-8a86-16ff7cf2bb35
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC93C:132A0E:3A17FD6:4C2BC89:696D2476
html-safe-nonce4c61bf3d5ca2748992aa711582c4126d7f5240c547b2873f72cb0425c40225e1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTNDOjEzMkEwRTozQTE3RkQ2OjRDMkJDODk6Njk2RDI0NzYiLCJ2aXNpdG9yX2lkIjoiMjAwMTk1NjQ2OTcxOTUwODA4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac42a48ae95b9711aea044c6d9c3a2732f6d9f6a3eabb4db2e446da0c202a8916d
hovercard-subject-tagpull_request:686978749
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/uniswap-python/uniswap-python/136/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a3fdf20edd922cb0c5eff1f1556768dc12a706fc88c5abd32ad833db06dd066b/uniswap-python/uniswap-python/pull/136
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a3fdf20edd922cb0c5eff1f1556768dc12a706fc88c5abd32ad833db06dd066b/uniswap-python/uniswap-python/pull/136
og:image:altCloses #73 check_approval() decorator should check/approve first token only, there is no practical reason to check second actually. _approve() method becomes public to let users approve manually.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameliquid-8
hostnamegithub.com
expected-hostnamegithub.com
None0944e430045f4fb5f7bd103e0660080acfe593174063212555773ca41c144a14
turbo-cache-controlno-preview
go-importgithub.com/uniswap-python/uniswap-python git https://github.com/uniswap-python/uniswap-python.git
octolytics-dimension-user_id84646677
octolytics-dimension-user_loginuniswap-python
octolytics-dimension-repository_id163547548
octolytics-dimension-repository_nwouniswap-python/uniswap-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id163547548
octolytics-dimension-repository_network_root_nwouniswap-python/uniswap-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release66b6e773801d28660016072069017cfcc851f54b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/uniswap-python/uniswap-python/pull/136#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Funiswap-python%2Funiswap-python%2Fpull%2F136
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Funiswap-python%2Funiswap-python%2Fpull%2F136
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=uniswap-python%2Funiswap-python
Reloadhttps://github.com/uniswap-python/uniswap-python/pull/136
Reloadhttps://github.com/uniswap-python/uniswap-python/pull/136
Reloadhttps://github.com/uniswap-python/uniswap-python/pull/136
uniswap-python https://github.com/uniswap-python
uniswap-pythonhttps://github.com/uniswap-python/uniswap-python
Notifications https://github.com/login?return_to=%2Funiswap-python%2Funiswap-python
Fork 383 https://github.com/login?return_to=%2Funiswap-python%2Funiswap-python
Star 1k https://github.com/login?return_to=%2Funiswap-python%2Funiswap-python
Code https://github.com/uniswap-python/uniswap-python
Issues 57 https://github.com/uniswap-python/uniswap-python/issues
Pull requests 16 https://github.com/uniswap-python/uniswap-python/pulls
Discussions https://github.com/uniswap-python/uniswap-python/discussions
Actions https://github.com/uniswap-python/uniswap-python/actions
Projects 0 https://github.com/uniswap-python/uniswap-python/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/uniswap-python/uniswap-python/security
Please reload this pagehttps://github.com/uniswap-python/uniswap-python/pull/136
Insights https://github.com/uniswap-python/uniswap-python/pulse
Code https://github.com/uniswap-python/uniswap-python
Issues https://github.com/uniswap-python/uniswap-python/issues
Pull requests https://github.com/uniswap-python/uniswap-python/pulls
Discussions https://github.com/uniswap-python/uniswap-python/discussions
Actions https://github.com/uniswap-python/uniswap-python/actions
Projects https://github.com/uniswap-python/uniswap-python/projects
Security https://github.com/uniswap-python/uniswap-python/security
Insights https://github.com/uniswap-python/uniswap-python/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Funiswap-python%2Funiswap-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Funiswap-python%2Funiswap-python%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/uniswap-python/uniswap-python/pull/136#issue-comment-box
ErikBjarehttps://github.com/ErikBjare
uniswap-python:masterhttps://github.com/uniswap-python/uniswap-python/tree/master
liquid-8:masterhttps://github.com/liquid-8/uniswap-python/tree/master
fix/enhancement: removes over-approval, adds manual approve https://github.com/uniswap-python/uniswap-python/pull/136#top
ErikBjarehttps://github.com/ErikBjare
uniswap-python:masterhttps://github.com/uniswap-python/uniswap-python/tree/master
liquid-8:masterhttps://github.com/liquid-8/uniswap-python/tree/master
Conversation 1 https://github.com/uniswap-python/uniswap-python/pull/136
Commits 16 https://github.com/uniswap-python/uniswap-python/pull/136/commits
Checks 0 https://github.com/uniswap-python/uniswap-python/pull/136/checks
Files changed https://github.com/uniswap-python/uniswap-python/pull/136/files
Please reload this pagehttps://github.com/uniswap-python/uniswap-python/pull/136
https://github.co/hiddenchars
https://github.com/uniswap-python/uniswap-python/pull/{{ revealButtonHref }}
https://github.com/liquid-8
liquid-8https://github.com/liquid-8
Jul 9, 2021https://github.com/uniswap-python/uniswap-python/pull/136#issue-940993150
#73https://github.com/uniswap-python/uniswap-python/issues/73
Please reload this pagehttps://github.com/uniswap-python/uniswap-python/pull/136
liquid-8https://github.com/liquid-8
July 2, 2021 11:34https://github.com/uniswap-python/uniswap-python/pull/136#commits-pushed-fb09126
https://github.com/liquid-8
Update constants.pyhttps://github.com/uniswap-python/uniswap-python/pull/136/commits/fb091260416abd68f8be48b2a46fba90e2c0e1a7
fb09126https://github.com/uniswap-python/uniswap-python/pull/136/commits/fb091260416abd68f8be48b2a46fba90e2c0e1a7
https://github.com/liquid-8
Merge branch 'uniswap-python:master' into masterhttps://github.com/uniswap-python/uniswap-python/pull/136/commits/c2bbfa7d2577834152c1da6ea9b6ba69fec45aa0
c2bbfa7https://github.com/uniswap-python/uniswap-python/pull/136/commits/c2bbfa7d2577834152c1da6ea9b6ba69fec45aa0
https://github.com/liquid-8
Update uniswap.pyhttps://github.com/uniswap-python/uniswap-python/pull/136/commits/a21021a9aa33147aa8f0a74fd42d0aab004f1114
a21021ahttps://github.com/uniswap-python/uniswap-python/pull/136/commits/a21021a9aa33147aa8f0a74fd42d0aab004f1114
https://github.com/liquid-8
Update uniswap.pyhttps://github.com/uniswap-python/uniswap-python/pull/136/commits/74e87cbbc15c1a05c737b5ea6477d5fa9a8623b7
74e87cbhttps://github.com/uniswap-python/uniswap-python/pull/136/commits/74e87cbbc15c1a05c737b5ea6477d5fa9a8623b7
https://github.com/liquid-8
Update uniswap.pyhttps://github.com/uniswap-python/uniswap-python/pull/136/commits/87a14d9af93496561ec9f800d33eb5f10ff3e6e0
87a14d9https://github.com/uniswap-python/uniswap-python/pull/136/commits/87a14d9af93496561ec9f800d33eb5f10ff3e6e0
https://github.com/liquid-8
https://github.com/ErikBjare
Update uniswap/uniswap.pyhttps://github.com/uniswap-python/uniswap-python/pull/136/commits/949a10dab09414cc8194bbfeedde133547084460
949a10dhttps://github.com/uniswap-python/uniswap-python/pull/136/commits/949a10dab09414cc8194bbfeedde133547084460
https://github.com/liquid-8
https://github.com/ErikBjare
Update uniswap/uniswap.pyhttps://github.com/uniswap-python/uniswap-python/pull/136/commits/b59f6cc5d0690671c8561abf54f92a97ae628980
b59f6cchttps://github.com/uniswap-python/uniswap-python/pull/136/commits/b59f6cc5d0690671c8561abf54f92a97ae628980
https://github.com/liquid-8
https://github.com/ErikBjare
Update uniswap/uniswap.pyhttps://github.com/uniswap-python/uniswap-python/pull/136/commits/724527f4dc119a4242c2f58f4430fe179629fae0
724527fhttps://github.com/uniswap-python/uniswap-python/pull/136/commits/724527f4dc119a4242c2f58f4430fe179629fae0
https://github.com/liquid-8
https://github.com/ErikBjare
Update uniswap/uniswap.pyhttps://github.com/uniswap-python/uniswap-python/pull/136/commits/463890a31e3933373b9d5043e82e6f8de15cb8e9
463890ahttps://github.com/uniswap-python/uniswap-python/pull/136/commits/463890a31e3933373b9d5043e82e6f8de15cb8e9
https://github.com/ErikBjare
fix: remove duplicate lineshttps://github.com/uniswap-python/uniswap-python/pull/136/commits/4759a0ecaca6aa69156ad6ab070c0b036f550b44
4759a0ehttps://github.com/uniswap-python/uniswap-python/pull/136/commits/4759a0ecaca6aa69156ad6ab070c0b036f550b44
https://github.com/ErikBjare
fix: remove duplicate lineshttps://github.com/uniswap-python/uniswap-python/pull/136/commits/0165409fee5ca5b5862cacfefdb2c849588964eb
0165409https://github.com/uniswap-python/uniswap-python/pull/136/commits/0165409fee5ca5b5862cacfefdb2c849588964eb
https://github.com/liquid-8
Create black.ymlhttps://github.com/uniswap-python/uniswap-python/pull/136/commits/e8403ca2a777f7c396a757dc977b5698b3535551
e8403cahttps://github.com/uniswap-python/uniswap-python/pull/136/commits/e8403ca2a777f7c396a757dc977b5698b3535551
https://github.com/liquid-8
Delete black.ymlhttps://github.com/uniswap-python/uniswap-python/pull/136/commits/69d0af45422b63f3053d9067132045eef6c95d07
69d0af4https://github.com/uniswap-python/uniswap-python/pull/136/commits/69d0af45422b63f3053d9067132045eef6c95d07
https://github.com/liquid-8
black appliedhttps://github.com/uniswap-python/uniswap-python/pull/136/commits/b8788eabec80ce33ab37a58b753186e2ddea6829
b8788eahttps://github.com/uniswap-python/uniswap-python/pull/136/commits/b8788eabec80ce33ab37a58b753186e2ddea6829
https://github.com/liquid-8
Issuehttps://github.com/uniswap-python/uniswap-python/pull/136/commits/06c59d2104032cd5f7a5934f031bcad9090de872
uniswap-python#73https://github.com/uniswap-python/uniswap-python/issues/73
fixhttps://github.com/uniswap-python/uniswap-python/pull/136/commits/06c59d2104032cd5f7a5934f031bcad9090de872
06c59d2https://github.com/uniswap-python/uniswap-python/pull/136/commits/06c59d2104032cd5f7a5934f031bcad9090de872
https://github.com/liquid-8
Merge branch 'uniswap-python:master' into masterhttps://github.com/uniswap-python/uniswap-python/pull/136/commits/7d9a75a9812df3a0221e6ef877aca398b7083934
7d9a75ahttps://github.com/uniswap-python/uniswap-python/pull/136/commits/7d9a75a9812df3a0221e6ef877aca398b7083934
https://github.com/ErikBjare
ErikBjarehttps://github.com/ErikBjare
Jul 12, 2021https://github.com/uniswap-python/uniswap-python/pull/136#issuecomment-878494989
Please reload this pagehttps://github.com/uniswap-python/uniswap-python/pull/136
https://github.com/ErikBjare
ErikBjarehttps://github.com/ErikBjare
53b8ef3https://github.com/uniswap-python/uniswap-python/commit/53b8ef3cfcd49f4b176145a1c811303abb1d60ef
Jul 12, 2021https://github.com/uniswap-python/uniswap-python/pull/136#event-5009149786
https://github.com/hueit-og
hueit-oghttps://github.com/hueit-og
Oct 7, 2021 https://github.com/uniswap-python/uniswap-python/pull/136#ref-issue-1020474875
pip install uniswap-python not getting latest files?? #174 https://github.com/uniswap-python/uniswap-python/issues/174
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Funiswap-python%2Funiswap-python%2Fpull%2F136
Overly eager to approve tokens https://github.com/uniswap-python/uniswap-python/issues/73
Please reload this pagehttps://github.com/uniswap-python/uniswap-python/pull/136
https://github.com/liquid-8
https://github.com/ErikBjare
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.