| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d6a81f8c-3420-bb24-c0f0-2dd94fa2d6f3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DB40:35ABFC:137CCB6:1BC5A21:6A4CC21B |
| html-safe-nonce | ce6ebf81fa3deeb43bad88a7f1d15a100d3512c8614447c2e55aaeca8050a691 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjQwOjM1QUJGQzoxMzdDQ0I2OjFCQzVBMjE6NkE0Q0MyMUIiLCJ2aXNpdG9yX2lkIjoiNzE3NTY5MDM0MzgzMTg4MDIxOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2058e48141c985b05dafea837734a1cc5fc2a37c95deeeade0c4661be53d59d6 |
| hovercard-subject-tag | pull_request:1232602844 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/uber-java/tally/116/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5b693771afa0f7b16f460805f948742576b84bbc5342873fe8e4fa3d49a9738a/uber-java/tally/pull/116 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5b693771afa0f7b16f460805f948742576b84bbc5342873fe8e4fa3d49a9738a/uber-java/tally/pull/116 |
| og:image:alt | Why ?
The current Scope Key is defined by creating a new string based on the metric tags and prefixes. This is inefficient as it ends up creating temporary strings for each metric emission. In our ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sairamch04 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c |
| turbo-cache-control | no-cache |
| go-import | github.com/uber-java/tally git https://github.com/uber-java/tally.git |
| octolytics-dimension-user_id | 25932473 |
| octolytics-dimension-user_login | uber-java |
| octolytics-dimension-repository_id | 98915681 |
| octolytics-dimension-repository_nwo | uber-java/tally |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 98915681 |
| octolytics-dimension-repository_network_root_nwo | uber-java/tally |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c03e7e569190bc89b638cdd4acb4b6c6b38a170a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/uber-java/tally/pull/116#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fuber-java%2Ftally%2Fpull%2F116 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fuber-java%2Ftally%2Fpull%2F116 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=uber-java%2Ftally |
| Reload | https://github.com/uber-java/tally/pull/116 |
| Reload | https://github.com/uber-java/tally/pull/116 |
| Reload | https://github.com/uber-java/tally/pull/116 |
| Please reload this page | https://github.com/uber-java/tally/pull/116 |
|
uber-java
| https://github.com/uber-java |
| tally | https://github.com/uber-java/tally |
|
Notifications
| https://github.com/login?return_to=%2Fuber-java%2Ftally |
|
Fork
21
| https://github.com/login?return_to=%2Fuber-java%2Ftally |
|
Star
23
| https://github.com/login?return_to=%2Fuber-java%2Ftally |
|
Code
| https://github.com/uber-java/tally |
|
Issues
15
| https://github.com/uber-java/tally/issues |
|
Pull requests
10
| https://github.com/uber-java/tally/pulls |
|
Actions
| https://github.com/uber-java/tally/actions |
|
Projects
| https://github.com/uber-java/tally/projects |
|
Security and quality
0
| https://github.com/uber-java/tally/security |
|
Insights
| https://github.com/uber-java/tally/pulse |
|
Code
| https://github.com/uber-java/tally |
|
Issues
| https://github.com/uber-java/tally/issues |
|
Pull requests
| https://github.com/uber-java/tally/pulls |
|
Actions
| https://github.com/uber-java/tally/actions |
|
Projects
| https://github.com/uber-java/tally/projects |
|
Security and quality
| https://github.com/uber-java/tally/security |
|
Insights
| https://github.com/uber-java/tally/pulse |
| SokolAndrey | https://github.com/SokolAndrey |
| uber-java:master | https://github.com/uber-java/tally/tree/master |
| sairamch04:change-hashkey-tags | https://github.com/sairamch04/tally/tree/change-hashkey-tags |
| Conversation | https://github.com/uber-java/tally/pull/116 |
| Commits13 (13) | https://github.com/uber-java/tally/pull/116/commits |
| Checks | https://github.com/uber-java/tally/pull/116/checks |
| Files changed | https://github.com/uber-java/tally/pull/116/files |
| Define a custom Scope Key for reducing memory allocations | https://github.com/uber-java/tally/pull/116#top |
| SokolAndrey | https://github.com/SokolAndrey |
| uber-java:master | https://github.com/uber-java/tally/tree/master |
| sairamch04:change-hashkey-tags | https://github.com/sairamch04/tally/tree/change-hashkey-tags |
|
| https://github.com/sairamch04 |
| sairamch04 | https://github.com/sairamch04 |
| Feb 7, 2023 | https://github.com/uber-java/tally/pull/116#issue-1575037453 |
| Please reload this page | https://github.com/uber-java/tally/pull/116 |
| StringBuilder inside ScopeImpl.keyForPrefixedStringMap | https://github.com/uber-java/tally/pull/116/files#diff-56ff2476c313707cec55684b10ecc5166ad40eb30deddf9aa9eeef61adb6501dL169 |
| https://user-images.githubusercontent.com/5583254/217346920-b0b24b8d-a1b3-4629-b259-d4ca4b773f02.png |
| https://user-images.githubusercontent.com/5583254/217341744-36708fce-17c0-44b8-9a01-d62a091a67fb.png |
| Please reload this page | https://github.com/uber-java/tally/pull/116 |
| sairamch04 | https://github.com/sairamch04 |
| February 6, 2023 01:38 | https://github.com/uber-java/tally/pull/116#commits-pushed-da7737a |
|
| https://github.com/sairamch04 |
| save progress | https://github.com/uber-java/tally/pull/116/commits/da7737a119ab77bd8965278bd27e1b3d8f2363db |
| da7737a | https://github.com/uber-java/tally/pull/116/commits/da7737a119ab77bd8965278bd27e1b3d8f2363db |
|
| https://github.com/sairamch04 |
| revert to master | https://github.com/uber-java/tally/pull/116/commits/214401da4332d555e41cda58cda2647f2f9f798a |
| 214401d | https://github.com/uber-java/tally/pull/116/commits/214401da4332d555e41cda58cda2647f2f9f798a |
|
| https://github.com/sairamch04 |
| sync with master | https://github.com/uber-java/tally/pull/116/commits/33723599109b0ef721eb0219d3f205b6b50fa486 |
| 3372359 | https://github.com/uber-java/tally/pull/116/commits/33723599109b0ef721eb0219d3f205b6b50fa486 |
|
| https://github.com/sairamch04 |
| add gradle files | https://github.com/uber-java/tally/pull/116/commits/abdb897d20296bacc5d326737dd76f393068c000 |
| abdb897 | https://github.com/uber-java/tally/pull/116/commits/abdb897d20296bacc5d326737dd76f393068c000 |
|
| https://github.com/sairamch04 |
| gradle cleanup | https://github.com/uber-java/tally/pull/116/commits/4a9ee3a7c7b49e76685ceadb59c6ee0ba99df3cc |
| 4a9ee3a | https://github.com/uber-java/tally/pull/116/commits/4a9ee3a7c7b49e76685ceadb59c6ee0ba99df3cc |
|
| https://github.com/sairamch04 |
| add unit tests and cleanup code | https://github.com/uber-java/tally/pull/116/commits/7a1b51a5b29ae6d9489db5ad49d7eabf435dca54 |
| 7a1b51a | https://github.com/uber-java/tally/pull/116/commits/7a1b51a5b29ae6d9489db5ad49d7eabf435dca54 |
|
| https://github.com/sairamch04 |
| self review | https://github.com/uber-java/tally/pull/116/commits/dde606b544373307e90260b53be4dc81f17b84a4 |
| dde606b | https://github.com/uber-java/tally/pull/116/commits/dde606b544373307e90260b53be4dc81f17b84a4 |
|
| https://github.com/sairamch04 |
| self review | https://github.com/uber-java/tally/pull/116/commits/c05c3726dfdcdfe38f01a30db45fc64cd8e35a9b |
| c05c372 | https://github.com/uber-java/tally/pull/116/commits/c05c3726dfdcdfe38f01a30db45fc64cd8e35a9b |
| https://github.com/CLAassistant |
| CLAassistant | https://github.com/CLAassistant |
| Feb 7, 2023 | https://github.com/uber-java/tally/pull/116#issuecomment-1421466186 |
| Please reload this page | https://github.com/uber-java/tally/pull/116 |
| https://cla-assistant.io/uber-java/tally?pullRequest=116 |
| Please reload this page | https://github.com/uber-java/tally/pull/116 |
| https://github.com/sairamch04 |
| sairamch04 | https://github.com/sairamch04 |
|
Feb 7, 2023
| https://github.com/uber-java/tally/pull/116#ref-pullrequest-1571598391 |
|
Define a custom Scope Key for reducing memory allocations
sairamch04/tally#2
| https://github.com/sairamch04/tally/pull/2 |
| https://github.com/cdvr1993 |
| cdvr1993 | https://github.com/cdvr1993 |
|
Feb 7, 2023
| https://github.com/uber-java/tally/pull/116#pullrequestreview-1288033222 |
|
View reviewed changes
| https://github.com/uber-java/tally/pull/116/files/c05c3726dfdcdfe38f01a30db45fc64cd8e35a9b |
| cdvr1993 | https://github.com/cdvr1993 |
| https://github.com/uber-java/tally/pull/116#pullrequestreview-1288033222 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/uber-java/tally/pull/116 |
| https://github.com/SokolAndrey |
| SokolAndrey | https://github.com/SokolAndrey |
|
Feb 9, 2023
| https://github.com/uber-java/tally/pull/116#pullrequestreview-1288270505 |
|
View reviewed changes
| https://github.com/uber-java/tally/pull/116/files/c05c3726dfdcdfe38f01a30db45fc64cd8e35a9b |
| SokolAndrey | https://github.com/SokolAndrey |
| https://github.com/uber-java/tally/pull/116#pullrequestreview-1288270505 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/uber-java/tally/pull/116 |
| core/src/main/java/com/uber/m3/tally/ScopeKey.java | https://github.com/uber-java/tally/pull/116/files/c05c3726dfdcdfe38f01a30db45fc64cd8e35a9b#diff-2406a728a262289e6d90956efd7734200105b831052e6f916525c4f0c23b5cf6 |
| Please reload this page | https://github.com/uber-java/tally/pull/116 |
| core/src/main/java/com/uber/m3/tally/ScopeKey.java | https://github.com/uber-java/tally/pull/116/files/c05c3726dfdcdfe38f01a30db45fc64cd8e35a9b#diff-2406a728a262289e6d90956efd7734200105b831052e6f916525c4f0c23b5cf6 |
| Please reload this page | https://github.com/uber-java/tally/pull/116 |
| core/src/main/java/com/uber/m3/tally/ScopeKey.java | https://github.com/uber-java/tally/pull/116/files/c05c3726dfdcdfe38f01a30db45fc64cd8e35a9b#diff-2406a728a262289e6d90956efd7734200105b831052e6f916525c4f0c23b5cf6 |
| Please reload this page | https://github.com/uber-java/tally/pull/116 |
| core/src/test/java/com/uber/m3/tally/ScopeImplTest.java | https://github.com/uber-java/tally/pull/116/files/c05c3726dfdcdfe38f01a30db45fc64cd8e35a9b#diff-699025213ae66a5ed6361a4ef559eb3f9b1986e6c7b471c4a8a59d34234f7272 |
| Please reload this page | https://github.com/uber-java/tally/pull/116 |
| core/src/main/java/com/uber/m3/tally/ScopeKey.java | https://github.com/uber-java/tally/pull/116/files/c05c3726dfdcdfe38f01a30db45fc64cd8e35a9b#diff-2406a728a262289e6d90956efd7734200105b831052e6f916525c4f0c23b5cf6 |
| Please reload this page | https://github.com/uber-java/tally/pull/116 |
| sairamch04 | https://github.com/sairamch04 |
| February 10, 2023 20:43 | https://github.com/uber-java/tally/pull/116#commits-pushed-72df875 |
|
| https://github.com/sairamch04 |
| review comments address | https://github.com/uber-java/tally/pull/116/commits/72df875675d275bfa5ec9e9b61fa76a73bdf4df7 |
| 72df875 | https://github.com/uber-java/tally/pull/116/commits/72df875675d275bfa5ec9e9b61fa76a73bdf4df7 |
|
| https://github.com/sairamch04 |
| fix flaky test as pointed in review | https://github.com/uber-java/tally/pull/116/commits/c9b8e3deb0f2bdaadccbe18d2e141d24cd95a9bb |
| c9b8e3d | https://github.com/uber-java/tally/pull/116/commits/c9b8e3deb0f2bdaadccbe18d2e141d24cd95a9bb |
|
| https://github.com/sairamch04 |
| add benchmark | https://github.com/uber-java/tally/pull/116/commits/84481363ab663e5122cefd102fe96280bb119785 |
| 8448136 | https://github.com/uber-java/tally/pull/116/commits/84481363ab663e5122cefd102fe96280bb119785 |
|
| https://github.com/sairamch04 |
| self review | https://github.com/uber-java/tally/pull/116/commits/599d94dd173e10c37ff8cb1e600dffaa96f01221 |
| 599d94d | https://github.com/uber-java/tally/pull/116/commits/599d94dd173e10c37ff8cb1e600dffaa96f01221 |
| https://github.com/sairamch04 |
| sairamch04 | https://github.com/sairamch04 |
| Feb 10, 2023 | https://github.com/uber-java/tally/pull/116#issuecomment-1426056560 |
| @SokolAndrey | https://github.com/SokolAndrey |
| Please reload this page | https://github.com/uber-java/tally/pull/116 |
|
| https://github.com/sairamch04 |
| nit pick | https://github.com/uber-java/tally/pull/116/commits/ac4919dc328268e9c8ddf302fb1c51720381c1e9 |
| ac4919d | https://github.com/uber-java/tally/pull/116/commits/ac4919dc328268e9c8ddf302fb1c51720381c1e9 |
| https://github.com/SokolAndrey |
| SokolAndrey | https://github.com/SokolAndrey |
|
Feb 13, 2023
| https://github.com/uber-java/tally/pull/116#pullrequestreview-1296297132 |
|
View reviewed changes
| https://github.com/uber-java/tally/pull/116/files/ac4919dc328268e9c8ddf302fb1c51720381c1e9 |
| SokolAndrey | https://github.com/SokolAndrey |
| https://github.com/uber-java/tally/pull/116#pullrequestreview-1296297132 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/uber-java/tally/pull/116 |
| https://github.com/SokolAndrey |
| SokolAndrey | https://github.com/SokolAndrey |
| fa530e2 | https://github.com/uber-java/tally/commit/fa530e2390f2343cd5f9ef5f9293bc1f900ba408 |
| Feb 13, 2023 | https://github.com/uber-java/tally/pull/116#event-8508133457 |
| https://github.com/sairamch04 |
| sairamch04 | https://github.com/sairamch04 |
| February 13, 2023 19:36 | https://github.com/uber-java/tally/pull/116#event-8508140796 |
| https://github.co/hiddenchars |
| https://github.com/uber-java/tally/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fuber-java%2Ftally%2Fpull%2F116 |
|
| https://github.com/SokolAndrey |
|
SokolAndrey
| https://github.com/SokolAndrey |
|
| https://github.com/uber-java/tally/pull/116/files/ac4919dc328268e9c8ddf302fb1c51720381c1e9 |
|
| https://github.com/cdvr1993 |
|
cdvr1993
| https://github.com/cdvr1993 |
|
| https://github.com/uber-java/tally/pull/116/files/c05c3726dfdcdfe38f01a30db45fc64cd8e35a9b |
| Please reload this page | https://github.com/uber-java/tally/pull/116 |
|
| https://github.com/sairamch04 |
|
| https://github.com/CLAassistant |
|
| https://github.com/SokolAndrey |
|
| https://github.com/cdvr1993 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |