René's URL Explorer Experiment


Title: feat: allow cancelling jobs from trigger-client sdk by hmacr · Pull Request #562 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: feat: allow cancelling jobs from trigger-client sdk by hmacr · Pull Request #562 · triggerdotdev/trigger.dev

X Title: feat: allow cancelling jobs from trigger-client sdk by hmacr · Pull Request #562 · triggerdotdev/trigger.dev

Description: Closes #554 ✅ Checklist I have followed every step in the contributing guide The PR title follows the convention. I ran and tested the code works Testing Validated the SDK functionality Verified the job cancellation from SDK Verified the job cancellation from the Dashboard Changelog Introduced api/v1/runs/$runId/cancel endpoint. Added cancelJob function to SDK. Consolidated the Job Run fetch into a GetRunService. This will be used in both GET api/v1/runs/$runId and POST api/v1/runs/$runId/cancel API. The new cancel-job endpoint returns basic job-run information and does not accept any search parameters (as it does in the get-run API). I don't think it makes sense to accept search parameters in the cancel API. The intention is if the user wants additional information, they can use the get-run with the runId. Screenshots Test Job Cancelled Cancel Run API Response 💯

Open Graph Description: Closes #554 ✅ Checklist I have followed every step in the contributing guide The PR title follows the convention. I ran and tested the code works Testing Validated the SDK functionality Veri...

X Description: Closes #554 ✅ Checklist I have followed every step in the contributing guide The PR title follows the convention. I ran and tested the code works Testing Validated the SDK functionality Veri...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/562

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:03e6bd4d-ca6d-dacf-2742-e699c921c582
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE782:39F7DB:273261:39776B:6AFADEC4
html-safe-nonceddf7d9fcbc0449fff2e5d6c8fa0cb29125d03812a90be87cc4a1126742cb4996
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzgyOjM5RjdEQjoyNzMyNjE6Mzk3NzZCOjZBRkFERUM0IiwidmlzaXRvcl9pZCI6IjU4MDM2MjgyNTYxOTU5NjA1MTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac43adf6a864d3cbcf4d3b908deb44d62de1a5f24444118bdd65b74ab02668bdc7
hovercard-subject-tagpull_request:1542934617
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/562/files
twitter:imagehttps://avatars.githubusercontent.com/u/132386067?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/132386067?s=400&v=4
og:image:altCloses #554 ✅ Checklist I have followed every step in the contributing guide The PR title follows the convention. I ran and tested the code works Testing Validated the SDK functionality Veri...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None9d9bd51a568909a83d1abb9d6f74d68f0c87ca85fe3a56d3f5d70d8b89add9f2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a7ae932999cc6d511008dbf980ff9efad2a31f7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/562/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F562%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F562%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/562/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/562/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/562/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests66 (66)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
ericallamhttps://github.com/ericallam
triggerdotdev:mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
hmacr:issue-554https://github.com/hmacr/trigger.dev/tree/issue-554
Conversation 8 https://github.com/triggerdotdev/trigger.dev/pull/562
Commits 2 https://github.com/triggerdotdev/trigger.dev/pull/562/commits
Checks 0 https://github.com/triggerdotdev/trigger.dev/pull/562/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/562/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/562/files
feat: allow cancelling jobs from trigger-client sdk https://github.com/triggerdotdev/trigger.dev/pull/562/files#top
Show all changes 2 commits https://github.com/triggerdotdev/trigger.dev/pull/562/files
b383e4a feat: allow cancelling jobs from trigger-client sdk hmacr Oct 5, 2023 https://github.com/triggerdotdev/trigger.dev/pull/562/commits/b383e4af54676b7ab2571f166187a235a369e7a8
b1b9175 use presenter instead of service for non-mutating logic hmacr Oct 5, 2023 https://github.com/triggerdotdev/trigger.dev/pull/562/commits/b1b91758a9b869fbda8e872a0930da06747b290e
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/562/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/562/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/562/files
orange-falcons-smile.md https://github.com/triggerdotdev/trigger.dev/pull/562/files#diff-bddad50302aa4d2484532fe9d709bf11e9a82187531a0fa000911a30c5fe2d1a
ApiRunPresenter.server.ts https://github.com/triggerdotdev/trigger.dev/pull/562/files#diff-a8c866f5f7b447c92ae99193f513d73e4efc5e4dec6f11ef5ca4d0b7b15ecc25
api.v1.runs.$runId.cancel.ts https://github.com/triggerdotdev/trigger.dev/pull/562/files#diff-18b51c7872132828485cd4e378f336ffb8c109393c4eed54e4801b8abf6ff45b
api.v1.runs.$runId.ts https://github.com/triggerdotdev/trigger.dev/pull/562/files#diff-e11f6ff7eca0a2626d70aed77d1afc197fc07bce7ecc75df480a97b8a352682f
apiClient.ts https://github.com/triggerdotdev/trigger.dev/pull/562/files#diff-3df9dadf9461113eb72a4a93c36520e8b7504a2d21d18237460f3df2cd77299f
triggerClient.ts https://github.com/triggerdotdev/trigger.dev/pull/562/files#diff-28c81f1a74cbd8f47b72da1394f01dae03934c605a4ac296a4ac65efdcb3bbb7
.changeset/orange-falcons-smile.mdhttps://github.com/triggerdotdev/trigger.dev/pull/562/files#diff-bddad50302aa4d2484532fe9d709bf11e9a82187531a0fa000911a30c5fe2d1a
View file https://github.com/hmacr/trigger.dev/blob/b1b91758a9b869fbda8e872a0930da06747b290e/.changeset/orange-falcons-smile.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/562/{{ revealButtonHref }}
apps/webapp/app/presenters/ApiRunPresenter.server.tshttps://github.com/triggerdotdev/trigger.dev/pull/562/files#diff-a8c866f5f7b447c92ae99193f513d73e4efc5e4dec6f11ef5ca4d0b7b15ecc25
View file https://github.com/hmacr/trigger.dev/blob/b1b91758a9b869fbda8e872a0930da06747b290e/apps/webapp/app/presenters/ApiRunPresenter.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/562/{{ revealButtonHref }}
apps/webapp/app/routes/api.v1.runs.$runId.cancel.tshttps://github.com/triggerdotdev/trigger.dev/pull/562/files#diff-18b51c7872132828485cd4e378f336ffb8c109393c4eed54e4801b8abf6ff45b
View file https://github.com/hmacr/trigger.dev/blob/b1b91758a9b869fbda8e872a0930da06747b290e/apps/webapp/app/routes/api.v1.runs.%24runId.cancel.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/562/{{ revealButtonHref }}
apps/webapp/app/routes/api.v1.runs.$runId.tshttps://github.com/triggerdotdev/trigger.dev/pull/562/files#diff-e11f6ff7eca0a2626d70aed77d1afc197fc07bce7ecc75df480a97b8a352682f
View file https://github.com/hmacr/trigger.dev/blob/b1b91758a9b869fbda8e872a0930da06747b290e/apps/webapp/app/routes/api.v1.runs.%24runId.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/562/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/562/files#diff-e11f6ff7eca0a2626d70aed77d1afc197fc07bce7ecc75df480a97b8a352682f
https://github.com/triggerdotdev/trigger.dev/pull/562/files#diff-e11f6ff7eca0a2626d70aed77d1afc197fc07bce7ecc75df480a97b8a352682f
https://github.com/triggerdotdev/trigger.dev/pull/562/files#diff-e11f6ff7eca0a2626d70aed77d1afc197fc07bce7ecc75df480a97b8a352682f
packages/trigger-sdk/src/apiClient.tshttps://github.com/triggerdotdev/trigger.dev/pull/562/files#diff-3df9dadf9461113eb72a4a93c36520e8b7504a2d21d18237460f3df2cd77299f
View file https://github.com/hmacr/trigger.dev/blob/b1b91758a9b869fbda8e872a0930da06747b290e/packages/trigger-sdk/src/apiClient.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/562/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/562/files#diff-3df9dadf9461113eb72a4a93c36520e8b7504a2d21d18237460f3df2cd77299f
https://github.com/triggerdotdev/trigger.dev/pull/562/files#diff-3df9dadf9461113eb72a4a93c36520e8b7504a2d21d18237460f3df2cd77299f
packages/trigger-sdk/src/triggerClient.tshttps://github.com/triggerdotdev/trigger.dev/pull/562/files#diff-28c81f1a74cbd8f47b72da1394f01dae03934c605a4ac296a4ac65efdcb3bbb7
View file https://github.com/hmacr/trigger.dev/blob/b1b91758a9b869fbda8e872a0930da06747b290e/packages/trigger-sdk/src/triggerClient.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/562/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/562/files#diff-28c81f1a74cbd8f47b72da1394f01dae03934c605a4ac296a4ac65efdcb3bbb7
https://github.com/triggerdotdev/trigger.dev/pull/562/files#diff-28c81f1a74cbd8f47b72da1394f01dae03934c605a4ac296a4ac65efdcb3bbb7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.