René's URL Explorer Experiment


Title: Add typed filters to `Linear` getAll helper by nicktrn · Pull Request #517 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: Add typed filters to `Linear` getAll helper by nicktrn · Pull Request #517 · triggerdotdev/trigger.dev

X Title: Add typed filters to `Linear` getAll helper by nicktrn · Pull Request #517 · triggerdotdev/trigger.dev

Description: The helper previously accepted all valid params except filters. It will now accept entity-specific filters as it should. edit: Also fixed search function params. Some suggestions Maybe we could adopt a params pattern that exactly mirrors that of the target SDK, e.g.: function searchDocuments( key: IntegrationTaskKey, ...params: Parameters ): LinearReturnType { return this.runTask( key, async (client) => { const payload = await client.searchDocuments(...params); ... // Option #1 linear.searchDocuments("task-key", "search terms", { first: 5 }) // Option #2 - alternatively as single array param linear.searchDocuments("task-key", ["search terms", { first: 5 }]) Would prevent having to create keys, particularly for non-object params. These are never user-facing when using the original SDK, except for type hints. Currently: // Option #3 linear.searchDocuments("task-key", { term: "search terms", variables: { first: 5 } }) Alternatively, can merge params, but could cause key conflicts in rare cases: // Option #4 linear.searchDocuments("task-key", { term: "search terms", first: 5 }) Summary Would be great to standardise the params pattern across integrations! Personally prefer Option 1 or 2.

Open Graph Description: The helper previously accepted all valid params except filters. It will now accept entity-specific filters as it should. edit: Also fixed search function params. Some suggestions Maybe we could ado...

X Description: The helper previously accepted all valid params except filters. It will now accept entity-specific filters as it should. edit: Also fixed search function params. Some suggestions Maybe we could ado...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/517

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:09eaf964-0c56-642d-6174-c2efbbb6c217
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEBC4:1DD51C:384F1D:53B268:6AFAE260
html-safe-nonce9969b65826b7f14ec56deb3f60ed52849197058fbd134a537d8dc9cfaeda308f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkM0OjFERDUxQzozODRGMUQ6NTNCMjY4OjZBRkFFMjYwIiwidmlzaXRvcl9pZCI6IjM5MTUyMjM4NzIwNTIxODkxMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac07e80cea5abafb44d60e7367ff09f6bb1c4bd1f4ea8383d51393e43606d9253f
hovercard-subject-tagpull_request:1534280226
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/517/files
twitter:imagehttps://avatars.githubusercontent.com/u/55853254?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/55853254?s=400&v=4
og:image:altThe helper previously accepted all valid params except filters. It will now accept entity-specific filters as it should. edit: Also fixed search function params. Some suggestions Maybe we could ado...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None9d9bd51a568909a83d1abb9d6f74d68f0c87ca85fe3a56d3f5d70d8b89add9f2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a7ae932999cc6d511008dbf980ff9efad2a31f7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/517/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F517%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F517%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/517/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/517/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/517/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests66 (66)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
ericallamhttps://github.com/ericallam
triggerdotdev:mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
nicktrn:linear-getall-typeshttps://github.com/nicktrn/trigger.dev/tree/linear-getall-types
Conversation 1 https://github.com/triggerdotdev/trigger.dev/pull/517
Commits 5 https://github.com/triggerdotdev/trigger.dev/pull/517/commits
Checks 0 https://github.com/triggerdotdev/trigger.dev/pull/517/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/517/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/517/files
Add typed filters to Linear getAll helper https://github.com/triggerdotdev/trigger.dev/pull/517/files#top
Show all changes 5 commits https://github.com/triggerdotdev/trigger.dev/pull/517/files
194bf61 Fix getAll params type nicktrn Sep 28, 2023 https://github.com/triggerdotdev/trigger.dev/pull/517/commits/194bf6115395faefed385faa064e3c36178666b7
7c44f69 Changeset nicktrn Sep 28, 2023 https://github.com/triggerdotdev/trigger.dev/pull/517/commits/7c44f6981b075ea672c17f73b2be97f5ecb28241
7ffda7e Search param types nicktrn Sep 29, 2023 https://github.com/triggerdotdev/trigger.dev/pull/517/commits/7ffda7e37da1e6258e947d1f5f19b6fbf8f6ce29
1f9cb10 Update changeset nicktrn Sep 29, 2023 https://github.com/triggerdotdev/trigger.dev/pull/517/commits/1f9cb1036326c940f939b4ff30c2c0c3f2234adf
ff45860 Merge branch 'main' into linear-getall-types nicktrn Sep 29, 2023 https://github.com/triggerdotdev/trigger.dev/pull/517/commits/ff45860b28c2b359dd2c7d6da7f9e60ac7de51d6
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/517/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/517/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/517/files
sour-jars-punch.md https://github.com/triggerdotdev/trigger.dev/pull/517/files#diff-dfd1f8c7afb508e34bfe35f25da45bd381d1b2751fcc31d5ec4e611d41fbffb3
index.ts https://github.com/triggerdotdev/trigger.dev/pull/517/files#diff-950d07a60829742c9e406b53b2a0398140d029c92362f5116aed9ab7faefd3b6
.changeset/sour-jars-punch.mdhttps://github.com/triggerdotdev/trigger.dev/pull/517/files#diff-dfd1f8c7afb508e34bfe35f25da45bd381d1b2751fcc31d5ec4e611d41fbffb3
View file https://github.com/nicktrn/trigger.dev/blob/ff45860b28c2b359dd2c7d6da7f9e60ac7de51d6/.changeset/sour-jars-punch.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/517/{{ revealButtonHref }}
integrations/linear/src/index.tshttps://github.com/triggerdotdev/trigger.dev/pull/517/files#diff-950d07a60829742c9e406b53b2a0398140d029c92362f5116aed9ab7faefd3b6
View file https://github.com/nicktrn/trigger.dev/blob/ff45860b28c2b359dd2c7d6da7f9e60ac7de51d6/integrations/linear/src/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/517/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/517/files#diff-950d07a60829742c9e406b53b2a0398140d029c92362f5116aed9ab7faefd3b6
https://github.com/triggerdotdev/trigger.dev/pull/517/files#diff-950d07a60829742c9e406b53b2a0398140d029c92362f5116aed9ab7faefd3b6
https://github.com/triggerdotdev/trigger.dev/pull/517/files#diff-950d07a60829742c9e406b53b2a0398140d029c92362f5116aed9ab7faefd3b6
https://github.com/triggerdotdev/trigger.dev/pull/517/files#diff-950d07a60829742c9e406b53b2a0398140d029c92362f5116aed9ab7faefd3b6
https://github.com/triggerdotdev/trigger.dev/pull/517/files#diff-950d07a60829742c9e406b53b2a0398140d029c92362f5116aed9ab7faefd3b6
https://github.com/triggerdotdev/trigger.dev/pull/517/files#diff-950d07a60829742c9e406b53b2a0398140d029c92362f5116aed9ab7faefd3b6
https://github.com/triggerdotdev/trigger.dev/pull/517/files#diff-950d07a60829742c9e406b53b2a0398140d029c92362f5116aed9ab7faefd3b6
https://github.com/triggerdotdev/trigger.dev/pull/517/files#diff-950d07a60829742c9e406b53b2a0398140d029c92362f5116aed9ab7faefd3b6
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.