René's URL Explorer Experiment


Title: fix(webapp): preserve valid org flags when invalid flag is stored (#5058) by ghazy2001 · Pull Request #5086 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(webapp): preserve valid org flags when invalid flag is stored (#5058) by ghazy2001 · Pull Request #5086 · triggerdotdev/trigger.dev

X Title: fix(webapp): preserve valid org flags when invalid flag is stored (#5058) by ghazy2001 · Pull Request #5086 · triggerdotdev/trigger.dev

Description: Fixes #5058 Background & Issue When mergeOrgFeatureFlags merged stored organization flags onto global flags, it invoked validatePartialFeatureFlags(orgFeatureFlags). Because validatePartialFeatureFlags validates the object as a whole, a single invalid or deprecated flag in an organization's stored flags caused the entire parse to fail. Consequently, all valid org flag overrides were dropped and reverted to global defaults. Solution Updated mergeOrgFeatureFlags to use parseStoredOrgFlags(orgFeatureFlags).valid, which parses stored flags key-by-key and preserves all valid catalog flags even if an invalid or unknown flag is present. Placed mergeOrgFeatureFlags in apps/webapp/app/v3/featureFlags.ts alongside parseStoredOrgFlags, and re-exported it from apps/webapp/app/v3/featureFlags.server.ts for backward compatibility. Added unit tests in apps/webapp/test/storedOrgFlags.test.ts verifying that valid org flags are retained when invalid flags are present, unknown keys are ignored, and non-object inputs are safely handled.

Open Graph Description: Fixes #5058 Background & Issue When mergeOrgFeatureFlags merged stored organization flags onto global flags, it invoked validatePartialFeatureFlags(orgFeatureFlags). Because validatePartialFeat...

X Description: Fixes #5058 Background & Issue When mergeOrgFeatureFlags merged stored organization flags onto global flags, it invoked validatePartialFeatureFlags(orgFeatureFlags). Because validatePartial...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/5086

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:854b845b-be35-0618-5a50-a8266d9bf338
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA470:3ACD90:273EA1:3AD4FB:6AFADCF9
html-safe-noncec4f6337002cf34a85e50213a887ac40444901abeb487aa27fcbfb82c33937cab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDcwOjNBQ0Q5MDoyNzNFQTE6M0FENEZCOjZBRkFEQ0Y5IiwidmlzaXRvcl9pZCI6IjQwNDYxNzYyOTIwNjIyODkxNDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2119521782b7156b5d55c7d9e1ab5b3c202006f1896498459b3949fe7477db0b
hovercard-subject-tagpull_request:5071814155
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/5086/files
twitter:imagehttps://avatars.githubusercontent.com/u/68187836?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/68187836?s=400&v=4
og:image:altFixes #5058 Background & Issue When mergeOrgFeatureFlags merged stored organization flags onto global flags, it invoked validatePartialFeatureFlags(orgFeatureFlags). Because validatePartialFeat...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None9d9bd51a568909a83d1abb9d6f74d68f0c87ca85fe3a56d3f5d70d8b89add9f2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a7ae932999cc6d511008dbf980ff9efad2a31f7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/5086/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F5086%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F5086%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/5086/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/5086/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/5086/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests66 (66)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
ghazy2001https://github.com/ghazy2001
triggerdotdev:mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
ghazy2001:fix/merge-org-feature-flags-keep-valid-5058https://github.com/ghazy2001/trigger.dev/tree/fix/merge-org-feature-flags-keep-valid-5058
Conversation 6 https://github.com/triggerdotdev/trigger.dev/pull/5086
Commits 1 https://github.com/triggerdotdev/trigger.dev/pull/5086/commits
Checks 3 https://github.com/triggerdotdev/trigger.dev/pull/5086/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/5086/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/5086/files
fix(webapp): preserve valid org flags when invalid flag is stored (#5058) https://github.com/triggerdotdev/trigger.dev/pull/5086/files#top
Show all changes 1 commit https://github.com/triggerdotdev/trigger.dev/pull/5086/files
ac1d812 fix(webapp): preserve valid org flags when invalid flag is stored (#5… ghazy2001 Oct 29, 2026 https://github.com/triggerdotdev/trigger.dev/pull/5086/commits/ac1d8122269f22d34af14767c82155d3faa5d3d4
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/5086/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/5086/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/5086/files
featureFlags.server.ts https://github.com/triggerdotdev/trigger.dev/pull/5086/files#diff-e8a7b59b28b50b634a54e1259a74256f1ee8eef32c00e655d5de093d6f388945
featureFlags.ts https://github.com/triggerdotdev/trigger.dev/pull/5086/files#diff-b786b6c59ba126a02d9e947c4d01e2df333ea295686f0eace3043c932eb20cb0
storedOrgFlags.test.ts https://github.com/triggerdotdev/trigger.dev/pull/5086/files#diff-ade2b64b13e1875750b090934304f4251734c8113e40a1cd8e4349cfc1c7063b
apps/webapp/app/v3/featureFlags.server.tshttps://github.com/triggerdotdev/trigger.dev/pull/5086/files#diff-e8a7b59b28b50b634a54e1259a74256f1ee8eef32c00e655d5de093d6f388945
View file https://github.com/ghazy2001/trigger.dev/blob/ac1d8122269f22d34af14767c82155d3faa5d3d4/apps/webapp/app/v3/featureFlags.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/5086/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/5086/files#diff-e8a7b59b28b50b634a54e1259a74256f1ee8eef32c00e655d5de093d6f388945
https://github.com/triggerdotdev/trigger.dev/pull/5086/files#diff-e8a7b59b28b50b634a54e1259a74256f1ee8eef32c00e655d5de093d6f388945
https://github.com/triggerdotdev/trigger.dev/pull/5086/files#diff-e8a7b59b28b50b634a54e1259a74256f1ee8eef32c00e655d5de093d6f388945
https://github.com/triggerdotdev/trigger.dev/pull/5086/files#diff-e8a7b59b28b50b634a54e1259a74256f1ee8eef32c00e655d5de093d6f388945
apps/webapp/app/v3/featureFlags.tshttps://github.com/triggerdotdev/trigger.dev/pull/5086/files#diff-b786b6c59ba126a02d9e947c4d01e2df333ea295686f0eace3043c932eb20cb0
View file https://github.com/ghazy2001/trigger.dev/blob/ac1d8122269f22d34af14767c82155d3faa5d3d4/apps/webapp/app/v3/featureFlags.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/5086/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/5086/files#diff-b786b6c59ba126a02d9e947c4d01e2df333ea295686f0eace3043c932eb20cb0
devin-ai-integrationhttps://github.com/apps/devin-ai-integration
Oct 29, 2026https://github.com/triggerdotdev/trigger.dev/pull/5086/files#r4415076961
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
OrganizationsPresenterhttps://github.com/triggerdotdev/trigger.dev/blob/ac1d8122269f22d34af14767c82155d3faa5d3d4/apps/webapp/app/presenters/OrganizationsPresenter.server.ts#L167-L177
https://app.devin.ai/review/triggerdotdev/trigger.dev/pull/5086
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/5086/files
https://github.com/triggerdotdev/trigger.dev/pull/5086/files#diff-b786b6c59ba126a02d9e947c4d01e2df333ea295686f0eace3043c932eb20cb0
apps/webapp/test/storedOrgFlags.test.tshttps://github.com/triggerdotdev/trigger.dev/pull/5086/files#diff-ade2b64b13e1875750b090934304f4251734c8113e40a1cd8e4349cfc1c7063b
View file https://github.com/ghazy2001/trigger.dev/blob/ac1d8122269f22d34af14767c82155d3faa5d3d4/apps/webapp/test/storedOrgFlags.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/5086/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/5086/files#diff-ade2b64b13e1875750b090934304f4251734c8113e40a1cd8e4349cfc1c7063b
https://github.com/triggerdotdev/trigger.dev/pull/5086/files#diff-ade2b64b13e1875750b090934304f4251734c8113e40a1cd8e4349cfc1c7063b
https://github.com/triggerdotdev/trigger.dev/pull/5086/files#diff-ade2b64b13e1875750b090934304f4251734c8113e40a1cd8e4349cfc1c7063b
devin-ai-integrationhttps://github.com/apps/devin-ai-integration
Oct 29, 2026https://github.com/triggerdotdev/trigger.dev/pull/5086/files#r4415077184
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://app.devin.ai/review/triggerdotdev/trigger.dev/pull/5086
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/5086/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.