René's URL Explorer Experiment


Title: fix(webapp): forward condition value and windowSec in queryWatchFromPatch (#5065) by MilindChatrabhuji · Pull Request #5071 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(webapp): forward condition value and windowSec in queryWatchFromPatch (#5065) by MilindChatrabhuji · Pull Request #5071 · triggerdotdev/trigger.dev

X Title: fix(webapp): forward condition value and windowSec in queryWatchFromPatch (#5065) by MilindChatrabhuji · Pull Request #5071 · triggerdotdev/trigger.dev

Description: Summary Fixes #5065 When the dashboard agent prefills a query watch alert patch, queryWatchFromPatch previously only forwarded operator: patch.condition?.operator into QueryWatchPrefill, dropping patch.condition?.value and patch.condition?.windowSec. In addition, useQueryAlertDraft initialized valueText to "", causing draft.valueValid to remain false even if an operator was prefilled, preventing automatic pre-selection of the threshold step. Changes: queryWatchFromPatch (apps/webapp/app/components/dashboard-agent/alert-creation/draftPatch.ts): Forwards value: patch.condition?.value and windowSec: patch.condition?.windowSec to QueryWatchPrefill. QueryWatchPrefill & QueryAlertPrefill (QueryAlertTranscript.tsx, queryAlertLink.ts): Extended types to include optional value and windowSec fields, and forwarded from full in QueryAlertTranscript. useQueryAlertDraft (apps/webapp/app/components/alerts/useQueryAlertDraft.ts): Initializes valueText with prefill.value !== undefined ? String(prefill.value) : "" so draft.valueValid evaluates to true when prefilled with a valid number. Converts prefill.windowSec into minutes when present (Math.round(prefill.windowSec / 60)) and validates against analysis limits before setting windowText. Unit Test (draftPatch.test.ts): Added unit test verifying that queryWatchFromPatch properly forwards value and windowSec from the patch condition into QueryWatchPrefill. @algora-pbc /claim #5065

Open Graph Description: Summary Fixes #5065 When the dashboard agent prefills a query watch alert patch, queryWatchFromPatch previously only forwarded operator: patch.condition?.operator into QueryWatchPrefill, dropping p...

X Description: Summary Fixes #5065 When the dashboard agent prefills a query watch alert patch, queryWatchFromPatch previously only forwarded operator: patch.condition?.operator into QueryWatchPrefill, dropping p...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/5071

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9bdc8dc3-d8ec-1d1d-c05b-5be933e87b39
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD1CE:1F5CA2:20A8F5:301C70:6AFADADB
html-safe-nonce1642690282c0889171b5970711815951e191b866eeada2595116c276935ea26c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMUNFOjFGNUNBMjoyMEE4RjU6MzAxQzcwOjZBRkFEQURCIiwidmlzaXRvcl9pZCI6IjE1NzI2NjgxOTIwODgzMTY2MzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfa02c93d3ec0195cf20b7e341a67beda9380ee35b7f7ccdefc642279c1d46626
hovercard-subject-tagpull_request:5014475167
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/5071/files
twitter:imagehttps://avatars.githubusercontent.com/u/277298508?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/277298508?s=400&v=4
og:image:altSummary Fixes #5065 When the dashboard agent prefills a query watch alert patch, queryWatchFromPatch previously only forwarded operator: patch.condition?.operator into QueryWatchPrefill, dropping p...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None9d9bd51a568909a83d1abb9d6f74d68f0c87ca85fe3a56d3f5d70d8b89add9f2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a7ae932999cc6d511008dbf980ff9efad2a31f7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/5071/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F5071%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F5071%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/5071/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/5071/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/5071/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests65 (65)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
MilindChatrabhujihttps://github.com/MilindChatrabhuji
triggerdotdev:mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
MilindChatrabhuji:fix/query-watch-patch-prefill-5065https://github.com/MilindChatrabhuji/trigger.dev/tree/fix/query-watch-patch-prefill-5065
Conversation 6 https://github.com/triggerdotdev/trigger.dev/pull/5071
Commits 1 https://github.com/triggerdotdev/trigger.dev/pull/5071/commits
Checks 6 https://github.com/triggerdotdev/trigger.dev/pull/5071/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/5071/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/5071/files
fix(webapp): forward condition value and windowSec in queryWatchFromPatch (#5065) https://github.com/triggerdotdev/trigger.dev/pull/5071/files#top
Show all changes 1 commit https://github.com/triggerdotdev/trigger.dev/pull/5071/files
6ee18b5 fix(webapp): forward condition value and windowSec in queryWatchFromP… MilindChatrabhuji Oct 26, 2026 https://github.com/triggerdotdev/trigger.dev/pull/5071/commits/6ee18b5842d86d48bbb79a72ddeac3827c430858
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/5071/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/5071/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/5071/files
QueryAlertTranscript.tsx https://github.com/triggerdotdev/trigger.dev/pull/5071/files#diff-660fbfeef7e106a79aacbed926a2b5166afa75ee09bd7f6a33d2f6116566d08d
queryAlertLink.ts https://github.com/triggerdotdev/trigger.dev/pull/5071/files#diff-bc9dfe22566a8ccb2528342c183ed57763da5d98579f5773137691e4050e5185
useQueryAlertDraft.ts https://github.com/triggerdotdev/trigger.dev/pull/5071/files#diff-e135654cf911105d4d860b10a5e77caed17a320241d724c81238dd4c13fb9886
draftPatch.test.ts https://github.com/triggerdotdev/trigger.dev/pull/5071/files#diff-f006c57c96ce71764e9d04c8b60a58e1c5aee333b119c11a3f71c33e1dc89dbb
draftPatch.ts https://github.com/triggerdotdev/trigger.dev/pull/5071/files#diff-ea1e0dedae725677f9ad087d4ae8e1ac04907be90a1cfdc92d8b4881cb770cee
apps/webapp/app/components/alerts/QueryAlertTranscript.tsxhttps://github.com/triggerdotdev/trigger.dev/pull/5071/files#diff-660fbfeef7e106a79aacbed926a2b5166afa75ee09bd7f6a33d2f6116566d08d
View file https://github.com/MilindChatrabhuji/trigger.dev/blob/6ee18b5842d86d48bbb79a72ddeac3827c430858/apps/webapp/app/components/alerts/QueryAlertTranscript.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/5071/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/5071/files#diff-660fbfeef7e106a79aacbed926a2b5166afa75ee09bd7f6a33d2f6116566d08d
https://github.com/triggerdotdev/trigger.dev/pull/5071/files#diff-660fbfeef7e106a79aacbed926a2b5166afa75ee09bd7f6a33d2f6116566d08d
https://github.com/triggerdotdev/trigger.dev/pull/5071/files#diff-660fbfeef7e106a79aacbed926a2b5166afa75ee09bd7f6a33d2f6116566d08d
https://github.com/triggerdotdev/trigger.dev/pull/5071/files#diff-660fbfeef7e106a79aacbed926a2b5166afa75ee09bd7f6a33d2f6116566d08d
apps/webapp/app/components/alerts/queryAlertLink.tshttps://github.com/triggerdotdev/trigger.dev/pull/5071/files#diff-bc9dfe22566a8ccb2528342c183ed57763da5d98579f5773137691e4050e5185
View file https://github.com/MilindChatrabhuji/trigger.dev/blob/6ee18b5842d86d48bbb79a72ddeac3827c430858/apps/webapp/app/components/alerts/queryAlertLink.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/5071/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/5071/files#diff-bc9dfe22566a8ccb2528342c183ed57763da5d98579f5773137691e4050e5185
https://github.com/triggerdotdev/trigger.dev/pull/5071/files#diff-bc9dfe22566a8ccb2528342c183ed57763da5d98579f5773137691e4050e5185
apps/webapp/app/components/alerts/useQueryAlertDraft.tshttps://github.com/triggerdotdev/trigger.dev/pull/5071/files#diff-e135654cf911105d4d860b10a5e77caed17a320241d724c81238dd4c13fb9886
View file https://github.com/MilindChatrabhuji/trigger.dev/blob/6ee18b5842d86d48bbb79a72ddeac3827c430858/apps/webapp/app/components/alerts/useQueryAlertDraft.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/5071/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/5071/files#diff-e135654cf911105d4d860b10a5e77caed17a320241d724c81238dd4c13fb9886
devin-ai-integrationhttps://github.com/apps/devin-ai-integration
Oct 26, 2026https://github.com/triggerdotdev/trigger.dev/pull/5071/files#r4375321284
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
applyDraftPatchhttps://github.com/triggerdotdev/trigger.dev/blob/6ee18b5842d86d48bbb79a72ddeac3827c430858/apps/webapp/app/components/dashboard-agent/alert-creation/draftPatch.ts#L129-L130
queryAlertRequestBodyhttps://github.com/triggerdotdev/trigger.dev/blob/6ee18b5842d86d48bbb79a72ddeac3827c430858/apps/webapp/app/components/alerts/createAlertRequest.ts#L107
https://app.devin.ai/review/triggerdotdev/trigger.dev/pull/5071
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/5071/files
https://github.com/triggerdotdev/trigger.dev/pull/5071/files#diff-e135654cf911105d4d860b10a5e77caed17a320241d724c81238dd4c13fb9886
apps/webapp/app/components/dashboard-agent/alert-creation/draftPatch.test.tshttps://github.com/triggerdotdev/trigger.dev/pull/5071/files#diff-f006c57c96ce71764e9d04c8b60a58e1c5aee333b119c11a3f71c33e1dc89dbb
View file https://github.com/MilindChatrabhuji/trigger.dev/blob/6ee18b5842d86d48bbb79a72ddeac3827c430858/apps/webapp/app/components/dashboard-agent/alert-creation/draftPatch.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/5071/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/5071/files#diff-f006c57c96ce71764e9d04c8b60a58e1c5aee333b119c11a3f71c33e1dc89dbb
https://github.com/triggerdotdev/trigger.dev/pull/5071/files#diff-f006c57c96ce71764e9d04c8b60a58e1c5aee333b119c11a3f71c33e1dc89dbb
https://github.com/triggerdotdev/trigger.dev/pull/5071/files#diff-f006c57c96ce71764e9d04c8b60a58e1c5aee333b119c11a3f71c33e1dc89dbb
https://github.com/triggerdotdev/trigger.dev/pull/5071/files#diff-f006c57c96ce71764e9d04c8b60a58e1c5aee333b119c11a3f71c33e1dc89dbb
apps/webapp/app/components/dashboard-agent/alert-creation/draftPatch.tshttps://github.com/triggerdotdev/trigger.dev/pull/5071/files#diff-ea1e0dedae725677f9ad087d4ae8e1ac04907be90a1cfdc92d8b4881cb770cee
View file https://github.com/MilindChatrabhuji/trigger.dev/blob/6ee18b5842d86d48bbb79a72ddeac3827c430858/apps/webapp/app/components/dashboard-agent/alert-creation/draftPatch.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/5071/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/5071/files#diff-ea1e0dedae725677f9ad087d4ae8e1ac04907be90a1cfdc92d8b4881cb770cee
devin-ai-integrationhttps://github.com/apps/devin-ai-integration
Oct 26, 2026https://github.com/triggerdotdev/trigger.dev/pull/5071/files#r4375321437
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
server changes guidancehttps://github.com/triggerdotdev/trigger.dev/blob/6ee18b5842d86d48bbb79a72ddeac3827c430858/.server-changes/README.md#L5-L11
https://app.devin.ai/review/triggerdotdev/trigger.dev/pull/5071
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/5071/files
https://github.com/triggerdotdev/trigger.dev/pull/5071/files#diff-ea1e0dedae725677f9ad087d4ae8e1ac04907be90a1cfdc92d8b4881cb770cee
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.