René's URL Explorer Experiment


Title: fix(feature-flags): preserve valid org flags when stored flags contain invalid values (#5058) by MilindChatrabhuji · Pull Request #5070 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(feature-flags): preserve valid org flags when stored flags contain invalid values (#5058) by MilindChatrabhuji · Pull Request #5070 · triggerdotdev/trigger.dev

X Title: fix(feature-flags): preserve valid org flags when stored flags contain invalid values (#5058) by MilindChatrabhuji · Pull Request #5070 · triggerdotdev/trigger.dev

Description: Overview Fixes #5058 Problem In apps/webapp/app/v3/featureFlags.server.ts, mergeOrgFeatureFlags validated the entire orgFeatureFlags JSON blob at once with validatePartialFeatureFlags(orgFeatureFlags as Record). If an organization had even one invalid or obsolete stored flag value in Organization.featureFlags (which admin saves intentionally preserve), the whole validation failed and dropped all of the organization's valid flag overrides, falling back entirely to global defaults. In FeatureFlagsDialog.tsx: unsetFlag(key) deleted only next[key] without clearing derivedFlagsClearedWith(key), leaving derived grace-stamp flags like runOpsMintKindPrev and runOpsMintKindFlippedAt dangling in overrides. Checking "Unlock read-only flags" erroneously unlocked effect === "derived" grace-stamp rows into editable inputs even though they are server-computed. Solution In mergeOrgFeatureFlags, read parseStoredOrgFlags(orgFeatureFlags).valid instead of failing the entire object when an invalid flag is present. In FeatureFlagsDialog.tsx: Clear derivedFlagsClearedWith(key) inside unsetFlag. Keep effect === "derived" flags locked (read-only) even when unlocked is true. Added unit test in apps/webapp/test/storedOrgFlags.test.ts verifying that valid org feature flag overrides are preserved when an invalid flag is present in stored organization data. @algora-pbc /claim #5058

Open Graph Description: Overview Fixes #5058 Problem In apps/webapp/app/v3/featureFlags.server.ts, mergeOrgFeatureFlags validated the entire orgFeatureFlags JSON blob at once with validatePartialFeatureFlags(orgFeatureFl...

X Description: Overview Fixes #5058 Problem In apps/webapp/app/v3/featureFlags.server.ts, mergeOrgFeatureFlags validated the entire orgFeatureFlags JSON blob at once with validatePartialFeatureFlags(orgFeatureFl...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/5070

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9d25ebbb-5e38-8e3a-1975-be12df55744e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC88:1DFB79:2E34C00:4177FC1:6AFADB97
html-safe-noncedd9365d9e7bbc33c17bad59bacaf71c6c97699102ca753f40159d429891e2a12
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzg4OjFERkI3OToyRTM0QzAwOjQxNzdGQzE6NkFGQURCOTciLCJ2aXNpdG9yX2lkIjoiODI2NDMwMTY3NTMzNDUyMzc5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9cfdf10243d0a70a33a8dad1111cf073fd838b137845b2a2a94c296d8b0ce4b9
hovercard-subject-tagpull_request:5014383883
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/5070/files
twitter:imagehttps://avatars.githubusercontent.com/u/277298508?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/277298508?s=400&v=4
og:image:altOverview Fixes #5058 Problem In apps/webapp/app/v3/featureFlags.server.ts, mergeOrgFeatureFlags validated the entire orgFeatureFlags JSON blob at once with validatePartialFeatureFlags(orgFeatureFl...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None9d9bd51a568909a83d1abb9d6f74d68f0c87ca85fe3a56d3f5d70d8b89add9f2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a7ae932999cc6d511008dbf980ff9efad2a31f7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/5070/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F5070%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F5070%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/5070/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/5070/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/5070/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests65 (65)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
MilindChatrabhujihttps://github.com/MilindChatrabhuji
triggerdotdev:mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
MilindChatrabhuji:fix/merge-org-feature-flags-invalid-5058https://github.com/MilindChatrabhuji/trigger.dev/tree/fix/merge-org-feature-flags-invalid-5058
Conversation 6 https://github.com/triggerdotdev/trigger.dev/pull/5070
Commits 1 https://github.com/triggerdotdev/trigger.dev/pull/5070/commits
Checks 2 https://github.com/triggerdotdev/trigger.dev/pull/5070/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/5070/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/5070/files
fix(feature-flags): preserve valid org flags when stored flags contain invalid values (#5058) https://github.com/triggerdotdev/trigger.dev/pull/5070/files#top
Show all changes 1 commit https://github.com/triggerdotdev/trigger.dev/pull/5070/files
e74cc3a fix(feature-flags): preserve valid org flags when stored flags contai… MilindChatrabhuji Oct 26, 2026 https://github.com/triggerdotdev/trigger.dev/pull/5070/commits/e74cc3a9b3069cf80d07fbe87cee4cbd6d992f72
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/5070/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/5070/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/5070/files
FeatureFlagsDialog.tsx https://github.com/triggerdotdev/trigger.dev/pull/5070/files#diff-d14938e54e623f4a4d9668bad39cfd83db2ed5d310a530691757c242c28aea70
featureFlags.server.ts https://github.com/triggerdotdev/trigger.dev/pull/5070/files#diff-e8a7b59b28b50b634a54e1259a74256f1ee8eef32c00e655d5de093d6f388945
storedOrgFlags.test.ts https://github.com/triggerdotdev/trigger.dev/pull/5070/files#diff-ade2b64b13e1875750b090934304f4251734c8113e40a1cd8e4349cfc1c7063b
apps/webapp/app/components/admin/FeatureFlagsDialog.tsxhttps://github.com/triggerdotdev/trigger.dev/pull/5070/files#diff-d14938e54e623f4a4d9668bad39cfd83db2ed5d310a530691757c242c28aea70
View file https://github.com/MilindChatrabhuji/trigger.dev/blob/e74cc3a9b3069cf80d07fbe87cee4cbd6d992f72/apps/webapp/app/components/admin/FeatureFlagsDialog.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/5070/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/5070/files#diff-d14938e54e623f4a4d9668bad39cfd83db2ed5d310a530691757c242c28aea70
https://github.com/triggerdotdev/trigger.dev/pull/5070/files#diff-d14938e54e623f4a4d9668bad39cfd83db2ed5d310a530691757c242c28aea70
https://github.com/triggerdotdev/trigger.dev/pull/5070/files#diff-d14938e54e623f4a4d9668bad39cfd83db2ed5d310a530691757c242c28aea70
https://github.com/triggerdotdev/trigger.dev/pull/5070/files#diff-d14938e54e623f4a4d9668bad39cfd83db2ed5d310a530691757c242c28aea70
https://github.com/triggerdotdev/trigger.dev/pull/5070/files#diff-d14938e54e623f4a4d9668bad39cfd83db2ed5d310a530691757c242c28aea70
https://github.com/triggerdotdev/trigger.dev/pull/5070/files#diff-d14938e54e623f4a4d9668bad39cfd83db2ed5d310a530691757c242c28aea70
apps/webapp/app/v3/featureFlags.server.tshttps://github.com/triggerdotdev/trigger.dev/pull/5070/files#diff-e8a7b59b28b50b634a54e1259a74256f1ee8eef32c00e655d5de093d6f388945
View file https://github.com/MilindChatrabhuji/trigger.dev/blob/e74cc3a9b3069cf80d07fbe87cee4cbd6d992f72/apps/webapp/app/v3/featureFlags.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/5070/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/5070/files#diff-e8a7b59b28b50b634a54e1259a74256f1ee8eef32c00e655d5de093d6f388945
https://github.com/triggerdotdev/trigger.dev/pull/5070/files#diff-e8a7b59b28b50b634a54e1259a74256f1ee8eef32c00e655d5de093d6f388945
https://github.com/triggerdotdev/trigger.dev/pull/5070/files#diff-e8a7b59b28b50b634a54e1259a74256f1ee8eef32c00e655d5de093d6f388945
devin-ai-integrationhttps://github.com/apps/devin-ai-integration
Oct 26, 2026https://github.com/triggerdotdev/trigger.dev/pull/5070/files#r4375257724
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
OrganizationsPresenterhttps://github.com/triggerdotdev/trigger.dev/blob/e74cc3a9b3069cf80d07fbe87cee4cbd6d992f72/apps/webapp/app/presenters/OrganizationsPresenter.server.ts#L169-L178
https://app.devin.ai/review/triggerdotdev/trigger.dev/pull/5070
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/5070/files
https://github.com/triggerdotdev/trigger.dev/pull/5070/files#diff-e8a7b59b28b50b634a54e1259a74256f1ee8eef32c00e655d5de093d6f388945
apps/webapp/test/storedOrgFlags.test.tshttps://github.com/triggerdotdev/trigger.dev/pull/5070/files#diff-ade2b64b13e1875750b090934304f4251734c8113e40a1cd8e4349cfc1c7063b
View file https://github.com/MilindChatrabhuji/trigger.dev/blob/e74cc3a9b3069cf80d07fbe87cee4cbd6d992f72/apps/webapp/test/storedOrgFlags.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/5070/{{ revealButtonHref }}
devin-ai-integrationhttps://github.com/apps/devin-ai-integration
Oct 26, 2026https://github.com/triggerdotdev/trigger.dev/pull/5070/files#r4375257874
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://app.devin.ai/review/triggerdotdev/trigger.dev/pull/5070
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/5070/files
https://github.com/triggerdotdev/trigger.dev/pull/5070/files#diff-ade2b64b13e1875750b090934304f4251734c8113e40a1cd8e4349cfc1c7063b
https://github.com/triggerdotdev/trigger.dev/pull/5070/files#diff-ade2b64b13e1875750b090934304f4251734c8113e40a1cd8e4349cfc1c7063b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.