René's URL Explorer Experiment


Title: fix(core): match nested event filters when an ancestor key is missing… by Sadikdeveloper · Pull Request #5022 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(core): match nested event filters when an ancestor key is missing… by Sadikdeveloper · Pull Request #5022 · triggerdotdev/trigger.dev

X Title: fix(core): match nested event filters when an ancestor key is missing… by Sadikdeveloper · Pull Request #5022 · triggerdotdev/trigger.dev

Description: … or null eventFilterMatches returned false for any non-empty filter as soon as the payload was undefined/null, without evaluating the filter itself. Because missing nested keys recurse with an undefined payload, a nested $exists: false filter failed whenever its parent key was missing or null, while the same filter returned true at the top level. A nullish payload is now matched like an empty object, so a missing payload and a missing key take the same path. Only filters whose leaves already match a missing key change behavior: $exists: false, $isNull: false and $anythingBut now match a missing/null/non-object ancestor too, which is how $exists behaves on nested paths elsewhere (e.g. MongoDB) and how these filters already behaved for a missing key at the top level. Filters that require a value ($exists: true, $startsWith, $gt, value arrays, $includes, $not, ...) are unchanged. This is the user-facing path behind retry.fetch's bodyFilter, so a filter like { error: { retryAfter: [{ $exists: false }] } } now matches a response body with no error object instead of silently skipping the retry strategy. core: unit tests for missing/null/non-object ancestors, deep nesting, arrays, and guards proving positive filters don't over-match trigger-sdk: end-to-end tests for retry.fetch + bodyFilter against a local server Closes # ✅ Checklist I have followed every step in the contributing guide The PR title follows the convention. I ran and tested the code works Testing [Describe the steps you took to test this change] Changelog [Short description of what has changed] Screenshots [Screenshots] 💯

Open Graph Description: … or null eventFilterMatches returned false for any non-empty filter as soon as the payload was undefined/null, without evaluating the filter itself. Because missing nested keys recurse with an und...

X Description: … or null eventFilterMatches returned false for any non-empty filter as soon as the payload was undefined/null, without evaluating the filter itself. Because missing nested keys recurse with an und...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/5022

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e627e4c5-3a20-eceb-1d84-813e49263e79
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC638:19D56D:5F2F9DC:7EAE93F:6AFADB91
html-safe-nonceb662258fbcf3ea4dc39335a1736ab5b476215bb595d90ac447e262931e751082
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjM4OjE5RDU2RDo1RjJGOURDOjdFQUU5M0Y6NkFGQURCOTEiLCJ2aXNpdG9yX2lkIjoiNTQwODk2MDM2NTU4Njk5NjExMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac678ea8927a44859618dcf82e5c4d9744f07b971531bb6b9dfda1b04e4dbbfb81
hovercard-subject-tagpull_request:4827531699
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/5022/files
twitter:imagehttps://avatars.githubusercontent.com/u/26682501?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/26682501?s=400&v=4
og:image:alt… or null eventFilterMatches returned false for any non-empty filter as soon as the payload was undefined/null, without evaluating the filter itself. Because missing nested keys recurse with an und...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None9d9bd51a568909a83d1abb9d6f74d68f0c87ca85fe3a56d3f5d70d8b89add9f2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a7ae932999cc6d511008dbf980ff9efad2a31f7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/5022/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F5022%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F5022%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/5022/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/5022/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/5022/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests65 (65)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
Sadikdeveloperhttps://github.com/Sadikdeveloper
triggerdotdev:mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
Sadikdeveloper:arena/0e5c4aef-trigger-devhttps://github.com/Sadikdeveloper/trigger.dev/tree/arena/0e5c4aef-trigger-dev
Conversation 7 https://github.com/triggerdotdev/trigger.dev/pull/5022
Commits 1 https://github.com/triggerdotdev/trigger.dev/pull/5022/commits
Checks 2 https://github.com/triggerdotdev/trigger.dev/pull/5022/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/5022/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/5022/files
fix(core): match nested event filters when an ancestor key is missing… https://github.com/triggerdotdev/trigger.dev/pull/5022/files#top
Show all changes 1 commit https://github.com/triggerdotdev/trigger.dev/pull/5022/files
71e2fea fix(core): match nested event filters when an ancestor key is missing… Sadikdeveloper Oct 12, 2026 https://github.com/triggerdotdev/trigger.dev/pull/5022/commits/71e2fea729e9985c08a7486773d2fe05f594c9f2
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/5022/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/5022/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/5022/files
nested-event-filter-exists-false.md https://github.com/triggerdotdev/trigger.dev/pull/5022/files#diff-fc7d2c77186c6c26b84fdaa67fdc1ae5deb009649e8822d6efbc258fd5d6f9a7
eventFilterMatches.ts https://github.com/triggerdotdev/trigger.dev/pull/5022/files#diff-1e15ed4c444401f5cedbd2b1abeec6ef82edbf399906bcbfcbcac7deecd82943
eventFilterMatches.test.ts https://github.com/triggerdotdev/trigger.dev/pull/5022/files#diff-536280d9150b93d49dac4ea2c5ab2069bd516be1b5921fb8e11afaf7bedb572a
retry.test.ts https://github.com/triggerdotdev/trigger.dev/pull/5022/files#diff-3539dabda42099228655b354dbd911d9e5196572a8652e9640cb30e689614623
.changeset/nested-event-filter-exists-false.mdhttps://github.com/triggerdotdev/trigger.dev/pull/5022/files#diff-fc7d2c77186c6c26b84fdaa67fdc1ae5deb009649e8822d6efbc258fd5d6f9a7
View file https://github.com/Sadikdeveloper/trigger.dev/blob/71e2fea729e9985c08a7486773d2fe05f594c9f2/.changeset/nested-event-filter-exists-false.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/5022/{{ revealButtonHref }}
devin-ai-integrationhttps://github.com/apps/devin-ai-integration
Oct 12, 2026https://github.com/triggerdotdev/trigger.dev/pull/5022/files#r4246550159
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://app.devin.ai/review/triggerdotdev/trigger.dev/pull/5022
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/5022/files
packages/core/src/eventFilterMatches.tshttps://github.com/triggerdotdev/trigger.dev/pull/5022/files#diff-1e15ed4c444401f5cedbd2b1abeec6ef82edbf399906bcbfcbcac7deecd82943
View file https://github.com/Sadikdeveloper/trigger.dev/blob/71e2fea729e9985c08a7486773d2fe05f594c9f2/packages/core/src/eventFilterMatches.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/5022/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/5022/files#diff-1e15ed4c444401f5cedbd2b1abeec6ef82edbf399906bcbfcbcac7deecd82943
devin-ai-integrationhttps://github.com/apps/devin-ai-integration
Oct 12, 2026https://github.com/triggerdotdev/trigger.dev/pull/5022/files#r4246549972
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
getRetryStrategyForResponsehttps://github.com/triggerdotdev/trigger.dev/blob/71e2fea729e9985c08a7486773d2fe05f594c9f2/packages/trigger-sdk/src/v3/retry.ts#L430-L467
https://app.devin.ai/review/triggerdotdev/trigger.dev/pull/5022
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/5022/files
https://github.com/triggerdotdev/trigger.dev/pull/5022/files#diff-1e15ed4c444401f5cedbd2b1abeec6ef82edbf399906bcbfcbcac7deecd82943
packages/core/test/eventFilterMatches.test.tshttps://github.com/triggerdotdev/trigger.dev/pull/5022/files#diff-536280d9150b93d49dac4ea2c5ab2069bd516be1b5921fb8e11afaf7bedb572a
View file https://github.com/Sadikdeveloper/trigger.dev/blob/71e2fea729e9985c08a7486773d2fe05f594c9f2/packages/core/test/eventFilterMatches.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/5022/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/5022/files#diff-536280d9150b93d49dac4ea2c5ab2069bd516be1b5921fb8e11afaf7bedb572a
https://github.com/triggerdotdev/trigger.dev/pull/5022/files#diff-536280d9150b93d49dac4ea2c5ab2069bd516be1b5921fb8e11afaf7bedb572a
https://github.com/triggerdotdev/trigger.dev/pull/5022/files#diff-536280d9150b93d49dac4ea2c5ab2069bd516be1b5921fb8e11afaf7bedb572a
https://github.com/triggerdotdev/trigger.dev/pull/5022/files#diff-536280d9150b93d49dac4ea2c5ab2069bd516be1b5921fb8e11afaf7bedb572a
https://github.com/triggerdotdev/trigger.dev/pull/5022/files#diff-536280d9150b93d49dac4ea2c5ab2069bd516be1b5921fb8e11afaf7bedb572a
https://github.com/triggerdotdev/trigger.dev/pull/5022/files#diff-536280d9150b93d49dac4ea2c5ab2069bd516be1b5921fb8e11afaf7bedb572a
https://github.com/triggerdotdev/trigger.dev/pull/5022/files#diff-536280d9150b93d49dac4ea2c5ab2069bd516be1b5921fb8e11afaf7bedb572a
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/5022/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.