René's URL Explorer Experiment


Title: fix(core): accept IPC acks for void callbacks under zod 4.4+ by NERLOE · Pull Request #4980 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(core): accept IPC acks for void callbacks under zod 4.4+ by NERLOE · Pull Request #4980 · triggerdotdev/trigger.dev

X Title: fix(core): accept IPC acks for void callbacks under zod 4.4+ by NERLOE · Pull Request #4980 · triggerdotdev/trigger.dev

Description: Closes #4979 Credit to @marcus-dk for finding and root-causing this in #4979, including the zod version bisect and the end-to-end confirmation with a patched worker. Summary FLUSH and CANCEL declare callback: z.void(), so the task run process acks them with { type: "ACK", id, message: undefined }. Node's JSON IPC serialization drops the undefined message key. Under zod 4.4+ a z.any() object key is required at parse time (it was optional under zod 3 and 4.0–4.3), so Packet.safeParse rejects every such ack, #handlePacket returns silently, and sendWithAck waits out its full timeout. Because zodIpc.ts imports zod/v4 and @trigger.dev/core resolves zod from the user's project, every project on zod ≥ 4.4 pays this on every run: ~6 s between the task finishing and the completion reaching the engine (FLUSH: 5 s + 1 s), and ~31 s on cancel. The fix makes the ACK packet's message optional again (z.any().optional()). Only the ACK packet can legitimately carry undefined, so the other packets are unchanged. ✅ Checklist I have followed every step in the contributing guide The PR title follows the convention. I ran and tested the code works Testing Added packages/core/test/zodIpc.test.ts: forks a real child process (test/fixtures/zodIpcChild.ts) and sends FLUSH (void callback) and PING (payload callback) over Node's IPC channel, so the ack goes through the same JSON serialization as between a worker and its task run process. On main (zod 4.5.4 in this repo) the void-callback test fails with sendWithAck() timeout; with the fix it resolves immediately. pnpm run build --filter @trigger.dev/core passes. Production evidence from our self-hosted instance (completed_at - started_at - usage_duration_ms on successful runs): SDK runs p10 gap p50 gap 4.5.12 2.6M 179 ms 244 ms 4.5.15 5.0M 176 ms 251 ms 4.6.0 1.6M 6,162 ms 6,196 ms 4.6.2 4.0M 6,180 ms 6,240 ms Changelog Fix a ~6 second delay between a task finishing and its run completing (and a ~31 second delay when cancelling a run) in projects that use zod 4.4 or newer. 🤖 Generated with Claude Code

Open Graph Description: Closes #4979 Credit to @marcus-dk for finding and root-causing this in #4979, including the zod version bisect and the end-to-end confirmation with a patched worker. Summary FLUSH and CANCEL declar...

X Description: Closes #4979 Credit to @marcus-dk for finding and root-causing this in #4979, including the zod version bisect and the end-to-end confirmation with a patched worker. Summary FLUSH and CANCEL declar...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4980

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:99eaab9a-3a48-ddec-8fea-ef4eb41fd41e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id83E2:D23AD:353638B:4872020:6AFAF09A
html-safe-nonce2af0dd5a3b1d3178f9f90883fc1179fd6899d9cc282c086e8572ce0fda82e173
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4M0UyOkQyM0FEOjM1MzYzOEI6NDg3MjAyMDo2QUZBRjA5QSIsInZpc2l0b3JfaWQiOiI3MjczODIwNzIxNTM1MTg1MDUwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac89a96da793de68da8f488288a216b9e97e380f4aa8f0131f0f51094c84fc10f9
hovercard-subject-tagpull_request:4637391834
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4980/files
twitter:imagehttps://avatars.githubusercontent.com/u/32075361?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/32075361?s=400&v=4
og:image:altCloses #4979 Credit to @marcus-dk for finding and root-causing this in #4979, including the zod version bisect and the end-to-end confirmation with a patched worker. Summary FLUSH and CANCEL declar...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea85e96a83bed7871993e6b1ffda24105928eee17
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4980/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4980%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4980%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4980/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4980/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4980/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
matt-aitkenhttps://github.com/matt-aitken
triggerdotdev:mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
NERLOE:fix/zod-ipc-ack-optional-messagehttps://github.com/NERLOE/trigger.dev/tree/fix/zod-ipc-ack-optional-message
Conversation 13 https://github.com/triggerdotdev/trigger.dev/pull/4980
Commits 4 https://github.com/triggerdotdev/trigger.dev/pull/4980/commits
Checks 71 https://github.com/triggerdotdev/trigger.dev/pull/4980/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/4980/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4980/files
fix(core): accept IPC acks for void callbacks under zod 4.4+ https://github.com/triggerdotdev/trigger.dev/pull/4980/files#top
Show all changes 4 commits https://github.com/triggerdotdev/trigger.dev/pull/4980/files
a993aeb fix(core): accept IPC acks for void callbacks under zod 4.4+ NERLOE Sep 25, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4980/commits/a993aeb8af44c6885d934a875da4bb3c61c63f1b
67c7ca8 test(core): drop the timing assertion from the zodIpc ack test NERLOE Sep 25, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4980/commits/67c7ca8070cdfb8193fbaf56e05c6a93d0eb2056
edbe557 test(core): exercise zodIpc acks over a real forked child NERLOE Sep 25, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4980/commits/edbe5571cffdc77ca8f1b6a9ec141747abcbd97b
f5dd1bc Make it clear billed usage wasn't impacted for the release notes matt-aitken Sep 25, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4980/commits/f5dd1bc9350de9626809e6ae19a3fb314680f626
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/4980/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4980/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4980/files
void-ipc-acks.md https://github.com/triggerdotdev/trigger.dev/pull/4980/files#diff-fc58c512097b7de190c19275969398f2c4efcd656aec1810a48728f13bf36851
zodIpc.ts https://github.com/triggerdotdev/trigger.dev/pull/4980/files#diff-29766a2764b2ebfb19522845b7d380f6e83eaedb182b12b643a9a32bb5665d4d
zodIpcCatalog.ts https://github.com/triggerdotdev/trigger.dev/pull/4980/files#diff-3838c9bd449e87596a1619d2deb6be28c1e139102f959d327ea35ec2b18224ae
zodIpcChild.ts https://github.com/triggerdotdev/trigger.dev/pull/4980/files#diff-427076bb083d9ae5b15ee237304229660c96c60d39c231df75e421eae78f5501
zodIpc.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4980/files#diff-db70624fc6a636ef0c0fedfdafd06c1780b07983ccc5e15455dd95a95c5bd839
.changeset/void-ipc-acks.mdhttps://github.com/triggerdotdev/trigger.dev/pull/4980/files#diff-fc58c512097b7de190c19275969398f2c4efcd656aec1810a48728f13bf36851
View file https://github.com/NERLOE/trigger.dev/blob/f5dd1bc9350de9626809e6ae19a3fb314680f626/.changeset/void-ipc-acks.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4980/{{ revealButtonHref }}
packages/core/src/v3/zodIpc.tshttps://github.com/triggerdotdev/trigger.dev/pull/4980/files#diff-29766a2764b2ebfb19522845b7d380f6e83eaedb182b12b643a9a32bb5665d4d
View file https://github.com/NERLOE/trigger.dev/blob/f5dd1bc9350de9626809e6ae19a3fb314680f626/packages/core/src/v3/zodIpc.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4980/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4980/files#diff-29766a2764b2ebfb19522845b7d380f6e83eaedb182b12b643a9a32bb5665d4d
https://github.com/triggerdotdev/trigger.dev/pull/4980/files#diff-29766a2764b2ebfb19522845b7d380f6e83eaedb182b12b643a9a32bb5665d4d
packages/core/test/fixtures/zodIpcCatalog.tshttps://github.com/triggerdotdev/trigger.dev/pull/4980/files#diff-3838c9bd449e87596a1619d2deb6be28c1e139102f959d327ea35ec2b18224ae
View file https://github.com/NERLOE/trigger.dev/blob/f5dd1bc9350de9626809e6ae19a3fb314680f626/packages/core/test/fixtures/zodIpcCatalog.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4980/{{ revealButtonHref }}
packages/core/test/fixtures/zodIpcChild.tshttps://github.com/triggerdotdev/trigger.dev/pull/4980/files#diff-427076bb083d9ae5b15ee237304229660c96c60d39c231df75e421eae78f5501
View file https://github.com/NERLOE/trigger.dev/blob/f5dd1bc9350de9626809e6ae19a3fb314680f626/packages/core/test/fixtures/zodIpcChild.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4980/{{ revealButtonHref }}
packages/core/test/zodIpc.test.tshttps://github.com/triggerdotdev/trigger.dev/pull/4980/files#diff-db70624fc6a636ef0c0fedfdafd06c1780b07983ccc5e15455dd95a95c5bd839
View file https://github.com/NERLOE/trigger.dev/blob/f5dd1bc9350de9626809e6ae19a3fb314680f626/packages/core/test/zodIpc.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4980/{{ revealButtonHref }}
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4980/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4980/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.