René's URL Explorer Experiment


Title: fix: stop retrying silent chat streams indefinitely by gtremper · Pull Request #4949 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix: stop retrying silent chat streams indefinitely by gtremper · Pull Request #4949 · triggerdotdev/trigger.dev

X Title: fix: stop retrying silent chat streams indefinitely by gtremper · Pull Request #4949 · triggerdotdev/trigger.dev

Description: When the server returns 200 without records, chat subscriptions can retry indefinitely. The client stall timer fires after 60 seconds, before S2 closes the response at its 120-second timeout, so the existing EOF budget never applies. Terminal failures also leave persisted isStreaming state active, so a reload starts another subscription. Normal chat subscriptions now permit five reconnects after stall timeouts. A separate stall counter preserves unlimited retries for retryable connection failures, fetch timeouts, and browser wakeups. Decoded records restore the stall budget. Terminal failures clear state only for the owning subscription, and watch subscriptions remain unlimited. The existing stall timer already ignores keepalives because the parser drops them before the timer reset. The comment correction does not change that behavior. Checklist The PR title follows the contribution convention. The changes include tests and a changeset. Local package builds, formatting, lint, and knip passed. Maintainer CI and reference-project validation. Testing Regression tests reproduce timeout exhaustion, indefinite stalls, stale terminal state, and recovery beyond five connection failures. Full suites at 8149b96: 695 SDK tests and 1,122 core tests passed. Final error-message and constructor changes: all 43 stream tests passed. Core and SDK builds passed. Repository formatting, lint, and knip passed. General and security review passes found no remaining defects. The debug-marker check reports existing markers in apps/webapp/app/services/previewAutoArchive.server.ts; the changed files contain none. The tests use local HTTP servers. They cover separate stall limits, fetch timeouts, body failures, keepalives, progress resets, mixed failures, wakeups, cancellation, watch recovery, and replacement ownership. Core tests exercise stall exhaustion with short timers. The SDK's six-minute silence window needs reference-project validation. Changelog Silent chat subscriptions now report Stream stalled: no records received after five stall retries. Network failures retain automatic recovery, and watch subscriptions remain unlimited. Risk Condition Result Retryable connection or fetch failure No finite retry deadline; exponential backoff continues Repeated connected silence The sixth 60-second stall ends the subscription Browser wake or online event Reconnect without consuming or restoring the stall budget With immediate response headers, six silent attempts take 368.5–377 seconds, about 6.1–6.3 minutes. Network delays extend this window. A healthy tool call with no records can also reach this limit: silence does not prove that the run is dead. The terminal error stops automatic client resumption but does not cancel the server-side run. Shared core consumers retain their configured retry limits. Repeated successful responses without records now increase backoff until a decoded record arrives. Caller cancellation and token-refresh limits remain unchanged.

Open Graph Description: When the server returns 200 without records, chat subscriptions can retry indefinitely. The client stall timer fires after 60 seconds, before S2 closes the response at its 120-second timeout, so th...

X Description: When the server returns 200 without records, chat subscriptions can retry indefinitely. The client stall timer fires after 60 seconds, before S2 closes the response at its 120-second timeout, so th...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4949

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fd46cb0f-40bd-a716-1860-b90e925261ef
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id85EA:3FB3E8:2EC66C5:42F7919:6AFAF197
html-safe-nonce507919581b7a13c1b82d78afb478f1e7637f2e5ba956fa92e0d02a02c159ae8b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NUVBOjNGQjNFODoyRUM2NkM1OjQyRjc5MTk6NkFGQUYxOTciLCJ2aXNpdG9yX2lkIjoiNTg4Mjc2MTMxODIwMTM4OTAzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca3cce7f98cb7f9df773dbb9c30997607ac716cfa875fdc2172e9d03c7a6420f8
hovercard-subject-tagpull_request:4561680019
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4949/files
twitter:imagehttps://avatars.githubusercontent.com/u/1009134?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1009134?s=400&v=4
og:image:altWhen the server returns 200 without records, chat subscriptions can retry indefinitely. The client stall timer fires after 60 seconds, before S2 closes the response at its 120-second timeout, so th...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea85e96a83bed7871993e6b1ffda24105928eee17
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4949/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4949%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4949%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4949/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4949/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4949/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
ericallamhttps://github.com/ericallam
triggerdotdev:mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
gtremper:fix/chat-stream-retry-exhaustionhttps://github.com/gtremper/trigger.dev/tree/fix/chat-stream-retry-exhaustion
Conversation 3 https://github.com/triggerdotdev/trigger.dev/pull/4949
Commits 4 https://github.com/triggerdotdev/trigger.dev/pull/4949/commits
Checks 73 https://github.com/triggerdotdev/trigger.dev/pull/4949/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/4949/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4949/files
fix: stop retrying silent chat streams indefinitely https://github.com/triggerdotdev/trigger.dev/pull/4949/files#top
Show all changes 4 commits https://github.com/triggerdotdev/trigger.dev/pull/4949/files
10f1d02 fix: stop retrying failed chat streams indefinitely gtremper Sep 17, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4949/commits/10f1d02f534ff353e421ad3dd94d2ee5f9f61d9a
8149b96 fix: preserve network recovery with a separate stall limit gtremper Sep 17, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4949/commits/8149b9649ea81b954442f69b9fa220b74f227995
68398fd fix: distinguish stall exhaustion errors gtremper Sep 17, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4949/commits/68398fd72e7ac9c3fd0e27b5f797cddf5b75dd5a
7825d1b docs: name the stall exhaustion error in release notes gtremper Sep 17, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4949/commits/7825d1b84eb481a298132a0f4c3d05b6ac91f5fb
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/4949/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4949/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4949/files
quiet-chat-stream-retries.md https://github.com/triggerdotdev/trigger.dev/pull/4949/files#diff-27ff1a0e06b41e9945170b90b13de9a6376a61e3a7c4451c6a0cf03d923eebad
runStream-retries.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4949/files#diff-22369827399cbc39c7453dbc7585e260b89c87315713f6e2d75a5daa1c86462b
runStream.ts https://github.com/triggerdotdev/trigger.dev/pull/4949/files#diff-a39862a1fd92dcce12a5b075973bf8a25fe1b62bd4d35a24c9ac7291a06222b6
chat-retries.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4949/files#diff-11023546438895d2d075c0250cdb6c73f042c24fbff82b20c95c245fadf468b3
chat.ts https://github.com/triggerdotdev/trigger.dev/pull/4949/files#diff-fcabf40729dcab619f789d289291c0187dcc76366e51bf53dfe5bb6225587420
.changeset/quiet-chat-stream-retries.mdhttps://github.com/triggerdotdev/trigger.dev/pull/4949/files#diff-27ff1a0e06b41e9945170b90b13de9a6376a61e3a7c4451c6a0cf03d923eebad
View file https://github.com/gtremper/trigger.dev/blob/7825d1b84eb481a298132a0f4c3d05b6ac91f5fb/.changeset/quiet-chat-stream-retries.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4949/{{ revealButtonHref }}
packages/core/src/v3/apiClient/runStream-retries.test.tshttps://github.com/triggerdotdev/trigger.dev/pull/4949/files#diff-22369827399cbc39c7453dbc7585e260b89c87315713f6e2d75a5daa1c86462b
View file https://github.com/gtremper/trigger.dev/blob/7825d1b84eb481a298132a0f4c3d05b6ac91f5fb/packages/core/src/v3/apiClient/runStream-retries.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4949/{{ revealButtonHref }}
packages/core/src/v3/apiClient/runStream.tshttps://github.com/triggerdotdev/trigger.dev/pull/4949/files#diff-a39862a1fd92dcce12a5b075973bf8a25fe1b62bd4d35a24c9ac7291a06222b6
View file https://github.com/gtremper/trigger.dev/blob/7825d1b84eb481a298132a0f4c3d05b6ac91f5fb/packages/core/src/v3/apiClient/runStream.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4949/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4949/files#diff-a39862a1fd92dcce12a5b075973bf8a25fe1b62bd4d35a24c9ac7291a06222b6
https://github.com/triggerdotdev/trigger.dev/pull/4949/files#diff-a39862a1fd92dcce12a5b075973bf8a25fe1b62bd4d35a24c9ac7291a06222b6
https://github.com/triggerdotdev/trigger.dev/pull/4949/files#diff-a39862a1fd92dcce12a5b075973bf8a25fe1b62bd4d35a24c9ac7291a06222b6
https://github.com/triggerdotdev/trigger.dev/pull/4949/files#diff-a39862a1fd92dcce12a5b075973bf8a25fe1b62bd4d35a24c9ac7291a06222b6
https://github.com/triggerdotdev/trigger.dev/pull/4949/files#diff-a39862a1fd92dcce12a5b075973bf8a25fe1b62bd4d35a24c9ac7291a06222b6
https://github.com/triggerdotdev/trigger.dev/pull/4949/files#diff-a39862a1fd92dcce12a5b075973bf8a25fe1b62bd4d35a24c9ac7291a06222b6
https://github.com/triggerdotdev/trigger.dev/pull/4949/files#diff-a39862a1fd92dcce12a5b075973bf8a25fe1b62bd4d35a24c9ac7291a06222b6
https://github.com/triggerdotdev/trigger.dev/pull/4949/files#diff-a39862a1fd92dcce12a5b075973bf8a25fe1b62bd4d35a24c9ac7291a06222b6
https://github.com/triggerdotdev/trigger.dev/pull/4949/files#diff-a39862a1fd92dcce12a5b075973bf8a25fe1b62bd4d35a24c9ac7291a06222b6
https://github.com/triggerdotdev/trigger.dev/pull/4949/files#diff-a39862a1fd92dcce12a5b075973bf8a25fe1b62bd4d35a24c9ac7291a06222b6
https://github.com/triggerdotdev/trigger.dev/pull/4949/files#diff-a39862a1fd92dcce12a5b075973bf8a25fe1b62bd4d35a24c9ac7291a06222b6
https://github.com/triggerdotdev/trigger.dev/pull/4949/files#diff-a39862a1fd92dcce12a5b075973bf8a25fe1b62bd4d35a24c9ac7291a06222b6
https://github.com/triggerdotdev/trigger.dev/pull/4949/files#diff-a39862a1fd92dcce12a5b075973bf8a25fe1b62bd4d35a24c9ac7291a06222b6
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4949/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4949/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.