René's URL Explorer Experiment


Title: fix(cli): report build log stream failures clearly and exit instead of hanging by myftija · Pull Request #4887 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(cli): report build log stream failures clearly and exit instead of hanging by myftija · Pull Request #4887 · triggerdotdev/trigger.dev

X Title: fix(cli): report build log stream failures clearly and exit instead of hanging by myftija · Pull Request #4887 · triggerdotdev/trigger.dev

Description: When the build log stream failed during a build server deploy, the CLI printed the raw stream error (e.g. X Error: Invalid access token) and then hung the process. Only the log stream was lost, the deployment itself kept running. The CLI now stops the spinner, says the log stream failed and that the deployment continues on the build server, links the dashboard, and exits 1 right away. The non-zero exit is deliberate: the CLI can no longer confirm the outcome. Failing to open the stream now behaves the same way instead of exiting 0. Fix One handler for both stream failures that prints the message and throws an OutroCommandError, which exits the process instead of waiting for open handles. Return from the event loop on the finalized event, which cancels the read session directly. A late transport error can no longer discard a result already received or keep the stream reconnecting after the build is done.

Open Graph Description: When the build log stream failed during a build server deploy, the CLI printed the raw stream error (e.g. X Error: Invalid access token) and then hung the process. Only the log stream was lost, the...

X Description: When the build log stream failed during a build server deploy, the CLI printed the raw stream error (e.g. X Error: Invalid access token) and then hung the process. Only the log stream was lost, the...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4887

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d2d21f24-302b-9baa-bc18-6f6100611141
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idECAE:191BB2:2938D7:3AC101:6AFAFB47
html-safe-noncefd557dd0807f64c7d8eed68291703ffe866cc3dc2188148abe0f6217e44e02d1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0FFOjE5MUJCMjoyOTM4RDc6M0FDMTAxOjZBRkFGQjQ3IiwidmlzaXRvcl9pZCI6IjU5NzE3NzkxNTkyOTcwMzA5ODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacae35f6ad304b93fb9b7c60ddfa6479a7efb5636b5eb33da937b5a7126af6a6e6
hovercard-subject-tagpull_request:4441452424
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4887/files
twitter:imagehttps://avatars.githubusercontent.com/u/19681398?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/19681398?s=400&v=4
og:image:altWhen the build log stream failed during a build server deploy, the CLI printed the raw stream error (e.g. X Error: Invalid access token) and then hung the process. Only the log stream was lost, the...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None54f7a6886649661c85eee945cca0773566bfb4065370e0429b7c8f7204184650
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecf8450eb633ec589502c42ff6f4072e40db65da3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4887/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4887%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4887%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4887/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4887/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4887/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
myftijahttps://github.com/myftija
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
fix/cli-deploy-log-stream-errorhttps://github.com/triggerdotdev/trigger.dev/tree/fix/cli-deploy-log-stream-error
Conversation 10 https://github.com/triggerdotdev/trigger.dev/pull/4887
Commits 6 https://github.com/triggerdotdev/trigger.dev/pull/4887/commits
Checks 65 https://github.com/triggerdotdev/trigger.dev/pull/4887/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/4887/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4887/files
fix(cli): report build log stream failures clearly and exit instead of hanging https://github.com/triggerdotdev/trigger.dev/pull/4887/files#top
Show all changes 6 commits https://github.com/triggerdotdev/trigger.dev/pull/4887/files
d36ccae fix(cli): report build log stream disconnects clearly and exit instea… myftija Sep 4, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4887/commits/d36ccae7c30b7753f5d4b70c5c9942c3e6b5e2f1
222e8a6 fix(cli): stop reading the build log stream once the finalized event … myftija Sep 4, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4887/commits/222e8a649e4d765f0d2f6326a1c310b2c348aeff
123f091 fix(cli): neutral wording and bounded cause for build log stream fail… myftija Sep 4, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4887/commits/123f091e7330f17328b9d9af1f108d18eecf15a0
67e4c2d fix(cli): exit non-zero when the build log stream cannot be opened myftija Sep 4, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4887/commits/67e4c2dda635400b91d0fa68adba3933e67a3804
0fe474b test(cli): use plain callbacks in the finalized-stream test myftija Sep 4, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4887/commits/0fe474b314491d5392411506b1c325b98104b046
2a0691b fix(cli): import BuildLogRenderer as a type myftija Sep 4, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4887/commits/2a0691b194903294aa5b28534c744ffc4147fc98
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/4887/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4887/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4887/files
deploy-log-stream-disconnect.md https://github.com/triggerdotdev/trigger.dev/pull/4887/files#diff-5cd0a7a0df35f733cac1580ea6b0cb4bca61814ba3385a95efcaa7c1f04182d9
deploy.ts https://github.com/triggerdotdev/trigger.dev/pull/4887/files#diff-d7f5aeaec81b32b65d3e217c379ac8bf3616076254b49e6717c79a44265a6aa1
buildLogs.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4887/files#diff-3afe16abccae07186e182d795d2d9172149f60501863d1ab904e77a08a422003
buildLogs.ts https://github.com/triggerdotdev/trigger.dev/pull/4887/files#diff-fc0f1f7e66126b7286647b242ccf80e1e51f2e4f19f3ea5d72792f3a74d39994
.changeset/deploy-log-stream-disconnect.mdhttps://github.com/triggerdotdev/trigger.dev/pull/4887/files#diff-5cd0a7a0df35f733cac1580ea6b0cb4bca61814ba3385a95efcaa7c1f04182d9
View file https://github.com/triggerdotdev/trigger.dev/blob/2a0691b194903294aa5b28534c744ffc4147fc98/.changeset/deploy-log-stream-disconnect.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4887/{{ revealButtonHref }}
packages/cli-v3/src/commands/deploy.tshttps://github.com/triggerdotdev/trigger.dev/pull/4887/files#diff-d7f5aeaec81b32b65d3e217c379ac8bf3616076254b49e6717c79a44265a6aa1
View file https://github.com/triggerdotdev/trigger.dev/blob/2a0691b194903294aa5b28534c744ffc4147fc98/packages/cli-v3/src/commands/deploy.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4887/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4887/files#diff-d7f5aeaec81b32b65d3e217c379ac8bf3616076254b49e6717c79a44265a6aa1
https://github.com/triggerdotdev/trigger.dev/pull/4887/files#diff-d7f5aeaec81b32b65d3e217c379ac8bf3616076254b49e6717c79a44265a6aa1
https://github.com/triggerdotdev/trigger.dev/pull/4887/files#diff-d7f5aeaec81b32b65d3e217c379ac8bf3616076254b49e6717c79a44265a6aa1
https://github.com/triggerdotdev/trigger.dev/pull/4887/files#diff-d7f5aeaec81b32b65d3e217c379ac8bf3616076254b49e6717c79a44265a6aa1
https://github.com/triggerdotdev/trigger.dev/pull/4887/files#diff-d7f5aeaec81b32b65d3e217c379ac8bf3616076254b49e6717c79a44265a6aa1
https://github.com/triggerdotdev/trigger.dev/pull/4887/files#diff-d7f5aeaec81b32b65d3e217c379ac8bf3616076254b49e6717c79a44265a6aa1
packages/cli-v3/src/deploy/buildLogs.test.tshttps://github.com/triggerdotdev/trigger.dev/pull/4887/files#diff-3afe16abccae07186e182d795d2d9172149f60501863d1ab904e77a08a422003
View file https://github.com/triggerdotdev/trigger.dev/blob/2a0691b194903294aa5b28534c744ffc4147fc98/packages/cli-v3/src/deploy/buildLogs.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4887/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4887/files#diff-3afe16abccae07186e182d795d2d9172149f60501863d1ab904e77a08a422003
https://github.com/triggerdotdev/trigger.dev/pull/4887/files#diff-3afe16abccae07186e182d795d2d9172149f60501863d1ab904e77a08a422003
packages/cli-v3/src/deploy/buildLogs.tshttps://github.com/triggerdotdev/trigger.dev/pull/4887/files#diff-fc0f1f7e66126b7286647b242ccf80e1e51f2e4f19f3ea5d72792f3a74d39994
View file https://github.com/triggerdotdev/trigger.dev/blob/2a0691b194903294aa5b28534c744ffc4147fc98/packages/cli-v3/src/deploy/buildLogs.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4887/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4887/files#diff-fc0f1f7e66126b7286647b242ccf80e1e51f2e4f19f3ea5d72792f3a74d39994
https://github.com/triggerdotdev/trigger.dev/pull/4887/files#diff-fc0f1f7e66126b7286647b242ccf80e1e51f2e4f19f3ea5d72792f3a74d39994
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4887/files
https://github.com/triggerdotdev/trigger.dev/pull/4887/files#diff-fc0f1f7e66126b7286647b242ccf80e1e51f2e4f19f3ea5d72792f3a74d39994
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4887/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.