René's URL Explorer Experiment


Title: fix(build): playwright extension parses the Playwright 1.58+ `install --dry-run` output by NERLOE · Pull Request #4881 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(build): playwright extension parses the Playwright 1.58+ `install --dry-run` output by NERLOE · Pull Request #4881 · triggerdotdev/trigger.dev

X Title: fix(build): playwright extension parses the Playwright 1.58+ `install --dry-run` output by NERLOE · Pull Request #4881 · triggerdotdev/trigger.dev

Description: Fixes #3089 Problem The playwright build extension reads npx playwright install --dry-run to find each browser's install directory and download URL. Playwright 1.58 changed the per-browser header, so the extension's grep finds nothing and the image build fails at that step with exit code 1: < 1.58 browser: chromium-headless-shell version 143.0.7499.4 >= 1.58 Chrome Headless Shell 151.0.7922.34 (playwright chromium-headless-shell v1234) There is a second problem hiding behind the first. The old blocks were five lines (install location, download url, two fallback urls, blank), so grep -A5 was exact. The Chrome-for-Testing blocks in 1.58+ (chromium and chromium-headless-shell, the default install) are three lines (install location, download url, blank; Firefox and WebKit still print the fallbacks), so -A5 runs into the next browser's Install location: line. The downstream grep "Install location:" | cut | xargs then joins two paths and basename returns the next browser's directory: with the header grep alone fixed, chromium-headless-shell gets unpacked into firefox-/. Any grep-only fix (including the pnpm patch shared in #3089) has this bug. Fix The header match accepts both formats: grep -E "browser: |\(playwright v". The trailing space / v keep chromium from matching the chromium-headless-shell block in either format. The context window is narrowed to -A2, the two lines the extension actually reads. Both formats put Install location: and Download url: immediately after the header. A unit test asserts the generated header pattern selects each browser's block in both formats and never another browser's. I left the sed "s/mac-arm64/linux/g" rewrite alone, and I do not think the "dead linux64 URLs" report in #3089 is reachable from the extension. The --dry-run executes inside the Linux build container, so the URL it prints is already the Linux one and there is nothing for the rewrite to match. Checked by running the same command in a container: $ docker run --rm --platform linux/amd64 node:22-bookworm-slim \ sh -c 'npx -y playwright@1.62.0 install --dry-run' Chrome Headless Shell 151.0.7922.34 (playwright chromium-headless-shell v1234) Download url: https://cdn.playwright.dev/builds/cft/151.0.7922.34/linux64/chrome-headless-shell-linux64.zip Firefox 153.0 (playwright firefox v1538) Download url: https://cdn.playwright.dev/dbazure/download/playwright/builds/firefox/1538/firefox-debian-12.zip Rewriting mac-arm64 to linux64 would also be wrong for < 1.58, where the Linux artifact is …-linux.zip, so changing it would trade a dead branch for an incorrect one. Verification Ran the generated extraction (grep -A2 -m1 -E … | grep "Install location:" | cut | xargs | basename, and the same for Download url:) against real --dry-run output from Playwright 1.57.0 and 1.62.0, for all four browser keys: output browser directory url 1.57 chromium chromium-1200 chromium-linux.zip 1.57 chromium-headless-shell chromium_headless_shell-1200 chromium-headless-shell-linux.zip 1.57 firefox firefox-1497 firefox-linux.zip 1.57 webkit webkit-2227 webkit-ubuntu-20.04.zip 1.62 chromium chromium-1234 chrome-linux.zip 1.62 chromium-headless-shell chromium_headless_shell-1234 chrome-headless-shell-linux.zip 1.62 firefox firefox-1538 firefox-linux.zip 1.62 webkit webkit-2336 webkit-mac-26-arm64.zip (The webkit 1.62 URL shows the mac name only because my sample output came from a Mac; in the build container the dry-run prints Linux URLs.) End to end: built a node:22-bookworm-slim image (linux/amd64) that runs the extension's generated RUN steps verbatim for chromium-headless-shell against Playwright 1.62.0, then launched the browser through Playwright with PLAYWRIGHT_BROWSERS_PATH=/ms-playwright: install dir: chromium_headless_shell-1234 Downloading from https://cdn.playwright.dev/builds/cft/151.0.7922.34/linux64/chrome-headless-shell-linux64.zip /ms-playwright/chromium_headless_shell-1234/chrome-headless-shell-linux64 title: pw-e2e-ok | version: 151.0.7922.34 So the Chrome-for-Testing archive layout unpacks into the directory Playwright's registry expects, and the browser starts. Changeset @trigger.dev/build patch. 🤖 Generated with Claude Code

Open Graph Description: Fixes #3089 Problem The playwright build extension reads npx playwright install --dry-run to find each browser's install directory and download URL. Playwright 1.58 changed the per-browser head...

X Description: Fixes #3089 Problem The playwright build extension reads npx playwright install --dry-run to find each browser&#39;s install directory and download URL. Playwright 1.58 changed the per-browser ...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4881

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7c4e7e90-a6e1-9d91-e4af-d70d0f8af463
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE254:2F463F:7DAC9C:BA35AB:6AFAFB6A
html-safe-nonce174ce61c8af8b53b511c88c74a23bd613d2c37098e479fbec58ac0923f1ecdf8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjU0OjJGNDYzRjo3REFDOUM6QkEzNUFCOjZBRkFGQjZBIiwidmlzaXRvcl9pZCI6IjU2MjgxNzc3NzI3MDc1MTExNDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac93497b5843ea414c5d8f8cc0475fa014d8ed42240cee18133f948e629dc16f5e
hovercard-subject-tagpull_request:4427214739
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4881/files
twitter:imagehttps://avatars.githubusercontent.com/u/32075361?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/32075361?s=400&v=4
og:image:altFixes #3089 Problem The playwright build extension reads npx playwright install --dry-run to find each browser's install directory and download URL. Playwright 1.58 changed the per-browser head...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None54f7a6886649661c85eee945cca0773566bfb4065370e0429b7c8f7204184650
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecf8450eb633ec589502c42ff6f4072e40db65da3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4881/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4881%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4881%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4881/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4881/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4881/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
ericallamhttps://github.com/ericallam
triggerdotdev:mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
NERLOE:fix/playwright-extension-1-58-dry-runhttps://github.com/NERLOE/trigger.dev/tree/fix/playwright-extension-1-58-dry-run
Conversation 11 https://github.com/triggerdotdev/trigger.dev/pull/4881
Commits 3 https://github.com/triggerdotdev/trigger.dev/pull/4881/commits
Checks 65 https://github.com/triggerdotdev/trigger.dev/pull/4881/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/4881/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4881/files
fix(build): playwright extension parses the Playwright 1.58+ install --dry-run output https://github.com/triggerdotdev/trigger.dev/pull/4881/files#top
Show all changes 3 commits https://github.com/triggerdotdev/trigger.dev/pull/4881/files
040978c fix(build): playwright extension parses the 1.58+ install --dry-run o… NERLOE Sep 2, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4881/commits/040978c54c9b710be8d09732e44ba6bf00d195e8
b9dd0f0 fix(build): accurate comment, release-note changeset, header-pattern … NERLOE Sep 2, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4881/commits/b9dd0f09ceca62126a6ee0f1cabf7c51d1d83b58
3720e4b fix(build): test the dry-run header pattern directly NERLOE Sep 2, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4881/commits/3720e4b1e9769380db87783cc3c5e3238696fb1b
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/4881/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4881/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4881/files
playwright-extension-dry-run-1-58.md https://github.com/triggerdotdev/trigger.dev/pull/4881/files#diff-725e33cd5e10a93f3e2411a7d63abd49c2d386871b3219d9ff237cfe7c2ebc0a
playwright.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4881/files#diff-de19d4a9964470352f065f6932cf8d276585b04d04326231fb41b9d94c8ae2e4
playwright.ts https://github.com/triggerdotdev/trigger.dev/pull/4881/files#diff-32f52e1b8c8d429fe241c553f7058b4d2f55d98d9a1a62cd6742342342117861
.changeset/playwright-extension-dry-run-1-58.mdhttps://github.com/triggerdotdev/trigger.dev/pull/4881/files#diff-725e33cd5e10a93f3e2411a7d63abd49c2d386871b3219d9ff237cfe7c2ebc0a
View file https://github.com/NERLOE/trigger.dev/blob/3720e4b1e9769380db87783cc3c5e3238696fb1b/.changeset/playwright-extension-dry-run-1-58.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4881/{{ revealButtonHref }}
packages/build/src/extensions/playwright.test.tshttps://github.com/triggerdotdev/trigger.dev/pull/4881/files#diff-de19d4a9964470352f065f6932cf8d276585b04d04326231fb41b9d94c8ae2e4
View file https://github.com/NERLOE/trigger.dev/blob/3720e4b1e9769380db87783cc3c5e3238696fb1b/packages/build/src/extensions/playwright.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4881/{{ revealButtonHref }}
packages/build/src/extensions/playwright.tshttps://github.com/triggerdotdev/trigger.dev/pull/4881/files#diff-32f52e1b8c8d429fe241c553f7058b4d2f55d98d9a1a62cd6742342342117861
View file https://github.com/NERLOE/trigger.dev/blob/3720e4b1e9769380db87783cc3c5e3238696fb1b/packages/build/src/extensions/playwright.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4881/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4881/files#diff-32f52e1b8c8d429fe241c553f7058b4d2f55d98d9a1a62cd6742342342117861
https://github.com/triggerdotdev/trigger.dev/pull/4881/files#diff-32f52e1b8c8d429fe241c553f7058b4d2f55d98d9a1a62cd6742342342117861
https://github.com/triggerdotdev/trigger.dev/pull/4881/files#diff-32f52e1b8c8d429fe241c553f7058b4d2f55d98d9a1a62cd6742342342117861
https://github.com/triggerdotdev/trigger.dev/pull/4881/files#diff-32f52e1b8c8d429fe241c553f7058b4d2f55d98d9a1a62cd6742342342117861
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.