| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/commits(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:831b0bc2-ed5f-38e1-2814-848c538ba445 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AC2C:190EF6:F957D:16D6CB:6AFB1AC2 |
| html-safe-nonce | 7211b75533c45669db8b8a3f630a3404df56e32e453a791e56a7781298f2eded |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzJDOjE5MEVGNjpGOTU3RDoxNkQ2Q0I6NkFGQjFBQzIiLCJ2aXNpdG9yX2lkIjoiNjIzNzQ4MDEyMTI4ODgyNTUzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f71be30ea6bd65392ccf6b1c8a87cb8ec4f6f72c42a5c7007ad39f0fa65ec5fa |
| hovercard-subject-tag | pull_request:4402380845 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/commits |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4851/commits |
| twitter:image | https://opengraph.githubassets.com/888abe1dafb7f8b392810d0f6ca0581929ac8730cd812280c98b79dbb14fc03f/triggerdotdev/trigger.dev/pull/4851 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/888abe1dafb7f8b392810d0f6ca0581929ac8730cd812280c98b79dbb14fc03f/triggerdotdev/trigger.dev/pull/4851 |
| og:image:alt | Summary
The trigger.dev deploy and trigger.dev dev commands now warn (with the suggested fix) when your code loads a package through createRequire() that won't be available in the deployed imag... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | matt-aitken |
| hostname | github.com |
| expected-hostname | github.com |
| None | 24933791aba0f10b2f189f8b953a1452dd79933933ac13a0a67b8ad3acee3d9f |
| turbo-cache-control | no-cache |
| go-import | github.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git |
| octolytics-dimension-user_id | 95297378 |
| octolytics-dimension-user_login | triggerdotdev |
| octolytics-dimension-repository_id | 572570113 |
| octolytics-dimension-repository_nwo | triggerdotdev/trigger.dev |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 572570113 |
| octolytics-dimension-repository_network_root_nwo | triggerdotdev/trigger.dev |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 030711cc180b563614a434f4376acf7da5d445fa |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4851%2Fcommits |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4851%2Fcommits |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev |
| Reload | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits |
| Reload | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits |
| Reload | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits |
| triggerdotdev | https://github.com/triggerdotdev |
| trigger.dev | https://github.com/triggerdotdev/trigger.dev |
| Code | https://github.com/triggerdotdev/trigger.dev |
| Issues203 (203) | https://github.com/triggerdotdev/trigger.dev/issues |
| Pull requests67 (67) | https://github.com/triggerdotdev/trigger.dev/pulls |
| Discussions | https://github.com/triggerdotdev/trigger.dev/discussions |
| Actions | https://github.com/triggerdotdev/trigger.dev/actions |
| Projects | https://github.com/triggerdotdev/trigger.dev/projects |
| Security and quality39 (39) | https://github.com/triggerdotdev/trigger.dev/security |
| Insights | https://github.com/triggerdotdev/trigger.dev/pulse |
| https://github.com/triggerdotdev/trigger.dev |
| matt-aitken | https://github.com/matt-aitken |
| main | https://github.com/triggerdotdev/trigger.dev/tree/main |
| feat/cli-createrequire-deploy-warning | https://github.com/triggerdotdev/trigger.dev/tree/feat/cli-createrequire-deploy-warning |
| Conversation | https://github.com/triggerdotdev/trigger.dev/pull/4851 |
| Commits15 (15) | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits |
| Checks | https://github.com/triggerdotdev/trigger.dev/pull/4851/checks |
| Files changed | https://github.com/triggerdotdev/trigger.dev/pull/4851/files |
| feat(cli): warn on createRequire packages missing from deployed images | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits#top |
| matt-aitken | https://github.com/matt-aitken |
| main | https://github.com/triggerdotdev/trigger.dev/tree/main |
| feat/cli-createrequire-deploy-warning | https://github.com/triggerdotdev/trigger.dev/tree/feat/cli-createrequire-deploy-warning |
| feat(cli): warn on createRequire packages missing from deployed images | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/fc8081693fdaf19f553ee189a12e30d9aeb9fbf4 |
| https://github.com/matt-aitken |
| matt-aitken | https://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken |
| fc80816 | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/fc8081693fdaf19f553ee189a12e30d9aeb9fbf4 |
| https://github.com/triggerdotdev/trigger.dev/tree/fc8081693fdaf19f553ee189a12e30d9aeb9fbf4 |
| fix(cli): harden the createRequire scan against nested args and comment noise | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/37dd13e345bc27d3e796f6815763bcc5ad38c72d |
| https://github.com/matt-aitken |
| matt-aitken | https://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken |
| 37dd13e | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/37dd13e345bc27d3e796f6815763bcc5ad38c72d |
| https://github.com/triggerdotdev/trigger.dev/tree/37dd13e345bc27d3e796f6815763bcc5ad38c72d |
| feat(cli): show the exact trigger.config.ts fix in the createRequire warning | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/e64a9ae59284a83b9c320c3c12f23e2c70103692 |
| https://github.com/matt-aitken |
| matt-aitken | https://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken |
| e64a9ae | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/e64a9ae59284a83b9c320c3c12f23e2c70103692 |
| https://github.com/triggerdotdev/trigger.dev/tree/e64a9ae59284a83b9c320c3c12f23e2c70103692 |
| feat(cli,build): warn in dev too when createRequire loads a package deploys won't have | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/bf7849c9135af3f94d199263c001000df597c0f0 |
| https://github.com/matt-aitken |
| matt-aitken | https://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken |
| bf7849c | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/bf7849c9135af3f94d199263c001000df597c0f0 |
| https://github.com/triggerdotdev/trigger.dev/tree/bf7849c9135af3f94d199263c001000df597c0f0 |
| feat(cli,build,core): complete the dev createRequire warning, diagnostics-only suppression | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/48e10d480005aa52c6e4c7d2a62c3eea64ade3d9 |
| https://github.com/matt-aitken |
| matt-aitken | https://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken |
| 48e10d4 | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/48e10d480005aa52c6e4c7d2a62c3eea64ade3d9 |
| https://github.com/triggerdotdev/trigger.dev/tree/48e10d480005aa52c6e4c7d2a62c3eea64ade3d9 |
| fix(cli): lexer-based comment handling and binding-verified createRequire detection | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/25df644990a9dcaad51753ee9607a0c9eaaa4792 |
| https://github.com/matt-aitken |
| matt-aitken | https://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken |
| 25df644 | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/25df644990a9dcaad51753ee9607a0c9eaaa4792 |
| https://github.com/triggerdotdev/trigger.dev/tree/25df644990a9dcaad51753ee9607a0c9eaaa4792 |
| fix(cli,build): correct warning suppression sources and harden the scanner | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/6d68c53960fe29776a013fe2e9add7c2450cc511 |
| https://github.com/matt-aitken |
| matt-aitken | https://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken |
| 6d68c53 | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/6d68c53960fe29776a013fe2e9add7c2450cc511 |
| https://github.com/triggerdotdev/trigger.dev/tree/6d68c53960fe29776a013fe2e9add7c2450cc511 |
| fix(cli,build): scanner and suppression halves of the previous commit | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/813aa58b4ae58c267afdcd118d8f256a5848596d |
| https://github.com/matt-aitken |
| matt-aitken | https://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken |
| 813aa58 | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/813aa58b4ae58c267afdcd118d8f256a5848596d |
| https://github.com/triggerdotdev/trigger.dev/tree/813aa58b4ae58c267afdcd118d8f256a5848596d |
| fix(cli): close review-confirmed false positives and negatives in the createRequire warning | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/4046b86e4913ac2c6824c639c09be5d4f74b8832 |
| https://github.com/matt-aitken |
| matt-aitken | https://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken |
| 4046b86 | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/4046b86e4913ac2c6824c639c09be5d4f74b8832 |
| https://github.com/triggerdotdev/trigger.dev/tree/4046b86e4913ac2c6824c639c09be5d4f74b8832 |
| refactor(cli,build,core): parse-based createRequire scanner, scoped install-command suppression | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/cc36ea819575c371247d0e015ac03a58ac89d6de |
| https://github.com/matt-aitken |
| matt-aitken | https://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken |
| cc36ea8 | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/cc36ea819575c371247d0e015ac03a58ac89d6de |
| https://github.com/triggerdotdev/trigger.dev/tree/cc36ea819575c371247d0e015ac03a58ac89d6de |
| docs: correct the externalsForTarget contract and document installedPackagesForTarget | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/8c7f18466dd37e68d394faaa6c90894114ad76d7 |
| https://github.com/matt-aitken |
| matt-aitken | https://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken |
| 8c7f184 | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/8c7f18466dd37e68d394faaa6c90894114ad76d7 |
| https://github.com/triggerdotdev/trigger.dev/tree/8c7f18466dd37e68d394faaa6c90894114ad76d7 |
| fix(cli,build): dev warnings default on for undeclared extensions, scanner edge fixes | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/1c659504e046816b90a7d79935ab47c0d109be49 |
| https://github.com/matt-aitken |
| matt-aitken | https://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken |
| 1c65950 | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/1c659504e046816b90a7d79935ab47c0d109be49 |
| https://github.com/triggerdotdev/trigger.dev/tree/1c659504e046816b90a7d79935ab47c0d109be49 |
| refactor(cli,build,core): scope the createRequire warning to per-file scanning | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/b320848ac8600e5b6a6277375b1af9ec21375437 |
| https://github.com/matt-aitken |
| matt-aitken | https://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken |
| b320848 | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/b320848ac8600e5b6a6277375b1af9ec21375437 |
| https://github.com/triggerdotdev/trigger.dev/tree/b320848ac8600e5b6a6277375b1af9ec21375437 |
| fix(cli): parse decorator syntax and never suppress on global installs | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/08de7db013fc25113a57c0753f9812b79a474180 |
| https://github.com/matt-aitken |
| matt-aitken | https://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken |
| 08de7db | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/08de7db013fc25113a57c0753f9812b79a474180 |
| https://github.com/triggerdotdev/trigger.dev/tree/08de7db013fc25113a57c0753f9812b79a474180 |
| Improved changeset | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/b1a98d535aeefe0aefb2fd7a323702e399bf7c26 |
| https://github.com/matt-aitken |
| matt-aitken | https://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken |
| b1a98d5 | https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/b1a98d535aeefe0aefb2fd7a323702e399bf7c26 |
| https://github.com/triggerdotdev/trigger.dev/tree/b1a98d535aeefe0aefb2fd7a323702e399bf7c26 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |