René's URL Explorer Experiment


Title: feat(cli): warn on createRequire packages missing from deployed images by matt-aitken · Pull Request #4851 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: feat(cli): warn on createRequire packages missing from deployed images by matt-aitken · Pull Request #4851 · triggerdotdev/trigger.dev

X Title: feat(cli): warn on createRequire packages missing from deployed images by matt-aitken · Pull Request #4851 · triggerdotdev/trigger.dev

Description: Trigger.dev – build and deploy durable AI agents and workflows - feat(cli): warn on createRequire packages missing from deployed images by matt-aitken · Pull Request #4851 · triggerdotdev/trigger.dev

Open Graph Description: Summary The trigger.dev deploy and trigger.dev dev commands now warn (with the suggested fix) when your code loads a package through createRequire() that won't be available in the deployed imag...

X Description: Summary The trigger.dev deploy and trigger.dev dev commands now warn (with the suggested fix) when your code loads a package through createRequire() that won't be available in the deployed ...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4851

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:831b0bc2-ed5f-38e1-2814-848c538ba445
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAC2C:190EF6:F957D:16D6CB:6AFB1AC2
html-safe-nonce7211b75533c45669db8b8a3f630a3404df56e32e453a791e56a7781298f2eded
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzJDOjE5MEVGNjpGOTU3RDoxNkQ2Q0I6NkFGQjFBQzIiLCJ2aXNpdG9yX2lkIjoiNjIzNzQ4MDEyMTI4ODgyNTUzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf71be30ea6bd65392ccf6b1c8a87cb8ec4f6f72c42a5c7007ad39f0fa65ec5fa
hovercard-subject-tagpull_request:4402380845
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4851/commits
twitter:imagehttps://opengraph.githubassets.com/888abe1dafb7f8b392810d0f6ca0581929ac8730cd812280c98b79dbb14fc03f/triggerdotdev/trigger.dev/pull/4851
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/888abe1dafb7f8b392810d0f6ca0581929ac8730cd812280c98b79dbb14fc03f/triggerdotdev/trigger.dev/pull/4851
og:image:altSummary The trigger.dev deploy and trigger.dev dev commands now warn (with the suggested fix) when your code loads a package through createRequire() that won't be available in the deployed imag...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamematt-aitken
hostnamegithub.com
expected-hostnamegithub.com
None24933791aba0f10b2f189f8b953a1452dd79933933ac13a0a67b8ad3acee3d9f
turbo-cache-controlno-cache
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release030711cc180b563614a434f4376acf7da5d445fa
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4851/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4851%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4851%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4851/commits
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4851/commits
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4851/commits
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
https://github.com/triggerdotdev/trigger.dev
matt-aitkenhttps://github.com/matt-aitken
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
feat/cli-createrequire-deploy-warninghttps://github.com/triggerdotdev/trigger.dev/tree/feat/cli-createrequire-deploy-warning
Conversationhttps://github.com/triggerdotdev/trigger.dev/pull/4851
Commits15 (15)https://github.com/triggerdotdev/trigger.dev/pull/4851/commits
Checkshttps://github.com/triggerdotdev/trigger.dev/pull/4851/checks
Files changedhttps://github.com/triggerdotdev/trigger.dev/pull/4851/files
feat(cli): warn on createRequire packages missing from deployed imageshttps://github.com/triggerdotdev/trigger.dev/pull/4851/commits#top
matt-aitkenhttps://github.com/matt-aitken
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
feat/cli-createrequire-deploy-warninghttps://github.com/triggerdotdev/trigger.dev/tree/feat/cli-createrequire-deploy-warning
feat(cli): warn on createRequire packages missing from deployed imageshttps://github.com/triggerdotdev/trigger.dev/pull/4851/commits/fc8081693fdaf19f553ee189a12e30d9aeb9fbf4
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
fc80816https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/fc8081693fdaf19f553ee189a12e30d9aeb9fbf4
https://github.com/triggerdotdev/trigger.dev/tree/fc8081693fdaf19f553ee189a12e30d9aeb9fbf4
fix(cli): harden the createRequire scan against nested args and comment noisehttps://github.com/triggerdotdev/trigger.dev/pull/4851/commits/37dd13e345bc27d3e796f6815763bcc5ad38c72d
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
37dd13ehttps://github.com/triggerdotdev/trigger.dev/pull/4851/commits/37dd13e345bc27d3e796f6815763bcc5ad38c72d
https://github.com/triggerdotdev/trigger.dev/tree/37dd13e345bc27d3e796f6815763bcc5ad38c72d
feat(cli): show the exact trigger.config.ts fix in the createRequire warninghttps://github.com/triggerdotdev/trigger.dev/pull/4851/commits/e64a9ae59284a83b9c320c3c12f23e2c70103692
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
e64a9aehttps://github.com/triggerdotdev/trigger.dev/pull/4851/commits/e64a9ae59284a83b9c320c3c12f23e2c70103692
https://github.com/triggerdotdev/trigger.dev/tree/e64a9ae59284a83b9c320c3c12f23e2c70103692
feat(cli,build): warn in dev too when createRequire loads a package deploys won't havehttps://github.com/triggerdotdev/trigger.dev/pull/4851/commits/bf7849c9135af3f94d199263c001000df597c0f0
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
bf7849chttps://github.com/triggerdotdev/trigger.dev/pull/4851/commits/bf7849c9135af3f94d199263c001000df597c0f0
https://github.com/triggerdotdev/trigger.dev/tree/bf7849c9135af3f94d199263c001000df597c0f0
feat(cli,build,core): complete the dev createRequire warning, diagnostics-only suppressionhttps://github.com/triggerdotdev/trigger.dev/pull/4851/commits/48e10d480005aa52c6e4c7d2a62c3eea64ade3d9
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
48e10d4https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/48e10d480005aa52c6e4c7d2a62c3eea64ade3d9
https://github.com/triggerdotdev/trigger.dev/tree/48e10d480005aa52c6e4c7d2a62c3eea64ade3d9
fix(cli): lexer-based comment handling and binding-verified createRequire detectionhttps://github.com/triggerdotdev/trigger.dev/pull/4851/commits/25df644990a9dcaad51753ee9607a0c9eaaa4792
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
25df644https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/25df644990a9dcaad51753ee9607a0c9eaaa4792
https://github.com/triggerdotdev/trigger.dev/tree/25df644990a9dcaad51753ee9607a0c9eaaa4792
fix(cli,build): correct warning suppression sources and harden the scannerhttps://github.com/triggerdotdev/trigger.dev/pull/4851/commits/6d68c53960fe29776a013fe2e9add7c2450cc511
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
6d68c53https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/6d68c53960fe29776a013fe2e9add7c2450cc511
https://github.com/triggerdotdev/trigger.dev/tree/6d68c53960fe29776a013fe2e9add7c2450cc511
fix(cli,build): scanner and suppression halves of the previous commithttps://github.com/triggerdotdev/trigger.dev/pull/4851/commits/813aa58b4ae58c267afdcd118d8f256a5848596d
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
813aa58https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/813aa58b4ae58c267afdcd118d8f256a5848596d
https://github.com/triggerdotdev/trigger.dev/tree/813aa58b4ae58c267afdcd118d8f256a5848596d
fix(cli): close review-confirmed false positives and negatives in the createRequire warninghttps://github.com/triggerdotdev/trigger.dev/pull/4851/commits/4046b86e4913ac2c6824c639c09be5d4f74b8832
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
4046b86https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/4046b86e4913ac2c6824c639c09be5d4f74b8832
https://github.com/triggerdotdev/trigger.dev/tree/4046b86e4913ac2c6824c639c09be5d4f74b8832
refactor(cli,build,core): parse-based createRequire scanner, scoped install-command suppressionhttps://github.com/triggerdotdev/trigger.dev/pull/4851/commits/cc36ea819575c371247d0e015ac03a58ac89d6de
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
cc36ea8https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/cc36ea819575c371247d0e015ac03a58ac89d6de
https://github.com/triggerdotdev/trigger.dev/tree/cc36ea819575c371247d0e015ac03a58ac89d6de
docs: correct the externalsForTarget contract and document installedPackagesForTargethttps://github.com/triggerdotdev/trigger.dev/pull/4851/commits/8c7f18466dd37e68d394faaa6c90894114ad76d7
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
8c7f184https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/8c7f18466dd37e68d394faaa6c90894114ad76d7
https://github.com/triggerdotdev/trigger.dev/tree/8c7f18466dd37e68d394faaa6c90894114ad76d7
fix(cli,build): dev warnings default on for undeclared extensions, scanner edge fixeshttps://github.com/triggerdotdev/trigger.dev/pull/4851/commits/1c659504e046816b90a7d79935ab47c0d109be49
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
1c65950https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/1c659504e046816b90a7d79935ab47c0d109be49
https://github.com/triggerdotdev/trigger.dev/tree/1c659504e046816b90a7d79935ab47c0d109be49
refactor(cli,build,core): scope the createRequire warning to per-file scanninghttps://github.com/triggerdotdev/trigger.dev/pull/4851/commits/b320848ac8600e5b6a6277375b1af9ec21375437
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
b320848https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/b320848ac8600e5b6a6277375b1af9ec21375437
https://github.com/triggerdotdev/trigger.dev/tree/b320848ac8600e5b6a6277375b1af9ec21375437
fix(cli): parse decorator syntax and never suppress on global installshttps://github.com/triggerdotdev/trigger.dev/pull/4851/commits/08de7db013fc25113a57c0753f9812b79a474180
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
08de7dbhttps://github.com/triggerdotdev/trigger.dev/pull/4851/commits/08de7db013fc25113a57c0753f9812b79a474180
https://github.com/triggerdotdev/trigger.dev/tree/08de7db013fc25113a57c0753f9812b79a474180
Improved changesethttps://github.com/triggerdotdev/trigger.dev/pull/4851/commits/b1a98d535aeefe0aefb2fd7a323702e399bf7c26
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
b1a98d5https://github.com/triggerdotdev/trigger.dev/pull/4851/commits/b1a98d535aeefe0aefb2fd7a323702e399bf7c26
https://github.com/triggerdotdev/trigger.dev/tree/b1a98d535aeefe0aefb2fd7a323702e399bf7c26
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.