| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6e56ee47-e094-cc63-6953-361106edfbea |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9ACA:1F5D:F84399:1690BE5:6AFAF65F |
| html-safe-nonce | b92ea0f13a0fff7bf23a00b6f052f12b16fb4963aab779bc4cacdff95b99d83a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QUNBOjFGNUQ6Rjg0Mzk5OjE2OTBCRTU6NkFGQUY2NUYiLCJ2aXNpdG9yX2lkIjoiNDk3NTgzMTUwMjQwMzg2MDA2MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f56b02e3e5d2588e6a3ff36956e981bd5f941fd6334a139f9c60cab308a02494 |
| hovercard-subject-tag | pull_request:4401963494 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4849/files |
| twitter:image | https://avatars.githubusercontent.com/u/10635986?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/10635986?s=400&v=4 |
| og:image:alt | Summary
A run's finish commit and its follow-up side effects (completing the associated waitpoint, waking blocked parents, releasing the queue slot, nudging batch completion) are separate write... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git |
| octolytics-dimension-user_id | 95297378 |
| octolytics-dimension-user_login | triggerdotdev |
| octolytics-dimension-repository_id | 572570113 |
| octolytics-dimension-repository_nwo | triggerdotdev/trigger.dev |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 572570113 |
| octolytics-dimension-repository_network_root_nwo | triggerdotdev/trigger.dev |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a85e96a83bed7871993e6b1ffda24105928eee17 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/triggerdotdev/trigger.dev/pull/4849/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4849%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4849%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev |
| Reload | https://github.com/triggerdotdev/trigger.dev/pull/4849/files |
| Reload | https://github.com/triggerdotdev/trigger.dev/pull/4849/files |
| Reload | https://github.com/triggerdotdev/trigger.dev/pull/4849/files |
| triggerdotdev | https://github.com/triggerdotdev |
| trigger.dev | https://github.com/triggerdotdev/trigger.dev |
| Code | https://github.com/triggerdotdev/trigger.dev |
| Issues203 (203) | https://github.com/triggerdotdev/trigger.dev/issues |
| Pull requests67 (67) | https://github.com/triggerdotdev/trigger.dev/pulls |
| Discussions | https://github.com/triggerdotdev/trigger.dev/discussions |
| Actions | https://github.com/triggerdotdev/trigger.dev/actions |
| Projects | https://github.com/triggerdotdev/trigger.dev/projects |
| Security and quality39 (39) | https://github.com/triggerdotdev/trigger.dev/security |
| Insights | https://github.com/triggerdotdev/trigger.dev/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose |
| matt-aitken | https://github.com/matt-aitken |
| main | https://github.com/triggerdotdev/trigger.dev/tree/main |
| fix/run-finalization-guard-tri-13537 | https://github.com/triggerdotdev/trigger.dev/tree/fix/run-finalization-guard-tri-13537 |
|
Conversation
34
| https://github.com/triggerdotdev/trigger.dev/pull/4849 |
|
Commits
6
| https://github.com/triggerdotdev/trigger.dev/pull/4849/commits |
|
Checks
57
| https://github.com/triggerdotdev/trigger.dev/pull/4849/checks |
|
Files changed
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files |
| Please reload this page | https://github.com/triggerdotdev/trigger.dev/pull/4849/files |
|
fix(run-engine,webapp): guard run finalization against lost resume signals
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#top |
|
Show all changes
6 commits
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files |
|
710563d
fix(run-engine,webapp): guard run finalization against lost resume si…
matt-aitken Aug 31, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4849/commits/710563d965c1f8d37eaf59094e781359ac5bb8c5 |
|
7d0aa79
fix(run-engine): guard defers to in-flight cancellation and covers en…
matt-aitken Aug 31, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4849/commits/7d0aa79568127a87fbfa188c85d516c3993726c6 |
|
92354c7
fix(run-engine): close guard gaps found in adversarial review
matt-aitken Aug 31, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4849/commits/92354c7e54ceb44d3593547170bc0155546500e9 |
|
5c1dcdb
fix(run-engine): guard defers only while a worker owns the canceled run
matt-aitken Aug 31, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4849/commits/5c1dcdbc8253fb3fa48da0a8e5c52eab5679b480 |
|
116abe2
fix(run-engine): bound the guard's cancellation deferral
matt-aitken Aug 31, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4849/commits/116abe22cc41bd4bf255247d7d505d88fff317ee |
|
933a6a6
Better server changes file
matt-aitken Aug 31, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4849/commits/933a6a64404f7b9d22a0e5d9e1f133bb304d38e8 |
|
Clear filters
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files |
| Please reload this page | https://github.com/triggerdotdev/trigger.dev/pull/4849/files |
| Please reload this page | https://github.com/triggerdotdev/trigger.dev/pull/4849/files |
|
run-finalization-guard.md
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-fc9f91392824fa4e23da9e7a908eca77684d79aa60a3eb22bcfa00df81bc0841 |
|
unblockRouteCatalog.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-1bf947a5a3bef1f178a56499c3e8c980cbf0b5163cd96a5887c37ef78a19d2d5 |
|
index.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-d29236a78d70dd8a019a2ec308d8eab0eda9f5fbf116d19d5c99b8f573a1b5df |
|
runAttemptSystem.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-6be6606119f2547e117a3cfdbb47eb2fc6797271b8604e6c2ee1dc6d1db57ae8 |
|
ttlSystem.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-a01749dbbfb43cc676fdddff903e364c23589836cd1e31eabe4279010a369b38 |
|
waitpointSystem.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-18bdabc2533cc85221b94d4292bdd96c0e035ae336748f18ce978efb957c1efd |
|
ensureRunFinalized.test.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-c3d32872cc4ba45c562129d39eb879e1b352bae7a9c36f3215783674e2969e47 |
|
types.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-81c21d7967ac61777b1a20d53a0f821068d182af9f44ec4bd64b967c8fbd6d92 |
|
workerCatalog.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-55ab20d8af33b3a592f976001330dcd40c0bc15eae84b6e6a75d2d1c45f7c9e4 |
| .server-changes/run-finalization-guard.md | https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-fc9f91392824fa4e23da9e7a908eca77684d79aa60a3eb22bcfa00df81bc0841 |
|
View file
| https://github.com/triggerdotdev/trigger.dev/blob/933a6a64404f7b9d22a0e5d9e1f133bb304d38e8/.server-changes/run-finalization-guard.md |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/triggerdotdev/trigger.dev/pull/4849/{{ revealButtonHref }} |
| Please reload this page | https://github.com/triggerdotdev/trigger.dev/pull/4849/files |
| apps/webapp/app/v3/runOpsMigration/unblockRouteCatalog.ts | https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-1bf947a5a3bef1f178a56499c3e8c980cbf0b5163cd96a5887c37ef78a19d2d5 |
|
View file
| https://github.com/triggerdotdev/trigger.dev/blob/933a6a64404f7b9d22a0e5d9e1f133bb304d38e8/apps/webapp/app/v3/runOpsMigration/unblockRouteCatalog.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/triggerdotdev/trigger.dev/pull/4849/{{ revealButtonHref }} |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-1bf947a5a3bef1f178a56499c3e8c980cbf0b5163cd96a5887c37ef78a19d2d5 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-1bf947a5a3bef1f178a56499c3e8c980cbf0b5163cd96a5887c37ef78a19d2d5 |
| internal-packages/run-engine/src/engine/index.ts | https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-d29236a78d70dd8a019a2ec308d8eab0eda9f5fbf116d19d5c99b8f573a1b5df |
|
View file
| https://github.com/triggerdotdev/trigger.dev/blob/933a6a64404f7b9d22a0e5d9e1f133bb304d38e8/internal-packages/run-engine/src/engine/index.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/triggerdotdev/trigger.dev/pull/4849/{{ revealButtonHref }} |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-d29236a78d70dd8a019a2ec308d8eab0eda9f5fbf116d19d5c99b8f573a1b5df |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-d29236a78d70dd8a019a2ec308d8eab0eda9f5fbf116d19d5c99b8f573a1b5df |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-d29236a78d70dd8a019a2ec308d8eab0eda9f5fbf116d19d5c99b8f573a1b5df |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-d29236a78d70dd8a019a2ec308d8eab0eda9f5fbf116d19d5c99b8f573a1b5df |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-d29236a78d70dd8a019a2ec308d8eab0eda9f5fbf116d19d5c99b8f573a1b5df |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-d29236a78d70dd8a019a2ec308d8eab0eda9f5fbf116d19d5c99b8f573a1b5df |
| internal-packages/run-engine/src/engine/systems/runAttemptSystem.ts | https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-6be6606119f2547e117a3cfdbb47eb2fc6797271b8604e6c2ee1dc6d1db57ae8 |
|
View file
| https://github.com/triggerdotdev/trigger.dev/blob/933a6a64404f7b9d22a0e5d9e1f133bb304d38e8/internal-packages/run-engine/src/engine/systems/runAttemptSystem.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/triggerdotdev/trigger.dev/pull/4849/{{ revealButtonHref }} |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-6be6606119f2547e117a3cfdbb47eb2fc6797271b8604e6c2ee1dc6d1db57ae8 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-6be6606119f2547e117a3cfdbb47eb2fc6797271b8604e6c2ee1dc6d1db57ae8 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-6be6606119f2547e117a3cfdbb47eb2fc6797271b8604e6c2ee1dc6d1db57ae8 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-6be6606119f2547e117a3cfdbb47eb2fc6797271b8604e6c2ee1dc6d1db57ae8 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-6be6606119f2547e117a3cfdbb47eb2fc6797271b8604e6c2ee1dc6d1db57ae8 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-6be6606119f2547e117a3cfdbb47eb2fc6797271b8604e6c2ee1dc6d1db57ae8 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-6be6606119f2547e117a3cfdbb47eb2fc6797271b8604e6c2ee1dc6d1db57ae8 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-6be6606119f2547e117a3cfdbb47eb2fc6797271b8604e6c2ee1dc6d1db57ae8 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-6be6606119f2547e117a3cfdbb47eb2fc6797271b8604e6c2ee1dc6d1db57ae8 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-6be6606119f2547e117a3cfdbb47eb2fc6797271b8604e6c2ee1dc6d1db57ae8 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-6be6606119f2547e117a3cfdbb47eb2fc6797271b8604e6c2ee1dc6d1db57ae8 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-6be6606119f2547e117a3cfdbb47eb2fc6797271b8604e6c2ee1dc6d1db57ae8 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-6be6606119f2547e117a3cfdbb47eb2fc6797271b8604e6c2ee1dc6d1db57ae8 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-6be6606119f2547e117a3cfdbb47eb2fc6797271b8604e6c2ee1dc6d1db57ae8 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-6be6606119f2547e117a3cfdbb47eb2fc6797271b8604e6c2ee1dc6d1db57ae8 |
| Please reload this page | https://github.com/triggerdotdev/trigger.dev/pull/4849/files |
| Please reload this page | https://github.com/triggerdotdev/trigger.dev/pull/4849/files |
| Please reload this page | https://github.com/triggerdotdev/trigger.dev/pull/4849/files |
| Please reload this page | https://github.com/triggerdotdev/trigger.dev/pull/4849/files |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-6be6606119f2547e117a3cfdbb47eb2fc6797271b8604e6c2ee1dc6d1db57ae8 |
| internal-packages/run-engine/src/engine/systems/ttlSystem.ts | https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-a01749dbbfb43cc676fdddff903e364c23589836cd1e31eabe4279010a369b38 |
|
View file
| https://github.com/triggerdotdev/trigger.dev/blob/933a6a64404f7b9d22a0e5d9e1f133bb304d38e8/internal-packages/run-engine/src/engine/systems/ttlSystem.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/triggerdotdev/trigger.dev/pull/4849/{{ revealButtonHref }} |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-a01749dbbfb43cc676fdddff903e364c23589836cd1e31eabe4279010a369b38 |
| Please reload this page | https://github.com/triggerdotdev/trigger.dev/pull/4849/files |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-a01749dbbfb43cc676fdddff903e364c23589836cd1e31eabe4279010a369b38 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-a01749dbbfb43cc676fdddff903e364c23589836cd1e31eabe4279010a369b38 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-a01749dbbfb43cc676fdddff903e364c23589836cd1e31eabe4279010a369b38 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-a01749dbbfb43cc676fdddff903e364c23589836cd1e31eabe4279010a369b38 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-a01749dbbfb43cc676fdddff903e364c23589836cd1e31eabe4279010a369b38 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-a01749dbbfb43cc676fdddff903e364c23589836cd1e31eabe4279010a369b38 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-a01749dbbfb43cc676fdddff903e364c23589836cd1e31eabe4279010a369b38 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-a01749dbbfb43cc676fdddff903e364c23589836cd1e31eabe4279010a369b38 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4849/files#diff-a01749dbbfb43cc676fdddff903e364c23589836cd1e31eabe4279010a369b38 |
| Please reload this page | https://github.com/triggerdotdev/trigger.dev/pull/4849/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |