Title: fix(cli): forward TRIGGER_WORKER_INSTANCE_NAME into the run process by Srinivasan8888 · Pull Request #4847 · triggerdotdev/trigger.dev · GitHub
Open Graph Title: fix(cli): forward TRIGGER_WORKER_INSTANCE_NAME into the run process by Srinivasan8888 · Pull Request #4847 · triggerdotdev/trigger.dev
X Title: fix(cli): forward TRIGGER_WORKER_INSTANCE_NAME into the run process by Srinivasan8888 · Pull Request #4847 · triggerdotdev/trigger.dev
Description: Problem On self-hosted Kubernetes, task-run spans and logs exported over OTLP to an off-node collector arrive with no host, so every such span gets tagged issue_type:empty_hostname. The node name is already on the pod. apps/supervisor/src/workloadManager/kubernetes.ts injects it into the run-controller container via the downward API: { name: "TRIGGER_WORKER_INSTANCE_NAME", valueFrom: { fieldRef: { fieldPath: "spec.nodeName" } } } But the task-run worker is fork()ed with an explicit, replaced env built by RunnerEnv.gatherProcessEnv(), which allowlisted only NODE_ENV, NODE_EXTRA_CA_CERTS, the two OTLP endpoint names and UV_USE_IO_URING. So the node identity never reaches the run process, and there is no supported way for a user's trigger.config.ts telemetry resource to recover it. Change Add TRIGGER_WORKER_INSTANCE_NAME to the forwarded set. It is a required field on the runner env schema (env.ts:55, z.string()), so it is always present, and the existing undefined-filter leaves behaviour unchanged for the optional entries. Cost/benefit Small and low-risk: one additional key in an env allowlist, on a value the supervisor already computes and already passes to the controller. It adds no new config surface and no new failure mode. The benefit is that self-hosted Kubernetes users get a usable host on their run telemetry instead of an empty one. Tests packages/cli-v3/src/entryPoints/managed/env.test.ts — 4 tests: the instance name is forwarded, a Kubernetes-style node name survives, the OTLP endpoint is still forwarded under both names, and undefined values are still filtered out. pnpm vitest run src/entryPoints/managed/env.test.ts -> 4 passed pnpm run typecheck -> clean Removing the added line makes 2 of the 4 fail, so they pin the behaviour rather than restate it. Note: the cli-v3 suite has 5 failing test files and 1 failing test on unmodified main. I baselined before and after — this branch adds no new failures. refs #4214
Open Graph Description: Problem On self-hosted Kubernetes, task-run spans and logs exported over OTLP to an off-node collector arrive with no host, so every such span gets tagged issue_type:empty_hostname. The node name i...
X Description: Problem On self-hosted Kubernetes, task-run spans and logs exported over OTLP to an off-node collector arrive with no host, so every such span gets tagged issue_type:empty_hostname. The node name i...
Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4847
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:84a3af38-1e42-19d6-9e3e-a49e3a7f2ba7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8A8C:29CAD0:5F5314:8D1DFB:6AFAF022 |
| html-safe-nonce | 1434171dbd6d2ddc96df125cf0e36f6f0fa09cf4a46fa2d651bd09e93124a61a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QThDOjI5Q0FEMDo1RjUzMTQ6OEQxREZCOjZBRkFGMDIyIiwidmlzaXRvcl9pZCI6IjcyNDk4MDU2MzA5NDI5MzMwMjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 90498cffeb6fb9e70193ed2db5e3f835539e14f0b6c848109b3b77f2012d26e5 |
| hovercard-subject-tag | pull_request:4400212882 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4847/files |
| twitter:image | https://avatars.githubusercontent.com/u/92676627?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/92676627?s=400&v=4 |
| og:image:alt | Problem On self-hosted Kubernetes, task-run spans and logs exported over OTLP to an off-node collector arrive with no host, so every such span gets tagged issue_type:empty_hostname. The node name i... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git |
| octolytics-dimension-user_id | 95297378 |
| octolytics-dimension-user_login | triggerdotdev |
| octolytics-dimension-repository_id | 572570113 |
| octolytics-dimension-repository_nwo | triggerdotdev/trigger.dev |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 572570113 |
| octolytics-dimension-repository_network_root_nwo | triggerdotdev/trigger.dev |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 12fff95459b24b0f882a66698ee6a36a5934d247 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width