René's URL Explorer Experiment


Title: fix(cli): forward TRIGGER_WORKER_INSTANCE_NAME into the run process by Srinivasan8888 · Pull Request #4847 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(cli): forward TRIGGER_WORKER_INSTANCE_NAME into the run process by Srinivasan8888 · Pull Request #4847 · triggerdotdev/trigger.dev

X Title: fix(cli): forward TRIGGER_WORKER_INSTANCE_NAME into the run process by Srinivasan8888 · Pull Request #4847 · triggerdotdev/trigger.dev

Description: Problem On self-hosted Kubernetes, task-run spans and logs exported over OTLP to an off-node collector arrive with no host, so every such span gets tagged issue_type:empty_hostname. The node name is already on the pod. apps/supervisor/src/workloadManager/kubernetes.ts injects it into the run-controller container via the downward API: { name: "TRIGGER_WORKER_INSTANCE_NAME", valueFrom: { fieldRef: { fieldPath: "spec.nodeName" } } } But the task-run worker is fork()ed with an explicit, replaced env built by RunnerEnv.gatherProcessEnv(), which allowlisted only NODE_ENV, NODE_EXTRA_CA_CERTS, the two OTLP endpoint names and UV_USE_IO_URING. So the node identity never reaches the run process, and there is no supported way for a user's trigger.config.ts telemetry resource to recover it. Change Add TRIGGER_WORKER_INSTANCE_NAME to the forwarded set. It is a required field on the runner env schema (env.ts:55, z.string()), so it is always present, and the existing undefined-filter leaves behaviour unchanged for the optional entries. Cost/benefit Small and low-risk: one additional key in an env allowlist, on a value the supervisor already computes and already passes to the controller. It adds no new config surface and no new failure mode. The benefit is that self-hosted Kubernetes users get a usable host on their run telemetry instead of an empty one. Tests packages/cli-v3/src/entryPoints/managed/env.test.ts — 4 tests: the instance name is forwarded, a Kubernetes-style node name survives, the OTLP endpoint is still forwarded under both names, and undefined values are still filtered out. pnpm vitest run src/entryPoints/managed/env.test.ts -> 4 passed pnpm run typecheck -> clean Removing the added line makes 2 of the 4 fail, so they pin the behaviour rather than restate it. Note: the cli-v3 suite has 5 failing test files and 1 failing test on unmodified main. I baselined before and after — this branch adds no new failures. refs #4214

Open Graph Description: Problem On self-hosted Kubernetes, task-run spans and logs exported over OTLP to an off-node collector arrive with no host, so every such span gets tagged issue_type:empty_hostname. The node name i...

X Description: Problem On self-hosted Kubernetes, task-run spans and logs exported over OTLP to an off-node collector arrive with no host, so every such span gets tagged issue_type:empty_hostname. The node name i...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4847

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:84a3af38-1e42-19d6-9e3e-a49e3a7f2ba7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A8C:29CAD0:5F5314:8D1DFB:6AFAF022
html-safe-nonce1434171dbd6d2ddc96df125cf0e36f6f0fa09cf4a46fa2d651bd09e93124a61a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QThDOjI5Q0FEMDo1RjUzMTQ6OEQxREZCOjZBRkFGMDIyIiwidmlzaXRvcl9pZCI6IjcyNDk4MDU2MzA5NDI5MzMwMjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac90498cffeb6fb9e70193ed2db5e3f835539e14f0b6c848109b3b77f2012d26e5
hovercard-subject-tagpull_request:4400212882
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4847/files
twitter:imagehttps://avatars.githubusercontent.com/u/92676627?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/92676627?s=400&v=4
og:image:altProblem On self-hosted Kubernetes, task-run spans and logs exported over OTLP to an off-node collector arrive with no host, so every such span gets tagged issue_type:empty_hostname. The node name i...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release12fff95459b24b0f882a66698ee6a36a5934d247
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4847/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4847%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4847%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4847/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4847/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4847/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
Srinivasan8888https://github.com/Srinivasan8888
triggerdotdev:mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
Srinivasan8888:fix/k8s-worker-instance-name-4214https://github.com/Srinivasan8888/trigger.dev/tree/fix/k8s-worker-instance-name-4214
Conversation 3 https://github.com/triggerdotdev/trigger.dev/pull/4847
Commits 1 https://github.com/triggerdotdev/trigger.dev/pull/4847/commits
Checks 2 https://github.com/triggerdotdev/trigger.dev/pull/4847/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/4847/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4847/files
fix(cli): forward TRIGGER_WORKER_INSTANCE_NAME into the run process https://github.com/triggerdotdev/trigger.dev/pull/4847/files#top
Show all changes 1 commit https://github.com/triggerdotdev/trigger.dev/pull/4847/files
91c6ec3 fix(cli): forward TRIGGER_WORKER_INSTANCE_NAME into the run process (… Aug 31, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4847/commits/91c6ec32fd3ebcdcf0a5f8e0ee77493160c27ce0
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/4847/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4847/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4847/files
forward-worker-instance-name.md https://github.com/triggerdotdev/trigger.dev/pull/4847/files#diff-618bb34440bcb0149e1fcc88c43cb1f5884a90d186497a5983fb223e1c794cc7
env.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4847/files#diff-f39ac1992a0e8ddb144cb3fe818f778244aad50b90aa153e0eb48ba8bd2397ea
env.ts https://github.com/triggerdotdev/trigger.dev/pull/4847/files#diff-37cff5daede6e4bfd5bc981e87c84ef3551ca309c386fc7dfc54a2d85fd7e9a9
.changeset/forward-worker-instance-name.mdhttps://github.com/triggerdotdev/trigger.dev/pull/4847/files#diff-618bb34440bcb0149e1fcc88c43cb1f5884a90d186497a5983fb223e1c794cc7
View file https://github.com/Srinivasan8888/trigger.dev/blob/91c6ec32fd3ebcdcf0a5f8e0ee77493160c27ce0/.changeset/forward-worker-instance-name.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4847/{{ revealButtonHref }}
packages/cli-v3/src/entryPoints/managed/env.test.tshttps://github.com/triggerdotdev/trigger.dev/pull/4847/files#diff-f39ac1992a0e8ddb144cb3fe818f778244aad50b90aa153e0eb48ba8bd2397ea
View file https://github.com/Srinivasan8888/trigger.dev/blob/91c6ec32fd3ebcdcf0a5f8e0ee77493160c27ce0/packages/cli-v3/src/entryPoints/managed/env.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4847/{{ revealButtonHref }}
packages/cli-v3/src/entryPoints/managed/env.tshttps://github.com/triggerdotdev/trigger.dev/pull/4847/files#diff-37cff5daede6e4bfd5bc981e87c84ef3551ca309c386fc7dfc54a2d85fd7e9a9
View file https://github.com/Srinivasan8888/trigger.dev/blob/91c6ec32fd3ebcdcf0a5f8e0ee77493160c27ce0/packages/cli-v3/src/entryPoints/managed/env.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4847/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4847/files#diff-37cff5daede6e4bfd5bc981e87c84ef3551ca309c386fc7dfc54a2d85fd7e9a9
https://github.com/triggerdotdev/trigger.dev/pull/4847/files#diff-37cff5daede6e4bfd5bc981e87c84ef3551ca309c386fc7dfc54a2d85fd7e9a9
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.