René's URL Explorer Experiment


Title: test(run-store,webapp): cover the run-ops router at three shards by d-cs · Pull Request #4805 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: test(run-store,webapp): cover the run-ops router at three shards by d-cs · Pull Request #4805 · triggerdotdev/trigger.dev

X Title: test(run-store,webapp): cover the run-ops router at three shards by d-cs · Pull Request #4805 · triggerdotdev/trigger.dev

Description: Summary Several of the run-ops router's rules only apply above two stores, and the fake-slot suites only ever built two, so those rules were untestable by construction. clearIdempotencyKey is the sole caller of the "every other shard" helper, and with two stores that helper returns a single entry, which hides a take-the-first bug. The absent-id partition has the same blind spot: a gen-2 id and a cuid select the same store when only one other store exists. Three suites now run at two shards and at three, with the expected value indexed by topology wherever the rule genuinely changes. The fourth stays at two and says why in the file, because its N-shard behaviour is already pinned in runOpsStore.shardMap.test.ts. Two webapp tests defined their own local RoutingRunStore. They compiled against a two-store model whatever the real class did, and one described a routing rule the code never implemented. Both now build the real router over the two Postgres stores they already create. Validating a test-only change Every new assertion passed the first time it ran, which proves nothing. Each was checked by breaking the router in the way the test claims to guard, then confirming the failure lands in the three-shard arm while the two-shard arm still passes: take-the-first fan-out in the "every other shard" helper gen-2 keys moved to the front of the merge precedence order the absent-id partition sending every id to the gen-1 pair, which fails as expected +0 to be 1, the shape a silently under-counted waitpoint takes residency routing disabled entirely, caught by 3 of the 5 webapp tests Each mutation was reverted. No production code changes. One note for anyone extending these: the webapp resolves @internal/run-store to dist/, not to source, so a source edit without a rebuild makes those two tests assert against the previous router and pass.

Open Graph Description: Summary Several of the run-ops router's rules only apply above two stores, and the fake-slot suites only ever built two, so those rules were untestable by construction. clearIdempotencyKey is t...

X Description: Summary Several of the run-ops router's rules only apply above two stores, and the fake-slot suites only ever built two, so those rules were untestable by construction. clearIdempotencyKey ...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4805

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6f447d31-1792-b7b5-5329-aec89d1433e9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE586:249B37:4921A70:630F5AE:6AFAF6B9
html-safe-nonce1267658315305bbd96be413dda3f74888ee4d7fc01826d923ecc9d42cea4cedd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTg2OjI0OUIzNzo0OTIxQTcwOjYzMEY1QUU6NkFGQUY2QjkiLCJ2aXNpdG9yX2lkIjoiODI4NTk3NzEyMTE0Njk5MjMxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac07ff54d8e39bf680f023e22311525c328f78f323bc93d72d664bd086e0a2bd4a
hovercard-subject-tagpull_request:4377971611
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4805/files
twitter:imagehttps://avatars.githubusercontent.com/u/45313566?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/45313566?s=400&v=4
og:image:altSummary Several of the run-ops router's rules only apply above two stores, and the fake-slot suites only ever built two, so those rules were untestable by construction. clearIdempotencyKey is t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea85e96a83bed7871993e6b1ffda24105928eee17
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4805/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4805%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4805%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4805/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4805/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4805/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
d-cshttps://github.com/d-cs
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
test/fake-slot-shard-parameterization-tri-13433https://github.com/triggerdotdev/trigger.dev/tree/test/fake-slot-shard-parameterization-tri-13433
Conversation 7 https://github.com/triggerdotdev/trigger.dev/pull/4805
Commits 3 https://github.com/triggerdotdev/trigger.dev/pull/4805/commits
Checks 58 https://github.com/triggerdotdev/trigger.dev/pull/4805/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/4805/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4805/files
test(run-store,webapp): cover the run-ops router at three shards https://github.com/triggerdotdev/trigger.dev/pull/4805/files#top
Show all changes 3 commits https://github.com/triggerdotdev/trigger.dev/pull/4805/files
831b341 test(run-store,webapp): cover the run-ops router at three shards d-cs Aug 27, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4805/commits/831b341516e04463b9167ab92e273044b5becc11
0440909 Merge remote-tracking branch 'origin/main' into test/fake-slot-shard-… d-cs Aug 27, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4805/commits/04409095f5ef597b76dad25b079441d483726e31
800e8c6 test(webapp): give the NEW store its production schema variant d-cs Aug 28, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4805/commits/800e8c62b2807b40bbb750fe0e457c7dbedac441
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/4805/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4805/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4805/files
performTaskRunAlertsStoreRouting.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4805/files#diff-9f87a09bde9829bdd5bed1df9033914e17018ca15c6db0cf786c30969233073c
updateMetadataStoreRoutingHetero.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4805/files#diff-6a00e24270042a340e01ec2bd32c978e4fef5e25f4fd9a1679844cd356a3c6b6
runOpsStore.envScopedResidency.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4805/files#diff-a523e846dce32e38af1b92b7fcfc5b5e54d8e3d3586be8669a48a0dab3c3ca8e
runOpsStore.forWaitpointCompletion.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4805/files#diff-19eceb13b96d5f50c8164497ebfc63e5cbadf80e342cf582272751f533817bcd
runOpsStore.newMethods.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4805/files#diff-3bce78554f613b9e46b4f1201f8001c50c7918af5edfe679a22915ea6dbd7595
runOpsStore.runKeyedRouting.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4805/files#diff-65d27ef8ba20f3515cd6cb87d081a94cbe8a92d99327b9ecdde5d5f5c7698b73
apps/webapp/test/performTaskRunAlertsStoreRouting.test.tshttps://github.com/triggerdotdev/trigger.dev/pull/4805/files#diff-9f87a09bde9829bdd5bed1df9033914e17018ca15c6db0cf786c30969233073c
View file https://github.com/triggerdotdev/trigger.dev/blob/800e8c62b2807b40bbb750fe0e457c7dbedac441/apps/webapp/test/performTaskRunAlertsStoreRouting.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4805/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4805/files#diff-9f87a09bde9829bdd5bed1df9033914e17018ca15c6db0cf786c30969233073c
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4805/files
https://github.com/triggerdotdev/trigger.dev/pull/4805/files#diff-9f87a09bde9829bdd5bed1df9033914e17018ca15c6db0cf786c30969233073c
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4805/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.