| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d5caaa04-e1c3-fd13-32c0-e09bd3bbc4bd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CAA2:39C4C0:3C59:50E6:6AFB08AF |
| html-safe-nonce | 95b70d09e012f192b94dc7897a68dcba37ab900e905222ae61a3df3b563a3688 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQUEyOjM5QzRDMDozQzU5OjUwRTY6NkFGQjA4QUYiLCJ2aXNpdG9yX2lkIjoiMjE5MDU0MDExNzExNjY1MTY5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f295a8f6e6e06ba240a2784b19b99e5237e9aadb9d03c93f42d2b63740af79f0 |
| hovercard-subject-tag | pull_request:4370172247 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4795/files |
| twitter:image | https://avatars.githubusercontent.com/u/534?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/534?s=400&v=4 |
| og:image:alt | Follow-up to #4644, now rebased onto main so the diff is just these three commits.
Summary
Two ways a chat could lose a user message, both pre-existing and both raised while reviewing #4644.
A mess... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 76fb13cb43f1834708971f45a9cfcab5df3177a7582086613d7cdc6e98c4bfde |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git |
| octolytics-dimension-user_id | 95297378 |
| octolytics-dimension-user_login | triggerdotdev |
| octolytics-dimension-repository_id | 572570113 |
| octolytics-dimension-repository_nwo | triggerdotdev/trigger.dev |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 572570113 |
| octolytics-dimension-repository_network_root_nwo | triggerdotdev/trigger.dev |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | afc998826cdd963c8f91a96ae5372809ab5e296b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/triggerdotdev/trigger.dev/pull/4795/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4795%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4795%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev |
| Reload | https://github.com/triggerdotdev/trigger.dev/pull/4795/files |
| Reload | https://github.com/triggerdotdev/trigger.dev/pull/4795/files |
| Reload | https://github.com/triggerdotdev/trigger.dev/pull/4795/files |
| triggerdotdev | https://github.com/triggerdotdev |
| trigger.dev | https://github.com/triggerdotdev/trigger.dev |
| Code | https://github.com/triggerdotdev/trigger.dev |
| Issues203 (203) | https://github.com/triggerdotdev/trigger.dev/issues |
| Pull requests67 (67) | https://github.com/triggerdotdev/trigger.dev/pulls |
| Discussions | https://github.com/triggerdotdev/trigger.dev/discussions |
| Actions | https://github.com/triggerdotdev/trigger.dev/actions |
| Projects | https://github.com/triggerdotdev/trigger.dev/projects |
| Security and quality39 (39) | https://github.com/triggerdotdev/trigger.dev/security |
| Insights | https://github.com/triggerdotdev/trigger.dev/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose |
| ericallam | https://github.com/ericallam |
| main | https://github.com/triggerdotdev/trigger.dev/tree/main |
| fix/mid-turn-resume-floor | https://github.com/triggerdotdev/trigger.dev/tree/fix/mid-turn-resume-floor |
|
Conversation
46
| https://github.com/triggerdotdev/trigger.dev/pull/4795 |
|
Commits
11
| https://github.com/triggerdotdev/trigger.dev/pull/4795/commits |
|
Checks
74
| https://github.com/triggerdotdev/trigger.dev/pull/4795/checks |
|
Files changed
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files |
| Please reload this page | https://github.com/triggerdotdev/trigger.dev/pull/4795/files |
|
fix(chat): stop losing a user message that arrived mid-turn
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#top |
|
Show all changes
11 commits
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files |
|
9a21f57
fix(chat,sdk): hold the resume floor behind a message buffered mid-turn
ericallam Aug 26, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4795/commits/9a21f57b159bf3723c338ae22c3140e75990ba63 |
|
383d169
fix(chat,core): defer a declined steering message instead of dropping it
ericallam Aug 26, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4795/commits/383d169e78982c2f402948c18576a6a3d5fc820e |
|
3dd60c2
docs(ai-chat): say what happens to a message that is not injected
ericallam Aug 26, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4795/commits/3dd60c20106ae07ec16db2053162a8fade5302e6 |
|
87e4577
fix(chat,sdk): consume only the steering batch the callbacks were given
ericallam Aug 27, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4795/commits/87e45776361c9a9863a60d105c5a87f29dbe15e5 |
|
66c83c8
fix(core): refuse to clear a replayable route's queue
ericallam Aug 27, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4795/commits/66c83c8c8828f2df7897811b3f2c4debd5c6549b |
|
02aa30d
fix(chat): correct the wiring caveat, deferral does not need the spread
ericallam Aug 27, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4795/commits/02aa30d5a686b92fc15afc65503c8a983fadf927 |
|
e3e6ad7
fix(chat,sdk): inject only the steering entries this drain claimed
ericallam Aug 27, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4795/commits/e3e6ad7b20b6f2b86c7f7e521cdded84ae6623fb |
|
f581a50
test(core): pin the observe-versus-puller ordering that take() guards
ericallam Aug 27, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4795/commits/f581a5097347afc3f8e52f375343e1c2e2545ab0 |
|
41e132d
fix(chat,core): give the steering claim back when the transform throws
ericallam Aug 27, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4795/commits/41e132d67038d138980569cf712446ccb1b0d954 |
|
f6bfe94
test(sdk): cover injection at a prepareStep boundary
ericallam Aug 27, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4795/commits/f6bfe941f55e01197bc970fb56ed21bf3d78d112 |
|
b0ecb91
test(sdk): repro the managed path dropping an injected message from h…
ericallam Aug 27, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4795/commits/b0ecb9114cf0c6a2dfbcc67fdf2759caf6a1d0fe |
|
Clear filters
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files |
| Please reload this page | https://github.com/triggerdotdev/trigger.dev/pull/4795/files |
| Please reload this page | https://github.com/triggerdotdev/trigger.dev/pull/4795/files |
|
quiet-floors-hold.md
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-bef165c1ac11d6968540ea27777638c8c0e6fcb4bc80bb0080b515953cd50757 |
|
spry-steers-defer.md
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-66124a8e73763d313b95771cffe2823b01ba91d7172a540ef3884281fc5a6811 |
|
client-protocol.mdx
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-819a1ba7afd2b06146ffe45804f1a7995d727954e4103eb48e0074e14c6ca057 |
|
pending-messages.mdx
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-8221029e3926d4ab845c60011262851aa8c6f10af9790210471963d1cc4c3bec |
|
reference.mdx
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-58e648685c48d39e8d19f714ccdb9a6eca84024f3490b656f62a0ff535a22f3d |
|
router.test.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-1069c46425e65b53fa0d1a154e312345b67dd9ef1e8d9e8b9ea88e507cf72336 |
|
router.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-7e0b91091bf4dbcde4a0484d7698f87635dd589e12100917487d9fc84cc242ee |
|
ai.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-1a41664a01679e09d7182b5d113a193cea9eaad0f2092f68b4beca081617a53a |
|
test-session-handle.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-4a1d5a2e027987bf49c6900bfcb998aa70db61b3bdd364306c06f3b7302c099a |
|
mid-turn-resume-floor.test.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-0b9f88e2550828ffcd108091cb5f311d5bc14bae9e3e3b2b3cd124a534f1fca0 |
|
pending-message-drain.test.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-84e4d3d7b402617b73df402590e83aeb6bd76cc47ff693b1c05ba88d7c10a773 |
|
steering-injection.test.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-4b24e7b007a38b17160e7a37f6091bae85e6545c69e4eea013069f99fd72463d |
| .changeset/quiet-floors-hold.md | https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-bef165c1ac11d6968540ea27777638c8c0e6fcb4bc80bb0080b515953cd50757 |
|
View file
| https://github.com/triggerdotdev/trigger.dev/blob/b0ecb9114cf0c6a2dfbcc67fdf2759caf6a1d0fe/.changeset/quiet-floors-hold.md |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/triggerdotdev/trigger.dev/pull/4795/{{ revealButtonHref }} |
| .changeset/spry-steers-defer.md | https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-66124a8e73763d313b95771cffe2823b01ba91d7172a540ef3884281fc5a6811 |
|
View file
| https://github.com/triggerdotdev/trigger.dev/blob/b0ecb9114cf0c6a2dfbcc67fdf2759caf6a1d0fe/.changeset/spry-steers-defer.md |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/triggerdotdev/trigger.dev/pull/4795/{{ revealButtonHref }} |
| docs/ai-chat/client-protocol.mdx | https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-819a1ba7afd2b06146ffe45804f1a7995d727954e4103eb48e0074e14c6ca057 |
|
View file
| https://github.com/triggerdotdev/trigger.dev/blob/b0ecb9114cf0c6a2dfbcc67fdf2759caf6a1d0fe/docs/ai-chat/client-protocol.mdx |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/triggerdotdev/trigger.dev/pull/4795/{{ revealButtonHref }} |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-819a1ba7afd2b06146ffe45804f1a7995d727954e4103eb48e0074e14c6ca057 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-819a1ba7afd2b06146ffe45804f1a7995d727954e4103eb48e0074e14c6ca057 |
| docs/ai-chat/pending-messages.mdx | https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-8221029e3926d4ab845c60011262851aa8c6f10af9790210471963d1cc4c3bec |
|
View file
| https://github.com/triggerdotdev/trigger.dev/blob/b0ecb9114cf0c6a2dfbcc67fdf2759caf6a1d0fe/docs/ai-chat/pending-messages.mdx |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/triggerdotdev/trigger.dev/pull/4795/{{ revealButtonHref }} |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-8221029e3926d4ab845c60011262851aa8c6f10af9790210471963d1cc4c3bec |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-8221029e3926d4ab845c60011262851aa8c6f10af9790210471963d1cc4c3bec |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-8221029e3926d4ab845c60011262851aa8c6f10af9790210471963d1cc4c3bec |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-8221029e3926d4ab845c60011262851aa8c6f10af9790210471963d1cc4c3bec |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-8221029e3926d4ab845c60011262851aa8c6f10af9790210471963d1cc4c3bec |
| docs/ai-chat/reference.mdx | https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-58e648685c48d39e8d19f714ccdb9a6eca84024f3490b656f62a0ff535a22f3d |
|
View file
| https://github.com/triggerdotdev/trigger.dev/blob/b0ecb9114cf0c6a2dfbcc67fdf2759caf6a1d0fe/docs/ai-chat/reference.mdx |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/triggerdotdev/trigger.dev/pull/4795/{{ revealButtonHref }} |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-58e648685c48d39e8d19f714ccdb9a6eca84024f3490b656f62a0ff535a22f3d |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-58e648685c48d39e8d19f714ccdb9a6eca84024f3490b656f62a0ff535a22f3d |
| packages/core/src/v3/sessionStreams/router.test.ts | https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-1069c46425e65b53fa0d1a154e312345b67dd9ef1e8d9e8b9ea88e507cf72336 |
|
View file
| https://github.com/triggerdotdev/trigger.dev/blob/b0ecb9114cf0c6a2dfbcc67fdf2759caf6a1d0fe/packages/core/src/v3/sessionStreams/router.test.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/triggerdotdev/trigger.dev/pull/4795/{{ revealButtonHref }} |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-1069c46425e65b53fa0d1a154e312345b67dd9ef1e8d9e8b9ea88e507cf72336 |
| packages/core/src/v3/sessionStreams/router.ts | https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-7e0b91091bf4dbcde4a0484d7698f87635dd589e12100917487d9fc84cc242ee |
|
View file
| https://github.com/triggerdotdev/trigger.dev/blob/b0ecb9114cf0c6a2dfbcc67fdf2759caf6a1d0fe/packages/core/src/v3/sessionStreams/router.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/triggerdotdev/trigger.dev/pull/4795/{{ revealButtonHref }} |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-7e0b91091bf4dbcde4a0484d7698f87635dd589e12100917487d9fc84cc242ee |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-7e0b91091bf4dbcde4a0484d7698f87635dd589e12100917487d9fc84cc242ee |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-7e0b91091bf4dbcde4a0484d7698f87635dd589e12100917487d9fc84cc242ee |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-7e0b91091bf4dbcde4a0484d7698f87635dd589e12100917487d9fc84cc242ee |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-7e0b91091bf4dbcde4a0484d7698f87635dd589e12100917487d9fc84cc242ee |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-7e0b91091bf4dbcde4a0484d7698f87635dd589e12100917487d9fc84cc242ee |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-7e0b91091bf4dbcde4a0484d7698f87635dd589e12100917487d9fc84cc242ee |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-7e0b91091bf4dbcde4a0484d7698f87635dd589e12100917487d9fc84cc242ee |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4795/files#diff-7e0b91091bf4dbcde4a0484d7698f87635dd589e12100917487d9fc84cc242ee |
| Please reload this page | https://github.com/triggerdotdev/trigger.dev/pull/4795/files |
| Please reload this page | https://github.com/triggerdotdev/trigger.dev/pull/4795/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |