René's URL Explorer Experiment


Title: fix(chat): stop losing a user message that arrived mid-turn by ericallam · Pull Request #4795 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(chat): stop losing a user message that arrived mid-turn by ericallam · Pull Request #4795 · triggerdotdev/trigger.dev

X Title: fix(chat): stop losing a user message that arrived mid-turn by ericallam · Pull Request #4795 · triggerdotdev/trigger.dev

Description: Trigger.dev – build and deploy durable AI agents and workflows - fix(chat): stop losing a user message that arrived mid-turn by ericallam · Pull Request #4795 · triggerdotdev/trigger.dev

Open Graph Description: Follow-up to #4644, now rebased onto main so the diff is just these three commits. Summary Two ways a chat could lose a user message, both pre-existing and both raised while reviewing #4644. A mess...

X Description: Follow-up to #4644, now rebased onto main so the diff is just these three commits. Summary Two ways a chat could lose a user message, both pre-existing and both raised while reviewing #4644. A mess...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4795

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:a31641bd-b418-f492-0574-1724ac57528a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A54:3FB3E8:326B10A:4865330:6AFB081B
html-safe-nonce5dcb79b24d197c71db84e15624c971de7487c00ace6140f579c4d72e2cab3c7c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTU0OjNGQjNFODozMjZCMTBBOjQ4NjUzMzA6NkFGQjA4MUIiLCJ2aXNpdG9yX2lkIjoiNTk5Nzk5Njg2ODAzMjQ2NDkyMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb56fad8323c2d0908603f40e1075e5972fc62e8a2777de7f49751bbb98e9446b
hovercard-subject-tagpull_request:4370172247
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4795/commits
twitter:imagehttps://opengraph.githubassets.com/eec4215e1622278ef734ba0d34b5381ca48dccacbe31d69439e5730bf156602b/triggerdotdev/trigger.dev/pull/4795
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/eec4215e1622278ef734ba0d34b5381ca48dccacbe31d69439e5730bf156602b/triggerdotdev/trigger.dev/pull/4795
og:image:altFollow-up to #4644, now rebased onto main so the diff is just these three commits. Summary Two ways a chat could lose a user message, both pre-existing and both raised while reviewing #4644. A mess...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameericallam
hostnamegithub.com
expected-hostnamegithub.com
None76fb13cb43f1834708971f45a9cfcab5df3177a7582086613d7cdc6e98c4bfde
turbo-cache-controlno-cache
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseafc998826cdd963c8f91a96ae5372809ab5e296b
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4795/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4795%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4795%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4795/commits
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4795/commits
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4795/commits
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
https://github.com/triggerdotdev/trigger.dev
ericallamhttps://github.com/ericallam
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
fix/mid-turn-resume-floorhttps://github.com/triggerdotdev/trigger.dev/tree/fix/mid-turn-resume-floor
Conversationhttps://github.com/triggerdotdev/trigger.dev/pull/4795
Commits11 (11)https://github.com/triggerdotdev/trigger.dev/pull/4795/commits
Checkshttps://github.com/triggerdotdev/trigger.dev/pull/4795/checks
Files changedhttps://github.com/triggerdotdev/trigger.dev/pull/4795/files
fix(chat): stop losing a user message that arrived mid-turnhttps://github.com/triggerdotdev/trigger.dev/pull/4795/commits#top
ericallamhttps://github.com/ericallam
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
fix/mid-turn-resume-floorhttps://github.com/triggerdotdev/trigger.dev/tree/fix/mid-turn-resume-floor
fix(chat,sdk): hold the resume floor behind a message buffered mid-turnhttps://github.com/triggerdotdev/trigger.dev/pull/4795/commits/9a21f57b159bf3723c338ae22c3140e75990ba63
https://github.com/ericallam
ericallamhttps://github.com/triggerdotdev/trigger.dev/commits?author=ericallam
9a21f57https://github.com/triggerdotdev/trigger.dev/pull/4795/commits/9a21f57b159bf3723c338ae22c3140e75990ba63
https://github.com/triggerdotdev/trigger.dev/tree/9a21f57b159bf3723c338ae22c3140e75990ba63
fix(chat,core): defer a declined steering message instead of dropping ithttps://github.com/triggerdotdev/trigger.dev/pull/4795/commits/383d169e78982c2f402948c18576a6a3d5fc820e
https://github.com/ericallam
ericallamhttps://github.com/triggerdotdev/trigger.dev/commits?author=ericallam
383d169https://github.com/triggerdotdev/trigger.dev/pull/4795/commits/383d169e78982c2f402948c18576a6a3d5fc820e
https://github.com/triggerdotdev/trigger.dev/tree/383d169e78982c2f402948c18576a6a3d5fc820e
docs(ai-chat): say what happens to a message that is not injectedhttps://github.com/triggerdotdev/trigger.dev/pull/4795/commits/3dd60c20106ae07ec16db2053162a8fade5302e6
https://github.com/ericallam
ericallamhttps://github.com/triggerdotdev/trigger.dev/commits?author=ericallam
3dd60c2https://github.com/triggerdotdev/trigger.dev/pull/4795/commits/3dd60c20106ae07ec16db2053162a8fade5302e6
https://github.com/triggerdotdev/trigger.dev/tree/3dd60c20106ae07ec16db2053162a8fade5302e6
fix(chat,sdk): consume only the steering batch the callbacks were givenhttps://github.com/triggerdotdev/trigger.dev/pull/4795/commits/87e45776361c9a9863a60d105c5a87f29dbe15e5
https://github.com/ericallam
ericallamhttps://github.com/triggerdotdev/trigger.dev/commits?author=ericallam
87e4577https://github.com/triggerdotdev/trigger.dev/pull/4795/commits/87e45776361c9a9863a60d105c5a87f29dbe15e5
https://github.com/triggerdotdev/trigger.dev/tree/87e45776361c9a9863a60d105c5a87f29dbe15e5
fix(core): refuse to clear a replayable route's queuehttps://github.com/triggerdotdev/trigger.dev/pull/4795/commits/66c83c8c8828f2df7897811b3f2c4debd5c6549b
https://github.com/ericallam
ericallamhttps://github.com/triggerdotdev/trigger.dev/commits?author=ericallam
66c83c8https://github.com/triggerdotdev/trigger.dev/pull/4795/commits/66c83c8c8828f2df7897811b3f2c4debd5c6549b
https://github.com/triggerdotdev/trigger.dev/tree/66c83c8c8828f2df7897811b3f2c4debd5c6549b
fix(chat): correct the wiring caveat, deferral does not need the spreadhttps://github.com/triggerdotdev/trigger.dev/pull/4795/commits/02aa30d5a686b92fc15afc65503c8a983fadf927
https://github.com/ericallam
ericallamhttps://github.com/triggerdotdev/trigger.dev/commits?author=ericallam
02aa30dhttps://github.com/triggerdotdev/trigger.dev/pull/4795/commits/02aa30d5a686b92fc15afc65503c8a983fadf927
https://github.com/triggerdotdev/trigger.dev/tree/02aa30d5a686b92fc15afc65503c8a983fadf927
fix(chat,sdk): inject only the steering entries this drain claimedhttps://github.com/triggerdotdev/trigger.dev/pull/4795/commits/e3e6ad7b20b6f2b86c7f7e521cdded84ae6623fb
https://github.com/ericallam
ericallamhttps://github.com/triggerdotdev/trigger.dev/commits?author=ericallam
e3e6ad7https://github.com/triggerdotdev/trigger.dev/pull/4795/commits/e3e6ad7b20b6f2b86c7f7e521cdded84ae6623fb
https://github.com/triggerdotdev/trigger.dev/tree/e3e6ad7b20b6f2b86c7f7e521cdded84ae6623fb
test(core): pin the observe-versus-puller ordering that take() guardshttps://github.com/triggerdotdev/trigger.dev/pull/4795/commits/f581a5097347afc3f8e52f375343e1c2e2545ab0
https://github.com/ericallam
ericallamhttps://github.com/triggerdotdev/trigger.dev/commits?author=ericallam
f581a50https://github.com/triggerdotdev/trigger.dev/pull/4795/commits/f581a5097347afc3f8e52f375343e1c2e2545ab0
https://github.com/triggerdotdev/trigger.dev/tree/f581a5097347afc3f8e52f375343e1c2e2545ab0
fix(chat,core): give the steering claim back when the transform throwshttps://github.com/triggerdotdev/trigger.dev/pull/4795/commits/41e132d67038d138980569cf712446ccb1b0d954
https://github.com/ericallam
ericallamhttps://github.com/triggerdotdev/trigger.dev/commits?author=ericallam
41e132dhttps://github.com/triggerdotdev/trigger.dev/pull/4795/commits/41e132d67038d138980569cf712446ccb1b0d954
https://github.com/triggerdotdev/trigger.dev/tree/41e132d67038d138980569cf712446ccb1b0d954
test(sdk): cover injection at a prepareStep boundaryhttps://github.com/triggerdotdev/trigger.dev/pull/4795/commits/f6bfe941f55e01197bc970fb56ed21bf3d78d112
https://github.com/ericallam
ericallamhttps://github.com/triggerdotdev/trigger.dev/commits?author=ericallam
f6bfe94https://github.com/triggerdotdev/trigger.dev/pull/4795/commits/f6bfe941f55e01197bc970fb56ed21bf3d78d112
https://github.com/triggerdotdev/trigger.dev/tree/f6bfe941f55e01197bc970fb56ed21bf3d78d112
test(sdk): repro the managed path dropping an injected message from historyhttps://github.com/triggerdotdev/trigger.dev/pull/4795/commits/b0ecb9114cf0c6a2dfbcc67fdf2759caf6a1d0fe
https://github.com/ericallam
ericallamhttps://github.com/triggerdotdev/trigger.dev/commits?author=ericallam
b0ecb91https://github.com/triggerdotdev/trigger.dev/pull/4795/commits/b0ecb9114cf0c6a2dfbcc67fdf2759caf6a1d0fe
https://github.com/triggerdotdev/trigger.dev/tree/b0ecb9114cf0c6a2dfbcc67fdf2759caf6a1d0fe
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.