Title: fix(clickhouse): renumber the external deployment id migration to 041 by 0ski · Pull Request #4734 · triggerdotdev/trigger.dev · GitHub
Open Graph Title: fix(clickhouse): renumber the external deployment id migration to 041 by 0ski · Pull Request #4734 · triggerdotdev/trigger.dev
X Title: fix(clickhouse): renumber the external deployment id migration to 041 by 0ski · Pull Request #4734 · triggerdotdev/trigger.dev
Description: Summary goose up against internal-packages/clickhouse/schema panics on main today, so ClickHouse migrations cannot be applied from a fresh checkout. Renumbering the external deployment id migration from 040 to 041 clears it. Root cause Two migrations claim version 40. #4615 added 040_create_task_events_search_v2.sql, and #4661 added 040_add_task_runs_v2_external_deployment_id.sql a day later. #4661 was opened before #4615 merged, so 040 was genuinely free at branch time, and because the two files have different names there is no textual conflict for git or a rebase to surface. Both merged green, and no workflow in this repo runs goose, so the collision only shows up the first time someone actually migrates. goose parses the numeric filename prefix as the version and refuses duplicates: panic: goose: duplicate version 40 detected: .../040_create_task_events_search_v2.sql .../040_add_task_runs_v2_external_deployment_id.sql It aborts while collecting the directory, before executing any SQL, so nothing was half applied and there is no migration state to repair. This migration gets renumbered rather than the task_events_search_v2 one because goose keys on the version number and not the filename: version 40 is already recorded wherever 040 has been applied, so renaming that file would re-run an applied migration. Verified with a full goose up against ClickHouse 26.2.19.43 (the image pinned in internal-packages/testcontainers): migrations apply cleanly through version 41, and task_runs_v2.external_deployment_id lands as String DEFAULT ''.
Open Graph Description: Summary goose up against internal-packages/clickhouse/schema panics on main today, so ClickHouse migrations cannot be applied from a fresh checkout. Renumbering the external deployment id migration...
X Description: Summary goose up against internal-packages/clickhouse/schema panics on main today, so ClickHouse migrations cannot be applied from a fresh checkout. Renumbering the external deployment id migration...
Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4734
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:97a39e1d-4ae3-9a84-e300-cd09e693dd56 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AB4C:1F63:C54E9B:124D6C8:6AFAFE42 |
| html-safe-nonce | f73a30fca675b69cba20204238cdfa21023ea156c621e0bfa2a172b81f701dd4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjRDOjFGNjM6QzU0RTlCOjEyNEQ2Qzg6NkFGQUZFNDIiLCJ2aXNpdG9yX2lkIjoiODExNzgzMjIwNTIzMDM0MTY5OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ef474dab48dc862b3b7e718680e196dfcff10ad46bbf26c6233ec2255be5064e |
| hovercard-subject-tag | pull_request:4321092464 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4734/files |
| twitter:image | https://avatars.githubusercontent.com/u/1408674?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1408674?s=400&v=4 |
| og:image:alt | Summary goose up against internal-packages/clickhouse/schema panics on main today, so ClickHouse migrations cannot be applied from a fresh checkout. Renumbering the external deployment id migration... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 54f7a6886649661c85eee945cca0773566bfb4065370e0429b7c8f7204184650 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git |
| octolytics-dimension-user_id | 95297378 |
| octolytics-dimension-user_login | triggerdotdev |
| octolytics-dimension-repository_id | 572570113 |
| octolytics-dimension-repository_nwo | triggerdotdev/trigger.dev |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 572570113 |
| octolytics-dimension-repository_network_root_nwo | triggerdotdev/trigger.dev |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3a69df62e401f1cbe8bd1ad791845bb4fc5b1c1d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width